[GitHub] [skywalking-banyandb] wu-sheng commented on pull request #305: Support multiple roles for banyand

2023-07-25 Thread via GitHub
wu-sheng commented on PR #305: URL: https://github.com/apache/skywalking-banyandb/pull/305#issuecomment-1650954954 I mean, do we expect am external etcd in cluster? Or still running internally? -- This is an automated message from the Apache Git Service. To respond to the message,

[skywalking-banyandb] branch cluster deleted (was c976d23d)

2023-07-25 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch cluster in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git was c976d23d Separate etcd server from the schema registry The revisions that were on this branch are

[skywalking-banyandb] branch main updated: Support multiple roles for banyand (#305)

2023-07-25 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git The following commit(s) were added to refs/heads/main by this push: new 42c10e61 Support multiple roles for

[GitHub] [skywalking-banyandb] hanahmily merged pull request #305: Support multiple roles for banyand

2023-07-25 Thread via GitHub
hanahmily merged PR #305: URL: https://github.com/apache/skywalking-banyandb/pull/305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[skywalking-kubernetes] branch master updated: Add doc for oap init job metadata labels. (#128)

2023-07-25 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git The following commit(s) were added to refs/heads/master by this push: new 16e6505 Add doc for oap

[GitHub] [skywalking-kubernetes] kezhenxu94 merged pull request #128: Add doc for oap init job metadata labels.

2023-07-25 Thread via GitHub
kezhenxu94 merged PR #128: URL: https://github.com/apache/skywalking-kubernetes/pull/128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [skywalking-kubernetes] kezhenxu94 commented on a diff in pull request #128: Add doc for oap init job metadata labels.

2023-07-25 Thread via GitHub
kezhenxu94 commented on code in PR #128: URL: https://github.com/apache/skywalking-kubernetes/pull/128#discussion_r1274306106 ## chart/skywalking/values.yaml: ## @@ -178,6 +178,8 @@ oapInit: nodeAffinity: {} nodeSelector: {} tolerations: [] + extraPodLabels: []

[GitHub] [skywalking-banyandb] wu-sheng commented on pull request #305: Support multiple roles for banyand

2023-07-25 Thread via GitHub
wu-sheng commented on PR #305: URL: https://github.com/apache/skywalking-banyandb/pull/305#issuecomment-1650871593 So, with this spliting, banyandb still is able to run in stand alone mode? But as support to set an external etcd cluster? -- This is an automated message from the Apache

[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #305: Support multiple roles for banyand

2023-07-25 Thread via GitHub
hanahmily commented on code in PR #305: URL: https://github.com/apache/skywalking-banyandb/pull/305#discussion_r1274290626 ## banyand/metadata/embeddedetcd/server.go: ## @@ -0,0 +1,159 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +//

[skywalking-banyandb] branch cluster updated (595c6a0f -> c976d23d)

2023-07-25 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch cluster in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from 595c6a0f Merge branch 'main' into cluster add c976d23d Separate etcd server from the schema

[GitHub] [skywalking-kubernetes] innerpeacez opened a new pull request, #128: Add doc for oap init job metadata labels.

2023-07-25 Thread via GitHub
innerpeacez opened a new pull request, #128: URL: https://github.com/apache/skywalking-kubernetes/pull/128 refer to #125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[skywalking-python] branch dependabot/pip/certifi-2023.7.22 deleted (was f5d03a7)

2023-07-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/pip/certifi-2023.7.22 in repository https://gitbox.apache.org/repos/asf/skywalking-python.git was f5d03a7 Bump certifi from 2022.12.7 to 2023.7.22 The revisions that were

[GitHub] [skywalking-python] dependabot[bot] commented on pull request #318: Bump certifi from 2022.12.7 to 2023.7.22

2023-07-25 Thread via GitHub
dependabot[bot] commented on PR #318: URL: https://github.com/apache/skywalking-python/pull/318#issuecomment-1650721843 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [skywalking-python] wu-sheng closed pull request #318: Bump certifi from 2022.12.7 to 2023.7.22

2023-07-25 Thread via GitHub
wu-sheng closed pull request #318: Bump certifi from 2022.12.7 to 2023.7.22 URL: https://github.com/apache/skywalking-python/pull/318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [skywalking-python] dependabot[bot] opened a new pull request, #318: Bump certifi from 2022.12.7 to 2023.7.22

2023-07-25 Thread via GitHub
dependabot[bot] opened a new pull request, #318: URL: https://github.com/apache/skywalking-python/pull/318 Bumps [certifi](https://github.com/certifi/python-certifi) from 2022.12.7 to 2023.7.22. Commits

[skywalking-python] branch dependabot/pip/certifi-2023.7.22 created (now f5d03a7)

2023-07-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/pip/certifi-2023.7.22 in repository https://gitbox.apache.org/repos/asf/skywalking-python.git at f5d03a7 Bump certifi from 2022.12.7 to 2023.7.22 No new revisions were

[skywalking-java] branch dependabot/maven/test/plugin/scenarios/armeria-0.96plus-scenario/com.linecorp.armeria-armeria-1.24.3 deleted (was d6541dde9e)

2023-07-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/test/plugin/scenarios/armeria-0.96plus-scenario/com.linecorp.armeria-armeria-1.24.3 in repository https://gitbox.apache.org/repos/asf/skywalking-java.git was

[skywalking-java] branch dependabot/maven/apm-sniffer/apm-sdk-plugin/apm-armeria-plugins/apm-armeria-1.0.x-plugin/com.linecorp.armeria-armeria-1.24.3 deleted (was 9517496ea9)

2023-07-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/apm-sniffer/apm-sdk-plugin/apm-armeria-plugins/apm-armeria-1.0.x-plugin/com.linecorp.armeria-armeria-1.24.3 in repository

[GitHub] [skywalking-java] dependabot[bot] commented on pull request #586: Bump com.linecorp.armeria:armeria from 0.96.0 to 1.24.3 in /test/plugin/scenarios/armeria-0.96plus-scenario

2023-07-25 Thread via GitHub
dependabot[bot] commented on PR #586: URL: https://github.com/apache/skywalking-java/pull/586#issuecomment-1650416899 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [skywalking-java] wu-sheng closed pull request #586: Bump com.linecorp.armeria:armeria from 0.96.0 to 1.24.3 in /test/plugin/scenarios/armeria-0.96plus-scenario

2023-07-25 Thread via GitHub
wu-sheng closed pull request #586: Bump com.linecorp.armeria:armeria from 0.96.0 to 1.24.3 in /test/plugin/scenarios/armeria-0.96plus-scenario URL: https://github.com/apache/skywalking-java/pull/586 -- This is an automated message from the Apache Git Service. To respond to the message,

[skywalking-java] branch dependabot/maven/apm-sniffer/apm-sdk-plugin/apm-armeria-plugins/apm-armeria-0.85.x-plugin/com.linecorp.armeria-armeria-1.24.3 deleted (was 2037771f23)

2023-07-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/apm-sniffer/apm-sdk-plugin/apm-armeria-plugins/apm-armeria-0.85.x-plugin/com.linecorp.armeria-armeria-1.24.3 in repository

[GitHub] [skywalking-java] dependabot[bot] commented on pull request #585: Bump com.linecorp.armeria:armeria from 1.0.0 to 1.24.3 in /apm-sniffer/apm-sdk-plugin/apm-armeria-plugins/apm-armeria-1.0.x-p

2023-07-25 Thread via GitHub
dependabot[bot] commented on PR #585: URL: https://github.com/apache/skywalking-java/pull/585#issuecomment-1650416743 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [skywalking-java] wu-sheng closed pull request #585: Bump com.linecorp.armeria:armeria from 1.0.0 to 1.24.3 in /apm-sniffer/apm-sdk-plugin/apm-armeria-plugins/apm-armeria-1.0.x-plugin

2023-07-25 Thread via GitHub
wu-sheng closed pull request #585: Bump com.linecorp.armeria:armeria from 1.0.0 to 1.24.3 in /apm-sniffer/apm-sdk-plugin/apm-armeria-plugins/apm-armeria-1.0.x-plugin URL: https://github.com/apache/skywalking-java/pull/585 -- This is an automated message from the Apache Git Service. To

[skywalking-java] branch dependabot/maven/test/plugin/scenarios/armeria-0.96minus-scenario/com.linecorp.armeria-armeria-1.24.3 deleted (was 80c92dd329)

2023-07-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/test/plugin/scenarios/armeria-0.96minus-scenario/com.linecorp.armeria-armeria-1.24.3 in repository https://gitbox.apache.org/repos/asf/skywalking-java.git was

[GitHub] [skywalking-java] dependabot[bot] commented on pull request #583: Bump com.linecorp.armeria:armeria from 0.85.0 to 1.24.3 in /apm-sniffer/apm-sdk-plugin/apm-armeria-plugins/apm-armeria-0.85.x

2023-07-25 Thread via GitHub
dependabot[bot] commented on PR #583: URL: https://github.com/apache/skywalking-java/pull/583#issuecomment-1650416599 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [skywalking-java] wu-sheng closed pull request #583: Bump com.linecorp.armeria:armeria from 0.85.0 to 1.24.3 in /apm-sniffer/apm-sdk-plugin/apm-armeria-plugins/apm-armeria-0.85.x-plugin

2023-07-25 Thread via GitHub
wu-sheng closed pull request #583: Bump com.linecorp.armeria:armeria from 0.85.0 to 1.24.3 in /apm-sniffer/apm-sdk-plugin/apm-armeria-plugins/apm-armeria-0.85.x-plugin URL: https://github.com/apache/skywalking-java/pull/583 -- This is an automated message from the Apache Git Service. To

[GitHub] [skywalking-java] dependabot[bot] commented on pull request #584: Bump com.linecorp.armeria:armeria from 0.90.0 to 1.24.3 in /test/plugin/scenarios/armeria-0.96minus-scenario

2023-07-25 Thread via GitHub
dependabot[bot] commented on PR #584: URL: https://github.com/apache/skywalking-java/pull/584#issuecomment-1650416493 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [skywalking-java] wu-sheng closed pull request #584: Bump com.linecorp.armeria:armeria from 0.90.0 to 1.24.3 in /test/plugin/scenarios/armeria-0.96minus-scenario

2023-07-25 Thread via GitHub
wu-sheng closed pull request #584: Bump com.linecorp.armeria:armeria from 0.90.0 to 1.24.3 in /test/plugin/scenarios/armeria-0.96minus-scenario URL: https://github.com/apache/skywalking-java/pull/584 -- This is an automated message from the Apache Git Service. To respond to the message,

[skywalking-java] branch dependabot/maven/test/plugin/scenarios/armeria-0.96plus-scenario/com.linecorp.armeria-armeria-1.24.3 created (now d6541dde9e)

2023-07-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/test/plugin/scenarios/armeria-0.96plus-scenario/com.linecorp.armeria-armeria-1.24.3 in repository https://gitbox.apache.org/repos/asf/skywalking-java.git at

[skywalking-java] branch dependabot/maven/apm-sniffer/apm-sdk-plugin/apm-armeria-plugins/apm-armeria-1.0.x-plugin/com.linecorp.armeria-armeria-1.24.3 created (now 9517496ea9)

2023-07-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/apm-sniffer/apm-sdk-plugin/apm-armeria-plugins/apm-armeria-1.0.x-plugin/com.linecorp.armeria-armeria-1.24.3 in repository

[skywalking-java] branch dependabot/maven/apm-sniffer/apm-sdk-plugin/apm-armeria-plugins/apm-armeria-0.85.x-plugin/com.linecorp.armeria-armeria-1.24.3 created (now 2037771f23)

2023-07-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/apm-sniffer/apm-sdk-plugin/apm-armeria-plugins/apm-armeria-0.85.x-plugin/com.linecorp.armeria-armeria-1.24.3 in repository

[GitHub] [skywalking-java] dependabot[bot] opened a new pull request, #583: Bump com.linecorp.armeria:armeria from 0.85.0 to 1.24.3 in /apm-sniffer/apm-sdk-plugin/apm-armeria-plugins/apm-armeria-0.85.

2023-07-25 Thread via GitHub
dependabot[bot] opened a new pull request, #583: URL: https://github.com/apache/skywalking-java/pull/583 Bumps [com.linecorp.armeria:armeria](https://github.com/line/armeria) from 0.85.0 to 1.24.3. Release notes Sourced from

[GitHub] [skywalking-java] dependabot[bot] opened a new pull request, #586: Bump com.linecorp.armeria:armeria from 0.96.0 to 1.24.3 in /test/plugin/scenarios/armeria-0.96plus-scenario

2023-07-25 Thread via GitHub
dependabot[bot] opened a new pull request, #586: URL: https://github.com/apache/skywalking-java/pull/586 Bumps [com.linecorp.armeria:armeria](https://github.com/line/armeria) from 0.96.0 to 1.24.3. Release notes Sourced from

[GitHub] [skywalking-java] dependabot[bot] opened a new pull request, #584: Bump com.linecorp.armeria:armeria from 0.90.0 to 1.24.3 in /test/plugin/scenarios/armeria-0.96minus-scenario

2023-07-25 Thread via GitHub
dependabot[bot] opened a new pull request, #584: URL: https://github.com/apache/skywalking-java/pull/584 Bumps [com.linecorp.armeria:armeria](https://github.com/line/armeria) from 0.90.0 to 1.24.3. Release notes Sourced from

[skywalking-java] branch dependabot/maven/test/plugin/scenarios/armeria-0.96minus-scenario/com.linecorp.armeria-armeria-1.24.3 created (now 80c92dd329)

2023-07-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/test/plugin/scenarios/armeria-0.96minus-scenario/com.linecorp.armeria-armeria-1.24.3 in repository https://gitbox.apache.org/repos/asf/skywalking-java.git at

[GitHub] [skywalking-java] dependabot[bot] opened a new pull request, #585: Bump com.linecorp.armeria:armeria from 1.0.0 to 1.24.3 in /apm-sniffer/apm-sdk-plugin/apm-armeria-plugins/apm-armeria-1.0.x-

2023-07-25 Thread via GitHub
dependabot[bot] opened a new pull request, #585: URL: https://github.com/apache/skywalking-java/pull/585 Bumps [com.linecorp.armeria:armeria](https://github.com/line/armeria) from 1.0.0 to 1.24.3. Release notes Sourced from

[GitHub] [skywalking-kubernetes] Yangfisher1 commented on pull request #127: Adding support for zipkin UI

2023-07-25 Thread via GitHub
Yangfisher1 commented on PR #127: URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649920667 @kezhenxu94 @innerpeacez @wu-sheng Thank you for your help! This is a wonderful community and everyone is kind朗 -- This is an automated message from the Apache Git

[skywalking-website] branch asf-site updated: deploy: c86dd19253ef2d15a7fa2b1bf7ceef53cd2ca86f

2023-07-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/asf-site by this push: new ba4ee8497a2 deploy:

[skywalking-java] branch main updated: avoid ThreadPoolExecutor duplicate enhancement (#582)

2023-07-25 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-java.git The following commit(s) were added to refs/heads/main by this push: new fbabc3d3ab avoid ThreadPoolExecutor

[GitHub] [skywalking-java] wu-sheng merged pull request #582: avoid ThreadPoolExecutor duplicate enhancement

2023-07-25 Thread via GitHub
wu-sheng merged PR #582: URL: https://github.com/apache/skywalking-java/pull/582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [skywalking-kubernetes] wu-sheng commented on pull request #127: Adding support for zipkin UI

2023-07-25 Thread via GitHub
wu-sheng commented on PR #127: URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649884412 Congrats @Yangfisher1 to be 800th GitHub contributor of SkyWalking. Welcome. -- This is an automated message from the Apache Git Service. To respond to the message,

[skywalking-website] branch asf-site updated: deploy: c86dd19253ef2d15a7fa2b1bf7ceef53cd2ca86f

2023-07-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 6bb64926038 deploy:

[GitHub] [skywalking-kubernetes] innerpeacez merged pull request #127: Adding support for zipkin UI

2023-07-25 Thread via GitHub
innerpeacez merged PR #127: URL: https://github.com/apache/skywalking-kubernetes/pull/127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[skywalking-kubernetes] branch master updated: Adding support for zipkin UI (#127)

2023-07-25 Thread innerpeacez
This is an automated email from the ASF dual-hosted git repository. innerpeacez pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git The following commit(s) were added to refs/heads/master by this push: new 73f5788 Adding support for

[GitHub] [skywalking-kubernetes] Yangfisher1 commented on pull request #127: Adding support for zipkin UI

2023-07-25 Thread via GitHub
Yangfisher1 commented on PR #127: URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649612979 @kezhenxu94 @innerpeacez Renaming is done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [skywalking-kubernetes] innerpeacez commented on pull request #127: Adding support for zipkin UI

2023-07-25 Thread via GitHub
innerpeacez commented on PR #127: URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649566565 > > @innerpeacez > > > > I'm ok with this. But I'm concerned that using `zk` instead of `zipkin` might be confusing. Using 'index' would ensure the readability of

[GitHub] [skywalking-kubernetes] Yangfisher1 commented on pull request #127: Adding support for zipkin UI

2023-07-25 Thread via GitHub
Yangfisher1 commented on PR #127: URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649561819 @kezhenxu94 > We can use zipkinreceiver or zipkinquery? I'm ok with this. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking-kubernetes] kezhenxu94 commented on pull request #127: Adding support for zipkin UI

2023-07-25 Thread via GitHub
kezhenxu94 commented on PR #127: URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649552633 > @innerpeacez > > I'm ok with this. But I'm concerned that using `zk` instead of `zipkin` might be confusing. Using 'index' would ensure the readability of these

[GitHub] [skywalking-kubernetes] kezhenxu94 commented on pull request #127: Adding support for zipkin UI

2023-07-25 Thread via GitHub
kezhenxu94 commented on PR #127: URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649551697 I vote for not to use `index` function, using `.` is also friendly for completion in IDEs。 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [skywalking-kubernetes] Yangfisher1 commented on pull request #127: Adding support for zipkin UI

2023-07-25 Thread via GitHub
Yangfisher1 commented on PR #127: URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649523540 @innerpeacez I'm ok with this. But I'm concerned that using `zk` instead of `zipkin` might be confusing. Using 'index' would ensure the readability of these ports.

[GitHub] [skywalking-kubernetes] innerpeacez commented on pull request #127: Adding support for zipkin UI

2023-07-25 Thread via GitHub
innerpeacez commented on PR #127: URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649452691 > @innerpeacez My bad. It's the restriction of Kubernetes as `a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and

[GitHub] [skywalking-kubernetes] Yangfisher1 commented on pull request #127: Adding support for zipkin UI

2023-07-25 Thread via GitHub
Yangfisher1 commented on PR #127: URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649421217 @innerpeacez My bad. It's the restriction of Kubernetes as `a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end

[GitHub] [skywalking-kubernetes] innerpeacez commented on pull request #127: Adding support for zipkin UI

2023-07-25 Thread via GitHub
innerpeacez commented on PR #127: URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649411959 > Since helm only supports lowercase letters so I rename these ports. Camel-Case is supported, let's keep it. ref to

[GitHub] [skywalking-kubernetes] Yangfisher1 commented on pull request #127: Adding support for zipkin UI

2023-07-25 Thread via GitHub
Yangfisher1 commented on PR #127: URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649387845 @innerpeacez @kezhenxu94 I tested it on my k8s cluster and it worked well. Since helm only supports lowercase letters so I rename these ports. -- This is an

[GitHub] [skywalking-kubernetes] innerpeacez commented on a diff in pull request #127: Adding support for zipkin UI

2023-07-25 Thread via GitHub
innerpeacez commented on code in PR #127: URL: https://github.com/apache/skywalking-kubernetes/pull/127#discussion_r1273172925 ## chart/skywalking/templates/oap-deployment.yaml: ## @@ -127,6 +127,18 @@ spec: {{ toYaml .Values.oap.resources | indent 10 }} {{- end }}

[GitHub] [skywalking-kubernetes] Yangfisher1 commented on pull request #127: Adding support for zipkin UI

2023-07-25 Thread via GitHub
Yangfisher1 commented on PR #127: URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649254933 @innerpeacez @kezhenxu94 It works for me, making it more convenient and graceful. Users only need to configure these two ports to enable zipkin trace and they can choose

[skywalking-nodejs] branch kezhenxu94-patch-1 deleted (was 4dd3d4a)

2023-07-25 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch kezhenxu94-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-nodejs.git was 4dd3d4a Update test.yaml The revisions that were on this branch are still contained in

[skywalking-nodejs] branch master updated: Disable dependabot pull requests (#117)

2023-07-25 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-nodejs.git The following commit(s) were added to refs/heads/master by this push: new fcd51df Disable dependabot pull

[GitHub] [skywalking-nodejs] wu-sheng merged pull request #117: Disable dependabot pull requests

2023-07-25 Thread via GitHub
wu-sheng merged PR #117: URL: https://github.com/apache/skywalking-nodejs/pull/117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [skywalking-kubernetes] kezhenxu94 commented on pull request #127: Adding support for zipkin UI

2023-07-25 Thread via GitHub
kezhenxu94 commented on PR #127: URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649213683 > values.yaml > > ``` > oap: > ports: > # add more ports here if you need, for example > # zabbix: 10051 > grpc: 11800 > rest:

[GitHub] [skywalking-kubernetes] innerpeacez commented on pull request #127: Adding support for zipkin UI

2023-07-25 Thread via GitHub
innerpeacez commented on PR #127: URL: https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649208747 values.yaml ``` oap: ports: # add more ports here if you need, for example # zabbix: 10051 grpc: 11800 rest: 12800 #

[skywalking-nodejs] branch kezhenxu94-patch-1 updated (8ad999d -> 4dd3d4a)

2023-07-25 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch kezhenxu94-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-nodejs.git from 8ad999d Update test.yaml add 4dd3d4a Update test.yaml No new revisions were added

[GitHub] [skywalking-java] xiaqi1210 commented on pull request #582: avoid ThreadPoolExecutor duplicate enhancement

2023-07-25 Thread via GitHub
xiaqi1210 commented on PR #582: URL: https://github.com/apache/skywalking-java/pull/582#issuecomment-1649184810 > I think you missed the change log? pushed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the