[GitHub] sanoopmm commented on issue #4957: Not able to perform Multidimensional analysis using Pivot visualization

2018-05-18 Thread GitBox
sanoopmm commented on issue #4957: Not able to perform Multidimensional analysis using Pivot visualization URL: https://github.com/apache/incubator-superset/issues/4957#issuecomment-390381426 @mistercrunch @xrmx can you suggest me a solution for the above requirement? Do you have any

[GitHub] john-bodley commented on issue #4947: [sql lab] a better approach at limiting queries

2018-05-18 Thread GitBox
john-bodley commented on issue #4947: [sql lab] a better approach at limiting queries URL: https://github.com/apache/incubator-superset/pull/4947#issuecomment-390368404 @betodealmeida @mistercrunch are you sure we want to be augmenting a query that someone authors? This seems overly

[GitHub] timifasubaa commented on issue #4834: Load async sql lab results early for Presto

2018-05-18 Thread GitBox
timifasubaa commented on issue #4834: Load async sql lab results early for Presto URL: https://github.com/apache/incubator-superset/pull/4834#issuecomment-390372158 The current approach incorporates the various feedback I have received on this PR. 1. It abandons the presto

[GitHub] timifasubaa commented on issue #4834: Load async sql lab results early for Presto

2018-05-18 Thread GitBox
timifasubaa commented on issue #4834: Load async sql lab results early for Presto URL: https://github.com/apache/incubator-superset/pull/4834#issuecomment-390372158 The current approach incorporates feedback from the 1. It abandons the presto specific logic and uses fetchmany to

[GitHub] codecov-io commented on issue #5023: [sqllab] force limit queries only when there is no existing limit

2018-05-18 Thread GitBox
codecov-io commented on issue #5023: [sqllab] force limit queries only when there is no existing limit URL: https://github.com/apache/incubator-superset/pull/5023#issuecomment-389737583 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr=h1) Report > Merging

[GitHub] john-bodley commented on issue #4947: [sql lab] a better approach at limiting queries

2018-05-18 Thread GitBox
john-bodley commented on issue #4947: [sql lab] a better approach at limiting queries URL: https://github.com/apache/incubator-superset/pull/4947#issuecomment-390368404 @betodealmeida @mistercrunch are you sure we want to be augmenting a query that someone authors? This seems overly

[GitHub] timifasubaa commented on issue #5023: [sqllab] force limit queries only when there is no existing limit

2018-05-18 Thread GitBox
timifasubaa commented on issue #5023: [sqllab] force limit queries only when there is no existing limit URL: https://github.com/apache/incubator-superset/pull/5023#issuecomment-390367349 @mistercrunch That makes sense. I took out your regex and made it a helper method in utils. Now I

[GitHub] graceguo-supercat commented on issue #4931: date/datetime/timestamp using unix timestamp in Table-viz

2018-05-18 Thread GitBox
graceguo-supercat commented on issue #4931: date/datetime/timestamp using unix timestamp in Table-viz URL: https://github.com/apache/incubator-superset/issues/4931#issuecomment-390336380 @zhaoyongjie can you try latest master? i can't reproduce your issue.

[GitHub] daniel5001 commented on issue #4725: Add "Published" feature to dashboards

2018-05-18 Thread GitBox
daniel5001 commented on issue #4725: Add "Published" feature to dashboards URL: https://github.com/apache/incubator-superset/pull/4725#issuecomment-390321547 Looks awesome @Tresdon can't thank you enough for putting this together. It's a real lifesaver when utilizing this tool in a large

[GitHub] bgriffen commented on issue #4984: Pivot table not working - unhashable type: 'dict'

2018-05-18 Thread GitBox
bgriffen commented on issue #4984: Pivot table not working - unhashable type: 'dict' URL: https://github.com/apache/incubator-superset/issues/4984#issuecomment-390294267 Did your original query work when doing heatmaps? I have a table which has row and column and a value at that row and

[GitHub] graceguo-supercat commented on issue #4988: redirect edit url of chart under dashboard to explore

2018-05-18 Thread GitBox
graceguo-supercat commented on issue #4988: redirect edit url of chart under dashboard to explore URL: https://github.com/apache/incubator-superset/pull/4988#issuecomment-390283372 @liyuance Is the last icon, 'Explore chart' will go to chart explore page?

[GitHub] graceguo-supercat commented on issue #4988: redirect edit url of chart under dashboard to explore

2018-05-18 Thread GitBox
graceguo-supercat commented on issue #4988: redirect edit url of chart under dashboard to explore URL: https://github.com/apache/incubator-superset/pull/4988#issuecomment-390283372 @liyuance isn't last icon, 'Explore chart' will go to chart explore page?

[GitHub] mistercrunch commented on issue #5035: bugfix when use "Time Series - Line Chart" and "Big Number with Trendline" on dashboard

2018-05-18 Thread GitBox
mistercrunch commented on issue #5035: bugfix when use "Time Series - Line Chart" and "Big Number with Trendline" on dashboard URL: https://github.com/apache/incubator-superset/pull/5035#issuecomment-390252876 Which version is this? Does it happen on `master` ?

[GitHub] mistercrunch commented on issue #5034: fix virtualaztion js error

2018-05-18 Thread GitBox
mistercrunch commented on issue #5034: fix virtualaztion js error URL: https://github.com/apache/incubator-superset/pull/5034#issuecomment-390252339 @graceguo-supercat knows this area of the code most This is an automated

[GitHub] mistercrunch commented on issue #5037: Change sea color from white to blue in world visualization

2018-05-18 Thread GitBox
mistercrunch commented on issue #5037: Change sea color from white to blue in world visualization URL: https://github.com/apache/incubator-superset/pull/5037#issuecomment-390251811 please add before/after screenshot This is

[GitHub] villebro commented on issue #5036: Which db is best with Superset 0.24 and later (0.25+)?

2018-05-18 Thread GitBox
villebro commented on issue #5036: Which db is best with Superset 0.24 and later (0.25+)? URL: https://github.com/apache/incubator-superset/issues/5036#issuecomment-390226352 They're both fine, as should be most other SQL Alchemy databases.

[GitHub] codecov-io commented on issue #5037: Change sea color from white to blue in world visualization

2018-05-18 Thread GitBox
codecov-io commented on issue #5037: Change sea color from white to blue in world visualization URL: https://github.com/apache/incubator-superset/pull/5037#issuecomment-390216056 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5037?src=pr=h1) Report > Merging

[GitHub] Benji81 opened a new pull request #5037: Change sea color from white to blue in world visualization

2018-05-18 Thread GitBox
Benji81 opened a new pull request #5037: Change sea color from white to blue in world visualization URL: https://github.com/apache/incubator-superset/pull/5037 to see white countries borders This is an automated message

[GitHub] joaomg commented on issue #3729: Added multi-tenancy support.

2018-05-18 Thread GitBox
joaomg commented on issue #3729: Added multi-tenancy support. URL: https://github.com/apache/incubator-superset/pull/3729#issuecomment-390159803 @thakur00mayank I'm interested in multi-tenancy, you need help on making the changes?

[GitHub] sharonlx commented on issue #5034: fix virtualaztion js error

2018-05-18 Thread GitBox
sharonlx commented on issue #5034: fix virtualaztion js error URL: https://github.com/apache/incubator-superset/pull/5034#issuecomment-390158093 @zhaoyongjie I have read other chart code like `big_numbers`, all of them use real dom by `slice.seletor` , i do not understand why nvd3

[GitHub] codecov-io commented on issue #5034: fix virtualaztion js error

2018-05-18 Thread GitBox
codecov-io commented on issue #5034: fix virtualaztion js error URL: https://github.com/apache/incubator-superset/pull/5034#issuecomment-390154031 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5034?src=pr=h1) Report > Merging

[GitHub] zhaoyongjie commented on issue #5034: fix virtualaztion js error

2018-05-18 Thread GitBox
zhaoyongjie commented on issue #5034: fix virtualaztion js error URL: https://github.com/apache/incubator-superset/pull/5034#issuecomment-390136708 @sharonlx , You may need throttle to solve this problem. This is an

[GitHub] codecov-io commented on issue #5025: [bugfix]fix metrics type error in pivot table viz

2018-05-18 Thread GitBox
codecov-io commented on issue #5025: [bugfix]fix metrics type error in pivot table viz URL: https://github.com/apache/incubator-superset/pull/5025#issuecomment-390133281 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5025?src=pr=h1) Report > Merging

[GitHub] Maxwell2022 opened a new issue #5033: [question] Is it possible to have multiple authentication type?

2018-05-18 Thread GitBox
Maxwell2022 opened a new issue #5033: [question] Is it possible to have multiple authentication type? URL: https://github.com/apache/incubator-superset/issues/5033 ### Superset version `0.25.2` I'm embedding superset in an iframe for a client product. When loading the iframe, I

[GitHub] codecov-io commented on issue #5026: [bugfix] Fix ZeroDivisionError and get metrics label with percent metrics

2018-05-18 Thread GitBox
codecov-io commented on issue #5026: [bugfix] Fix ZeroDivisionError and get metrics label with percent metrics URL: https://github.com/apache/incubator-superset/pull/5026#issuecomment-390092106 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5026?src=pr=h1) Report >

[GitHub] codecov-io commented on issue #5026: [bugfix] Fix ZeroDivisionError and get metrics label with percent metrics

2018-05-18 Thread GitBox
codecov-io commented on issue #5026: [bugfix] Fix ZeroDivisionError and get metrics label with percent metrics URL: https://github.com/apache/incubator-superset/pull/5026#issuecomment-390092106 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5026?src=pr=h1) Report >