[GitHub] sbarlock commented on issue #5003: Date formating lost when selecting MAX(date)

2018-05-23 Thread GitBox
sbarlock commented on issue #5003: Date formating lost when selecting MAX(date) URL: https://github.com/apache/incubator-superset/issues/5003#issuecomment-391595289 Ok Thanks! This is an automated message from the Apache

[GitHub] mistercrunch commented on issue #5057: Translate string to array for multi fields in getControlsState

2018-05-23 Thread GitBox
mistercrunch commented on issue #5057: Translate string to array for multi fields in getControlsState URL: https://github.com/apache/incubator-superset/pull/5057#issuecomment-391594340 Actually after thinking a bit more I'm thinking while this fixes the problem in the explore view, I

[GitHub] mistercrunch closed pull request #5057: Translate string to array for multi fields in getControlsState

2018-05-23 Thread GitBox
mistercrunch closed pull request #5057: Translate string to array for multi fields in getControlsState URL: https://github.com/apache/incubator-superset/pull/5057 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] mistercrunch commented on a change in pull request #5067: Allow multiple time shifts

2018-05-23 Thread GitBox
mistercrunch commented on a change in pull request #5067: Allow multiple time shifts URL: https://github.com/apache/incubator-superset/pull/5067#discussion_r190469532 ## File path: superset/assets/src/explore/controls.jsx ## @@ -1575,11 +1575,20 @@ export const controls

[GitHub] mistercrunch closed issue #5011: Existing histogram slices are broken

2018-05-23 Thread GitBox
mistercrunch closed issue #5011: Existing histogram slices are broken URL: https://github.com/apache/incubator-superset/issues/5011 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] betodealmeida commented on a change in pull request #5067: Allow multiple time shifts

2018-05-23 Thread GitBox
betodealmeida commented on a change in pull request #5067: Allow multiple time shifts URL: https://github.com/apache/incubator-superset/pull/5067#discussion_r190465666 ## File path: superset/viz.py ## @@ -1199,10 +1199,10 @@ def process_data(self, df, aggregate=False):

[GitHub] betodealmeida commented on a change in pull request #5067: Allow multiple time shifts

2018-05-23 Thread GitBox
betodealmeida commented on a change in pull request #5067: Allow multiple time shifts URL: https://github.com/apache/incubator-superset/pull/5067#discussion_r190465245 ## File path: superset/assets/src/explore/controls.jsx ## @@ -1575,11 +1575,20 @@ export const controls

[GitHub] mistercrunch closed pull request #5065: [line] fix time shift color assignments

2018-05-23 Thread GitBox
mistercrunch closed pull request #5065: [line] fix time shift color assignments URL: https://github.com/apache/incubator-superset/pull/5065 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] aok1425 opened a new pull request #5068: Add 24 hours refresh for dashboard

2018-05-23 Thread GitBox
aok1425 opened a new pull request #5068: Add 24 hours refresh for dashboard URL: https://github.com/apache/incubator-superset/pull/5068 For dashboards, add an autorefresh time interval option of 24 hours. Fixes #5058. @mistercrunch @michellethomas @niksem

[GitHub] timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit

2018-05-23 Thread GitBox
timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit URL: https://github.com/apache/incubator-superset/pull/5023#discussion_r190459975 ## File path: superset/sql_lab.py ## @@ -171,6 +171,8 @@ def

[GitHub] qin4zhang commented on issue #5054: Security vulnerability for 0.25.0

2018-05-23 Thread GitBox
qin4zhang commented on issue #5054: Security vulnerability for 0.25.0 URL: https://github.com/apache/incubator-superset/issues/5054#issuecomment-391577820 @sebastianwindeck @mistercrunch Get it. I forgot to run `superset init` after upgrading. I will try to check it.

[GitHub] qin4zhang commented on issue #5054: Security vulnerability for 0.25.0

2018-05-23 Thread GitBox
qin4zhang commented on issue #5054: Security vulnerability for 0.25.0 URL: https://github.com/apache/incubator-superset/issues/5054#issuecomment-391577820 @sebastianwindeck @mistercrunch Get it. I forget to run superset init after upgrading. I will try to check it.

[GitHub] mistercrunch commented on a change in pull request #5067: Allow multiple time shifts

2018-05-23 Thread GitBox
mistercrunch commented on a change in pull request #5067: Allow multiple time shifts URL: https://github.com/apache/incubator-superset/pull/5067#discussion_r190442395 ## File path: superset/assets/src/explore/controls.jsx ## @@ -1575,11 +1575,20 @@ export const controls

[GitHub] codecov-io commented on issue #5067: Allow multiple time shifts

2018-05-23 Thread GitBox
codecov-io commented on issue #5067: Allow multiple time shifts URL: https://github.com/apache/incubator-superset/pull/5067#issuecomment-391556360 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5067?src=pr=h1) Report > Merging

[GitHub] betodealmeida opened a new pull request #5067: Allow multiple time shifts

2018-05-23 Thread GitBox
betodealmeida opened a new pull request #5067: Allow multiple time shifts URL: https://github.com/apache/incubator-superset/pull/5067 This PR changes the Advanced Analytics section to allow multiple time shifts, instead of only one:

[GitHub] williaster commented on issue #4993: [dashboard v2] tests!

2018-05-23 Thread GitBox
williaster commented on issue #4993: [dashboard v2] tests! URL: https://github.com/apache/incubator-superset/pull/4993#issuecomment-391545672 abandoning because of a weird git state after rebasing `dashboard-builder`. see #5066

[GitHub] ahsanshah commented on issue #4759: Ability to add multiple sources (namely time series) to a chart

2018-05-23 Thread GitBox
ahsanshah commented on issue #4759: Ability to add multiple sources (namely time series) to a chart URL: https://github.com/apache/incubator-superset/issues/4759#issuecomment-391542204 Agree this would be killer addition. Right now, we use a variety of Druid datasources at varying

[GitHub] codecov-io commented on issue #5065: [line] fix time shift color assignments

2018-05-23 Thread GitBox
codecov-io commented on issue #5065: [line] fix time shift color assignments URL: https://github.com/apache/incubator-superset/pull/5065#issuecomment-391540777 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5065?src=pr=h1) Report > Merging

[GitHub] mistercrunch opened a new pull request #5065: [line] fix time shift color assignments

2018-05-23 Thread GitBox
mistercrunch opened a new pull request #5065: [line] fix time shift color assignments URL: https://github.com/apache/incubator-superset/pull/5065 I think what happened is last minute "addressing comments" changes broke the PR closes

[GitHub] williaster closed pull request #5064: [dashboard v2] check for default_filters before json-loads-ing them

2018-05-23 Thread GitBox
williaster closed pull request #5064: [dashboard v2] check for default_filters before json-loads-ing them URL: https://github.com/apache/incubator-superset/pull/5064 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] williaster opened a new pull request #5064: [dashboard v2] check for default_filters before json_loads-ing them

2018-05-23 Thread GitBox
williaster opened a new pull request #5064: [dashboard v2] check for default_filters before json_loads-ing them URL: https://github.com/apache/incubator-superset/pull/5064 @graceguo-supercat This is an automated message

[GitHub] michellethomas closed issue #5049: Slices with new Adhoc Filters break dashboards

2018-05-23 Thread GitBox
michellethomas closed issue #5049: Slices with new Adhoc Filters break dashboards URL: https://github.com/apache/incubator-superset/issues/5049 This is an automated message from the Apache Git Service. To respond to the

[GitHub] michellethomas commented on issue #4765: [line] fix verbose names in time shift

2018-05-23 Thread GitBox
michellethomas commented on issue #4765: [line] fix verbose names in time shift URL: https://github.com/apache/incubator-superset/pull/4765#issuecomment-391510562 @mistercrunch it looks like this broke the time shift color assignment (that you fixed here

[GitHub] codecov-io commented on issue #5057: Translate string to array for multi fields in getControlsState

2018-05-23 Thread GitBox
codecov-io commented on issue #5057: Translate string to array for multi fields in getControlsState URL: https://github.com/apache/incubator-superset/pull/5057#issuecomment-391177397 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5057?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5057: Translate string to array for multi fields in getControlsState

2018-05-23 Thread GitBox
codecov-io commented on issue #5057: Translate string to array for multi fields in getControlsState URL: https://github.com/apache/incubator-superset/pull/5057#issuecomment-391177397 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5057?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5057: Translate string to array for multi fields in getControlsState

2018-05-23 Thread GitBox
codecov-io commented on issue #5057: Translate string to array for multi fields in getControlsState URL: https://github.com/apache/incubator-superset/pull/5057#issuecomment-391177397 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5057?src=pr=h1) Report > Merging

[GitHub] michellethomas commented on a change in pull request #5057: Translate string to array for multi fields in getControlsState

2018-05-23 Thread GitBox
michellethomas commented on a change in pull request #5057: Translate string to array for multi fields in getControlsState URL: https://github.com/apache/incubator-superset/pull/5057#discussion_r190402766 ## File path: superset/assets/src/explore/store.js ## @@ -56,6

[GitHub] mariomarf opened a new issue #5063: Apache superset - Error retrive db2 table information

2018-05-23 Thread GitBox
mariomarf opened a new issue #5063: Apache superset - Error retrive db2 table information URL: https://github.com/apache/incubator-superset/issues/5063 Make sure these boxes are checked before submitting your issue - thank you! - [ x ] I have checked the superset logs for python

[GitHub] john-bodley closed pull request #5062: [markup] Enable allow-forms

2018-05-23 Thread GitBox
john-bodley closed pull request #5062: [markup] Enable allow-forms URL: https://github.com/apache/incubator-superset/pull/5062 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] mistercrunch commented on issue #5003: Date formating lost when selecting MAX(date)

2018-05-23 Thread GitBox
mistercrunch commented on issue #5003: Date formating lost when selecting MAX(date) URL: https://github.com/apache/incubator-superset/issues/5003#issuecomment-391475829 For now I think you'll have to use a `Table` visualization. In the future I'd like to have `Markup` visualization

[GitHub] graceguo-supercat commented on issue #4993: [dashboard v2] tests!

2018-05-23 Thread GitBox
graceguo-supercat commented on issue #4993: [dashboard v2] tests! URL: https://github.com/apache/incubator-superset/pull/4993#issuecomment-391472515 I only see filters related tests for `componentDidUpdate`. We should also test dashboard's default_filters are pre-populated.

[GitHub] codecov-io commented on issue #5057: Translate string to array for multi fields in getControlsState

2018-05-23 Thread GitBox
codecov-io commented on issue #5057: Translate string to array for multi fields in getControlsState URL: https://github.com/apache/incubator-superset/pull/5057#issuecomment-391177397 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5057?src=pr=h1) Report > Merging

[GitHub] betodealmeida commented on issue #4981: Make time filter more usable

2018-05-23 Thread GitBox
betodealmeida commented on issue #4981: Make time filter more usable URL: https://github.com/apache/incubator-superset/pull/4981#issuecomment-391458918 > (1) I like the organization that @elibrumbaugh suggested. Can we name the tab "Relative" vs. Defaults. Custom is good. @vylc,

[GitHub] codecov-io commented on issue #5062: [markup] Enable allow-forms

2018-05-23 Thread GitBox
codecov-io commented on issue #5062: [markup] Enable allow-forms URL: https://github.com/apache/incubator-superset/pull/5062#issuecomment-391457330 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5062?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5062: [markup] Enable allow-forms

2018-05-23 Thread GitBox
codecov-io commented on issue #5062: [markup] Enable allow-forms URL: https://github.com/apache/incubator-superset/pull/5062#issuecomment-391457330 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5062?src=pr=h1) Report > Merging

[GitHub] mistercrunch commented on a change in pull request #5057: Translate string to array for multi fields in getControlsState

2018-05-23 Thread GitBox
mistercrunch commented on a change in pull request #5057: Translate string to array for multi fields in getControlsState URL: https://github.com/apache/incubator-superset/pull/5057#discussion_r190360447 ## File path: superset/assets/src/explore/store.js ## @@ -56,6

[GitHub] michellethomas commented on a change in pull request #5057: Translate string to array for multi fields in getControlsState

2018-05-23 Thread GitBox
michellethomas commented on a change in pull request #5057: Translate string to array for multi fields in getControlsState URL: https://github.com/apache/incubator-superset/pull/5057#discussion_r190359546 ## File path: superset/assets/src/explore/store.js ## @@ -56,6

[GitHub] john-bodley closed pull request #5060: [get_df] Adding support for multi-statement SQL

2018-05-23 Thread GitBox
john-bodley closed pull request #5060: [get_df] Adding support for multi-statement SQL URL: https://github.com/apache/incubator-superset/pull/5060 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] john-bodley commented on a change in pull request #5056: [Adhoc Filters] integrating dashboard filters with adhoc filters

2018-05-23 Thread GitBox
john-bodley commented on a change in pull request #5056: [Adhoc Filters] integrating dashboard filters with adhoc filters URL: https://github.com/apache/incubator-superset/pull/5056#discussion_r190356344 ## File path: superset/viz.py ## @@ -235,7 +235,11 @@ def

[GitHub] john-bodley commented on a change in pull request #5056: [Adhoc Filters] integrating dashboard filters with adhoc filters

2018-05-23 Thread GitBox
john-bodley commented on a change in pull request #5056: [Adhoc Filters] integrating dashboard filters with adhoc filters URL: https://github.com/apache/incubator-superset/pull/5056#discussion_r190356316 ## File path: superset/viz.py ## @@ -235,7 +235,11 @@ def

[GitHub] john-bodley opened a new pull request #5062: [markup] Enable allow-forms

2018-05-23 Thread GitBox
john-bodley opened a new pull request #5062: [markup] Enable allow-forms URL: https://github.com/apache/incubator-superset/pull/5062 This PR fixes an issue where a dashboard contained a markup slice with links to other dashboards, and when one tried to either export or explore a slice on

[GitHub] vylc commented on issue #4981: Make time filter more usable

2018-05-23 Thread GitBox
vylc commented on issue #4981: Make time filter more usable URL: https://github.com/apache/incubator-superset/pull/4981#issuecomment-391450331 Looks great! (1) I like the organization that @elibrumbaugh suggested. Can we name the tab "Relative" vs. Defaults. Custom is good. (2) Re:

[GitHub] aok1425 commented on issue #5058: Add option for 24h dashboard refresh frequency

2018-05-23 Thread GitBox
aok1425 commented on issue #5058: Add option for 24h dashboard refresh frequency URL: https://github.com/apache/incubator-superset/issues/5058#issuecomment-391438223 Amazing! I will do that--thanks This is an automated

[GitHub] mistercrunch commented on issue #5048: [bugfix] Render to section by override value

2018-05-23 Thread GitBox
mistercrunch commented on issue #5048: [bugfix] Render to section by override value URL: https://github.com/apache/incubator-superset/pull/5048#issuecomment-391432296 Why closing?  This is an automated message from the

[GitHub] mistercrunch commented on issue #5053: Database Permission for version 0.25.0

2018-05-23 Thread GitBox
mistercrunch commented on issue #5053: Database Permission for version 0.25.0 URL: https://github.com/apache/incubator-superset/issues/5053#issuecomment-391431982 What's keeping you from granting database access? Is the perm missing? it should show as `database access on

[GitHub] mistercrunch commented on a change in pull request #5057: Translate string to array for multi fields in getControlsState

2018-05-23 Thread GitBox
mistercrunch commented on a change in pull request #5057: Translate string to array for multi fields in getControlsState URL: https://github.com/apache/incubator-superset/pull/5057#discussion_r190332713 ## File path: superset/assets/src/explore/store.js ## @@ -56,6

[GitHub] ujhujuh opened a new issue #1768: I want to add some chart style, such as linePlusBarChart, multiBarHorizontalChart, multiChart

2018-05-23 Thread GitBox
ujhujuh opened a new issue #1768: I want to add some chart style, such as linePlusBarChart, multiBarHorizontalChart, multiChart URL: https://github.com/apache/incubator-superset/issues/1768 Make sure these boxes are checked before submitting your issue - thank you! - [yes ] I have

[GitHub] mistercrunch commented on issue #5061: Support Multi charts

2018-05-23 Thread GitBox
mistercrunch commented on issue #5061: Support Multi charts URL: https://github.com/apache/incubator-superset/issues/5061#issuecomment-391429655 Reopened the original issue This is an automated message from the Apache Git

[GitHub] mistercrunch closed issue #5061: Support Multi charts

2018-05-23 Thread GitBox
mistercrunch closed issue #5061: Support Multi charts URL: https://github.com/apache/incubator-superset/issues/5061 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] mistercrunch commented on issue #5054: Security vulnerability for 0.25.0

2018-05-23 Thread GitBox
mistercrunch commented on issue #5054: Security vulnerability for 0.25.0 URL: https://github.com/apache/incubator-superset/issues/5054#issuecomment-391428932 On my environment the gamma user gets redirected to the welcome page. Have you run `superset init` since upgrade? The

[GitHub] mistercrunch commented on issue #5054: Security vulnerability for 0.25.0

2018-05-23 Thread GitBox
mistercrunch commented on issue #5054: Security vulnerability for 0.25.0 URL: https://github.com/apache/incubator-superset/issues/5054#issuecomment-391428932 Have you run `superset init` since upgrade? The provided roles are updated/synced when running `supreset init`, perhaps `Gamma`

[GitHub] john-bodley commented on issue #5031: Dashboard initial page load logging with tabs

2018-05-23 Thread GitBox
john-bodley commented on issue #5031: Dashboard initial page load logging with tabs URL: https://github.com/apache/incubator-superset/pull/5031#issuecomment-391418634 I think there’s merit in providing more generic logging where each page component is uniquely identifiable. That provides

[GitHub] hughhhh commented on issue #5057: Translate string to array for multi fields in getControlsState

2018-05-23 Thread GitBox
hug commented on issue #5057: Translate string to array for multi fields in getControlsState URL: https://github.com/apache/incubator-superset/pull/5057#issuecomment-391362905  This is an automated message from the

[GitHub] hughhhh commented on a change in pull request #5057: Translate string to array for multi fields in getControlsState

2018-05-23 Thread GitBox
hug commented on a change in pull request #5057: Translate string to array for multi fields in getControlsState URL: https://github.com/apache/incubator-superset/pull/5057#discussion_r190262556 ## File path: superset/assets/src/explore/store.js ## @@ -56,6 +56,10 @@

[GitHub] sebastianwindeck commented on issue #5054: Security vulnerability for 0.25.0

2018-05-23 Thread GitBox
sebastianwindeck commented on issue #5054: Security vulnerability for 0.25.0 URL: https://github.com/apache/incubator-superset/issues/5054#issuecomment-391354802 @qin4zhang Ok, I used simple users, within the fab-manager of the flask-app. - Maybe check which user superset identifies

[GitHub] zhangjian0111 closed issue #5045: Can't select the table's other metrics when explore the chart expect the count(*) metric

2018-05-23 Thread GitBox
zhangjian0111 closed issue #5045: Can't select the table's other metrics when explore the chart expect the count(*) metric URL: https://github.com/apache/incubator-superset/issues/5045 This is an automated message from the

[GitHub] abdurrehmanab92 closed issue #4811: Add section to "Security" docs describing permissions

2018-05-23 Thread GitBox
abdurrehmanab92 closed issue #4811: Add section to "Security" docs describing permissions URL: https://github.com/apache/incubator-superset/issues/4811 This is an automated message from the Apache Git Service. To respond to

[GitHub] neilsoncarlos commented on issue #3464: Issue using Oracle DB as superset database - Error running a migration script

2018-05-23 Thread GitBox
neilsoncarlos commented on issue #3464: Issue using Oracle DB as superset database - Error running a migration script URL: https://github.com/apache/incubator-superset/issues/3464#issuecomment-391329084 I´m also fighting to get superset working with oracle. I created sequences for every

[GitHub] anju-jsl opened a new issue #5061: Support Multi charts

2018-05-23 Thread GitBox
anju-jsl opened a new issue #5061: Support Multi charts URL: https://github.com/apache/incubator-superset/issues/5061 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktraces and included it here as

[GitHub] qin4zhang commented on issue #5053: Database Permission for version 0.25.0

2018-05-23 Thread GitBox
qin4zhang commented on issue #5053: Database Permission for version 0.25.0 URL: https://github.com/apache/incubator-superset/issues/5053#issuecomment-391304183 @TianyangLi I try to upgrade to 0.25.5. Adding a postgres db, however I can't grant database access on [dbname]. I just want to

[GitHub] qin4zhang commented on issue #5054: Security vulnerability for 0.25.0

2018-05-23 Thread GitBox
qin4zhang commented on issue #5054: Security vulnerability for 0.25.0 URL: https://github.com/apache/incubator-superset/issues/5054#issuecomment-391289151 @sebastianwindeck Same thing happened in version 0.25.5. As a common user with Gamma, I can get url /users/list/. Let's see picture

[GitHub] zhaoyongjie closed pull request #5048: [bugfix] Render to section by override value

2018-05-23 Thread GitBox
zhaoyongjie closed pull request #5048: [bugfix] Render to section by override value URL: https://github.com/apache/incubator-superset/pull/5048 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] williaster commented on issue #4993: [dashboard v2] tests!

2018-05-23 Thread GitBox
williaster commented on issue #4993: [dashboard v2] tests! URL: https://github.com/apache/incubator-superset/pull/4993#issuecomment-391246102 javascript tests are passing  we might need to rebase the `dashboard-builder` branch on master to fix the `py36-sqlite` + `py36-postgres` tests

[GitHub] miloradkrstevski commented on issue #5041: Permission to enable / disable CSV export on chart / slice

2018-05-23 Thread GitBox
miloradkrstevski commented on issue #5041: Permission to enable / disable CSV export on chart / slice URL: https://github.com/apache/incubator-superset/issues/5041#issuecomment-391233239 @TianyangLi What do I need to do here in order to delete the permission for CSV export? Can you help

[GitHub] codecov-io commented on issue #5060: [get_df] Adding support for multi-statement SQL

2018-05-23 Thread GitBox
codecov-io commented on issue #5060: [get_df] Adding support for multi-statement SQL URL: https://github.com/apache/incubator-superset/pull/5060#issuecomment-391232807 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5060?src=pr=h1) Report > Merging