mistercrunch commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1567835935
##
superset/migrations/versions/2024-04-15_16-06_0dc386701747_.py:
##
@@ -0,0 +1,38 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
mistercrunch commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1567835548
##
superset/migrations/versions/2024-04-15_16-06_0dc386701747_.py:
##
@@ -0,0 +1,38 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
sadpandajoe commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1567637221
##
superset/migrations/versions/2024-04-15_16-06_0dc386701747_.py:
##
@@ -0,0 +1,38 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
sadpandajoe commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1567636900
##
superset/migrations/versions/2024-04-11_00-49_bbf146925528_.py:
##
@@ -0,0 +1,38 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
mistercrunch merged PR #27849:
URL: https://github.com/apache/superset/pull/27849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mistercrunch commented on PR #27849:
URL: https://github.com/apache/superset/pull/27849#issuecomment-2058064791
@dpgaspar I addressed pretty much all feedback. Personally prefer avoiding
the CELERY_BEAT configuration, but open to consider that approach too if we
decide it's preferable.
mistercrunch commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1566593892
##
superset/views/users/api.py:
##
@@ -93,3 +97,85 @@ def get_my_roles(self) -> Response:
return self.response_401()
user =
mistercrunch commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1566593892
##
superset/views/users/api.py:
##
@@ -93,3 +97,85 @@ def get_my_roles(self) -> Response:
return self.response_401()
user =
mistercrunch commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1566589124
##
tests/integration_tests/users/api_tests.py:
##
@@ -62,3 +63,23 @@ def test_get_me_anonymous(self, mock_g):
mock_g.user =
mistercrunch commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1566588802
##
superset/config.py:
##
@@ -1453,6 +1455,7 @@ def EMAIL_HEADER_MUTATOR( # pylint:
disable=invalid-name,unused-argument
"data:",
mistercrunch commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1564818341
##
superset/utils/slack.py:
##
@@ -0,0 +1,33 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
mistercrunch commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1564815827
##
superset/config.py:
##
@@ -1453,6 +1455,7 @@ def EMAIL_HEADER_MUTATOR( # pylint:
disable=invalid-name,unused-argument
"data:",
mistercrunch commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1564797018
##
superset/config.py:
##
@@ -1453,6 +1455,7 @@ def EMAIL_HEADER_MUTATOR( # pylint:
disable=invalid-name,unused-argument
"data:",
mistercrunch commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1564797018
##
superset/config.py:
##
@@ -1453,6 +1455,7 @@ def EMAIL_HEADER_MUTATOR( # pylint:
disable=invalid-name,unused-argument
"data:",
rusackas commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1563072835
##
superset/config.py:
##
@@ -1453,6 +1455,7 @@ def EMAIL_HEADER_MUTATOR( # pylint:
disable=invalid-name,unused-argument
"data:",
mistercrunch commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1563018685
##
superset/config.py:
##
@@ -1328,6 +1328,8 @@ def EMAIL_HEADER_MUTATOR( # pylint:
disable=invalid-name,unused-argument
# Slack API token for the superset
mistercrunch commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1562908645
##
tests/integration_tests/users/api_tests.py:
##
@@ -62,3 +63,23 @@ def test_get_me_anonymous(self, mock_g):
mock_g.user =
mistercrunch commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1562902595
##
superset/views/users/api.py:
##
@@ -93,3 +97,85 @@ def get_my_roles(self) -> Response:
return self.response_401()
user =
mistercrunch commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1562902595
##
superset/views/users/api.py:
##
@@ -93,3 +97,85 @@ def get_my_roles(self) -> Response:
return self.response_401()
user =
mistercrunch commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1562793384
##
tests/integration_tests/users/api_tests.py:
##
@@ -62,3 +63,23 @@ def test_get_me_anonymous(self, mock_g):
mock_g.user =
mistercrunch commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1562752025
##
superset/config.py:
##
@@ -1453,6 +1455,7 @@ def EMAIL_HEADER_MUTATOR( # pylint:
disable=invalid-name,unused-argument
"data:",
mistercrunch commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1562748940
##
superset/models/user_attributes.py:
##
@@ -39,6 +41,22 @@ class UserAttribute(Model, AuditMixinNullable):
user = relationship(
dpgaspar commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1562493039
##
superset/views/users/api.py:
##
@@ -93,3 +97,85 @@ def get_my_roles(self) -> Response:
return self.response_401()
user =
dpgaspar commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1562487735
##
superset/utils/slack.py:
##
@@ -0,0 +1,33 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
mistercrunch commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1561788473
##
superset/config.py:
##
@@ -1328,6 +1328,8 @@ def EMAIL_HEADER_MUTATOR( # pylint:
disable=invalid-name,unused-argument
# Slack API token for the superset
michael-s-molina commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1561585283
##
superset/config.py:
##
@@ -1328,6 +1328,8 @@ def EMAIL_HEADER_MUTATOR( # pylint:
disable=invalid-name,unused-argument
# Slack API token for the
rusackas commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1561503023
##
superset/config.py:
##
@@ -1453,6 +1455,7 @@ def EMAIL_HEADER_MUTATOR( # pylint:
disable=invalid-name,unused-argument
"data:",
rusackas commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1561501550
##
superset/config.py:
##
@@ -1328,6 +1328,8 @@ def EMAIL_HEADER_MUTATOR( # pylint:
disable=invalid-name,unused-argument
# Slack API token for the superset
codecov[bot] commented on PR #27849:
URL: https://github.com/apache/superset/pull/27849#issuecomment-2031092195
##
[Codecov](https://app.codecov.io/gh/apache/superset/pull/27849?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
mistercrunch commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1547136207
##
superset/dashboards/api.py:
##
@@ -179,6 +179,9 @@ def ensure_thumbnails_enabled(self) -> Optional[Response]:
"owners.id",
mistercrunch commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1547131639
##
docker/pythonpath_dev/superset_config.py:
##
@@ -99,6 +99,7 @@ class CeleryConfig:
WEBDRIVER_BASEURL_USER_FRIENDLY = WEBDRIVER_BASEURL
mistercrunch commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1547130615
##
.gitignore:
##
@@ -110,5 +110,6 @@ release.json
messages.mo
docker/requirements-local.txt
+docker/.env-local
Review Comment:
Note: I was working
mistercrunch opened a new pull request, #27849:
URL: https://github.com/apache/superset/pull/27849
### SUMMARY
Our current Avatars are a little dry, using a limited variety of colors
and showing the user's initials. The app could use a little more
personality.
Now given we
33 matches
Mail list logo