rusackas closed pull request #27415: fix(maps): Rename Ukrainian City to
Ukrainian format and deccomunization
URL: https://github.com/apache/superset/pull/27415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
rusackas commented on PR #27415:
URL: https://github.com/apache/superset/pull/27415#issuecomment-2112863306
Closing this since it's not fixed in the notebook, and at least half of it
was covered by this PR: https://github.com/apache/superset/pull/28226
If you want to rename
rusackas commented on PR #27415:
URL: https://github.com/apache/superset/pull/27415#issuecomment-2032594644
One bit of technical feedback here: This geojson will be overwritten
whenever anyone runs the Jupyter Notebook, and pulls new data from Natural
Earth. So if you want to make changes
rusackas commented on PR #27415:
URL: https://github.com/apache/superset/pull/27415#issuecomment-1984713913
Ooh, that's even better. If NaturalEarth would reflect this in their data,
the fix would be far more impactful than affecting only Superset.
--
This is an automated message from
villebro commented on PR #27415:
URL: https://github.com/apache/superset/pull/27415#issuecomment-1984148512
> If we want this change to "stick" we should make an edit in the Jupyter
notebook, rather than editing a generated file which might get overridden.
Very good point @rusackas -
rusackas commented on PR #27415:
URL: https://github.com/apache/superset/pull/27415#issuecomment-1982315380
If we want this change to "stick" we should make an edit in the Jupyter
notebook, rather than editing a generated file which might get overridden.
--
This is an automated message
