rusackas commented on PR #27415: URL: https://github.com/apache/superset/pull/27415#issuecomment-2032594644
One bit of technical feedback here: This geojson will be overwritten whenever anyone runs the Jupyter Notebook, and pulls new data from Natural Earth. So if you want to make changes to the geojson file, it should be done in the notebook as part of that process/worflow. To address the elephant in the room: This does indeed feel a little political in nature, which is something we generally try not to dabble in in general. For instance, when there is a boundary dispute, we both sides "win" in the maps. With a given name, we don't usually default to the region's own language for the name; for example, we have a Spain map... not an España map. However, in this case, things are a little different, since indeed Kiev was imposed as a standard the USSR, which clearly no longer exists in its own right. Ukraine has been trying to adjust this standard since its independence in 1991, which far predates the current geopolitical struggles it faces, so I think there's a strong case to change it. Additionally, in 2019, the United States Board on Geographic Names officially changed its official spelling to "Kyiv," so I believe this change has merit if we're going to refer to other regions/territories by their American-English names (e.g. Spain). In other words, while this feels like stepping in controversy, I feel like this is actually consistent, current, accurate, and I'd have a significantly harder time making a case for the opposite. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
