[GitHub] [incubator-superset] aboganas commented on issue #8230: Deck GL Screengrid overlay does not update
aboganas commented on issue #8230: Deck GL Screengrid overlay does not update URL: https://github.com/apache/incubator-superset/issues/8230#issuecomment-532095583 Also on Screen Grid Play no longer works This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on issue #8226: Handle int64 columns with missing data in SQL Lab
betodealmeida commented on issue #8226: Handle int64 columns with missing data in SQL Lab URL: https://github.com/apache/incubator-superset/pull/8226#issuecomment-532080546 > The dataframe implementation looks good, as does the Presto engine dtype fix, but does this fully address #8225 if only Presto is handled? Are there other databases this fix should be implemented for (even in a separate PR)? You're right, this only fixes Presto. I'll do a separate PR addressing the other DBs. > Also curious about your thoughts on the feasibility of the PyArrow workaround here. Looks like it would solve our problem, but I don't know if it would be better to monkey patch PyArrow (or if it can be done), or if we should create a light wrapper around it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] kalimuthu123 commented on issue #7127: onClick not working on the chart items.
kalimuthu123 commented on issue #7127: onClick not working on the chart items. URL: https://github.com/apache/incubator-superset/issues/7127#issuecomment-532085500 any one having idea for this chart This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8233: Simplify and improve `expand_data` in Presto
codecov-io commented on issue #8233: Simplify and improve `expand_data` in Presto URL: https://github.com/apache/incubator-superset/pull/8233#issuecomment-532087901 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8233?src=pr=h1) Report > Merging [#8233](https://codecov.io/gh/apache/incubator-superset/pull/8233?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1ad17936ba46ece16e4243b8f42adc155d7fe48b?src=pr=desc) will **increase** coverage by `0.04%`. > The diff coverage is `93.97%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8233?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8233 +/- ## == + Coverage 65.98% 66.03% +0.04% == Files 479 479 Lines 2303823105 +67 Branches 2552 2552 == + Hits1520215257 +55 - Misses 7700 7712 +12 Partials 136 136 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8233?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8233/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.33% <100%> (+0.38%)` | :arrow_up: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/8233/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `77.52% <92.06%> (-0.28%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8233?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8233?src=pr=footer). Last update [1ad1793...e337b35](https://codecov.io/gh/apache/incubator-superset/pull/8233?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] kalimuthu123 opened a new issue #8234: Filter dashboard clicking on chart #5941
kalimuthu123 opened a new issue #8234: Filter dashboard clicking on chart #5941 URL: https://github.com/apache/incubator-superset/issues/8234 **Is your feature request related to a problem? Please describe.** click the chart to affect the other chart as a filter **Describe the solution you'd like** chart filter by single click **Describe alternatives you've considered** click based chart filter This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8234: Filter dashboard clicking on chart #5941
issue-label-bot[bot] commented on issue #8234: Filter dashboard clicking on chart #5941 URL: https://github.com/apache/incubator-superset/issues/8234#issuecomment-532148398 Issue-Label Bot is automatically applying the label `#enhancement` to this issue, with a confidence of 0.88. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] closed issue #7859: "Create Option" is not working in Filter Box
stale[bot] closed issue #7859: "Create Option" is not working in Filter Box URL: https://github.com/apache/incubator-superset/issues/7859 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] celestewang1026 commented on issue #8114: superset conn hive faied
celestewang1026 commented on issue #8114: superset conn hive faied URL: https://github.com/apache/incubator-superset/issues/8114#issuecomment-532161623 > > @celestewang1026 Try this steps > > > > 1. stop Superset process > > 2. activate virtual environment if you use it > > 3. pip uninstall pyhive > > 4. pip install --force-reinstall --no-cache-dir --upgrade pyhive > > 5. restart Superset process > > sorry to say it's not work unless pip uninstall impyla. > > Another question the table has a column that's type is array,but it can not show >  > >  Is it convenient for you to provide wechat ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] celestewang1026 edited a comment on issue #8114: superset conn hive faied
celestewang1026 edited a comment on issue #8114: superset conn hive faied URL: https://github.com/apache/incubator-superset/issues/8114#issuecomment-532161623 > > @celestewang1026 Try this steps > > > > 1. stop Superset process > > 2. activate virtual environment if you use it > > 3. pip uninstall pyhive > > 4. pip install --force-reinstall --no-cache-dir --upgrade pyhive > > 5. restart Superset process > > sorry to say it's not work unless pip uninstall impyla. > > Another question the table has a column that's type is array,but it can not show >  > >  Is it convenient for you to provide wechat information? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8235: ERROR: {"error": "Connection failed!\n\nThe error message returned was:\n(psycopg2.OperationalError) could not translate ho
issue-label-bot[bot] commented on issue #8235: ERROR: {"error": "Connection
failed!\n\nThe error message returned was:\n(psycopg2.OperationalError) could
not translate host name \"example.com\" to address: Name or service not known\n
(Background on this error at: http://sqlalche.me/e/e3q8)"}
URL:
https://github.com/apache/incubator-superset/issues/8235#issuecomment-532170795
Issue-Label Bot is automatically applying the label `#question` to this
issue, with a confidence of 0.73. Please mark this comment with :thumbsup: or
:thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot),
[dashboard](https://mlbot.net/data/apache/incubator-superset) and
[code](https://github.com/hamelsmu/MLapp) for this bot.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] Gowtham029 opened a new issue #8235: ERROR: {"error": "Connection failed!\n\nThe error message returned was:\n(psycopg2.OperationalError) could not translate host name \"
Gowtham029 opened a new issue #8235: ERROR: {"error": "Connection
failed!\n\nThe error message returned was:\n(psycopg2.OperationalError) could
not translate host name \"example.com\" to address: Name or service not known\n
(Background on this error at: http://sqlalche.me/e/e3q8)"}
URL: https://github.com/apache/incubator-superset/issues/8235
Hi All,
I have been trying to connect to postgres, but I am ending up with the error.
ERROR: {"error": "Connection failed!\n\nThe error message returned
was:\n(psycopg2.OperationalError) could not translate host name \"example.com\"
to address: Name or service not known\n (Background on this error at:
http://sqlalche.me/e/e3q8)"}
OS : Centos 7
DB : Postgres 9+
Name: superset
Version: 0.28.1
License: Apache License, Version 2.0
Location: /home/centos/venv/lib/python3.6/site-packages
Requires: bleach, boto3, botocore, celery, click, colorama, contextlib2,
cryptography, flask, flask-appbuilder, flask-caching, flask-compress,
flask-migrate, flask-wtf, flower, future, geopy, gunicorn, humanize, idna,
isodate, markdown, pandas, parsedatetime, pathlib2, polyline, pydruid, pyhive,
python-dateutil, python-geohash, pyyaml, requests, simplejson, sqlalchemy,
sqlalchemy-utils, sqlparse, tableschema, thrift, thrift-sasl, unicodecsv,
unidecode
`
I have installed the following packages
pip install psycopg2
Version: 2.8.3
pip install psycopg2-binary
Version: 2.8.3
DB connection String :
1.postgresql://username:passw...@example.com/test_db
**The above connection works when I installed superset with Docker.**
2.postgresql+psycopg2://username:passw...@example.com/test_db
Help me to solve the issue!
Thanks in Advance.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] celestewang1026 edited a comment on issue #8114: superset conn hive faied
celestewang1026 edited a comment on issue #8114: superset conn hive faied URL: https://github.com/apache/incubator-superset/issues/8114#issuecomment-532161623 > > @celestewang1026 Try this steps > > > > 1. stop Superset process > > 2. activate virtual environment if you use it > > 3. pip uninstall pyhive > > 4. pip install --force-reinstall --no-cache-dir --upgrade pyhive > > 5. restart Superset process > > sorry to say it's not work unless pip uninstall impyla. > > Another question the table has a column that's type is array,but it can not show >  > >  Is it convenient for you to provide wechat ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ganesh8614 commented on issue #5119: [sqllab] allow gamma users to access their SQLLab views
ganesh8614 commented on issue #5119: [sqllab] allow gamma users to access their SQLLab views URL: https://github.com/apache/incubator-superset/pull/5119#issuecomment-532169771 Hi @mistercrunch I also faced similar issue for gamma user and while trying to modify the files i don't see them. **Files** 1) superset/assets/spec/javascripts/sqllab/VisualizeModal_spec.jsx 2) superset/assets/src/SqlLab/actions.js 3) superset/assets/src/SqlLab/components/VisualizeModal.jsx i have installed and verified in both 0.28v & 0.34v (which is latest) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #7899: How to get superset charts in angular project?
stale[bot] commented on issue #7899: How to get superset charts in angular project? URL: https://github.com/apache/incubator-superset/issues/7899#issuecomment-532146673 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] closed issue #7825: Superset cannot start, reporting "AttributeError: 'NoneType' object has no attribute 'session' at startup"
stale[bot] closed issue #7825: Superset cannot start, reporting "AttributeError: 'NoneType' object has no attribute 'session' at startup" URL: https://github.com/apache/incubator-superset/issues/7825 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on issue #8235: Connection failed!\n\nThe error message returned was:\n(psycopg2.OperationalError) could not translate host name \"example.com\" to add
dpgaspar commented on issue #8235: Connection failed!\n\nThe error message returned was:\n(psycopg2.OperationalError) could not translate host name \"example.com\" to address: Name or service not known\n (Background on this error at: http://sqlalche.me/e/e3q8) URL: https://github.com/apache/incubator-superset/issues/8235#issuecomment-532220508 You must replace the URI with the details from your postgres DB: https://docs.sqlalchemy.org/en/13/core/engines.html#engine-configuration This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ganesh8614 edited a comment on issue #5119: [sqllab] allow gamma users to access their SQLLab views
ganesh8614 edited a comment on issue #5119: [sqllab] allow gamma users to access their SQLLab views URL: https://github.com/apache/incubator-superset/pull/5119#issuecomment-532169771 Hi @mistercrunch I also faced similar issue for gamma user and while trying to modify the files i don't see them. **Files** 1) superset/assets/spec/javascripts/sqllab/VisualizeModal_spec.jsx 2) superset/assets/src/SqlLab/actions.js 3) superset/assets/src/SqlLab/components/VisualizeModal.jsx i have installed and verified in both 0.28v & 0.34v (Latest Version) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8172: Allow users to estimate query cost before executing it
betodealmeida commented on a change in pull request #8172: Allow users to
estimate query cost before executing it
URL:
https://github.com/apache/incubator-superset/pull/8172#discussion_r325234395
##
File path: superset/views/core.py
##
@@ -105,8 +106,12 @@
get_viz,
)
+
config = app.config
CACHE_DEFAULT_TIMEOUT = config.get("CACHE_DEFAULT_TIMEOUT", 0)
+SQLLAB_QUERY_COST_ESTIMATE_TIMEOUT = config.get(
Review comment:
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on issue #8240: [database] Improve form and API validation for invalid URI
etr2460 commented on issue #8240: [database] Improve form and API validation for invalid URI URL: https://github.com/apache/incubator-superset/pull/8240#issuecomment-532292668 Can you include screenshots of the new error message/UI changes? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #7886: shortner use origin instead of host
stale[bot] commented on issue #7886: shortner use origin instead of host URL: https://github.com/apache/incubator-superset/pull/7886#issuecomment-532303406 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8172: Allow users to estimate query cost before executing it
betodealmeida commented on a change in pull request #8172: Allow users to
estimate query cost before executing it
URL:
https://github.com/apache/incubator-superset/pull/8172#discussion_r325234987
##
File path: superset/views/core.py
##
@@ -2391,6 +2396,34 @@ def select_star(self, database_id, table_name,
schema=None):
mydb.select_star(table_name, schema, latest_partition=True,
show_cols=True)
)
+@has_access_api
+@expose("/estimate_query_cost//", methods=["POST"])
+@expose("/estimate_query_cost///", methods=["POST"])
+@event_logger.log_this
+def estimate_query_cost(self, database_id: int, schema: str = None) ->
Response:
+mydb =
db.session.query(models.Database).filter_by(id=database_id).first()
Review comment:
Ah, I wasn't familiar with `one_or_none()`, seems better suited. I'll change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang closed pull request #8224: [wip][sqllab] create query slightly earlier
serenajiang closed pull request #8224: [wip][sqllab] create query slightly earlier URL: https://github.com/apache/incubator-superset/pull/8224 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang opened a new pull request #8224: [wip][sqllab] create query slightly earlier
serenajiang opened a new pull request #8224: [wip][sqllab] create query slightly earlier URL: https://github.com/apache/incubator-superset/pull/8224 ### CATEGORY Choose one - [X] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Part of the ongoing saga of trying to fix `stop_query` issues. Flips the order of the rejected tables check and query creation so that queries are created slightly earlier. This might prevent errors like `No row was found for one()` if a user stops the query before it is actually created. This also means that if a user doesn't have access to the tables in the query, the query will still be recorded in the queries table with the status `QueryStatus.FAILED`. Previously, these queries were not recorded. ### TEST PLAN Ran some queries locally to make sure they still worked. Confirmed that queries are now logged to the queries table with the status QueryStatus.FAILED if the user does not have access to a table in the query. ### REVIEWERS @etr2460 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] thewoodenshoe commented on issue #3729: Added multi-tenancy support.
thewoodenshoe commented on issue #3729: Added multi-tenancy support. URL: https://github.com/apache/incubator-superset/pull/3729#issuecomment-532387644 Any updates on this, I'm interested in this as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida merged pull request #8172: Allow users to estimate query cost before executing it
betodealmeida merged pull request #8172: Allow users to estimate query cost before executing it URL: https://github.com/apache/incubator-superset/pull/8172 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang opened a new pull request #8224: [wip][sqllab] create query slightly earlier
serenajiang opened a new pull request #8224: [wip][sqllab] create query slightly earlier URL: https://github.com/apache/incubator-superset/pull/8224 ### CATEGORY Choose one - [X] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Part of the ongoing saga of trying to fix `stop_query` issues. Flips the order of the rejected tables check and query creation so that queries are created slightly earlier. This might prevent errors like `No row was found for one()` if a user stops the query before it is actually created. This also means that if a user doesn't have access to the tables in the query, the query will still be recorded in the queries table with the status `QueryStatus.FAILED`. Previously, these queries were not recorded. ### TEST PLAN Ran some queries locally to make sure they still worked. Confirmed that queries are now logged to the queries table with the status QueryStatus.FAILED if the user does not have access to a table in the query. ### REVIEWERS @etr2460 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang closed pull request #8224: [wip][sqllab] create query slightly earlier
serenajiang closed pull request #8224: [wip][sqllab] create query slightly earlier URL: https://github.com/apache/incubator-superset/pull/8224 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] aboganas commented on a change in pull request #7866: [wip] fix: multi deck.gl bug fixes (pt 2)
aboganas commented on a change in pull request #7866: [wip] fix: multi deck.gl
bug fixes (pt 2)
URL:
https://github.com/apache/incubator-superset/pull/7866#discussion_r325290906
##
File path:
superset/assets/src/visualizations/deckgl/layers/Screengrid/Screengrid.jsx
##
@@ -41,7 +41,7 @@ function setTooltipContent(o) {
);
}
-export function getLayer(formData, payload, onAddFilter, setTooltip, filters) {
+export function getLayer(formData, payload, onAddFilter, setTooltip, selected,
onSelect, filters) {
Review comment:
This broke the play slider (doesn't play anymore), if I revert this line
back then it works
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] khtruong commented on a change in pull request #8233: Simplify and improve `expand_data` in Presto
khtruong commented on a change in pull request #8233: Simplify and improve
`expand_data` in Presto
URL:
https://github.com/apache/incubator-superset/pull/8233#discussion_r325309653
##
File path: superset/db_engine_specs/presto.py
##
@@ -40,6 +40,51 @@
QueryStatus = utils.QueryStatus
+def get_children(column: Dict[str, str]) -> List[Dict[str, str]]:
+"""
+Get the children of a complex Presto type (row or array).
+
+For arrays, we return a single list with the base type:
+
+>>> get_children(dict(name="a", type="ARRAY(BIGINT)"))
+[{"name": "a", "type": "BIGINT"}]
+
+For rows, we return a list of the columns:
+
+>>> get_children(dict(name="a", type="ROW(BIGINT,FOO VARCHAR)"))
Review comment:
This is more for my understanding than a PR comment. I thought each row has
a variable name before the type. For example `ROW(FOO BIGINT, BAR VARCHAR)`.
When will there be a nameless column again?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] closed issue #7865: Example dashboards are unpublished by default
stale[bot] closed issue #7865: Example dashboards are unpublished by default URL: https://github.com/apache/incubator-superset/issues/7865 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #7903: Gamma users can create charts for the data source they don't have access
stale[bot] commented on issue #7903: Gamma users can create charts for the data source they don't have access URL: https://github.com/apache/incubator-superset/issues/7903#issuecomment-532405413 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang opened a new pull request #8224: [wip][sqllab] create query slightly earlier
serenajiang opened a new pull request #8224: [wip][sqllab] create query slightly earlier URL: https://github.com/apache/incubator-superset/pull/8224 ### CATEGORY Choose one - [X] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Part of the ongoing saga of trying to fix `stop_query` issues. Flips the order of the rejected tables check and query creation so that queries are created slightly earlier. This might prevent errors like `No row was found for one()` if a user stops the query before it is actually created. This also means that if a user doesn't have access to the tables in the query, the query will still be recorded in the queries table with the status `QueryStatus.FAILED`. Previously, these queries were not recorded. ### TEST PLAN Ran some queries locally to make sure they still worked. Confirmed that queries are now logged to the queries table with the status QueryStatus.FAILED if the user does not have access to a table in the query. ### REVIEWERS @etr2460 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang closed pull request #8224: [wip][sqllab] create query slightly earlier
serenajiang closed pull request #8224: [wip][sqllab] create query slightly earlier URL: https://github.com/apache/incubator-superset/pull/8224 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8242: X-axis label and y-axis label for Heatmap
issue-label-bot[bot] commented on issue #8242: X-axis label and y-axis label for Heatmap URL: https://github.com/apache/incubator-superset/issues/8242#issuecomment-532466675 Issue-Label Bot is automatically applying the label `#enhancement` to this issue, with a confidence of 0.88. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] syazwan0913 opened a new issue #8242: X-axis label and y-axis label for Heatmap
syazwan0913 opened a new issue #8242: X-axis label and y-axis label for Heatmap URL: https://github.com/apache/incubator-superset/issues/8242 I would like to request the Heatmap visualization to have x-axis label and y-axis label. Just like NVD3 chart, they have the labels.  X-axis/Y-axis label on NVD3 Bar chart  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8224: [sqllab] create query slightly earlier
codecov-io edited a comment on issue #8224: [sqllab] create query slightly earlier URL: https://github.com/apache/incubator-superset/pull/8224#issuecomment-531398993 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=h1) Report > Merging [#8224](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/bf7ce62166a753d2e05a0a7d3dcbaff486784dad?src=pr=desc) will **increase** coverage by `1.51%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8224 +/- ## == + Coverage 65.97% 67.49% +1.51% == Files 479 481 +2 Lines 2303825371+2333 Branches 2552 2655 +103 == + Hits1520017124+1924 - Misses 7702 8106 +404 - Partials 136 141 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.6% <75%> (+5.46%)` | :arrow_up: | | [superset/assets/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL1RhYmxlU2VsZWN0b3IuanN4) | `80.92% <0%> (-3.25%)` | :arrow_down: | | [...rset/assets/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9UYWJsZUVsZW1lbnQuanN4) | `83.2% <0%> (-1.14%)` | :arrow_down: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `89.17% <0%> (-0.83%)` | :arrow_down: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.35% <0%> (-0.48%)` | :arrow_down: | | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `100% <0%> (ø)` | :arrow_up: | | [...rset/assets/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0% <0%> (ø)` | :arrow_up: | | [superset/assets/src/SqlLab/components/ShowSQL.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TaG93U1FMLmpzeA==) | `55.55% <0%> (ø)` | | | [.../src/SqlLab/components/EstimateQueryCostButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9Fc3RpbWF0ZVF1ZXJ5Q29zdEJ1dHRvbi5qc3g=) | `17.39% <0%> (ø)` | | | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.33% <0%> (+0.38%)` | :arrow_up: | | ... and [9 more](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=footer). Last update [bf7ce62...9384b9f](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8224: [sqllab] create query slightly earlier
codecov-io edited a comment on issue #8224: [sqllab] create query slightly earlier URL: https://github.com/apache/incubator-superset/pull/8224#issuecomment-531398993 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=h1) Report > Merging [#8224](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/bf7ce62166a753d2e05a0a7d3dcbaff486784dad?src=pr=desc) will **increase** coverage by `1.51%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8224 +/- ## == + Coverage 65.97% 67.49% +1.51% == Files 479 481 +2 Lines 2303825371+2333 Branches 2552 2655 +103 == + Hits1520017124+1924 - Misses 7702 8106 +404 - Partials 136 141 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.6% <75%> (+5.46%)` | :arrow_up: | | [superset/assets/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL1RhYmxlU2VsZWN0b3IuanN4) | `80.92% <0%> (-3.25%)` | :arrow_down: | | [...rset/assets/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9UYWJsZUVsZW1lbnQuanN4) | `83.2% <0%> (-1.14%)` | :arrow_down: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `89.17% <0%> (-0.83%)` | :arrow_down: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.35% <0%> (-0.48%)` | :arrow_down: | | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `100% <0%> (ø)` | :arrow_up: | | [...rset/assets/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0% <0%> (ø)` | :arrow_up: | | [superset/assets/src/SqlLab/components/ShowSQL.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TaG93U1FMLmpzeA==) | `55.55% <0%> (ø)` | | | [.../src/SqlLab/components/EstimateQueryCostButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9Fc3RpbWF0ZVF1ZXJ5Q29zdEJ1dHRvbi5qc3g=) | `17.39% <0%> (ø)` | | | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.33% <0%> (+0.38%)` | :arrow_up: | | ... and [9 more](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=footer). Last update [bf7ce62...9384b9f](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull request #8224: [sqllab] create query slightly earlier
john-bodley commented on a change in pull request #8224: [sqllab] create query slightly earlier URL: https://github.com/apache/incubator-superset/pull/8224#discussion_r325433240 ## File path: superset/views/core.py ## @@ -2608,11 +2601,21 @@ def sql_json(self): session.add(query) session.flush() query_id = query.id -session.commit() # shouldn't be necessary +session.commit() Review comment: Can we just revert this from a blame perspective. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull request #8224: [sqllab] create query slightly earlier
john-bodley commented on a change in pull request #8224: [sqllab] create query
slightly earlier
URL:
https://github.com/apache/incubator-superset/pull/8224#discussion_r325432439
##
File path: superset/views/core.py
##
@@ -2572,19 +2572,12 @@ def sql_json(self):
limit = limit or app.config.get("SQL_MAX_ROW")
session = db.session()
-mydb = session.query(models.Database).filter_by(id=database_id).first()
+mydb =
session.query(models.Database).filter_by(id=database_id).one_or_none()
if not mydb:
-json_error_response("Database with id {} is
missing.".format(database_id))
-
-rejected_tables = security_manager.rejected_tables(sql, mydb, schema)
-if rejected_tables:
return json_error_response(
-security_manager.get_table_access_error_msg(rejected_tables),
-link=security_manager.get_table_access_link(rejected_tables),
-status=403,
+"Database with id {} is missing.".format(database_id)
Review comment:
Can we use `f` strings here?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8243: Show Presto views as views, not tables
codecov-io edited a comment on issue #8243: Show Presto views as views, not tables URL: https://github.com/apache/incubator-superset/pull/8243#issuecomment-532478701 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8243?src=pr=h1) Report > Merging [#8243](https://codecov.io/gh/apache/incubator-superset/pull/8243?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/88777943faf468df7b2c38fc5f5117a5c0ad8cc3?src=pr=desc) will **increase** coverage by `7.61%`. > The diff coverage is `30.76%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8243?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8243 +/- ## == + Coverage 65.72% 73.34% +7.61% == Files 481 115 -366 Lines 2331712241 -11076 Branches 25720-2572 == - Hits15326 8978-6348 + Misses 7853 3263-4590 + Partials 1380 -138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8243?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.55% <ø> (ø)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <ø> (ø)` | :arrow_up: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.36% <0%> (-0.05%)` | :arrow_down: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.61% <100%> (ø)` | :arrow_up: | | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `72.41% <100%> (ø)` | :arrow_up: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.33% <22.72%> (-2.04%)` | :arrow_down: | | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | | | | [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | | | | [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | | | | [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | | | | ... and [361 more](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8243?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8243?src=pr=footer). Last update [8877794...4a6847f](https://codecov.io/gh/apache/incubator-superset/pull/8243?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8243: Show Presto views as views, not tables
codecov-io commented on issue #8243: Show Presto views as views, not tables URL: https://github.com/apache/incubator-superset/pull/8243#issuecomment-532478701 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8243?src=pr=h1) Report > Merging [#8243](https://codecov.io/gh/apache/incubator-superset/pull/8243?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/88777943faf468df7b2c38fc5f5117a5c0ad8cc3?src=pr=desc) will **increase** coverage by `7.61%`. > The diff coverage is `30.76%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8243?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8243 +/- ## == + Coverage 65.72% 73.34% +7.61% == Files 481 115 -366 Lines 2331712241 -11076 Branches 25720-2572 == - Hits15326 8978-6348 + Misses 7853 3263-4590 + Partials 1380 -138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8243?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.55% <ø> (ø)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <ø> (ø)` | :arrow_up: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.36% <0%> (-0.05%)` | :arrow_down: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.61% <100%> (ø)` | :arrow_up: | | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `72.41% <100%> (ø)` | :arrow_up: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.33% <22.72%> (-2.04%)` | :arrow_down: | | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | | | | [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | | | | [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | | | | [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | | | | ... and [361 more](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8243?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8243?src=pr=footer). Last update [8877794...4a6847f](https://codecov.io/gh/apache/incubator-superset/pull/8243?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #8219: [WIP] Build better support for schema permissions
bkyryliuk commented on a change in pull request #8219: [WIP] Build better support for schema permissions URL: https://github.com/apache/incubator-superset/pull/8219#discussion_r325380478 ## File path: superset/security.py ## @@ -376,19 +380,47 @@ def rejected_tables(self, sql: str, database: "Database", schema: str) -> List[s if not self._datasource_access_by_fullname(database, t, schema) ] -def _user_datasource_perms(self) -> Set[str]: -""" -Return the set of FAB permission view-menu names the user can access. +def get_public_role(self): Review comment: Done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8213: Better distinction between tables and views, and show CREATE VIEW
codecov-io commented on issue #8213: Better distinction between tables and views, and show CREATE VIEW URL: https://github.com/apache/incubator-superset/pull/8213#issuecomment-532408612 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8213?src=pr=h1) Report > Merging [#8213](https://codecov.io/gh/apache/incubator-superset/pull/8213?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4132d8fb0f7d79556e4ecf6199e0611da5303aea?src=pr=desc) will **decrease** coverage by `0.06%`. > The diff coverage is `42.85%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8213?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8213 +/- ## == - Coverage 65.79% 65.72% -0.07% == Files 480 481 +1 Lines 2327323317 +44 Branches 2567 2572 +5 == + Hits1531215326 +14 - Misses 7823 7853 +30 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8213?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8213/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.41% <ø> (ø)` | :arrow_up: | | [superset/assets/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8213/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL1RhYmxlU2VsZWN0b3IuanN4) | `77.69% <0%> (-6.48%)` | :arrow_down: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/8213/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.61% <40%> (-0.49%)` | :arrow_down: | | [...rset/assets/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8213/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9UYWJsZUVsZW1lbnQuanN4) | `83.52% <50%> (-0.81%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/8213/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `72.37% <53.33%> (-1.48%)` | :arrow_down: | | [superset/assets/src/SqlLab/components/ShowSQL.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8213/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TaG93U1FMLmpzeA==) | `55.55% <55.55%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8213?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8213?src=pr=footer). Last update [4132d8f...d93c426](https://codecov.io/gh/apache/incubator-superset/pull/8213?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] nmits opened a new issue #8241: Superset fails to build JSON (specifically with producing label colors) for very large sets of data
nmits opened a new issue #8241: Superset fails to build JSON (specifically with
producing label colors) for very large sets of data
URL: https://github.com/apache/incubator-superset/issues/8241
A clear and concise description of what the bug is.
### Expected results
Produces UI for large quantity of elements
### Actual results
Superset throws 500 error and UI becomes unusable for listing dashboards or
viewing affected dashboard
How to reproduce the bug
1. Create a pie chart with large limit for rows (Enough that string length
of Parameters, specifically with label colors > 65530 characters)
2. Set a color scheme (To generate Label Colors dynamically)
3. Save in Superset UI
4. 500 Error on listing dashboards or viewing affected dashboard
Error is due to String length of Parameters exceeding 65530 characters
(2^16) and being truncated therefore invalid JSON leading to JSON deserialize
error
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included
it here as text if there are any.
- [ ] I have reproduced the issue with at least the latest released version
of superset.
- [X] I have checked the issue tracker for the same issue and I haven't
found one similar.
### Additional context
Add any other context about the problem here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8241: Superset fails to build JSON (specifically with producing label colors) for very large sets of data
issue-label-bot[bot] commented on issue #8241: Superset fails to build JSON (specifically with producing label colors) for very large sets of data URL: https://github.com/apache/incubator-superset/issues/8241#issuecomment-532418391 Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.90. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida opened a new pull request #8243: Show Presto views as views, not tables
betodealmeida opened a new pull request #8243: Show Presto views as views, not tables URL: https://github.com/apache/incubator-superset/pull/8243 ### CATEGORY Choose one - [ ] Bug Fix - [X] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Currently, Presto displays views as tables, since the statement `SHOW TABLES` shows both views and tables, and there's no `SHOW VIEWS`. One workaround to get the list of views is to query the `information_schema` schema: ```sql SELECT table_name FROM information_schema_views WHERE table_schema='default'; ``` This returns the actual list of views, but it's slow. On our Presto cluster it takes approximately 90 seconds to get all the views across all schemas. Fortunately, the API that exposes the views is cached, so this shouldn't be too bad. I added a new feature flag, `PRESTO_SPLIT_VIEWS_FROM_TABLES` (open for better name suggestions), that when enabled will show views differently than tables in SQL Lab. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Now views are properly marked as such in Presto: https://user-images.githubusercontent.com/1534870/65093650-e51e2280-d971-11e9-8eec-9d1442fcf1ee.png;> ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @khtruong @etr2460 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8224: [sqllab] create query slightly earlier
serenajiang commented on a change in pull request #8224: [sqllab] create query slightly earlier URL: https://github.com/apache/incubator-superset/pull/8224#discussion_r325410020 ## File path: superset/views/core.py ## @@ -2608,11 +2601,21 @@ def sql_json(self): session.add(query) session.flush() query_id = query.id -session.commit() # shouldn't be necessary +session.commit() Review comment: afaik, flushing actually doesn't actually affect the database, just the session. If something went wrong before a commit, the query creation would be rolled back. I'm actually not sure if `session.flush()` is necessary in this case, but I think `session.commit()` is. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8233: Simplify and improve `expand_data` in Presto
betodealmeida commented on a change in pull request #8233: Simplify and improve
`expand_data` in Presto
URL:
https://github.com/apache/incubator-superset/pull/8233#discussion_r325384988
##
File path: superset/db_engine_specs/presto.py
##
@@ -40,6 +40,51 @@
QueryStatus = utils.QueryStatus
+def get_children(column: Dict[str, str]) -> List[Dict[str, str]]:
+"""
+Get the children of a complex Presto type (row or array).
+
+For arrays, we return a single list with the base type:
+
+>>> get_children(dict(name="a", type="ARRAY(BIGINT)"))
+[{"name": "a", "type": "BIGINT"}]
+
+For rows, we return a list of the columns:
+
+>>> get_children(dict(name="a", type="ROW(BIGINT,FOO VARCHAR)"))
Review comment:
Good question! If you do a query like:
```sql
SELECT ARRAY[ROW(100,0,'hello')]
```
The resulting column has type `ARRAY(ROW(INTEGER,INTEGER,VARCHAR(5)))`,
without names.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida merged pull request #8233: Simplify and improve `expand_data` in Presto
betodealmeida merged pull request #8233: Simplify and improve `expand_data` in Presto URL: https://github.com/apache/incubator-superset/pull/8233 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida merged pull request #8213: Better distinction between tables and views, and show CREATE VIEW
betodealmeida merged pull request #8213: Better distinction between tables and views, and show CREATE VIEW URL: https://github.com/apache/incubator-superset/pull/8213 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #7904: Export .csv API to Excel, Google Sheets, etc.
stale[bot] commented on issue #7904: Export .csv API to Excel, Google Sheets, etc. URL: https://github.com/apache/incubator-superset/issues/7904#issuecomment-532423395 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] syazwan0913 closed issue #8169: Where to find superset.log file?
syazwan0913 closed issue #8169: Where to find superset.log file? URL: https://github.com/apache/incubator-superset/issues/8169 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] syazwan0913 commented on issue #8169: Where to find superset.log file?
syazwan0913 commented on issue #8169: Where to find superset.log file? URL: https://github.com/apache/incubator-superset/issues/8169#issuecomment-532467245 Alright thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8224: [sqllab] create query slightly earlier
etr2460 commented on a change in pull request #8224: [sqllab] create query slightly earlier URL: https://github.com/apache/incubator-superset/pull/8224#discussion_r325406007 ## File path: superset/views/core.py ## @@ -2608,11 +2601,21 @@ def sql_json(self): session.add(query) session.flush() query_id = query.id -session.commit() # shouldn't be necessary +session.commit() Review comment: why'd we remove the comment here? By flushing, i think the commit should happen automatically, so it does seem that this still shouldn't be necessary This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8224: [sqllab] create query slightly earlier
codecov-io edited a comment on issue #8224: [sqllab] create query slightly earlier URL: https://github.com/apache/incubator-superset/pull/8224#issuecomment-531398993 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=h1) Report > Merging [#8224](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/bf7ce62166a753d2e05a0a7d3dcbaff486784dad?src=pr=desc) will **increase** coverage by `1.51%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8224 +/- ## == + Coverage 65.97% 67.49% +1.51% == Files 479 481 +2 Lines 2303825371+2333 Branches 2552 2655 +103 == + Hits1520017124+1924 - Misses 7702 8106 +404 - Partials 136 141 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.6% <75%> (+5.46%)` | :arrow_up: | | [superset/assets/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL1RhYmxlU2VsZWN0b3IuanN4) | `80.92% <0%> (-3.25%)` | :arrow_down: | | [...rset/assets/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9UYWJsZUVsZW1lbnQuanN4) | `83.2% <0%> (-1.14%)` | :arrow_down: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `89.17% <0%> (-0.83%)` | :arrow_down: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.35% <0%> (-0.48%)` | :arrow_down: | | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `100% <0%> (ø)` | :arrow_up: | | [...rset/assets/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0% <0%> (ø)` | :arrow_up: | | [superset/assets/src/SqlLab/components/ShowSQL.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TaG93U1FMLmpzeA==) | `55.55% <0%> (ø)` | | | [.../src/SqlLab/components/EstimateQueryCostButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9Fc3RpbWF0ZVF1ZXJ5Q29zdEJ1dHRvbi5qc3g=) | `17.39% <0%> (ø)` | | | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.33% <0%> (+0.38%)` | :arrow_up: | | ... and [9 more](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=footer). Last update [bf7ce62...9384b9f](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8224: [sqllab] create query slightly earlier
codecov-io edited a comment on issue #8224: [sqllab] create query slightly earlier URL: https://github.com/apache/incubator-superset/pull/8224#issuecomment-531398993 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=h1) Report > Merging [#8224](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/bf7ce62166a753d2e05a0a7d3dcbaff486784dad?src=pr=desc) will **increase** coverage by `1.51%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8224 +/- ## == + Coverage 65.97% 67.49% +1.51% == Files 479 481 +2 Lines 2303825371+2333 Branches 2552 2655 +103 == + Hits1520017124+1924 - Misses 7702 8106 +404 - Partials 136 141 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.6% <75%> (+5.46%)` | :arrow_up: | | [superset/assets/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL1RhYmxlU2VsZWN0b3IuanN4) | `80.92% <0%> (-3.25%)` | :arrow_down: | | [...rset/assets/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9UYWJsZUVsZW1lbnQuanN4) | `83.2% <0%> (-1.14%)` | :arrow_down: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `89.17% <0%> (-0.83%)` | :arrow_down: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.35% <0%> (-0.48%)` | :arrow_down: | | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `100% <0%> (ø)` | :arrow_up: | | [...rset/assets/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0% <0%> (ø)` | :arrow_up: | | [superset/assets/src/SqlLab/components/ShowSQL.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TaG93U1FMLmpzeA==) | `55.55% <0%> (ø)` | | | [.../src/SqlLab/components/EstimateQueryCostButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9Fc3RpbWF0ZVF1ZXJ5Q29zdEJ1dHRvbi5qc3g=) | `17.39% <0%> (ø)` | | | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.33% <0%> (+0.38%)` | :arrow_up: | | ... and [9 more](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=footer). Last update [bf7ce62...9384b9f](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #3729: Added multi-tenancy support.
mistercrunch commented on issue #3729: Added multi-tenancy support. URL: https://github.com/apache/incubator-superset/pull/3729#issuecomment-532529961 We don't think this is the right approach, and it turns out making Superset multitenant with strong security/isolation guarantees isn't easy. This would require a SIP (Superset Improvement Proposal) with a detailed plan. Also to be discussed is whether we'd want to do schema-level multitenancy or row-level. Row-level seems like the right approach, but would have to be baked deeply in the app. That's hard to do as an afterthought, and especially given the fact that FAB is not tenant aware. Making FAB tenant-aware may be part of the solution. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #8241: Superset fails to build JSON (specifically with producing label colors) for very large sets of data
mistercrunch commented on issue #8241: Superset fails to build JSON (specifically with producing label colors) for very large sets of data URL: https://github.com/apache/incubator-superset/issues/8241#issuecomment-532531314 @khtruong I think this is related to the dashboard color feature you added, should we limit the payload there? I noticed charts getting saved with large payloads too related to this This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] dpgaspar opened a new pull request #8239: [superset] Fix, missing return on error and improved query
dpgaspar opened a new pull request #8239: [superset] Fix, missing return on error and improved query URL: https://github.com/apache/incubator-superset/pull/8239 ### CATEGORY Choose one - [X] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Small fix ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida merged pull request #8226: Handle int64 columns with missing data in SQL Lab
betodealmeida merged pull request #8226: Handle int64 columns with missing data in SQL Lab URL: https://github.com/apache/incubator-superset/pull/8226 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida closed issue #8225: Pandas casting int64 to float64, misrepresenting value
betodealmeida closed issue #8225: Pandas casting int64 to float64, misrepresenting value URL: https://github.com/apache/incubator-superset/issues/8225 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] dpgaspar opened a new pull request #8240: [database] Improve form and API validation for invalid URI
dpgaspar opened a new pull request #8240: [database] Improve form and API validation for invalid URI URL: https://github.com/apache/incubator-superset/pull/8240 ### CATEGORY - [ ] Bug Fix - [X] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Improves database connection form validation (and API data submission). Currently a user would only know about URI parse validation errors after form submission, with this change an error is shown to the user while still editing the form. A properly formatted error is also return on the new API referencing the column `sqlalchemy_uri` ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #7793: Official release is delayed for so long, how can community help development team?
stale[bot] commented on issue #7793: Official release is delayed for so long, how can community help development team? URL: https://github.com/apache/incubator-superset/issues/7793#issuecomment-532227511 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8237: Pivot Table order by Column or Row Name
issue-label-bot[bot] commented on issue #8237: Pivot Table order by Column or Row Name URL: https://github.com/apache/incubator-superset/issues/8237#issuecomment-532233939 Issue-Label Bot is automatically applying the label `#enhancement` to this issue, with a confidence of 0.73. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] davidhassan opened a new issue #8237: Pivot Table order by Column or Row Name
davidhassan opened a new issue #8237: Pivot Table order by Column or Row Name URL: https://github.com/apache/incubator-superset/issues/8237 When using a pivot table there is no ability to order by rows or columns. It would be nice to be able to control the order that the row and column labels appear in. Currently I have a pivot table with columns that are dates in the format of mm/dd/ and rows that are just numbers to represent hours (13 - 21). When the pivot tables loads the hours are all out of order because the chart is ordered by the metric(s). Can we have control to order by dimension fields? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8236: Pivot Table Conditional Formatting on Cells - Add Colour to cells
issue-label-bot[bot] commented on issue #8236: Pivot Table Conditional Formatting on Cells - Add Colour to cells URL: https://github.com/apache/incubator-superset/issues/8236#issuecomment-532224547 Issue-Label Bot is automatically applying the label `#enhancement` to this issue, with a confidence of 0.80. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] davidhassan opened a new issue #8236: Pivot Table Conditional Formatting on Cells - Add Colour to cells
davidhassan opened a new issue #8236: Pivot Table Conditional Formatting on Cells - Add Colour to cells URL: https://github.com/apache/incubator-superset/issues/8236 It would be nice if there was a way to add conditional formatting to individual cells to highlight them a certain color if the value in that cell is in or out of a range etc. This was being worked on at some point in time on older versions of Superset. #3416 However, it looks like progress stopped. Can someone champion this feature and continue what was already done? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] davidhassan opened a new issue #8238: Pivot Table Freeze Columns or Rows - "Freeze Pane"
davidhassan opened a new issue #8238: Pivot Table Freeze Columns or Rows - "Freeze Pane" URL: https://github.com/apache/incubator-superset/issues/8238 I would like the ability to freeze a row or column from moving when I scroll down or over on the pivot table chart. If you have a large pivot table that involves scrolling in either direction you can easily lose track of which row or column you are looking at. By freezing the column or row on scrolling we do not have that issue. This feature is called "Freeze Pane" in MS Excel. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8238: Pivot Table Freeze Columns or Rows - "Freeze Pane"
issue-label-bot[bot] commented on issue #8238: Pivot Table Freeze Columns or Rows - "Freeze Pane" URL: https://github.com/apache/incubator-superset/issues/8238#issuecomment-532235314 Issue-Label Bot is automatically applying the label `#enhancement` to this issue, with a confidence of 0.76. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #8219: [WIP] Build better support for schema permissions
dpgaspar commented on a change in pull request #8219: [WIP] Build better support for schema permissions URL: https://github.com/apache/incubator-superset/pull/8219#discussion_r325194493 ## File path: superset/security.py ## @@ -376,19 +380,47 @@ def rejected_tables(self, sql: str, database: "Database", schema: str) -> List[s if not self._datasource_access_by_fullname(database, t, schema) ] -def _user_datasource_perms(self) -> Set[str]: -""" -Return the set of FAB permission view-menu names the user can access. +def get_public_role(self): Review comment: Add return type This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
