[GitHub] [incubator-superset] nytai opened a new pull request #9381: fix: [dashboard] add row padding

2020-03-25 Thread GitBox
nytai opened a new pull request #9381: fix: [dashboard] add row padding URL: https://github.com/apache/incubator-superset/pull/9381 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build /

[GitHub] [incubator-superset] ktmud commented on issue #9378: chore: bump black to 19.10b0 and mypy to 0.7000

2020-03-25 Thread GitBox
ktmud commented on issue #9378: chore: bump black to 19.10b0 and mypy to 0.7000 URL: https://github.com/apache/incubator-superset/pull/9378#issuecomment-603964736 > Out of interest why was the mypy version bumped as this seems unrelated to black? I was seeing this error while `pip

[GitHub] [incubator-superset] ktmud commented on a change in pull request #9345: [explore view] fix long query issue from Run in SQL LAB Button

2020-03-25 Thread GitBox
ktmud commented on a change in pull request #9345: [explore view] fix long query issue from Run in SQL LAB Button URL: https://github.com/apache/incubator-superset/pull/9345#discussion_r398069551 ## File path: superset/views/core.py ## @@ -2743,19 +2743,30 @@ def

[GitHub] [incubator-superset] suddjian commented on issue #9372: upgrade to react-bootstrap v0.33.1

2020-03-25 Thread GitBox
suddjian commented on issue #9372: upgrade to react-bootstrap v0.33.1 URL: https://github.com/apache/incubator-superset/pull/9372#issuecomment-604021994 CI passed but it looks like Travis didn't get the message through to GitHub.

[GitHub] [incubator-superset] villebro commented on issue #9348: fix: filter_values in jinja_context not processing adhoc_filters

2020-03-25 Thread GitBox
villebro commented on issue #9348: fix: filter_values in jinja_context not processing adhoc_filters URL: https://github.com/apache/incubator-superset/pull/9348#issuecomment-604038716 @mistercrunch is this ok to merge? This

[GitHub] [incubator-superset] suddjian commented on a change in pull request #9370: Add visualization flow to the CTA queries

2020-03-25 Thread GitBox
suddjian commented on a change in pull request #9370: Add visualization flow to the CTA queries URL: https://github.com/apache/incubator-superset/pull/9370#discussion_r398129307 ## File path: superset/views/core.py ## @@ -1968,6 +1970,48 @@ def sync_druid_source(self):

[GitHub] [incubator-superset] axelet commented on issue #8699: [SIP-29] Add support for row-level security

2020-03-25 Thread GitBox
axelet commented on issue #8699: [SIP-29] Add support for row-level security URL: https://github.com/apache/incubator-superset/pull/8699#issuecomment-603984942 @altef @villebro @justin-barton @mistercrunch Thank you for the update! It's a nice feature and we find it very use useful.

[GitHub] [incubator-superset] axelet edited a comment on issue #8699: [SIP-29] Add support for row-level security

2020-03-25 Thread GitBox
axelet edited a comment on issue #8699: [SIP-29] Add support for row-level security URL: https://github.com/apache/incubator-superset/pull/8699#issuecomment-603984942 @altef @villebro @justin-barton @mistercrunch Thank you for the update! It's a nice feature and we find it very use

[GitHub] [incubator-superset] john-bodley merged pull request #9377: [sip-15] Fixing typo in docstring

2020-03-25 Thread GitBox
john-bodley merged pull request #9377: [sip-15] Fixing typo in docstring URL: https://github.com/apache/incubator-superset/pull/9377 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-superset] altef commented on issue #9365: fix: Row Level Security get_rls_filters func SELECT statement

2020-03-25 Thread GitBox
altef commented on issue #9365: fix: Row Level Security get_rls_filters func SELECT statement URL: https://github.com/apache/incubator-superset/pull/9365#issuecomment-604025074 Looks good to me! This is an automated message

[GitHub] [incubator-superset] john-bodley edited a comment on issue #9378: chore: bump black to 19.10b0 and mypy to 0.7000

2020-03-25 Thread GitBox
john-bodley edited a comment on issue #9378: chore: bump black to 19.10b0 and mypy to 0.7000 URL: https://github.com/apache/incubator-superset/pull/9378#issuecomment-603673843 I think the issue may because of a local misalignment of `black`. I’m all for bumping the version of `black`

[GitHub] [incubator-superset] john-bodley opened a new pull request #9382: [fix] Fixing cache key inconsistencies

2020-03-25 Thread GitBox
john-bodley opened a new pull request #9382: [fix] Fixing cache key inconsistencies URL: https://github.com/apache/incubator-superset/pull/9382 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ]

[GitHub] [incubator-superset] rusackas commented on issue #9372: upgrade to react-bootstrap v0.33.1

2020-03-25 Thread GitBox
rusackas commented on issue #9372: upgrade to react-bootstrap v0.33.1 URL: https://github.com/apache/incubator-superset/pull/9372#issuecomment-604022711 > CI passed but it looks like Travis didn't get the message through to GitHub. Same thing happened to me on another PR. Not sure

[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #9345: [explore view] fix long query issue from Run in SQL LAB Button

2020-03-25 Thread GitBox
graceguo-supercat commented on a change in pull request #9345: [explore view] fix long query issue from Run in SQL LAB Button URL: https://github.com/apache/incubator-superset/pull/9345#discussion_r397632039 ## File path: superset/views/core.py ## @@ -2743,19 +2743,30 @@

[GitHub] [incubator-superset] altef commented on issue #8699: [SIP-29] Add support for row-level security

2020-03-25 Thread GitBox
altef commented on issue #8699: [SIP-29] Add support for row-level security URL: https://github.com/apache/incubator-superset/pull/8699#issuecomment-604024366 @axelet hey, thanks for that! It looks good to me; I must have introduced that in one of the query format changes.

[GitHub] [incubator-superset] suddjian commented on a change in pull request #9370: Add visualization flow to the CTA queries

2020-03-25 Thread GitBox
suddjian commented on a change in pull request #9370: Add visualization flow to the CTA queries URL: https://github.com/apache/incubator-superset/pull/9370#discussion_r398095093 ## File path: superset-frontend/src/SqlLab/actions/sqlLab.js ## @@ -1249,3 +1249,27 @@ export

[GitHub] [incubator-superset] suddjian commented on a change in pull request #9370: Add visualization flow to the CTA queries

2020-03-25 Thread GitBox
suddjian commented on a change in pull request #9370: Add visualization flow to the CTA queries URL: https://github.com/apache/incubator-superset/pull/9370#discussion_r398095648 ## File path: superset-frontend/src/SqlLab/actions/sqlLab.js ## @@ -1249,3 +1249,27 @@ export

[GitHub] [incubator-superset] suddjian commented on a change in pull request #9370: Add visualization flow to the CTA queries

2020-03-25 Thread GitBox
suddjian commented on a change in pull request #9370: Add visualization flow to the CTA queries URL: https://github.com/apache/incubator-superset/pull/9370#discussion_r398131060 ## File path: superset/views/core.py ## @@ -1968,6 +1970,48 @@ def sync_druid_source(self):

[GitHub] [incubator-superset] graceguo-supercat commented on issue #9350: [dashboard] handle markdown error

2020-03-25 Thread GitBox
graceguo-supercat commented on issue #9350: [dashboard] handle markdown error URL: https://github.com/apache/incubator-superset/pull/9350#issuecomment-604122939 Added a gif to show redo/undo flow to fix markdown error. This

[GitHub] [incubator-superset] graceguo-supercat merged pull request #9345: [explore view] fix long query issue from Run in SQL LAB Button

2020-03-25 Thread GitBox
graceguo-supercat merged pull request #9345: [explore view] fix long query issue from Run in SQL LAB Button URL: https://github.com/apache/incubator-superset/pull/9345 This is an automated message from the Apache Git

[GitHub] [incubator-superset] petacube commented on issue #4464: Integrate Jupyter model to superset

2020-03-25 Thread GitBox
petacube commented on issue #4464: Integrate Jupyter model to superset URL: https://github.com/apache/incubator-superset/issues/4464#issuecomment-604116368 this should not be closed. its important feature to have This is an

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #9350: [dashboard] handle markdown error

2020-03-25 Thread GitBox
etr2460 commented on a change in pull request #9350: [dashboard] handle markdown error URL: https://github.com/apache/incubator-superset/pull/9350#discussion_r398147585 ## File path: superset-frontend/src/dashboard/components/gridComponents/Markdown.jsx ## @@ -73,6

[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #9350: [dashboard] handle markdown error

2020-03-25 Thread GitBox
graceguo-supercat commented on a change in pull request #9350: [dashboard] handle markdown error URL: https://github.com/apache/incubator-superset/pull/9350#discussion_r398162832 ## File path: superset-frontend/src/dashboard/components/gridComponents/Markdown.jsx ## @@

[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #9350: [dashboard] handle markdown error

2020-03-25 Thread GitBox
graceguo-supercat commented on a change in pull request #9350: [dashboard] handle markdown error URL: https://github.com/apache/incubator-superset/pull/9350#discussion_r398162832 ## File path: superset-frontend/src/dashboard/components/gridComponents/Markdown.jsx ## @@

[GitHub] [incubator-superset] tooptoop4 removed a comment on issue #6463: how to connect to HiveServer2 with ssl?

2020-03-25 Thread GitBox
tooptoop4 removed a comment on issue #6463: how to connect to HiveServer2 with ssl? URL: https://github.com/apache/incubator-superset/issues/6463#issuecomment-499278334 @kristw any idea on this one? This is an automated

[GitHub] [incubator-superset] villebro commented on issue #9372: upgrade to react-bootstrap v0.33.1

2020-03-25 Thread GitBox
villebro commented on issue #9372: upgrade to react-bootstrap v0.33.1 URL: https://github.com/apache/incubator-superset/pull/9372#issuecomment-604063070 Something weird going on with Codecov and Travis, they don't seem to be triggering like they should lately.

[GitHub] [incubator-superset] rusackas commented on a change in pull request #9372: upgrade to react-bootstrap v0.33.1

2020-03-25 Thread GitBox
rusackas commented on a change in pull request #9372: upgrade to react-bootstrap v0.33.1 URL: https://github.com/apache/incubator-superset/pull/9372#discussion_r398165690 ## File path: superset-frontend/src/explore/components/controls/HiddenControl.jsx ## @@ -26,6 +26,9

[GitHub] [incubator-superset] rusackas commented on a change in pull request #9372: upgrade to react-bootstrap v0.33.1

2020-03-25 Thread GitBox
rusackas commented on a change in pull request #9372: upgrade to react-bootstrap v0.33.1 URL: https://github.com/apache/incubator-superset/pull/9372#discussion_r398165035 ## File path: superset-frontend/src/explore/components/ControlPanelSection.jsx ## @@ -40,6 +40,7 @@

[GitHub] [incubator-superset] rusackas commented on a change in pull request #9372: upgrade to react-bootstrap v0.33.1

2020-03-25 Thread GitBox
rusackas commented on a change in pull request #9372: upgrade to react-bootstrap v0.33.1 URL: https://github.com/apache/incubator-superset/pull/9372#discussion_r398161071 ## File path: superset-frontend/src/dashboard/components/filterscope/FilterFieldTree.jsx ## @@

[GitHub] [incubator-superset] rusackas commented on a change in pull request #9372: upgrade to react-bootstrap v0.33.1

2020-03-25 Thread GitBox
rusackas commented on a change in pull request #9372: upgrade to react-bootstrap v0.33.1 URL: https://github.com/apache/incubator-superset/pull/9372#discussion_r398162569 ## File path: superset-frontend/src/dashboard/components/filterscope/FilterScopeTree.jsx ## @@

[GitHub] [incubator-superset] kevinflaherty1 commented on issue #5981: WTF_CSRF_EXEMPT_LIST doesn't work

2020-03-25 Thread GitBox
kevinflaherty1 commented on issue #5981: WTF_CSRF_EXEMPT_LIST doesn't work URL: https://github.com/apache/incubator-superset/issues/5981#issuecomment-604098882 Realized it was the directory path to the file that was needed so in my case I had a customer_security_manager.py file alongside

[GitHub] [incubator-superset] tooptoop4 opened a new issue #9384: presto issues

2020-03-25 Thread GitBox
tooptoop4 opened a new issue #9384: presto issues URL: https://github.com/apache/incubator-superset/issues/9384 using superset for first time on 0.35.2 release , found several oddities: 1. Schema on the left shows datatype of OTHER instead of varchar(40) log has 2020-03-26

[GitHub] [incubator-superset] villebro commented on issue #9372: upgrade to react-bootstrap v0.33.1

2020-03-25 Thread GitBox
villebro commented on issue #9372: upgrade to react-bootstrap v0.33.1 URL: https://github.com/apache/incubator-superset/pull/9372#issuecomment-604068719 @suddjian I restarted CI, let's see if this fixes it. This is an

[GitHub] [incubator-superset] kevinflaherty1 edited a comment on issue #5981: WTF_CSRF_EXEMPT_LIST doesn't work

2020-03-25 Thread GitBox
kevinflaherty1 edited a comment on issue #5981: WTF_CSRF_EXEMPT_LIST doesn't work URL: https://github.com/apache/incubator-superset/issues/5981#issuecomment-604079814 @brayan-arrieta any luck on this? Having the same issue.

[GitHub] [incubator-superset] kevinflaherty1 commented on issue #5981: WTF_CSRF_EXEMPT_LIST doesn't work

2020-03-25 Thread GitBox
kevinflaherty1 commented on issue #5981: WTF_CSRF_EXEMPT_LIST doesn't work URL: https://github.com/apache/incubator-superset/issues/5981#issuecomment-604079814 > Hello thanks for the help, I tried with `WTF_CSRF_EXEMPT_LIST = ['login']` and doesn't work. Maybe you have another idea.

[GitHub] [incubator-superset] codecov-io edited a comment on issue #9333: build: use manifest hooks for dev server proxy

2020-03-25 Thread GitBox
codecov-io edited a comment on issue #9333: build: use manifest hooks for dev server proxy URL: https://github.com/apache/incubator-superset/pull/9333#issuecomment-602775834 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9333?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] graceguo-supercat merged pull request #9383: [dashboard] Fix a typo in set prop value for metadata modal

2020-03-25 Thread GitBox
graceguo-supercat merged pull request #9383: [dashboard] Fix a typo in set prop value for metadata modal URL: https://github.com/apache/incubator-superset/pull/9383 This is an automated message from the Apache Git Service.

[GitHub] [incubator-superset] codecov-io commented on issue #9372: upgrade to react-bootstrap v0.33.1

2020-03-25 Thread GitBox
codecov-io commented on issue #9372: upgrade to react-bootstrap v0.33.1 URL: https://github.com/apache/incubator-superset/pull/9372#issuecomment-604075266 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9372?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #9370: Add visualization flow to the CTA queries

2020-03-25 Thread GitBox
bkyryliuk commented on a change in pull request #9370: Add visualization flow to the CTA queries URL: https://github.com/apache/incubator-superset/pull/9370#discussion_r398178814 ## File path: superset/views/core.py ## @@ -1968,6 +1970,48 @@ def sync_druid_source(self):

[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #9383: [dashboard] Fix a typo in set prop value for metadata modal

2020-03-25 Thread GitBox
graceguo-supercat opened a new pull request #9383: [dashboard] Fix a typo in set prop value for metadata modal URL: https://github.com/apache/incubator-superset/pull/9383 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor

[GitHub] [incubator-superset] rusackas opened a new pull request #9385: Mirgrating unique Partition chart controls

2020-03-25 Thread GitBox
rusackas opened a new pull request #9385: Mirgrating unique Partition chart controls URL: https://github.com/apache/incubator-superset/pull/9385 ### CATEGORY Choose one - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [x] Refactor - [ ] Add tests - [ ]

[GitHub] [incubator-superset] rusackas opened a new pull request #9386: Migrating unique PivotTable controls

2020-03-25 Thread GitBox
rusackas opened a new pull request #9386: Migrating unique PivotTable controls URL: https://github.com/apache/incubator-superset/pull/9386 ### CATEGORY Choose one - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [x] Refactor - [ ] Add tests - [ ] Build

[GitHub] [incubator-superset] codecov-io commented on issue #9385: Mirgrating unique Partition chart controls

2020-03-25 Thread GitBox
codecov-io commented on issue #9385: Mirgrating unique Partition chart controls URL: https://github.com/apache/incubator-superset/pull/9385#issuecomment-604195347 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9385?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] stale[bot] commented on issue #9022: Internet Explorer 11 does not load Apache superset URL

2020-03-25 Thread GitBox
stale[bot] commented on issue #9022: Internet Explorer 11 does not load Apache superset URL URL: https://github.com/apache/incubator-superset/issues/9022#issuecomment-604204698 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9376: Add CUSTOM_TEMPLATE_PROCESSOR config

2020-03-25 Thread GitBox
dpgaspar commented on a change in pull request #9376: Add CUSTOM_TEMPLATE_PROCESSOR config URL: https://github.com/apache/incubator-superset/pull/9376#discussion_r398314274 ## File path: tests/core_tests.py ## @@ -668,6 +668,80 @@ def test_templated_sql_json(self):

[GitHub] [incubator-superset] rusackas opened a new pull request #9391: Removing WordCloud controls from CONTRIBUTING.md

2020-03-25 Thread GitBox
rusackas opened a new pull request #9391: Removing WordCloud controls from CONTRIBUTING.md URL: https://github.com/apache/incubator-superset/pull/9391 ### CATEGORY Choose one - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests

[GitHub] [incubator-superset] codecov-io edited a comment on issue #9375: [cache] Cleaning up viz/cache logic

2020-03-25 Thread GitBox
codecov-io edited a comment on issue #9375: [cache] Cleaning up viz/cache logic URL: https://github.com/apache/incubator-superset/pull/9375#issuecomment-603939413 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9375?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-io commented on issue #9386: Migrating unique PivotTable controls

2020-03-25 Thread GitBox
codecov-io commented on issue #9386: Migrating unique PivotTable controls URL: https://github.com/apache/incubator-superset/pull/9386#issuecomment-604197941 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9386?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] rusackas opened a new pull request #9388: Migrating unique Table controls

2020-03-25 Thread GitBox
rusackas opened a new pull request #9388: Migrating unique Table controls URL: https://github.com/apache/incubator-superset/pull/9388 ### CATEGORY Choose one - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [x] Refactor - [ ] Add tests - [ ] Build /

[GitHub] [incubator-superset] codecov-io commented on issue #9388: Migrating unique Table controls

2020-03-25 Thread GitBox
codecov-io commented on issue #9388: Migrating unique Table controls URL: https://github.com/apache/incubator-superset/pull/9388#issuecomment-604226212 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9388?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] rusackas commented on issue #9385: Mirgrating unique Partition chart controls

2020-03-25 Thread GitBox
rusackas commented on issue #9385: Mirgrating unique Partition chart controls URL: https://github.com/apache/incubator-superset/pull/9385#issuecomment-604192909 @kristw note that this one is a little peculiar. It uses some JSX, importing and passing a component. We'll probably need a way

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9376: Add CUSTOM_TEMPLATE_PROCESSOR config

2020-03-25 Thread GitBox
dpgaspar commented on a change in pull request #9376: Add CUSTOM_TEMPLATE_PROCESSOR config URL: https://github.com/apache/incubator-superset/pull/9376#discussion_r398311460 ## File path: superset/config.py ## @@ -585,6 +588,59 @@ class CeleryConfig: # pylint:

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9376: Add CUSTOM_TEMPLATE_PROCESSOR config

2020-03-25 Thread GitBox
dpgaspar commented on a change in pull request #9376: Add CUSTOM_TEMPLATE_PROCESSOR config URL: https://github.com/apache/incubator-superset/pull/9376#discussion_r398311680 ## File path: superset/config.py ## @@ -585,6 +588,59 @@ class CeleryConfig: # pylint:

[GitHub] [incubator-superset] codecov-io commented on issue #9392: Migrating unique BoxPlot controls

2020-03-25 Thread GitBox
codecov-io commented on issue #9392: Migrating unique BoxPlot controls URL: https://github.com/apache/incubator-superset/pull/9392#issuecomment-604235756 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9392?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] rusackas merged pull request #9359: Migrating unique DirectedForce controls

2020-03-25 Thread GitBox
rusackas merged pull request #9359: Migrating unique DirectedForce controls URL: https://github.com/apache/incubator-superset/pull/9359 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-superset] dpgaspar opened a new pull request #9387: [charts] New, bulk delete API endpoint

2020-03-25 Thread GitBox
dpgaspar opened a new pull request #9387: [charts] New, bulk delete API endpoint URL: https://github.com/apache/incubator-superset/pull/9387 ### CATEGORY Choose one - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ]

[GitHub] [incubator-superset] codecov-io commented on issue #9387: [charts] New, bulk delete API endpoint

2020-03-25 Thread GitBox
codecov-io commented on issue #9387: [charts] New, bulk delete API endpoint URL: https://github.com/apache/incubator-superset/pull/9387#issuecomment-604224186 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9387?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] rusackas opened a new pull request #9392: Migrating unique BoxPlot controls

2020-03-25 Thread GitBox
rusackas opened a new pull request #9392: Migrating unique BoxPlot controls URL: https://github.com/apache/incubator-superset/pull/9392 ### CATEGORY Choose one - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [x] Refactor - [ ] Add tests - [ ] Build /

[GitHub] [incubator-superset] rusackas closed pull request #9371: [WiP] Styling new list views with Emotion

2020-03-25 Thread GitBox
rusackas closed pull request #9371: [WiP] Styling new list views with Emotion URL: https://github.com/apache/incubator-superset/pull/9371 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-superset] rusackas commented on issue #9201: [WIP] Frontend monorepo

2020-03-25 Thread GitBox
rusackas commented on issue #9201: [WIP] Frontend monorepo URL: https://github.com/apache/incubator-superset/pull/9201#issuecomment-604230709 @ktmud Now that your (amazing) `npm link` work is in, I guess we can close this one? Up to you :D

[GitHub] [incubator-superset] rusackas merged pull request #9261: Update MANIFEST.in

2020-03-25 Thread GitBox
rusackas merged pull request #9261: Update MANIFEST.in URL: https://github.com/apache/incubator-superset/pull/9261 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-superset] nawazxy opened a new issue #9393: Propagation of roles and permissions from Keycloak to Superset

2020-03-25 Thread GitBox
nawazxy opened a new issue #9393: Propagation of roles and permissions from Keycloak to Superset URL: https://github.com/apache/incubator-superset/issues/9393 **Problem Description** I was able to set up authentication via **Keycloak** thanks to a couple of Stackoverflow answers and

[GitHub] [incubator-superset] rusackas commented on a change in pull request #9389: Migrating unique BigNumber(/Total) controls

2020-03-25 Thread GitBox
rusackas commented on a change in pull request #9389: Migrating unique BigNumber(/Total) controls URL: https://github.com/apache/incubator-superset/pull/9389#discussion_r398310221 ## File path: CONTRIBUTING.md ## @@ -1016,15 +1016,6 @@ The `metric` (or equivalent) and

[GitHub] [incubator-superset] rusackas opened a new pull request #9389: Migrating unique BigNumber(/Total) controls

2020-03-25 Thread GitBox
rusackas opened a new pull request #9389: Migrating unique BigNumber(/Total) controls URL: https://github.com/apache/incubator-superset/pull/9389 ### CATEGORY Choose one - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [x] Refactor - [ ] Add tests - [

[GitHub] [incubator-superset] petacube opened a new issue #9390: installation issues

2020-03-25 Thread GitBox
petacube opened a new issue #9390: installation issues URL: https://github.com/apache/incubator-superset/issues/9390 pip install apache-superset -- worked fine superset db upgrade ImportError: cannot import name 'secure_filename' from 'werkzeug'

[GitHub] [incubator-superset] villebro commented on issue #9348: fix: filter_values in jinja_context not processing adhoc_filters

2020-03-25 Thread GitBox
villebro commented on issue #9348: fix: filter_values in jinja_context not processing adhoc_filters URL: https://github.com/apache/incubator-superset/pull/9348#issuecomment-603858945 @lilila I assume this is on the Public role?

[GitHub] [incubator-superset] codecov-io commented on issue #9375: [cache] Cleaning up viz/cache logic

2020-03-25 Thread GitBox
codecov-io commented on issue #9375: [cache] Cleaning up viz/cache logic URL: https://github.com/apache/incubator-superset/pull/9375#issuecomment-603939413 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9375?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] john-bodley commented on issue #9375: [cache] Cleaning up viz/cache logic

2020-03-25 Thread GitBox
john-bodley commented on issue #9375: [cache] Cleaning up viz/cache logic URL: https://github.com/apache/incubator-superset/pull/9375#issuecomment-603935159 @etr2460 and @villebro I addressed your comments. This is an

[GitHub] [incubator-superset] kalimuthu123 opened a new issue #9380: Time-Series table crush header

2020-03-25 Thread GitBox
kalimuthu123 opened a new issue #9380: Time-Series table crush header URL: https://github.com/apache/incubator-superset/issues/9380 A clear and concise description of what the bug is. Time-Series table crush #6788 what you expected to happen. header and tooltip are

[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #9345: [explore view] fix long query issue from Run in SQL LAB Button

2020-03-25 Thread GitBox
graceguo-supercat commented on a change in pull request #9345: [explore view] fix long query issue from Run in SQL LAB Button URL: https://github.com/apache/incubator-superset/pull/9345#discussion_r397632039 ## File path: superset/views/core.py ## @@ -2743,19 +2743,30 @@

[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #9345: [explore view] fix long query issue from Run in SQL LAB Button

2020-03-25 Thread GitBox
graceguo-supercat commented on a change in pull request #9345: [explore view] fix long query issue from Run in SQL LAB Button URL: https://github.com/apache/incubator-superset/pull/9345#discussion_r397631501 ## File path: superset/views/core.py ## @@ -2752,7 +2752,7 @@

[GitHub] [incubator-superset] codecov-io edited a comment on issue #9345: [WIP][explore view] fix long query issue from Run in SQL LAB Button

2020-03-25 Thread GitBox
codecov-io edited a comment on issue #9345: [WIP][explore view] fix long query issue from Run in SQL LAB Button URL: https://github.com/apache/incubator-superset/pull/9345#issuecomment-602119775 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9345?src=pr=h1) Report >

[GitHub] [incubator-superset] ktmud opened a new pull request #9378: chore: bump black to 19.10b0 and mypy to 0.7000

2020-03-25 Thread GitBox
ktmud opened a new pull request #9378: chore: bump black to 19.10b0 and mypy to 0.7000 URL: https://github.com/apache/incubator-superset/pull/9378 ### CATEGORY - [x] Build / Development Environment ### SUMMARY @graceguo-supercat noticed `black==19.10b0` and

[GitHub] [incubator-superset] john-bodley commented on issue #9378: chore: bump black to 19.10b0 and mypy to 0.7000

2020-03-25 Thread GitBox
john-bodley commented on issue #9378: chore: bump black to 19.10b0 and mypy to 0.7000 URL: https://github.com/apache/incubator-superset/pull/9378#issuecomment-603673843 I think the issue may because of a local misalignment of `black`. I’m all for bumping the version of `black` though

[GitHub] [incubator-superset] john-bodley edited a comment on issue #9378: chore: bump black to 19.10b0 and mypy to 0.7000

2020-03-25 Thread GitBox
john-bodley edited a comment on issue #9378: chore: bump black to 19.10b0 and mypy to 0.7000 URL: https://github.com/apache/incubator-superset/pull/9378#issuecomment-603673843 I think the issue may because of a local misalignment of `black`. I’m all for bumping the version of `black`

[GitHub] [incubator-superset] lilila commented on issue #9379: Add Sort option for bar chart

2020-03-25 Thread GitBox
lilila commented on issue #9379: Add Sort option for bar chart URL: https://github.com/apache/incubator-superset/issues/9379#issuecomment-603680349 This was already asked in this [issue](https://github.com/apache/incubator-superset/issues/3380)

[GitHub] [incubator-superset] lilila closed issue #9328: Jinja filter defined in DataSource not considered in "Explore Chart"

2020-03-25 Thread GitBox
lilila closed issue #9328: Jinja filter defined in DataSource not considered in "Explore Chart" URL: https://github.com/apache/incubator-superset/issues/9328 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-superset] lilila commented on issue #9328: Jinja filter defined in DataSource not considered in "Explore Chart"

2020-03-25 Thread GitBox
lilila commented on issue #9328: Jinja filter defined in DataSource not considered in "Explore Chart" URL: https://github.com/apache/incubator-superset/issues/9328#issuecomment-603671526 Thank you for the fix This is an

[GitHub] [incubator-superset] lilila opened a new issue #9379: Add Sort option for bar chart

2020-03-25 Thread GitBox
lilila opened a new issue #9379: Add Sort option for bar chart URL: https://github.com/apache/incubator-superset/issues/9379 It would be great to add the following options to sort Bar Chart 1. Sort descending / ascending by Y-axis based on a user selected metric (as it is in Time

[GitHub] [incubator-superset] fortmate commented on issue #1519: Choose encoding when export csv

2020-03-25 Thread GitBox
fortmate commented on issue #1519: Choose encoding when export csv URL: https://github.com/apache/incubator-superset/issues/1519#issuecomment-603758342 For those who are still suffering from csv export encoding matters, Try editting /views/core.py Look for the term 'Responce(csv,'

[GitHub] [incubator-superset] lilila commented on issue #9348: fix: filter_values in jinja_context not processing adhoc_filters

2020-03-25 Thread GitBox
lilila commented on issue #9348: fix: filter_values in jinja_context not processing adhoc_filters URL: https://github.com/apache/incubator-superset/pull/9348#issuecomment-603794932 This is a great improvement, thank you again. Just a comment @villebro , if I display a plot in a an