[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: Implement csv upload configuration func for the schema enforcement

codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9734?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] craig-rueda closed pull request #9837: fix - issue with duplicated dependencies

craig-rueda closed pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: Implement csv upload configuration func for the schema enforcement

codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: Implement csv upload configuration func for the schema enforcement

codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9734?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: Implement csv upload configuration func for the schema enforcement

codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9794: feat: implement create view as functionality in Sqllab

codecov-commenter edited a comment on pull request #9794: URL: https://github.com/apache/incubator-superset/pull/9794#issuecomment-63056 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9794?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9794: feat: implement create view as functionality in Sqllab

codecov-commenter edited a comment on pull request #9794: URL: https://github.com/apache/incubator-superset/pull/9794#issuecomment-63056 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9794?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

graceguo-supercat commented on a change in pull request #9829: URL: https://github.com/apache/incubator-superset/pull/9829#discussion_r426931499 ## File path: superset-frontend/src/explore/components/controls/FilterBoxItemControl.jsx ## @@ -60,7 +63,35 @@ export default

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

codecov-io edited a comment on pull request #9829: URL: https://github.com/apache/incubator-superset/pull/9829#issuecomment-629905910 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter commented on pull request #9810: feat: [WIP] Superset report slack integration

codecov-commenter commented on pull request #9810: URL: https://github.com/apache/incubator-superset/pull/9810#issuecomment-630512435 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9810?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9810: feat: [WIP] Superset report slack integration

codecov-commenter edited a comment on pull request #9810: URL: https://github.com/apache/incubator-superset/pull/9810#issuecomment-630512435 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9810?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9810: feat: [WIP] Superset report slack integration

codecov-commenter edited a comment on pull request #9810: URL: https://github.com/apache/incubator-superset/pull/9810#issuecomment-630512435 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9810?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9810: feat: [WIP] Superset report slack integration

codecov-commenter edited a comment on pull request #9810: URL: https://github.com/apache/incubator-superset/pull/9810#issuecomment-630512435 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9810?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: feat: implement csv upload configuration func for the schema enforcement

codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9734?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: feat: implement csv upload configuration func for the schema enforcement

codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9734?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: feat: implement csv upload configuration func for the schema enforcement

codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-superset] codecov-commenter commented on pull request #9794: feat: implement create view as functionality in Sqllab

codecov-commenter commented on pull request #9794: URL: https://github.com/apache/incubator-superset/pull/9794#issuecomment-63056 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9794?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] graceguo-supercat merged pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

graceguo-supercat merged pull request #9829: URL: https://github.com/apache/incubator-superset/pull/9829 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-superset] villebro commented on issue #9830: Error When Installing Dev Requirements pydruid

villebro commented on issue #9830: URL: https://github.com/apache/incubator-superset/issues/9830#issuecomment-630578531 Thanks @essajiwa , this is a known issue with `pydruid` on python 3.7, see https://github.com/druid-io/pydruid/issues/198 . FYI @etr2460 @john-bodley : To ensure

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

codecov-commenter edited a comment on pull request #9824: URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9794: feat: implement create view as functionality in Sqllab

codecov-commenter edited a comment on pull request #9794: URL: https://github.com/apache/incubator-superset/pull/9794#issuecomment-63056 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9794?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] ktmud commented on pull request #9817: fix: [explore view] inline edit slice name should not overwrite

ktmud commented on pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#issuecomment-630593453 I'm wondering whether we can just remove inline edit? There is an edit button/icon anyway, right?

[GitHub] [incubator-superset] graceguo-supercat merged pull request #9817: fix: [explore view] inline edit slice name should not overwrite

graceguo-supercat merged pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9734: feat: implement csv upload configuration func for the schema enforcement

john-bodley commented on a change in pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#discussion_r427013763 ## File path: superset/db_engine_specs/base.py ## @@ -454,55 +452,27 @@ def df_to_sql(cls, df: pd.DataFrame, **kwargs: Any) -> None:

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] villebro commented on issue #9836: Filter generated alias cause bigquery error: 400 Unrecognized name

villebro commented on issue #9836: URL: https://github.com/apache/incubator-superset/issues/9836#issuecomment-630577399 Thanks @esilver , I have not used nested fields on BigQuery with Superset, hence this has not come up in my testing. To make it easier to reproduce, can you shed some

[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #9817: fix: [explore view] inline edit slice name should not overwrite

graceguo-supercat commented on a change in pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#discussion_r427040230 ## File path: superset-frontend/spec/javascripts/explore/components/ExploreChartHeader_spec.jsx ## @@ -65,24 +65,9 @@

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9794: feat: implement create view as functionality in Sqllab

codecov-commenter edited a comment on pull request #9794: URL: https://github.com/apache/incubator-superset/pull/9794#issuecomment-63056 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9794?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #9817: fix: [explore view] inline edit slice name should not overwrite

graceguo-supercat edited a comment on pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#issuecomment-630594291 _inline edit_ feature is also requested by users :) I remembered the initial request is mean to overwrite without confirmation (quick save). But

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-superset] lilila commented on issue #9395: Preserve label_colors in standalone mode

lilila commented on issue #9395: URL: https://github.com/apache/incubator-superset/issues/9395#issuecomment-630565917 Dear @graceguo-supercat , do you have any clue to solve this issue ? Thank you This is an automated

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter commented on pull request #9824: style(mypy): enforcing mypy typing for connectors

codecov-commenter commented on pull request #9824: URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9794: feat: implement create view as functionality in Sqllab

codecov-commenter edited a comment on pull request #9794: URL: https://github.com/apache/incubator-superset/pull/9794#issuecomment-63056 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9794?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9794: feat: implement create view as functionality in Sqllab

codecov-commenter edited a comment on pull request #9794: URL: https://github.com/apache/incubator-superset/pull/9794#issuecomment-63056 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9794?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9794: feat: implement create view as functionality in Sqllab

codecov-commenter edited a comment on pull request #9794: URL: https://github.com/apache/incubator-superset/pull/9794#issuecomment-63056 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9794?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9794: feat: implement create view as functionality in Sqllab

codecov-commenter edited a comment on pull request #9794: URL: https://github.com/apache/incubator-superset/pull/9794#issuecomment-63056 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9794?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9794: feat: implement create view as functionality in Sqllab

codecov-commenter edited a comment on pull request #9794: URL: https://github.com/apache/incubator-superset/pull/9794#issuecomment-63056 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9794?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9794: feat: implement create view as functionality in Sqllab

codecov-commenter edited a comment on pull request #9794: URL: https://github.com/apache/incubator-superset/pull/9794#issuecomment-63056 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9794?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] villebro merged pull request #9834: docs: Update the link to ClickHouse official website

villebro merged pull request #9834: URL: https://github.com/apache/incubator-superset/pull/9834 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] lilila commented on issue #9823: filter box be applyed to all charts of one dashboard

lilila commented on issue #9823: URL: https://github.com/apache/incubator-superset/issues/9823#issuecomment-630565175 There is a nice way to edit filter scope. Click on `edit dashboard` then click on "filters" (1). It opens a nice interface to edit filter scope (2) (1)

[GitHub] [incubator-superset] villebro commented on a change in pull request #9825: WIP: Upload excel

villebro commented on a change in pull request #9825: URL: https://github.com/apache/incubator-superset/pull/9825#discussion_r427019488 ## File path: superset/config.py ## @@ -351,8 +351,9 @@ def _try_json_readsha(filepath, length): # pylint: disable=unused-argument

[GitHub] [incubator-superset] john-bodley commented on pull request #9833: build: Updating the sphinx configuration

john-bodley commented on pull request #9833: URL: https://github.com/apache/incubator-superset/pull/9833#issuecomment-630571695 @villebro agreed, hence why the comments. Note there's a chance this self resolves once we fully type the repo.

[GitHub] [incubator-superset] john-bodley merged pull request #9833: build: Updating the sphinx configuration

john-bodley merged pull request #9833: URL: https://github.com/apache/incubator-superset/pull/9833 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9794: feat: implement create view as functionality in Sqllab

codecov-commenter edited a comment on pull request #9794: URL: https://github.com/apache/incubator-superset/pull/9794#issuecomment-63056 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9794?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

codecov-commenter edited a comment on pull request #9824: URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

codecov-commenter edited a comment on pull request #9824: URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

codecov-commenter edited a comment on pull request #9824: URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] graceguo-supercat commented on pull request #9817: fix: [explore view] inline edit slice name should not overwrite

graceguo-supercat commented on pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#issuecomment-630594291 _inline edit_ feature is also requested by users :) This is an automated message from the

[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #9817: fix: [explore view] inline edit slice name should not overwrite

graceguo-supercat edited a comment on pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#issuecomment-630594291 _inline edit_ feature is also requested by users :) But it seems hard to decide overwrite or save_as.

[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #9817: fix: [explore view] inline edit slice name should not overwrite

graceguo-supercat edited a comment on pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#issuecomment-630594291 _inline edit_ feature is also requested by users :) But it seems hard to decide overwrite or save_as

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

codecov-commenter edited a comment on pull request #9824: URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

codecov-commenter edited a comment on pull request #9824: URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

codecov-commenter edited a comment on pull request #9824: URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #9817: fix: [explore view] inline edit slice name should not overwrite

graceguo-supercat edited a comment on pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#issuecomment-630594291 _inline edit_ feature is also requested by users :) I remembered the initial request is mean to overwrite without confirmation (quick save). But

<    1   2