[GitHub] [incubator-superset] john-bodley merged pull request #9883: style(mypy): Enforcing typing for superset.models

2020-05-22 Thread GitBox
john-bodley merged pull request #9883: URL: https://github.com/apache/incubator-superset/pull/9883 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9883: style(mypy): Enforcing typing for superset.models

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9883: URL: https://github.com/apache/incubator-superset/pull/9883#issuecomment-632512253 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9883: style(mypy): Enforcing typing for superset.models

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9883: URL: https://github.com/apache/incubator-superset/pull/9883#issuecomment-632512253 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] stale[bot] commented on issue #8366: No such file or directory

2020-05-22 Thread GitBox
stale[bot] commented on issue #8366: URL: https://github.com/apache/incubator-superset/issues/8366#issuecomment-632515095 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your

[GitHub] [incubator-superset] stale[bot] commented on issue #9301: Jinja tempate is not getting evaluated while in explore or dashboad view

2020-05-22 Thread GitBox
stale[bot] commented on issue #9301: URL: https://github.com/apache/incubator-superset/issues/9301#issuecomment-632515084 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your

[GitHub] [incubator-superset] Nishi-Mehta commented on issue #6615: Chart-based alarm function

2020-05-22 Thread GitBox
Nishi-Mehta commented on issue #6615: URL: https://github.com/apache/incubator-superset/issues/6615#issuecomment-632537718 @zhaoyu89730105 Can you write an article regarding this feature? I am sure it would be very helpful to lot of people

[GitHub] [incubator-superset] villebro commented on pull request #9824: style(mypy): enforcing mypy typing for superset.connectors

2020-05-22 Thread GitBox
villebro commented on pull request #9824: URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-632516280 Sure thing,@john-bodley , I'll review during the weekend This is an automated message from the

[GitHub] [incubator-superset] jsynl closed issue #9204: superset upgrade failed from v0.27 to v0.35

2020-05-22 Thread GitBox
jsynl closed issue #9204: URL: https://github.com/apache/incubator-superset/issues/9204 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-superset] codecov-commenter commented on pull request #9883: style(mypy): Enforcing typing for superset.models

2020-05-22 Thread GitBox
codecov-commenter commented on pull request #9883: URL: https://github.com/apache/incubator-superset/pull/9883#issuecomment-632512253 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] spaszek commented on issue #2571: Question:Is it posssible to integrate superset with other web application?

2020-05-22 Thread GitBox
spaszek commented on issue #2571: URL: https://github.com/apache/incubator-superset/issues/2571#issuecomment-632502763 This issue is closed - I don't think there are any updates coming. Unfortunately. This is an automated

[GitHub] [incubator-superset] john-bodley opened a new pull request #9883: style(mypy): Enforcing typing for superset.models

2020-05-22 Thread GitBox
john-bodley opened a new pull request #9883: URL: https://github.com/apache/incubator-superset/pull/9883 ### SUMMARY Adding `mypy` type enforcement to the `superset.models` module. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TEST PLAN CI. ###

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9883: style(mypy): Enforcing typing for superset.models

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9883: URL: https://github.com/apache/incubator-superset/pull/9883#issuecomment-632512253 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9883: style(mypy): Enforcing typing for superset.models

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9883: URL: https://github.com/apache/incubator-superset/pull/9883#issuecomment-632512253 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] villebro commented on pull request #9859: fix: raise error in sqllab when using reserved column name

2020-05-22 Thread GitBox
villebro commented on pull request #9859: URL: https://github.com/apache/incubator-superset/pull/9859#issuecomment-632517957 @eugeniamz the thing here is that the query as such is not really usable for re-exploration, as it has time grains, filters etc burned into the query. My

[GitHub] [incubator-superset] Jamesvasanth21 edited a comment on issue #8382: Error `The CSRF session token is missing` when embed superset in iframe

2020-05-22 Thread GitBox
Jamesvasanth21 edited a comment on issue #8382: URL: https://github.com/apache/incubator-superset/issues/8382#issuecomment-625820452 It is not working do you guys have any other suggestions?? This is the error I am getting 400 Bad Request Bad Request The CSRF session token is

[GitHub] [incubator-superset] Jamesvasanth21 edited a comment on issue #8382: Error `The CSRF session token is missing` when embed superset in iframe

2020-05-22 Thread GitBox
Jamesvasanth21 edited a comment on issue #8382: URL: https://github.com/apache/incubator-superset/issues/8382#issuecomment-625820452 It is not working do you guys have any other suggestions?? This is the error I am getting 400 Bad Request Bad Request The CSRF session token is

[GitHub] [incubator-superset] Jamesvasanth21 edited a comment on issue #8382: Error `The CSRF session token is missing` when embed superset in iframe

2020-05-22 Thread GitBox
Jamesvasanth21 edited a comment on issue #8382: URL: https://github.com/apache/incubator-superset/issues/8382#issuecomment-625820452 It is not working do you guys have any other suggestions?? This is the error I am getting 400 Bad Request Bad Request The CSRF session token is

[GitHub] [incubator-superset] stale[bot] commented on issue #9231: I want to add new visualizations in latest version of superset but unable to find the files where customization can done. Please help

2020-05-22 Thread GitBox
stale[bot] commented on issue #9231: URL: https://github.com/apache/incubator-superset/issues/9231#issuecomment-632668174 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your

[GitHub] [incubator-superset] nitacekarki commented on issue #8932: Superset to use both Local authentication plus OAuth authentication

2020-05-22 Thread GitBox
nitacekarki commented on issue #8932: URL: https://github.com/apache/incubator-superset/issues/8932#issuecomment-632623857 Hello All, I am unable to login via 0Auth, can you help me out? This is an automated message from

[GitHub] [incubator-superset] Jamesvasanth21 edited a comment on issue #8382: Error `The CSRF session token is missing` when embed superset in iframe

2020-05-22 Thread GitBox
Jamesvasanth21 edited a comment on issue #8382: URL: https://github.com/apache/incubator-superset/issues/8382#issuecomment-625820452 It is not working do you guys have any other suggestions?? This is the error I am getting 400 Bad Request Bad Request The CSRF session token is

[GitHub] [incubator-superset] elukey commented on pull request #8493: Fix column type on dbs.encrypted_extra, add instructions for testing migration downgrades

2020-05-22 Thread GitBox
elukey commented on pull request #8493: URL: https://github.com/apache/incubator-superset/pull/8493#issuecomment-632721492 Hi everybody, for some the first time that I migrated from 0.35.2 I didn't see any bug, but then I had to re-do it and I noticed the following when running `db

[GitHub] [incubator-superset] joseph-luketelo commented on issue #1170: Embedded Dashboards

2020-05-22 Thread GitBox
joseph-luketelo commented on issue #1170: URL: https://github.com/apache/incubator-superset/issues/1170#issuecomment-632728990 @bilalakil I did not see your response! But thank you for getting back to us. I also never figured out how to solve this problem up to date.

[GitHub] [incubator-superset] villebro commented on pull request #8493: Fix column type on dbs.encrypted_extra, add instructions for testing migration downgrades

2020-05-22 Thread GitBox
villebro commented on pull request #8493: URL: https://github.com/apache/incubator-superset/pull/8493#issuecomment-632729550 This is what broke it: https://github.com/kvesteri/sqlalchemy-utils/pull/426 The pinned version on master branch works. I suggest downgrading to that until

[GitHub] [incubator-superset] elaragon commented on issue #8183: How to pass time filters to SQL Lab queries

2020-05-22 Thread GitBox
elaragon commented on issue #8183: URL: https://github.com/apache/incubator-superset/issues/8183#issuecomment-632707828 > This is what I do, and it works for me. I do make some assumptions (taking the first time range filter if there are multiple, for example). @rubypollev thanks

[GitHub] [incubator-superset] Jamesvasanth21 removed a comment on issue #8382: Error `The CSRF session token is missing` when embed superset in iframe

2020-05-22 Thread GitBox
Jamesvasanth21 removed a comment on issue #8382: URL: https://github.com/apache/incubator-superset/issues/8382#issuecomment-625820452 It is not working do you guys have any other suggestions?? This is the error I am getting 400 Bad Request Bad Request The CSRF session token is

[GitHub] [incubator-superset] elukey commented on pull request #8493: Fix column type on dbs.encrypted_extra, add instructions for testing migration downgrades

2020-05-22 Thread GitBox
elukey commented on pull request #8493: URL: https://github.com/apache/incubator-superset/pull/8493#issuecomment-632738195 @villebro I confirm that pinning `sqlalchemy-utils==0.36.4 ` solves the problem, thanks! This is an

[GitHub] [incubator-superset] mistercrunch opened a new pull request #9890: css: beautify roles CRUD

2020-05-22 Thread GitBox
mistercrunch opened a new pull request #9890: URL: https://github.com/apache/incubator-superset/pull/9890 ## before https://user-images.githubusercontent.com/487433/82718734-31380a00-9c59-11ea-8b25-9530ba163cd1.png;>

[GitHub] [incubator-superset] codecov-commenter commented on pull request #9890: style: beautify roles CRUD

2020-05-22 Thread GitBox
codecov-commenter commented on pull request #9890: URL: https://github.com/apache/incubator-superset/pull/9890#issuecomment-632964214 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9890?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9890: style: beautify roles CRUD

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9890: URL: https://github.com/apache/incubator-superset/pull/9890#issuecomment-632964214 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9890?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9890: style: beautify roles CRUD

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9890: URL: https://github.com/apache/incubator-superset/pull/9890#issuecomment-632964214 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9890: style: beautify roles CRUD

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9890: URL: https://github.com/apache/incubator-superset/pull/9890#issuecomment-632964214 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9890?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9890: style: beautify roles CRUD

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9890: URL: https://github.com/apache/incubator-superset/pull/9890#issuecomment-632964214 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9890?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #9891: fix: [dashboard] should not trigger chart refresh when filter not applicable

2020-05-22 Thread GitBox
graceguo-supercat opened a new pull request #9891: URL: https://github.com/apache/incubator-superset/pull/9891 ### SUMMARY ### TEST PLAN This is an automated message from the Apache Git Service. To

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9891: fix: [dashboard] should not trigger chart refresh when filter not applicable

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9891: URL: https://github.com/apache/incubator-superset/pull/9891#issuecomment-632966454 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9891?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter commented on pull request #9891: fix: [dashboard] should not trigger chart refresh when filter not applicable

2020-05-22 Thread GitBox
codecov-commenter commented on pull request #9891: URL: https://github.com/apache/incubator-superset/pull/9891#issuecomment-632966454 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9891?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9891: fix: [dashboard] should not trigger chart refresh when filter not applicable

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9891: URL: https://github.com/apache/incubator-superset/pull/9891#issuecomment-632966454 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9891?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9891: fix: [dashboard] should not trigger chart refresh when filter not applicable

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9891: URL: https://github.com/apache/incubator-superset/pull/9891#issuecomment-632966454 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9891?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9891: fix: [dashboard] should not trigger chart refresh when filter not applicable

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9891: URL: https://github.com/apache/incubator-superset/pull/9891#issuecomment-632966454 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9891?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9891: fix: [dashboard] should not trigger chart refresh when filter not applicable

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9891: URL: https://github.com/apache/incubator-superset/pull/9891#issuecomment-632966454 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9891?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9884: fix: reenable table chart page length

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9884: URL: https://github.com/apache/incubator-superset/pull/9884#issuecomment-632789541 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9884?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] cachafla opened a new issue #8183: How to pass time filters to SQL Lab queries

2020-05-22 Thread GitBox
cachafla opened a new issue #8183: URL: https://github.com/apache/incubator-superset/issues/8183 Is there a way to pass `[from, to]` date filters to an SQL query? I've been looking everywhere in documentation and source code and haven't found a solution to passing date filters to

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9884: fix: reenable table chart page length

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9884: URL: https://github.com/apache/incubator-superset/pull/9884#issuecomment-632789541 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9884?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] govardhank opened a new issue #2571: Question:Is it posssible to integrate superset with other web application?

2020-05-22 Thread GitBox
govardhank opened a new issue #2571: URL: https://github.com/apache/incubator-superset/issues/2571 Is it posssible to integrate superset with other web application? This is an automated message from the Apache Git

[GitHub] [incubator-superset] mistercrunch commented on issue #9502: Filter box on a metric

2020-05-22 Thread GitBox
mistercrunch commented on issue #9502: URL: https://github.com/apache/incubator-superset/issues/9502#issuecomment-632821430 The filter box "visualization" could have an option to reuse the `FilterControl`. In theory this should work

[GitHub] [incubator-superset] codecov-commenter commented on pull request #9884: fix: reenable table chart page length

2020-05-22 Thread GitBox
codecov-commenter commented on pull request #9884: URL: https://github.com/apache/incubator-superset/pull/9884#issuecomment-632789541 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9884?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] mistercrunch commented on issue #9301: Jinja tempate is not getting evaluated while in explore or dashboad view

2020-05-22 Thread GitBox
mistercrunch commented on issue #9301: URL: https://github.com/apache/incubator-superset/issues/9301#issuecomment-632796961 Is this still an issue? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-superset] john-bodley merged pull request #9884: fix: reenable table chart page length

2020-05-22 Thread GitBox
john-bodley merged pull request #9884: URL: https://github.com/apache/incubator-superset/pull/9884 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-superset] mistercrunch commented on issue #9502: Filter box on a metric

2020-05-22 Thread GitBox
mistercrunch commented on issue #9502: URL: https://github.com/apache/incubator-superset/issues/9502#issuecomment-632821965 Workaround idea: creating a "bracket" column either as a physical column or as an expression. This

[GitHub] [incubator-superset] villebro commented on pull request #8493: Fix column type on dbs.encrypted_extra, add instructions for testing migration downgrades

2020-05-22 Thread GitBox
villebro commented on pull request #8493: URL: https://github.com/apache/incubator-superset/pull/8493#issuecomment-632768992 I'll start working on `0.36.1` so we can get this fix out to the broader community. This is an

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9884: fix: reenable table chart page length

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9884: URL: https://github.com/apache/incubator-superset/pull/9884#issuecomment-632789541 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9884?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9884: fix: reenable table chart page length

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9884: URL: https://github.com/apache/incubator-superset/pull/9884#issuecomment-632789541 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9884?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] mistercrunch commented on issue #9502: Filter box on a metric

2020-05-22 Thread GitBox
mistercrunch commented on issue #9502: URL: https://github.com/apache/incubator-superset/issues/9502#issuecomment-632823329 Longer term we want to make filter box as a dashboard native component and completely redesign it.

[GitHub] [incubator-superset] mistercrunch edited a comment on issue #9502: Filter box on a metric

2020-05-22 Thread GitBox
mistercrunch edited a comment on issue #9502: URL: https://github.com/apache/incubator-superset/issues/9502#issuecomment-632823329 Longer term we want to make filter box as a dashboard native component (as opposed to the current "special visualization" status) and completely redesign it.

[GitHub] [incubator-superset] thunderbird57 commented on issue #9502: Filter box on a metric

2020-05-22 Thread GitBox
thunderbird57 commented on issue #9502: URL: https://github.com/apache/incubator-superset/issues/9502#issuecomment-632823060 > Workaround idea: creating a "bracket" column either as a physical column or as an expression. Yes this work in cases where we have static ranges known. We

[GitHub] [incubator-superset] ktmud opened a new pull request #9884: fix: reenable table chart page length

2020-05-22 Thread GitBox
ktmud opened a new pull request #9884: URL: https://github.com/apache/incubator-superset/pull/9884 # SUMMARY Bump @superset-ui/legacy-preset-chart-table to fix missing page length support. See https://github.com/apache-superset/superset-ui/pull/522 ###

[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #9826: chore(ts): convert base js files to typescript

2020-05-22 Thread GitBox
graceguo-supercat commented on a change in pull request #9826: URL: https://github.com/apache/incubator-superset/pull/9826#discussion_r429348946 ## File path: superset-frontend/src/reduxUtils.ts ## @@ -52,17 +67,22 @@ export function alterInArr(state, arrKey, obj,

[GitHub] [incubator-superset] stale[bot] closed issue #6799: Table view as dashboard filter - don't highlight item or clear filter

2020-05-22 Thread GitBox
stale[bot] closed issue #6799: URL: https://github.com/apache/incubator-superset/issues/6799 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-superset] stale[bot] closed pull request #7716: [WiP] feat: backend for thumnail computation + caching + endpoints

2020-05-22 Thread GitBox
stale[bot] closed pull request #7716: URL: https://github.com/apache/incubator-superset/pull/7716 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-superset] stale[bot] closed issue #9295: Issue rendering mapbox on superset version 0.29.0rc5

2020-05-22 Thread GitBox
stale[bot] closed issue #9295: URL: https://github.com/apache/incubator-superset/issues/9295 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-superset] stale[bot] closed issue #9085: Webpack not found

2020-05-22 Thread GitBox
stale[bot] closed issue #9085: URL: https://github.com/apache/incubator-superset/issues/9085 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-superset] mistercrunch edited a comment on issue #9502: Filter box on a metric

2020-05-22 Thread GitBox
mistercrunch edited a comment on issue #9502: URL: https://github.com/apache/incubator-superset/issues/9502#issuecomment-632821965 Workaround idea: creating a "bracket" column either as a physical column or as an expression. Ex: instead of an integer age column, you can expose a `0-9`,

[GitHub] [incubator-superset] smirs opened a new issue #9885: error in `docker-compose up`

2020-05-22 Thread GitBox
smirs opened a new issue #9885: URL: https://github.com/apache/incubator-superset/issues/9885 I setup the environments once and could successfully install and run Superset via `docker-compose up` yesterday. Today when I cloned a fresh version of `apache-superset`, I was unsuccessful on

[GitHub] [incubator-superset] smirs closed issue #9815: inserting a new database into Superset

2020-05-22 Thread GitBox
smirs closed issue #9815: URL: https://github.com/apache/incubator-superset/issues/9815 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9888: URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9888: URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9888: URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9888: URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9886: feat: [dashboard] Add notification and warning for auto force refresh settings

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9886: URL: https://github.com/apache/incubator-superset/pull/9886#issuecomment-632909949 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9886?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter commented on pull request #9886: feat: [dashboard] Add notification and warning for auto force refresh settings

2020-05-22 Thread GitBox
codecov-commenter commented on pull request #9886: URL: https://github.com/apache/incubator-superset/pull/9886#issuecomment-632909949 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9886?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9886: feat: [dashboard] Add notification and warning for auto force refresh settings

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9886: URL: https://github.com/apache/incubator-superset/pull/9886#issuecomment-632909949 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9886?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9886: feat: [dashboard] Add notification and warning for auto force refresh settings

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9886: URL: https://github.com/apache/incubator-superset/pull/9886#issuecomment-632909949 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9886?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9886: feat: [dashboard] Add notification and warning for auto force refresh settings

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9886: URL: https://github.com/apache/incubator-superset/pull/9886#issuecomment-632909949 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9886?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] ktmud commented on issue #9887: [SIP-43] Proposal for Unified Chart Controls

2020-05-22 Thread GitBox
ktmud commented on issue #9887: URL: https://github.com/apache/incubator-superset/issues/9887#issuecomment-632915334 I feel the SIP template could use a "Technical Challenges and Risks" section. This is an automated message

[GitHub] [incubator-superset] mistercrunch opened a new pull request #9888: feat: make CRUD annotations inline

2020-05-22 Thread GitBox
mistercrunch opened a new pull request #9888: URL: https://github.com/apache/incubator-superset/pull/9888 # Summary This makes the annotations inline of the "annotation layers". Originally they were setup as separate ModelViews because of a bug in FAB. ## Before

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9888: URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9888: URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9888: URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter commented on pull request #9888: feat: make CRUD annotations inline

2020-05-22 Thread GitBox
codecov-commenter commented on pull request #9888: URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9888: URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9888: URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9888: URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #9886: feat: [dashboard] Add notification and warning for auto force refresh settings

2020-05-22 Thread GitBox
graceguo-supercat opened a new pull request #9886: URL: https://github.com/apache/incubator-superset/pull/9886 ### SUMMARY ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TEST PLAN ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ]

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9886: feat: [dashboard] Add notification and warning for auto force refresh settings

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9886: URL: https://github.com/apache/incubator-superset/pull/9886#issuecomment-632909949 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9886?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] ktmud opened a new issue #9887: [SIP] Proposal for Unified Chart Controls

2020-05-22 Thread GitBox
ktmud opened a new issue #9887: URL: https://github.com/apache/incubator-superset/issues/9887 *Disclaimer: regardless of the details embedded, this document is a conceptual proposal intended to start conversations. We are not committed to implement all or any of the proposed changes yet.*

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9888: URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9888: URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9888: URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9888: URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline

2020-05-22 Thread GitBox
codecov-commenter edited a comment on pull request #9888: URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] MihailGershkovich opened a new issue #9889: creating admin user fails with Error! User already exists admin

2020-05-22 Thread GitBox
MihailGershkovich opened a new issue #9889: URL: https://github.com/apache/incubator-superset/issues/9889 "Snapshot" of the shell: # superset fab create-admin logging was configured successfully INFO:superset.utils.logging_configurator:logging was configured successfully

[GitHub] [incubator-superset] stale[bot] commented on issue #9354: Treemap splits labels on `.`

2020-05-22 Thread GitBox
stale[bot] commented on issue #9354: URL: https://github.com/apache/incubator-superset/issues/9354#issuecomment-632933426 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your