Re: [PR] chore(烙): bump python "alembic==1.13.1" [superset]

2024-03-26 Thread via GitHub
mistercrunch merged PR #27650: URL: https://github.com/apache/superset/pull/27650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] chore(烙): bump python "sqlalchemy==1.4.52" [superset]

2024-03-26 Thread via GitHub
mistercrunch opened a new pull request, #27655: URL: https://github.com/apache/superset/pull/27655 Updates the python "sqlalchemy" library version. Generated by @supersetbot 烙 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] chore(烙): bump python "nh3==0.2.15" [superset]

2024-03-26 Thread via GitHub
codecov[bot] commented on PR #27656: URL: https://github.com/apache/superset/pull/27656#issuecomment-2019504665 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27656?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

[PR] chore(烙): bump python "msgpack==1.0.8" [superset]

2024-03-26 Thread via GitHub
mistercrunch opened a new pull request, #27659: URL: https://github.com/apache/superset/pull/27659 Updates the python "msgpack" library version. Generated by @supersetbot 烙 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] chore(烙): bump python "tabulate==0.8.10" [superset]

2024-03-26 Thread via GitHub
codecov[bot] commented on PR #27654: URL: https://github.com/apache/superset/pull/27654#issuecomment-2019500891 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27654?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] chore(烙): bump python "backoff==2.2.1" [superset]

2024-03-26 Thread via GitHub
codecov[bot] commented on PR #27658: URL: https://github.com/apache/superset/pull/27658#issuecomment-2019507226 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27658?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] chore(烙): bump python "msgpack==1.0.8" [superset]

2024-03-26 Thread via GitHub
codecov[bot] commented on PR #27659: URL: https://github.com/apache/superset/pull/27659#issuecomment-2019507978 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27659?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] chore(烙): bump python "pip-tools==7.4.1" [superset]

2024-03-26 Thread via GitHub
codecov[bot] commented on PR #27660: URL: https://github.com/apache/superset/pull/27660#issuecomment-2019548588 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27660?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

[PR] chore(烙): bump python "tabulate==0.8.10" [superset]

2024-03-26 Thread via GitHub
mistercrunch opened a new pull request, #27654: URL: https://github.com/apache/superset/pull/27654 Updates the python "tabulate" library version. Generated by @supersetbot 烙 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] chore(烙): bump python "flask==2.3.3" [superset]

2024-03-26 Thread via GitHub
mistercrunch opened a new pull request, #27657: URL: https://github.com/apache/superset/pull/27657 Updates the python "flask" library version. Generated by @supersetbot 烙 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] chore(supersetbot): bump python library "flask" [superset]

2024-03-26 Thread via GitHub
mistercrunch closed pull request #27637: chore(supersetbot): bump python library "flask" URL: https://github.com/apache/superset/pull/27637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] chore(烙): bump python "backoff==2.2.1" [superset]

2024-03-26 Thread via GitHub
mistercrunch opened a new pull request, #27658: URL: https://github.com/apache/superset/pull/27658 Updates the python "backoff" library version. Generated by @supersetbot 烙 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] New chart save fails [superset]

2024-03-26 Thread via GitHub
lilkumsy commented on issue #10023: URL: https://github.com/apache/superset/issues/10023#issuecomment-2019534640 hello everybody, i am having the same issues on Apache superset as am unable to create new dashboards or save charts as each time i try to save a chart it brings the error

Re: [I] Adding IBM DB2 to superset using ibm_db_sa [superset]

2024-03-26 Thread via GitHub
rahulbharalsaini commented on issue #27568: URL: https://github.com/apache/superset/issues/27568#issuecomment-2019720348 I am able to resolve this by making the custom image on the window based platform. rahulbharalsaini/superset:latest is build on top of official superset image which

Re: [I] Adding IBM DB2 to superset using ibm_db_sa [superset]

2024-03-26 Thread via GitHub
rahulbharalsaini closed issue #27568: Adding IBM DB2 to superset using ibm_db_sa URL: https://github.com/apache/superset/issues/27568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Adding IBM DB2 to superset using ibm_db_sa [superset]

2024-03-26 Thread via GitHub
rahulbharalsaini commented on issue #27568: URL: https://github.com/apache/superset/issues/27568#issuecomment-2019721686 Resolved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] chore(烙): bump python "nh3==0.2.15" [superset]

2024-03-26 Thread via GitHub
mistercrunch opened a new pull request, #27656: URL: https://github.com/apache/superset/pull/27656 Updates the python "nh3" library version. Generated by @supersetbot 烙 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] chore(烙): bump python "pip-tools==7.4.1" [superset]

2024-03-26 Thread via GitHub
mistercrunch opened a new pull request, #27660: URL: https://github.com/apache/superset/pull/27660 Updates the python "pip-tools" library version. Generated by @supersetbot 烙 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] chore(烙): bump python "sqlalchemy==1.4.52" [superset]

2024-03-26 Thread via GitHub
codecov[bot] commented on PR #27655: URL: https://github.com/apache/superset/pull/27655#issuecomment-2019503841 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27655?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] chore(烙): bump python "sqlalchemy==1.4.52" [superset]

2024-03-26 Thread via GitHub
mistercrunch merged PR #27655: URL: https://github.com/apache/superset/pull/27655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] feat(db_engine): Add custom_user_agent when connecting to MotherDuck [superset]

2024-03-26 Thread via GitHub
guenp opened a new pull request, #27665: URL: https://github.com/apache/superset/pull/27665 ### SUMMARY This PR adds a `custom_user_agent` key to the config that is passed to the SQLAlchemy engine for DuckDB. This is needed for MotherDuck so we can track usage of Superset. ###

Re: [PR] chore(烙): bump python "flask==2.3.3" [superset]

2024-03-26 Thread via GitHub
codecov[bot] commented on PR #27657: URL: https://github.com/apache/superset/pull/27657#issuecomment-2021149171 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27657?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] fix(AlertsReports): making log retention "None" option valid [superset]

2024-03-26 Thread via GitHub
geido commented on code in PR #27554: URL: https://github.com/apache/superset/pull/27554#discussion_r1539861292 ## superset-frontend/src/features/alerts/AlertReportModal.tsx: ## @@ -1610,11 +1610,7 @@ const AlertReportModal: FunctionComponent = ({

Re: [PR] feat(SIP-85): OAuth2 for databases [superset]

2024-03-26 Thread via GitHub
villebro commented on code in PR #27631: URL: https://github.com/apache/superset/pull/27631#discussion_r1539940030 ## superset/utils/oauth2.py: ## @@ -0,0 +1,152 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

Re: [PR] chore(烙): bump python "tabulate==0.8.10" [superset]

2024-03-26 Thread via GitHub
mistercrunch closed pull request #27654: chore(烙): bump python "tabulate==0.8.10" URL: https://github.com/apache/superset/pull/27654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] fix: Leverage actual database for rendering Jinjarized SQL [superset]

2024-03-26 Thread via GitHub
john-bodley merged PR #27646: URL: https://github.com/apache/superset/pull/27646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] chore(烙): bump python "msgpack==1.0.8" [superset]

2024-03-26 Thread via GitHub
mistercrunch closed pull request #27659: chore(烙): bump python "msgpack==1.0.8" URL: https://github.com/apache/superset/pull/27659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] chore(料): bump python "flask-session==0.8.0" [superset]

2024-03-26 Thread via GitHub
mistercrunch closed pull request #27669: chore(料): bump python "flask-session==0.8.0" URL: https://github.com/apache/superset/pull/27669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] chore(烙): bump python "nh3==0.2.15" [superset]

2024-03-26 Thread via GitHub
mistercrunch closed pull request #27656: chore(烙): bump python "nh3==0.2.15" URL: https://github.com/apache/superset/pull/27656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] chore(料): bump python "click-option-group==0.5.6" [superset]

2024-03-26 Thread via GitHub
mistercrunch closed pull request #27670: chore(料): bump python "click-option-group==0.5.6" URL: https://github.com/apache/superset/pull/27670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] feat(SIP-85): OAuth2 for databases [superset]

2024-03-26 Thread via GitHub
betodealmeida commented on code in PR #27631: URL: https://github.com/apache/superset/pull/27631#discussion_r1540142151 ## superset/utils/oauth2.py: ## @@ -0,0 +1,152 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] feat(time-comparison-table): show and hide time comparison columns [superset]

2024-03-26 Thread via GitHub
eschutho commented on PR #27446: URL: https://github.com/apache/superset/pull/27446#issuecomment-2021069605 I'm going to remove the hold label because this PR is being merged into a feature branch, and will put another hold label on the feature branch PR when ready if the SIP hasn't been

Re: [PR] fix(AlertReports): disabling value when not null option is active [superset]

2024-03-26 Thread via GitHub
geido merged PR #27550: URL: https://github.com/apache/superset/pull/27550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] feat(time-comparison-table): show and hide time comparison columns [superset]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #27446: URL: https://github.com/apache/superset/pull/27446#issuecomment-2021209855 Ephemeral environment shutdown and build artifacts deleted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] chore(料): bump python "click-option-group==0.5.6" [superset]

2024-03-26 Thread via GitHub
github-actions[bot] opened a new pull request, #27670: URL: https://github.com/apache/superset/pull/27670 Updates the python "click-option-group" library version. Generated by @supersetbot 料 -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] chore(料): bump python "flask-session==0.8.0" [superset]

2024-03-26 Thread via GitHub
github-actions[bot] opened a new pull request, #27669: URL: https://github.com/apache/superset/pull/27669 Updates the python "flask-session" library version. Generated by @supersetbot 料 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] chore(料): bump python "typing-extensions==4.10.0" [superset]

2024-03-26 Thread via GitHub
mistercrunch closed pull request #27676: chore(料): bump python "typing-extensions==4.10.0" URL: https://github.com/apache/superset/pull/27676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] chore(料): bump python "humanize==4.9.0" [superset]

2024-03-26 Thread via GitHub
mistercrunch closed pull request #27677: chore(料): bump python "humanize==4.9.0" URL: https://github.com/apache/superset/pull/27677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] chore(料): bump python "xlsxwriter==3.0.9" [superset]

2024-03-26 Thread via GitHub
mistercrunch closed pull request #27678: chore(料): bump python "xlsxwriter==3.0.9" URL: https://github.com/apache/superset/pull/27678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] fix(Chart Annotation modal): Table and Superset annotation options will paginate, exceeding previous max limit 100 [superset]

2024-03-26 Thread via GitHub
eschutho merged PR #27022: URL: https://github.com/apache/superset/pull/27022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Annotation Layer modal doesn't list all table charts when there are more than 100 tables [superset]

2024-03-26 Thread via GitHub
eschutho closed issue #25421: Annotation Layer modal doesn't list all table charts when there are more than 100 tables URL: https://github.com/apache/superset/issues/25421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[I] gauge chart should allow in customize to configure legend position and alignment [superset]

2024-03-26 Thread via GitHub
nigzak opened a new issue, #27664: URL: https://github.com/apache/superset/issues/27664 ## Screenshot ![image](https://github.com/apache/superset/assets/102737855/841bbfa0-7f65-4aaa-86b6-946d56b1a55d) ## Description Gauge Chart: let the user decide to position the

Re: [PR] feat(db_engine): Add custom_user_agent when connecting to MotherDuck [superset]

2024-03-26 Thread via GitHub
codecov[bot] commented on PR #27665: URL: https://github.com/apache/superset/pull/27665#issuecomment-2021097289 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27665?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] fix: Provide more inclusive error handling for saved queries [superset]

2024-03-26 Thread via GitHub
michael-s-molina commented on code in PR #27644: URL: https://github.com/apache/superset/pull/27644#discussion_r1539859452 ## superset/models/sql_lab.py: ## @@ -76,7 +77,7 @@ def sql_tables(self) -> list[Table]: self.database.db_engine_spec.engine, # type:

Re: [PR] chore(烙): bump python "flask==2.3.3" [superset]

2024-03-26 Thread via GitHub
mistercrunch commented on PR #27657: URL: https://github.com/apache/superset/pull/27657#issuecomment-2021243261 @dpgaspar I fix the failing test wdyt!? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] chore(料): bump python "croniter==2.0.3" [superset]

2024-03-26 Thread via GitHub
mistercrunch closed pull request #27683: chore(料): bump python "croniter==2.0.3" URL: https://github.com/apache/superset/pull/27683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] chore(料): bump python "isodate==0.6.1" [superset]

2024-03-26 Thread via GitHub
mistercrunch closed pull request #27680: chore(料): bump python "isodate==0.6.1" URL: https://github.com/apache/superset/pull/27680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] chore(料): bump python "pyarrow==14.0.2" [superset]

2024-03-26 Thread via GitHub
mistercrunch closed pull request #27684: chore(料): bump python "pyarrow==14.0.2" URL: https://github.com/apache/superset/pull/27684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] chore(料): bump python "isodate==0.6.1" [superset]

2024-03-26 Thread via GitHub
codecov[bot] commented on PR #27680: URL: https://github.com/apache/superset/pull/27680#issuecomment-2021389270 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27680?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] feat(SIP-85): OAuth2 for databases [superset]

2024-03-26 Thread via GitHub
betodealmeida commented on code in PR #27631: URL: https://github.com/apache/superset/pull/27631#discussion_r1540042915 ## superset/db_engine_specs/gsheets.py: ## @@ -136,6 +153,89 @@ def extra_table_metadata( return {"metadata": metadata["extra"]} +

Re: [PR] fix: Provide more inclusive error handling for saved queries [superset]

2024-03-26 Thread via GitHub
john-bodley commented on code in PR #27644: URL: https://github.com/apache/superset/pull/27644#discussion_r1539766395 ## superset/models/sql_lab.py: ## @@ -76,7 +77,7 @@ def sql_tables(self) -> list[Table]: self.database.db_engine_spec.engine, # type:

[I] [SIP] add a data filter for "like" to allow user to filter in a table for matches as dashboard_filter or as table_filter [superset]

2024-03-26 Thread via GitHub
nigzak opened a new issue, #27666: URL: https://github.com/apache/superset/issues/27666 ## [SIP] Proposal for add a data filter for "like" to allow user to filter in a table for matches as dashboard_filter or as table_filter ### Motivation If you have a bigger raw table in

[PR] chore(料): bump python "python-dotenv==1.0.1" [superset]

2024-03-26 Thread via GitHub
github-actions[bot] opened a new pull request, #27675: URL: https://github.com/apache/superset/pull/27675 Updates the python "python-dotenv" library version. Generated by @supersetbot 料 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] chore(烙): bump python "backoff==2.2.1" [superset]

2024-03-26 Thread via GitHub
mistercrunch closed pull request #27658: chore(烙): bump python "backoff==2.2.1" URL: https://github.com/apache/superset/pull/27658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] chore(烙): bump python "pip-tools==7.4.1" [superset]

2024-03-26 Thread via GitHub
mistercrunch closed pull request #27660: chore(烙): bump python "pip-tools==7.4.1" URL: https://github.com/apache/superset/pull/27660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] chore(料): bump python "cron-descriptor==1.4.3" [superset]

2024-03-26 Thread via GitHub
mistercrunch closed pull request #27671: chore(料): bump python "cron-descriptor==1.4.3" URL: https://github.com/apache/superset/pull/27671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] chore(料): bump python "pyparsing==3.1.2" [superset]

2024-03-26 Thread via GitHub
mistercrunch closed pull request #27672: chore(料): bump python "pyparsing==3.1.2" URL: https://github.com/apache/superset/pull/27672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] chore(料): bump python "xlsxwriter==3.0.9" [superset]

2024-03-26 Thread via GitHub
mistercrunch closed pull request #27673: chore(料): bump python "xlsxwriter==3.0.9" URL: https://github.com/apache/superset/pull/27673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] chore(料): bump python "typing-extensions==4.10.0" [superset]

2024-03-26 Thread via GitHub
mistercrunch closed pull request #27674: chore(料): bump python "typing-extensions==4.10.0" URL: https://github.com/apache/superset/pull/27674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] chore(料): bump python "python-dotenv==1.0.1" [superset]

2024-03-26 Thread via GitHub
mistercrunch closed pull request #27675: chore(料): bump python "python-dotenv==1.0.1" URL: https://github.com/apache/superset/pull/27675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] chore(料): bump python "typing-extensions==4.10.0" [superset]

2024-03-26 Thread via GitHub
github-actions[bot] opened a new pull request, #27674: URL: https://github.com/apache/superset/pull/27674 Updates the python "typing-extensions" library version. Generated by @supersetbot 料 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] chore(料): bump python "polyline==2.0.2" [superset]

2024-03-26 Thread via GitHub
codecov[bot] commented on PR #27681: URL: https://github.com/apache/superset/pull/27681#issuecomment-2021393539 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27681?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] feat(SIP-85): OAuth2 for databases [superset]

2024-03-26 Thread via GitHub
eschutho commented on code in PR #27631: URL: https://github.com/apache/superset/pull/27631#discussion_r1540003340 ## superset/db_engine_specs/gsheets.py: ## @@ -136,6 +153,89 @@ def extra_table_metadata( return {"metadata": metadata["extra"]} +@staticmethod +

Re: [PR] chore(料): bump python "pyarrow==14.0.2" [superset]

2024-03-26 Thread via GitHub
codecov[bot] commented on PR #27684: URL: https://github.com/apache/superset/pull/27684#issuecomment-2021391878 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27684?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] fix(Chart Annotation modal): Table and Superset annotation options will paginate, exceeding previous max limit 100 [superset]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #27022: URL: https://github.com/apache/superset/pull/27022#issuecomment-2020979536 Ephemeral environment shutdown and build artifacts deleted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] fix(Dashboard): Add border to row when hovering HoverMenu in edit mode [superset]

2024-03-26 Thread via GitHub
eschutho commented on code in PR #27593: URL: https://github.com/apache/superset/pull/27593#discussion_r1539738046 ## superset-frontend/src/dashboard/components/menu/HoverMenu.tsx: ## @@ -70,6 +72,18 @@ export default class HoverMenu extends React.PureComponent {

Re: [PR] chore(烙): bump python "flask==2.3.3" [superset]

2024-03-26 Thread via GitHub
mistercrunch commented on PR #27657: URL: https://github.com/apache/superset/pull/27657#issuecomment-2020988460 Trying to get gpt to fix this one... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] fix(sqllab): unable to remove table [superset]

2024-03-26 Thread via GitHub
john-bodley merged PR #27636: URL: https://github.com/apache/superset/pull/27636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix: Provide more inclusive error handling for saved queries [superset]

2024-03-26 Thread via GitHub
john-bodley commented on code in PR #27644: URL: https://github.com/apache/superset/pull/27644#discussion_r1539766395 ## superset/models/sql_lab.py: ## @@ -76,7 +77,7 @@ def sql_tables(self) -> list[Table]: self.database.db_engine_spec.engine, # type:

Re: [PR] fix: Provide more inclusive error handling for saved queries [superset]

2024-03-26 Thread via GitHub
michael-s-molina commented on code in PR #27644: URL: https://github.com/apache/superset/pull/27644#discussion_r1539968925 ## superset/models/sql_lab.py: ## @@ -76,7 +77,7 @@ def sql_tables(self) -> list[Table]: self.database.db_engine_spec.engine, # type:

[PR] chore(料): bump python "pyarrow==14.0.2" [superset]

2024-03-26 Thread via GitHub
github-actions[bot] opened a new pull request, #27684: URL: https://github.com/apache/superset/pull/27684 Updates the python "pyarrow" library version. Generated by @supersetbot 料 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] chore(料): bump python "polyline==2.0.2" [superset]

2024-03-26 Thread via GitHub
github-actions[bot] opened a new pull request, #27681: URL: https://github.com/apache/superset/pull/27681 Updates the python "polyline" library version. Generated by @supersetbot 料 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[PR] chore(料): bump python "isodate==0.6.1" [superset]

2024-03-26 Thread via GitHub
github-actions[bot] opened a new pull request, #27680: URL: https://github.com/apache/superset/pull/27680 Updates the python "isodate" library version. Generated by @supersetbot 料 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] chore(料): bump python "click==8.1.7" [superset]

2024-03-26 Thread via GitHub
github-actions[bot] opened a new pull request, #27682: URL: https://github.com/apache/superset/pull/27682 Updates the python "click" library version. Generated by @supersetbot 料 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] chore(料): bump python "croniter==2.0.3" [superset]

2024-03-26 Thread via GitHub
github-actions[bot] opened a new pull request, #27683: URL: https://github.com/apache/superset/pull/27683 Updates the python "croniter" library version. Generated by @supersetbot 料 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] chore(料): bump python "polyline==2.0.2" [superset]

2024-03-26 Thread via GitHub
mistercrunch closed pull request #27681: chore(料): bump python "polyline==2.0.2" URL: https://github.com/apache/superset/pull/27681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] chore(料): bump python "python-dateutil==2.9.0.post0" [superset]

2024-03-26 Thread via GitHub
mistercrunch closed pull request #27679: chore(料): bump python "python-dateutil==2.9.0.post0" URL: https://github.com/apache/superset/pull/27679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] perf(explore): virtualized datasource field sections [superset]

2024-03-26 Thread via GitHub
justinpark commented on code in PR #27625: URL: https://github.com/apache/superset/pull/27625#discussion_r1540078296 ## superset-frontend/src/explore/components/DatasourcePanel/DatasourcePanelItem.tsx: ## @@ -0,0 +1,230 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] fix: Provide more inclusive error handling for saved queries [superset]

2024-03-26 Thread via GitHub
john-bodley commented on code in PR #27644: URL: https://github.com/apache/superset/pull/27644#discussion_r1539766395 ## superset/models/sql_lab.py: ## @@ -76,7 +77,7 @@ def sql_tables(self) -> list[Table]: self.database.db_engine_spec.engine, # type:

[PR] chore(料): bump python "cron-descriptor==1.4.3" [superset]

2024-03-26 Thread via GitHub
github-actions[bot] opened a new pull request, #27671: URL: https://github.com/apache/superset/pull/27671 Updates the python "cron-descriptor" library version. Generated by @supersetbot 料 -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] chore(料): bump python "pyparsing==3.1.2" [superset]

2024-03-26 Thread via GitHub
github-actions[bot] opened a new pull request, #27672: URL: https://github.com/apache/superset/pull/27672 Updates the python "pyparsing" library version. Generated by @supersetbot 料 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[PR] chore(料): bump python "xlsxwriter==3.0.9" [superset]

2024-03-26 Thread via GitHub
github-actions[bot] opened a new pull request, #27673: URL: https://github.com/apache/superset/pull/27673 Updates the python "xlsxwriter" library version. Generated by @supersetbot 料 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] chore(烙): bump python "flask==2.3.3" [superset]

2024-03-26 Thread via GitHub
mistercrunch merged PR #27657: URL: https://github.com/apache/superset/pull/27657 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] feat(time-comparison-table): show and hide time comparison columns [superset]

2024-03-26 Thread via GitHub
lilykuang merged PR #27446: URL: https://github.com/apache/superset/pull/27446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[I] Select component fires onChange when selected value has not changed [superset]

2024-03-26 Thread via GitHub
fisjac opened a new issue, #27668: URL: https://github.com/apache/superset/issues/27668 ### Bug description When rendering the Select component in singleMode (only one selection can be selected), selecting the currently selected value from the dropdown options triggers the onChange

Re: [PR] fix(AlertReports): preventing reset of notification settings when method does not change [superset]

2024-03-26 Thread via GitHub
fisjac commented on code in PR #27556: URL: https://github.com/apache/superset/pull/27556#discussion_r1539943054 ## superset-frontend/src/features/alerts/components/NotificationMethod.tsx: ## @@ -76,6 +76,9 @@ export const NotificationMethod: FunctionComponent = ({ }

Re: [PR] fix(AlertReports): preventing reset of notification settings when method does not change [superset]

2024-03-26 Thread via GitHub
fisjac closed pull request #27556: fix(AlertReports): preventing reset of notification settings when method does not change URL: https://github.com/apache/superset/pull/27556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] fix: Provide more inclusive error handling for saved queries [superset]

2024-03-26 Thread via GitHub
michael-s-molina merged PR #27644: URL: https://github.com/apache/superset/pull/27644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] chore(料): bump python "click==8.1.7" [superset]

2024-03-26 Thread via GitHub
mistercrunch closed pull request #27682: chore(料): bump python "click==8.1.7" URL: https://github.com/apache/superset/pull/27682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] DO NOT MERGE-test cypress error [superset]

2024-03-26 Thread via GitHub
eschutho closed pull request #27095: DO NOT MERGE-test cypress error URL: https://github.com/apache/superset/pull/27095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] fix(alerts/reports): removing duplicate notification method options [superset]

2024-03-26 Thread via GitHub
geido commented on PR #27239: URL: https://github.com/apache/superset/pull/27239#issuecomment-2021153660 Let's rebase this with master to unstuck CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] gauge chart should allow in customize to configure legend position and alignment [superset]

2024-03-26 Thread via GitHub
michael-s-molina commented on issue #27664: URL: https://github.com/apache/superset/issues/27664#issuecomment-2021213608 Moving to a GitHub discussion as this is more of a feature request. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] feat(accessibility): add tabbing to chart menu in dashboard [superset]

2024-03-26 Thread via GitHub
eschutho commented on code in PR #26138: URL: https://github.com/apache/superset/pull/26138#discussion_r1539906736 ## superset-frontend/src/dashboard/types.ts: ## @@ -237,3 +237,32 @@ export type Slice = { owners: { id: number }[]; created_by: { id: number }; }; +

Re: [I] gauge chart should allow in customize to configure legend position and alignment [superset]

2024-03-26 Thread via GitHub
michael-s-molina closed issue #27664: gauge chart should allow in customize to configure legend position and alignment URL: https://github.com/apache/superset/issues/27664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] fix(AlertReports): preventing reset of notification settings when method does not change [superset]

2024-03-26 Thread via GitHub
fisjac commented on PR #27556: URL: https://github.com/apache/superset/pull/27556#issuecomment-2021257651 Closing in favor of another PR to address upstream issue https://github.com/apache/superset/issues/27668 -- This is an automated message from the Apache Git Service. To respond to

[PR] chore(料): bump python "typing-extensions==4.10.0" [superset]

2024-03-26 Thread via GitHub
github-actions[bot] opened a new pull request, #27676: URL: https://github.com/apache/superset/pull/27676 Updates the python "typing-extensions" library version. Generated by @supersetbot 料 -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] chore(料): bump python "humanize==4.9.0" [superset]

2024-03-26 Thread via GitHub
github-actions[bot] opened a new pull request, #27677: URL: https://github.com/apache/superset/pull/27677 Updates the python "humanize" library version. Generated by @supersetbot 料 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[PR] chore(料): bump python "xlsxwriter==3.0.9" [superset]

2024-03-26 Thread via GitHub
github-actions[bot] opened a new pull request, #27678: URL: https://github.com/apache/superset/pull/27678 Updates the python "xlsxwriter" library version. Generated by @supersetbot 料 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[PR] chore(料): bump python "python-dateutil==2.9.0.post0" [superset]

2024-03-26 Thread via GitHub
github-actions[bot] opened a new pull request, #27679: URL: https://github.com/apache/superset/pull/27679 Updates the python "python-dateutil" library version. Generated by @supersetbot 料 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] chore(料): bump python "click==8.1.7" [superset]

2024-03-26 Thread via GitHub
codecov[bot] commented on PR #27682: URL: https://github.com/apache/superset/pull/27682#issuecomment-2021398348 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27682?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

  1   2   >