[GitHub] [incubator-superset] John-Athan commented on issue #6685: Druid Column Type does not get updated

[GitBox]

John-Athan commented on issue #6685: Druid Column Type does not get updated 
URL: 
https://github.com/apache/incubator-superset/issues/6685#issuecomment-584505824
 
 
   If I remember correctly, the column type gets updated one week after it has 
been changed, as superset requests metadata for the last week of available 
druid data for every topic. So you either need to wait one week or re-add the 
datasource to superset. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] villebro commented on issue #8699: [SIP-29] Add support for row-level security

[GitBox]

villebro commented on issue #8699: [SIP-29] Add support for row-level security
URL: 
https://github.com/apache/incubator-superset/pull/8699#issuecomment-584502731
 
 
   @altef having tests that validates that the query being generated correctly 
adds the expected where clause to the query based on a given role would be 
nice. We can add more tests later, but for now that should be enough.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] serenajiang commented on a change in pull request #9109: [migration] metadata for dashboard filters

[GitBox]

serenajiang commented on a change in pull request #9109: [migration] metadata 
for dashboard filters
URL: 
https://github.com/apache/incubator-superset/pull/9109#discussion_r377465441
 
 

 ##
 File path: 
superset/migrations/versions/3325d4caccc8_dashboard_scoped_filters.py
 ##
 @@ -0,0 +1,114 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""empty message
+
+Revision ID: 3325d4caccc8
+Revises: e96dbf2cfef0
+Create Date: 2020-02-07 14:13:51.714678
+
+"""
+
+# revision identifiers, used by Alembic.
+import json
+import logging
+
+from alembic import op
+from sqlalchemy import and_, Column, ForeignKey, Integer, String, Table, Text
+from sqlalchemy.ext.declarative import declarative_base
+from sqlalchemy.orm import relationship
+
+from superset import db
+from superset.utils.dashboard_filter_scopes_converter import 
convert_filter_scopes
+
+revision = "3325d4caccc8"
+down_revision = "e96dbf2cfef0"
+
+Base = declarative_base()
+
+
+class Slice(Base):
+"""Declarative class to do query in upgrade"""
+
+__tablename__ = "slices"
+id = Column(Integer, primary_key=True)
+slice_name = Column(String(250))
+params = Column(Text)
+viz_type = Column(String(250))
+
+
+dashboard_slices = Table(
+"dashboard_slices",
+Base.metadata,
+Column("id", Integer, primary_key=True),
+Column("dashboard_id", Integer, ForeignKey("dashboards.id")),
+Column("slice_id", Integer, ForeignKey("slices.id")),
+)
+
+
+class Dashboard(Base):
+__tablename__ = "dashboards"
+id = Column(Integer, primary_key=True)
+json_metadata = Column(Text)
+slices = relationship("Slice", secondary=dashboard_slices, 
backref="dashboards")
+
+
+def upgrade():
+bind = op.get_bind()
+session = db.Session(bind=bind)
+
+dashboards = session.query(Dashboard).all()
+for i, dashboard in enumerate(dashboards):
+print("scanning dashboard ({}/{}) ".format(i + 1, len(dashboards)))
+try:
+json_metadata = json.loads(dashboard.json_metadata or "{}")
+if "filter_scopes" in json_metadata:
+continue
+
+filter_scopes = {}
+slice_ids = [slice.id for slice in dashboard.slices]
+filters = (
+session.query(Slice)
+.filter(and_(Slice.id.in_(slice_ids), Slice.viz_type == 
"filter_box"))
+.all()
+)
 
 Review comment:
   I don't think the query for filters is necessary, since the slices shouuuld 
have all the info loaded, so you could just do something like:
   ```
   filters = [slice for slice in dashboard.slices if slice.viz_type == 
"filter_box"]
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] serenajiang commented on a change in pull request #9109: [migration] metadata for dashboard filters

[GitBox]

serenajiang commented on a change in pull request #9109: [migration] metadata 
for dashboard filters
URL: 
https://github.com/apache/incubator-superset/pull/9109#discussion_r377465658
 
 

 ##
 File path: 
superset/migrations/versions/3325d4caccc8_dashboard_scoped_filters.py
 ##
 @@ -0,0 +1,114 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""empty message
+
+Revision ID: 3325d4caccc8
+Revises: e96dbf2cfef0
+Create Date: 2020-02-07 14:13:51.714678
+
+"""
+
+# revision identifiers, used by Alembic.
+import json
+import logging
+
+from alembic import op
+from sqlalchemy import and_, Column, ForeignKey, Integer, String, Table, Text
+from sqlalchemy.ext.declarative import declarative_base
+from sqlalchemy.orm import relationship
+
+from superset import db
+from superset.utils.dashboard_filter_scopes_converter import 
convert_filter_scopes
+
+revision = "3325d4caccc8"
+down_revision = "e96dbf2cfef0"
+
+Base = declarative_base()
+
+
+class Slice(Base):
+"""Declarative class to do query in upgrade"""
+
+__tablename__ = "slices"
+id = Column(Integer, primary_key=True)
+slice_name = Column(String(250))
+params = Column(Text)
+viz_type = Column(String(250))
+
+
+dashboard_slices = Table(
+"dashboard_slices",
+Base.metadata,
+Column("id", Integer, primary_key=True),
+Column("dashboard_id", Integer, ForeignKey("dashboards.id")),
+Column("slice_id", Integer, ForeignKey("slices.id")),
+)
+
+
+class Dashboard(Base):
+__tablename__ = "dashboards"
+id = Column(Integer, primary_key=True)
+json_metadata = Column(Text)
+slices = relationship("Slice", secondary=dashboard_slices, 
backref="dashboards")
+
+
+def upgrade():
+bind = op.get_bind()
+session = db.Session(bind=bind)
+
+dashboards = session.query(Dashboard).all()
+for i, dashboard in enumerate(dashboards):
+print("scanning dashboard ({}/{}) ".format(i + 1, len(dashboards)))
+try:
+json_metadata = json.loads(dashboard.json_metadata or "{}")
+if "filter_scopes" in json_metadata:
+continue
+
+filter_scopes = {}
+slice_ids = [slice.id for slice in dashboard.slices]
+filters = (
+session.query(Slice)
+.filter(and_(Slice.id.in_(slice_ids), Slice.viz_type == 
"filter_box"))
+.all()
+)
+
+# if dashboard has filter_box
+if len(filters):
 
 Review comment:
   I slightly prefer 
   ```python
   if filters:
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] serenajiang commented on a change in pull request #9109: [migration] metadata for dashboard filters

[GitBox]

serenajiang commented on a change in pull request #9109: [migration] metadata 
for dashboard filters
URL: 
https://github.com/apache/incubator-superset/pull/9109#discussion_r377462655
 
 

 ##
 File path: 
superset/migrations/versions/3325d4caccc8_dashboard_scoped_filters.py
 ##
 @@ -0,0 +1,114 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""empty message
+
+Revision ID: 3325d4caccc8
+Revises: e96dbf2cfef0
+Create Date: 2020-02-07 14:13:51.714678
+
+"""
+
+# revision identifiers, used by Alembic.
+import json
+import logging
+
+from alembic import op
+from sqlalchemy import and_, Column, ForeignKey, Integer, String, Table, Text
+from sqlalchemy.ext.declarative import declarative_base
+from sqlalchemy.orm import relationship
+
+from superset import db
+from superset.utils.dashboard_filter_scopes_converter import 
convert_filter_scopes
+
+revision = "3325d4caccc8"
+down_revision = "e96dbf2cfef0"
+
+Base = declarative_base()
+
+
+class Slice(Base):
+"""Declarative class to do query in upgrade"""
+
+__tablename__ = "slices"
+id = Column(Integer, primary_key=True)
+slice_name = Column(String(250))
+params = Column(Text)
+viz_type = Column(String(250))
+
+
+dashboard_slices = Table(
 
 Review comment:
   Just for consistency, can you make this the same format as `Slice` and 
`Dashboard`?
   
   ```python
   class DashboardSlices(Base):
   __tablename__ = "dashboard_slices"
   id = Column(Integer, primary_key = True)
   ...and so on
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] serenajiang commented on a change in pull request #9109: [migration] metadata for dashboard filters

[GitBox]

serenajiang commented on a change in pull request #9109: [migration] metadata 
for dashboard filters
URL: 
https://github.com/apache/incubator-superset/pull/9109#discussion_r377468825
 
 

 ##
 File path: superset/utils/dashboard_filter_scopes_converter.py
 ##
 @@ -0,0 +1,72 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+import logging
+from typing import Dict, List
+
+from superset.models.slice import Slice
+
+logger = logging.getLogger(__name__)
+
+
+def convert_filter_scopes(json_metadata: Dict, filters: List[Slice]):
+filter_scopes = {}
+immuned_by_id: List[int] = json_metadata.get("filter_immune_slices") or []
+immuned_by_column: Dict = {}
+for slice_id, columns in json_metadata.get(
+"filter_immune_slice_fields", {}
+).items():
+for column in columns:
+if immuned_by_column.get(column, None) is None:
+immuned_by_column[column] = []
+immuned_by_column[column].append(int(slice_id))
+
+def add_filter_scope(filter_field, filter_id):
+# in case filter field is invalid
+if isinstance(filter_field, str):
+current_filter_immune = list(
+set(immuned_by_id + immuned_by_column.get(filter_field, []))
+)
+filter_fields[filter_field] = {
+"scope": ["ROOT_ID"],
+"immune": current_filter_immune,
+}
+else:
+logging.info(f"slice [{filter_id}] has invalid field: 
{filter_field}")
+
+for filter_slice in filters:
+filter_fields: Dict = {}
+filter_id = filter_slice.id
+slice_params = filter_slice.params or {}
+configs = slice_params.get("filter_configs") or []
+
+if slice_params.get("date_filter", False):
 
 Review comment:
   ```suggestion
   if slice_params.get("date_filter"):
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] serenajiang commented on a change in pull request #9109: [migration] metadata for dashboard filters

[GitBox]

serenajiang commented on a change in pull request #9109: [migration] metadata 
for dashboard filters
URL: 
https://github.com/apache/incubator-superset/pull/9109#discussion_r377466798
 
 

 ##
 File path: 
superset/migrations/versions/3325d4caccc8_dashboard_scoped_filters.py
 ##
 @@ -0,0 +1,114 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""empty message
+
+Revision ID: 3325d4caccc8
+Revises: e96dbf2cfef0
+Create Date: 2020-02-07 14:13:51.714678
+
+"""
+
+# revision identifiers, used by Alembic.
+import json
+import logging
+
+from alembic import op
+from sqlalchemy import and_, Column, ForeignKey, Integer, String, Table, Text
+from sqlalchemy.ext.declarative import declarative_base
+from sqlalchemy.orm import relationship
+
+from superset import db
+from superset.utils.dashboard_filter_scopes_converter import 
convert_filter_scopes
+
+revision = "3325d4caccc8"
+down_revision = "e96dbf2cfef0"
+
+Base = declarative_base()
+
+
+class Slice(Base):
+"""Declarative class to do query in upgrade"""
+
+__tablename__ = "slices"
+id = Column(Integer, primary_key=True)
+slice_name = Column(String(250))
+params = Column(Text)
+viz_type = Column(String(250))
+
+
+dashboard_slices = Table(
+"dashboard_slices",
+Base.metadata,
+Column("id", Integer, primary_key=True),
+Column("dashboard_id", Integer, ForeignKey("dashboards.id")),
+Column("slice_id", Integer, ForeignKey("slices.id")),
+)
+
+
+class Dashboard(Base):
+__tablename__ = "dashboards"
+id = Column(Integer, primary_key=True)
+json_metadata = Column(Text)
+slices = relationship("Slice", secondary=dashboard_slices, 
backref="dashboards")
+
+
+def upgrade():
+bind = op.get_bind()
+session = db.Session(bind=bind)
+
+dashboards = session.query(Dashboard).all()
+for i, dashboard in enumerate(dashboards):
+print("scanning dashboard ({}/{}) ".format(i + 1, len(dashboards)))
+try:
+json_metadata = json.loads(dashboard.json_metadata or "{}")
+if "filter_scopes" in json_metadata:
+continue
+
+filter_scopes = {}
+slice_ids = [slice.id for slice in dashboard.slices]
+filters = (
+session.query(Slice)
+.filter(and_(Slice.id.in_(slice_ids), Slice.viz_type == 
"filter_box"))
+.all()
+)
+
+# if dashboard has filter_box
+if len(filters):
+filter_scopes = convert_filter_scopes(json_metadata, filters)
+
+json_metadata.pop("filter_immune_slices", None)
+json_metadata.pop("filter_immune_slice_fields", None)
+if filter_scopes:
+json_metadata["filter_scopes"] = filter_scopes
+logging.info(
+f"Adding filter_scopes for dashboard {dashboard.id}: 
{json.dumps(filter_scopes)}"
+)
+if json_metadata:
+dashboard.json_metadata = json.dumps(
+json_metadata, indent=None, separators=(",", ":"), 
sort_keys=True
+)
+
+session.merge(dashboard)
+except Exception as e:
+logging.exception(f"dashboard {dashboard.id} has error: {e}")
 
 Review comment:
   When you tested this, were there ever any errors? I'm curious what kind of 
errors might occur.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] serenajiang commented on a change in pull request #9109: [migration] metadata for dashboard filters

[GitBox]

serenajiang commented on a change in pull request #9109: [migration] metadata 
for dashboard filters
URL: 
https://github.com/apache/incubator-superset/pull/9109#discussion_r377466527
 
 

 ##
 File path: 
superset/migrations/versions/3325d4caccc8_dashboard_scoped_filters.py
 ##
 @@ -0,0 +1,114 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""empty message
+
+Revision ID: 3325d4caccc8
+Revises: e96dbf2cfef0
+Create Date: 2020-02-07 14:13:51.714678
+
+"""
+
+# revision identifiers, used by Alembic.
+import json
+import logging
+
+from alembic import op
+from sqlalchemy import and_, Column, ForeignKey, Integer, String, Table, Text
+from sqlalchemy.ext.declarative import declarative_base
+from sqlalchemy.orm import relationship
+
+from superset import db
+from superset.utils.dashboard_filter_scopes_converter import 
convert_filter_scopes
+
+revision = "3325d4caccc8"
+down_revision = "e96dbf2cfef0"
+
+Base = declarative_base()
+
+
+class Slice(Base):
+"""Declarative class to do query in upgrade"""
+
+__tablename__ = "slices"
+id = Column(Integer, primary_key=True)
+slice_name = Column(String(250))
+params = Column(Text)
+viz_type = Column(String(250))
+
+
+dashboard_slices = Table(
+"dashboard_slices",
+Base.metadata,
+Column("id", Integer, primary_key=True),
+Column("dashboard_id", Integer, ForeignKey("dashboards.id")),
+Column("slice_id", Integer, ForeignKey("slices.id")),
+)
+
+
+class Dashboard(Base):
+__tablename__ = "dashboards"
+id = Column(Integer, primary_key=True)
+json_metadata = Column(Text)
+slices = relationship("Slice", secondary=dashboard_slices, 
backref="dashboards")
+
+
+def upgrade():
+bind = op.get_bind()
+session = db.Session(bind=bind)
+
+dashboards = session.query(Dashboard).all()
+for i, dashboard in enumerate(dashboards):
+print("scanning dashboard ({}/{}) ".format(i + 1, len(dashboards)))
 
 Review comment:
   Hmm, I don't have a strong preference for which, but we should probably 
either stick to `print` or `logging.info` and not do both.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] villebro edited a comment on issue #9110: Superset install pulls in werkzeug 1.0 which has changed paths for imports, breaking the intsall

[GitBox]

villebro edited a comment on issue #9110: Superset install pulls in werkzeug 
1.0 which has changed paths for imports, breaking the intsall
URL: 
https://github.com/apache/incubator-superset/issues/9110#issuecomment-584496976
 
 
   @dpgaspar looking more closely at the stacktrace, it seems `FAB` is pulling 
in `Flask-Babel<1.0`, which pulls in an unpinned version of `werkzeug` but 
actually depends on `werkzeug<1.0`. As this has been fixed in 
`Flask-Babel==1.0.0` which was released last week, I think the cleanest 
solution would be bump `werkzeug>=1.0.0` in `FAB` if it doesn't introduce any 
other problems.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] villebro edited a comment on issue #9110: Superset install pulls in werkzeug 1.0 which has changed paths for imports, breaking the intsall

[GitBox]

villebro edited a comment on issue #9110: Superset install pulls in werkzeug 
1.0 which has changed paths for imports, breaking the intsall
URL: 
https://github.com/apache/incubator-superset/issues/9110#issuecomment-584496976
 
 
   @dpgaspar looking more closely at the stacktrace, it seems `FAB` is pulling 
in `Flask-Babel<1.0`, which pulls in an unpinned version of `werkzeug` but 
actually depends on `werkzeug<1.0`. As this has been fixed in 
`Flask-Babel==1.0.0` which was released last week, I think the cleanest 
solution would be bump `werkzeug>=1.0.0` in FAB if it doesn't introduce any 
other problems.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] villebro commented on issue #9110: Superset install pulls in werkzeug 1.0 which has changed paths for imports, breaking the intsall

[GitBox]

villebro commented on issue #9110: Superset install pulls in werkzeug 1.0 which 
has changed paths for imports, breaking the intsall
URL: 
https://github.com/apache/incubator-superset/issues/9110#issuecomment-584496976
 
 
   @dpgaspar looking more closely at the stacktrace, it seems FAB is pulling in 
`Flask-Babel<1.0`, which pulls in an unpinned version of `werkzeug` but 
actually depends on `werkzeug<1.0`. As this has been fixed in 
`Flask-Babel==1.0.0` which was released last week, I think the cleanest 
solution would be bump `werkzeug>=1.0.0` in FAB if it doesn't introduce any 
other problems.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on issue #9109: [WIP][migration] metadata for dashboard filters

[GitBox]

codecov-io edited a comment on issue #9109: [WIP][migration] metadata for 
dashboard filters
URL: 
https://github.com/apache/incubator-superset/pull/9109#issuecomment-584293503
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=h1)
 Report
   > Merging 
[#9109](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/291306392443a5a0d0e2ee0cc4a95d37c56d4589?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/9109/graphs/tree.svg?width=650=KsB0fHcx6l=150=pr)](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master   #9109   +/-   ##
   ==
 Coverage59.1%   59.1%   
   ==
 Files 372 372   
 Lines   11920   11920   
 Branches 29172917   
   ==
 Hits 70457045   
 Misses   46934693   
 Partials  182 182
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=footer).
 Last update 
[2913063...24206ab](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] bharath0208 commented on issue #9113: The environment variable POSTGRES_HOST was missing !!!

[GitBox]

bharath0208 commented on issue #9113: The environment variable POSTGRES_HOST 
was missing !!!
URL: 
https://github.com/apache/incubator-superset/issues/9113#issuecomment-584474305
 
 
   @nytai i tried running --build command but still getting the same error. I 
have cleared all docker images and running containers as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] stale[bot] closed issue #8778: Druid Datasource Editor can not save changes when opening In Chart Editor

[GitBox]

stale[bot] closed issue #8778: Druid Datasource Editor can not save changes 
when opening In Chart Editor 
URL: https://github.com/apache/incubator-superset/issues/8778
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] stale[bot] commented on issue #8827: Permit "EXPLAIN" with "Allow DML" unchecked

[GitBox]

stale[bot] commented on issue #8827: Permit "EXPLAIN" with "Allow DML" unchecked
URL: 
https://github.com/apache/incubator-superset/issues/8827#issuecomment-584459219
 
 
   This issue has been automatically marked as stale because it has not had 
recent activity. It will be closed if no further activity occurs. Thank you for 
your contributions. For admin, please label this issue `.pinned` to prevent 
stale bot from closing the issue.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] suddjian edited a comment on issue #9114: fix Dockerfile for frontend builds

[GitBox]

suddjian edited a comment on issue #9114: fix Dockerfile for frontend builds
URL: 
https://github.com/apache/incubator-superset/pull/9114#issuecomment-584458879
 
 
   Whew. Had some trials and tribulations as you can see from the commit log 
but I dare say this is ready to go. Approvals/criticisms welcome.
   
   One change I was forced to make was moving `version_info.json` from 
`/static/assets` to `/static`. Issues arose around it being built by python 
code while webpack owns the contents of `/assets`. version_info isn't really an 
asset anyway, so I would argue that `/static` is the correct location for it in 
this directory structure.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] suddjian edited a comment on issue #9114: fix Dockerfile for frontend builds

[GitBox]

suddjian edited a comment on issue #9114: fix Dockerfile for frontend builds
URL: 
https://github.com/apache/incubator-superset/pull/9114#issuecomment-584458879
 
 
   Whew. Had some trials and tribulations as you can see from the commit log 
but I dare say this is ready to go. Approvals/criticisms welcome.
   
   One change I was forced to make was moving `version_info.json` from 
`/static/assets` to `/static`. Issues arose around it being built by python 
code and also around webpack cleaning the contents of `/assets`. version_info 
isn't really an asset anyway, so I would argue that `/static` is the correct 
location for it in this directory structure.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] suddjian commented on issue #9114: fix Dockerfile for frontend builds

[GitBox]

suddjian commented on issue #9114: fix Dockerfile for frontend builds
URL: 
https://github.com/apache/incubator-superset/pull/9114#issuecomment-584458879
 
 
   Whew. Had some trials and tribulations as you can see from the commit log 
but I dare say this is ready to go. Approvals/criticisms welcome.
   
   One change I was forced to make was moving `version_info.json` from 
`/static/assets` to `/static`, since it is built by python code and webpack 
cleans the contents of `/assets`. version_info isn't really an asset anyway, so 
I would argue that `/static` is the correct location for it in this directory 
structure.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on issue #9114: fix Dockerfile for frontend builds

[GitBox]

codecov-io edited a comment on issue #9114: fix Dockerfile for frontend builds
URL: 
https://github.com/apache/incubator-superset/pull/9114#issuecomment-584415532
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9114?src=pr=h1)
 Report
   > Merging 
[#9114](https://codecov.io/gh/apache/incubator-superset/pull/9114?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/291306392443a5a0d0e2ee0cc4a95d37c56d4589?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/9114/graphs/tree.svg?width=650=KsB0fHcx6l=150=pr)](https://codecov.io/gh/apache/incubator-superset/pull/9114?src=pr=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master   #9114   +/-   ##
   ==
 Coverage59.1%   59.1%   
   ==
 Files 372 372   
 Lines   11920   11920   
 Branches 29172917   
   ==
 Hits 70457045   
 Misses   46934693   
 Partials  182 182
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9114?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9114?src=pr=footer).
 Last update 
[2913063...65dfcae](https://codecov.io/gh/apache/incubator-superset/pull/9114?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on issue #9109: [WIP][migration] metadata for dashboard filters

[GitBox]

codecov-io edited a comment on issue #9109: [WIP][migration] metadata for 
dashboard filters
URL: 
https://github.com/apache/incubator-superset/pull/9109#issuecomment-584293503
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=h1)
 Report
   > Merging 
[#9109](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/291306392443a5a0d0e2ee0cc4a95d37c56d4589?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/9109/graphs/tree.svg?width=650=KsB0fHcx6l=150=pr)](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master   #9109   +/-   ##
   ==
 Coverage59.1%   59.1%   
   ==
 Files 372 372   
 Lines   11920   11920   
 Branches 29172917   
   ==
 Hits 70457045   
 Misses   46934693   
 Partials  182 182
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=footer).
 Last update 
[2913063...8e4147f](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] serenajiang commented on issue #9096: SQL Lab: Use numpy structured arrays, fallback to JSON serialization

[GitBox]

serenajiang commented on issue #9096: SQL Lab: Use numpy structured arrays, 
fallback to JSON serialization
URL: 
https://github.com/apache/incubator-superset/pull/9096#issuecomment-584449351
 
 
   @robdiciuccio 
   
   FYI, we're having an issue where certain nested presto structs fail to 
render in sqllab. The error is: `an integer is required (got type str)`
   
   I'm having trouble figuring out the exact situation that results in this 
problem, but it appears to be a regression, since this was fine a week ago. The 
column that errors has type:
   ```
   MAP>
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] Maria28281 commented on issue #6685: Druid Column Type does not get updated

[GitBox]

Maria28281 commented on issue #6685: Druid Column Type does not get updated 
URL: 
https://github.com/apache/incubator-superset/issues/6685#issuecomment-584432380
 
 
   someone else could be resolving this issue?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] suddjian commented on issue #9114: fix Dockerfile for frontend builds

[GitBox]

suddjian commented on issue #9114: fix Dockerfile for frontend builds
URL: 
https://github.com/apache/incubator-superset/pull/9114#issuecomment-584429361
 
 
   I think you're right, thanks for catching that @nytai


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] nytai commented on issue #9114: fix Dockerfile for frontend builds

[GitBox]

nytai commented on issue #9114: fix Dockerfile for frontend builds
URL: 
https://github.com/apache/incubator-superset/pull/9114#issuecomment-584429222
 
 
   Looks like `version_info.json` is produced by running setup.py. I think it's 
only meant to end up in the actual pip tarball package under 
`superset/static/assets/version_info.json`. Looking at `setup.py` I'm not sure 
the paths are correct for generating `version_info.json`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #9107: feat: add rolling window support to 'Big Number with Trendline' viz

[GitBox]

mistercrunch commented on a change in pull request #9107: feat: add rolling 
window support to 'Big Number with Trendline' viz
URL: 
https://github.com/apache/incubator-superset/pull/9107#discussion_r377399726
 
 

 ##
 File path: tests/viz_tests.py
 ##
 @@ -1163,3 +1163,26 @@ def test_process_data_resample(self):
 .tolist(),
 [1.0, 2.0, np.nan, np.nan, 5.0, np.nan, 7.0],
 )
+
+def test_apply_roling(self):
+datasource = self.get_datasource_mock()
+df = pd.DataFrame(
+index=pd.to_datetime(
+["2019-01-01", "2019-01-02", "2019-01-05", "2019-01-07"]
+),
+data={"y": [1.0, 1.0, 1.0, 1.0]},
+)
+self.assertEqual(
+viz.BigNumberViz(
+datasource,
+{
+"metrics": ["y"],
+"rolling_type": "cumsum",
 
 Review comment:
   Agreed, that was the plan to fast follow once I manage to get `tox` working 
locally. Somehow it's really hard to install python3.6 on a new Mac.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #9114: fix Dockerfile for frontend builds

[GitBox]

codecov-io commented on issue #9114: fix Dockerfile for frontend builds
URL: 
https://github.com/apache/incubator-superset/pull/9114#issuecomment-584415532
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9114?src=pr=h1)
 Report
   > Merging 
[#9114](https://codecov.io/gh/apache/incubator-superset/pull/9114?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/291306392443a5a0d0e2ee0cc4a95d37c56d4589?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/9114/graphs/tree.svg?width=650=KsB0fHcx6l=150=pr)](https://codecov.io/gh/apache/incubator-superset/pull/9114?src=pr=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master   #9114   +/-   ##
   ==
 Coverage59.1%   59.1%   
   ==
 Files 372 372   
 Lines   11920   11920   
 Branches 29172917   
   ==
 Hits 70457045   
 Misses   46934693   
 Partials  182 182
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9114?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9114?src=pr=footer).
 Last update 
[2913063...d1d0f05](https://codecov.io/gh/apache/incubator-superset/pull/9114?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] suddjian opened a new pull request #9114: fix Dockerfile for frontend builds

[GitBox]

suddjian opened a new pull request #9114: fix Dockerfile for frontend builds
URL: https://github.com/apache/incubator-superset/pull/9114
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   
   
   My previous PR introduced a bug to the Dockerfile. This fixes it.
   
   ### TEST PLAN
   
   
   I've verified this by running `docker-compose up --build`, but again would 
appreciate verification from someone more well-versed in docker-ology
   
   ### ADDITIONAL INFORMATION
   
   
   - [x] Has associated issue: Fixes #9112
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @mistercrunch @nytai 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] suddjian commented on issue #9112: Superset-node docker compose fails to create container

[GitBox]

suddjian commented on issue #9112: Superset-node docker compose fails to create 
container
URL: 
https://github.com/apache/incubator-superset/issues/9112#issuecomment-584411643
 
 
   Delving further into this, I've discovered a related issue with the 
Dockerfile: some files are not being copied at the correct times from the 
correct places. I'll have a fix up soon. `docker-compose build` or 
`docker-compose up --build` will still be necessary after the fix.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8867: Make schema name for the CTA queries and limit configurable

[GitBox]

codecov-io edited a comment on issue #8867: Make schema name for the CTA 
queries and limit configurable
URL: 
https://github.com/apache/incubator-superset/pull/8867#issuecomment-569331306
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8867?src=pr=h1)
 Report
   > Merging 
[#8867](https://codecov.io/gh/apache/incubator-superset/pull/8867?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/291306392443a5a0d0e2ee0cc4a95d37c56d4589?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/8867/graphs/tree.svg?width=650=KsB0fHcx6l=150=pr)](https://codecov.io/gh/apache/incubator-superset/pull/8867?src=pr=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master   #8867   +/-   ##
   ==
 Coverage59.1%   59.1%   
   ==
 Files 372 372   
 Lines   11920   11920   
 Branches 29172917   
   ==
 Hits 70457045   
 Misses   46934693   
 Partials  182 182
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8867?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8867?src=pr=footer).
 Last update 
[2913063...182b5ce](https://codecov.io/gh/apache/incubator-superset/pull/8867?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] bkyryliuk commented on issue #8867: Make schema name for the CTA queries and limit configurable

[GitBox]

bkyryliuk commented on issue #8867: Make schema name for the CTA queries and 
limit configurable
URL: 
https://github.com/apache/incubator-superset/pull/8867#issuecomment-584401801
 
 
   @villebro  - done, thanks !


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] nytai commented on issue #9113: The environment variable POSTGRES_HOST was missing !!!

[GitBox]

nytai commented on issue #9113: The environment variable POSTGRES_HOST was 
missing !!!
URL: 
https://github.com/apache/incubator-superset/issues/9113#issuecomment-584400863
 
 
   @bharath0208 have you previously run `docker-compose up` on the same 
computer? If so, try running `docker-compose up --build` to pull in the latest 
config into the container 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] bharath0208 opened a new issue #9113: The environment variable POSTGRES_HOST was missing !!!

[GitBox]

bharath0208 opened a new issue #9113: The environment variable POSTGRES_HOST 
was missing !!!
URL: https://github.com/apache/incubator-superset/issues/9113
 
 
   Unable to get login web page when using docker-compose up. 
   https://user-images.githubusercontent.com/44377322/74197260-20750280-4c2d-11ea-9b60-505333fa273d.png;>
   
   
   OSError: [The environment variable POSTGRES_HOST was missing,]([url](url)) 
abort...
   superset_1 | ERROR:root:Found but failed to import local 
superset_config
   superset_1 | Traceback (most recent call last):
   superset_1 |   File "/app/pythonpath/superset_config.py", line 48, 
in get_env_variable
   superset_1 | return os.environ[var_name]
   superset_1 |   File "/usr/local/lib/python3.6/os.py", line 669, in 
__getitem__
   superset_1 | raise KeyError(key) from None
   superset_1 | KeyError: 'POSTGRES_HOST'
   superset_1 | 
   superset_1 | During handling of the above exception, another 
exception occurred:
   superset_1 | 
   superset_1 | Traceback (most recent call last):
   superset_1 |   File "/app/superset/config.py", line 758, in 
   superset_1 | from superset_config import *  # pylint: 
disable=import-error,wildcard-import,unused-wildcard-import
   superset_1 |   File "/app/pythonpath/superset_config.py", line 61, 
in 
   superset_1 | POSTGRES_HOST = get_env_variable("POSTGRES_HOST")
   superset_1 |   File "/app/pythonpath/superset_config.py", line 56, 
in get_env_variable
   superset_1 | raise EnvironmentError(error_msg)
   superset_1 | OSError: The environment variable POSTGRES_HOST was 
missing, abort...
   superset_1 | ERROR:superset.app:Failed to create app
   superset_1 | Traceback (most recent call last):
   superset_1 |   File "/app/pythonpath/superset_config.py", line 48, 
in get_env_variable
   superset_1 | return os.environ[var_name]
   superset_1 |   File "/usr/local/lib/python3.6/os.py", line 669, in 
__getitem__
   superset_1 | raise KeyError(key) from None
   superset-worker_1  | ERROR:root:Found but failed to import local 
superset_config
   superset-worker_1  | Traceback (most recent call last):
   superset-worker_1  |   File "/app/pythonpath/superset_config.py", line 48, 
in get_env_variable
   superset-worker_1  | return os.environ[var_name]
   superset-worker_1  |   File "/usr/local/lib/python3.6/os.py", line 669, in 
__getitem__
   superset-worker_1  | raise KeyError(key) from None
   superset-worker_1  | KeyError: 'POSTGRES_HOST'
   superset-worker_1  | 
   superset-worker_1  | During handling of the above exception, another 
exception occurred:
   superset-worker_1  | 
   superset-worker_1  | Traceback (most recent call last):
   superset-worker_1  |   File "/app/superset/config.py", line 758, in 
   superset-worker_1  | from superset_config import *  # pylint: 
disable=import-error,wildcard-import,unused-wildcard-import
   superset-worker_1  |   File "/app/pythonpath/superset_config.py", line 61, 
in 
   superset-worker_1  | POSTGRES_HOST = get_env_variable("POSTGRES_HOST")
   superset-worker_1  |   File "/app/pythonpath/superset_config.py", line 56, 
in get_env_variable
   superset-worker_1  | raise EnvironmentError(error_msg)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] psiegrist opened a new issue #9112: Superset-node docker compose fails to create container

[GitBox]

psiegrist opened a new issue #9112: Superset-node docker compose fails to 
create container
URL: https://github.com/apache/incubator-superset/issues/9112
 
 
   A clear and concise description of what the bug is.
   
   ### Expected results
   Superset-node container starts with docker-compose. 
   
   ### Actual results
   
   Superset-node container does not start with docker-compose. 
   
   The docker error is bash: line 0: cd: /app/superset-frontend: No such file 
or directory
   Seems like this commit may have caused the problem:
   291306392 (David Aaron Suddjian 2020-02-09 17:53:56 -0800 69) command: 
["bash", "-c", "cd /app/superset-frontend && npm install && npm run dev"]
   
    Screenshots
   
   
    How to reproduce the bug
   git clone https://github.com/apache/incubator-superset/
   docker-compose up
   
   ### Environment
   Ubuntu 18.04.3 - AWS
   
   ### Checklist
   
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [ ] I have checked the superset logs for python stacktraces and included 
it here as text if there are any.
   - [ ] I have reproduced the issue with at least the latest released version 
of superset.
   - [ ] I have checked the issue tracker for the same issue and I haven't 
found one similar.
   
   ### Additional context
   
   Add any other context about the problem here.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] altef commented on issue #8699: [SIP-29] Add support for row-level security

[GitBox]

altef commented on issue #8699: [SIP-29] Add support for row-level security
URL: 
https://github.com/apache/incubator-superset/pull/8699#issuecomment-584377759
 
 
   @dpgaspar, @villebro; What test do you want?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #9111: fix: restrict werkzeug to <1.0 in setup.py

[GitBox]

codecov-io commented on issue #9111: fix: restrict werkzeug to <1.0 in setup.py
URL: 
https://github.com/apache/incubator-superset/pull/9111#issuecomment-584362315
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9111?src=pr=h1)
 Report
   > Merging 
[#9111](https://codecov.io/gh/apache/incubator-superset/pull/9111?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/291306392443a5a0d0e2ee0cc4a95d37c56d4589?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/9111/graphs/tree.svg?width=650=KsB0fHcx6l=150=pr)](https://codecov.io/gh/apache/incubator-superset/pull/9111?src=pr=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master   #9111   +/-   ##
   ==
 Coverage59.1%   59.1%   
   ==
 Files 372 372   
 Lines   11920   11920   
 Branches 29172917   
   ==
 Hits 70457045   
 Misses   46934693   
 Partials  182 182
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9111?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9111?src=pr=footer).
 Last update 
[2913063...c20a25e](https://codecov.io/gh/apache/incubator-superset/pull/9111?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] villebro opened a new pull request #9111: fix: restrict werkzeug to <1.0 in setup.py

[GitBox]

villebro opened a new pull request #9111: fix: restrict werkzeug to <1.0 in 
setup.py
URL: https://github.com/apache/incubator-superset/pull/9111
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   With the release of `werkzeug 1.0.0`, installing via `pip` pulls in a 
version of `werkzeug` which is not currently compatible with superset. This PR 
restricts the version of `werkzeug` to `<1.0` in `setup.py`, ensuring that 
installation via `pip` works properly.
   
   ### TEST PLAN
   Test locally
   
   ### ADDITIONAL INFORMATION
   
   
   - [x] Has associated issue: closes #9110
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] johnseekins commented on issue #9110: Superset install pulls in werkzeug 1.0 which has changed paths for imports, breaking the intsall

[GitBox]

johnseekins commented on issue #9110: Superset install pulls in werkzeug 1.0 
which has changed paths for imports, breaking the intsall
URL: 
https://github.com/apache/incubator-superset/issues/9110#issuecomment-584352265
 
 
   I mean...docs indicate that `pip3 install apache-airflow` is the correct way 
to install latest stable, so it may be worth fixing.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] villebro commented on issue #9110: Superset install pulls in werkzeug 1.0 which has changed paths for imports, breaking the intsall

[GitBox]

villebro commented on issue #9110: Superset install pulls in werkzeug 1.0 which 
has changed paths for imports, breaking the intsall
URL: 
https://github.com/apache/incubator-superset/issues/9110#issuecomment-584351736
 
 
   Werkzeug actually isn't restricted in `setup.py`, which means that `pip 
install apache-superset` pulls in the latest stable version. I noticed that 
airflow hit a similar problem with werkzeug this weekend, so superset also 
needs to either restrict the version or accommodate to the `1.0` version. I can 
look i to fixing this if needed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] johnseekins opened a new issue #9110: Superset install pulls in werkzeug 1.0 which has changed paths for imports, breaking the intsall

[GitBox]

johnseekins opened a new issue #9110: Superset install pulls in werkzeug 1.0 
which has changed paths for imports, breaking the intsall
URL: https://github.com/apache/incubator-superset/issues/9110
 
 
   A clear and concise description of what the bug is.
   
   ### Expected results
   Superset runs
   
   ### Actual results
   ```root@use1-hadoop-16:/datto/monitoring/superset# 
/datto/monitoring/superset/.pyenv/versions/3.6.8/bin/superset init
   Traceback (most recent call last):
 File "/datto/monitoring/superset/.pyenv/versions/3.6.8/bin/superset", line 
21, in 
   from superset.cli import create_app
 File 
"/datto/monitoring/superset/.pyenv/versions/3.6.8/lib/python3.6/site-packages/superset/__init__.py",
 line 27, in 
   from flask_appbuilder import AppBuilder, IndexView, SQLA
 File 
"/datto/monitoring/superset/.pyenv/versions/3.6.8/lib/python3.6/site-packages/flask_appbuilder/__init__.py",
 line 5, in 
   from .api import ModelRestApi  # noqa: F401
 File 
"/datto/monitoring/superset/.pyenv/versions/3.6.8/lib/python3.6/site-packages/flask_appbuilder/api/__init__.py",
 line 10, in 
   from flask_babel import lazy_gettext as _
 File 
"/datto/monitoring/superset/.pyenv/versions/3.6.8/lib/python3.6/site-packages/flask_babel/__init__.py",
 line 19, in 
   from werkzeug import ImmutableDict
   ImportError: cannot import name 'ImmutableDict'
   ```
   root@use1-hadoop-16:/datto/monitoring/superset# 
/datto/monitoring/superset/.pyenv/versions/3.6.8/bin/superset init
   Traceback (most recent call last):
 File "/datto/monitoring/superset/.pyenv/versions/3.6.8/bin/superset", line 
21, in 
   from superset.cli import create_app
 File 
"/datto/monitoring/superset/.pyenv/versions/3.6.8/lib/python3.6/site-packages/superset/__init__.py",
 line 27, in 
   from flask_appbuilder import AppBuilder, IndexView, SQLA
 File 
"/datto/monitoring/superset/.pyenv/versions/3.6.8/lib/python3.6/site-packages/flask_appbuilder/__init__.py",
 line 5, in 
   from .api import ModelRestApi  # noqa: F401
 File 
"/datto/monitoring/superset/.pyenv/versions/3.6.8/lib/python3.6/site-packages/flask_appbuilder/api/__init__.py",
 line 10, in 
   from flask_babel import lazy_gettext as _
 File 
"/datto/monitoring/superset/.pyenv/versions/3.6.8/lib/python3.6/site-packages/flask_babel/__init__.py",
 line 19, in 
   from werkzeug import ImmutableDict
   ImportError: cannot import name 'ImmutableDict'
   
    How to reproduce the bug
   1. Install superset per regular instructions: `pip3 install apache-superset`
   2. attempt to run a superset command
   
   ### Environment
   
   - superset version: 0.35.2
   - python version: 3.6.8
   - node.js version: ? (not installed as this is a binary install)
   - npm version: ? (not installed as this is a binary install)
   
   ### Checklist
   
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [x] I have checked the superset logs for python stacktraces and included 
it here as text if there are any.
   - [x] I have reproduced the issue with at least the latest released version 
of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't 
found one similar.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] johnseekins commented on issue #9110: Superset install pulls in werkzeug 1.0 which has changed paths for imports, breaking the intsall

[GitBox]

johnseekins commented on issue #9110: Superset install pulls in werkzeug 1.0 
which has changed paths for imports, breaking the intsall
URL: 
https://github.com/apache/incubator-superset/issues/9110#issuecomment-584347651
 
 
   It must be, yeah. Strange that just `pip3 install apache-superset` wouldn't 
pull the correct requirements.txt. Well...never mind then!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] johnseekins closed issue #9110: Superset install pulls in werkzeug 1.0 which has changed paths for imports, breaking the intsall

[GitBox]

johnseekins closed issue #9110: Superset install pulls in werkzeug 1.0 which 
has changed paths for imports, breaking the intsall
URL: https://github.com/apache/incubator-superset/issues/9110
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] nytai commented on issue #9110: Superset install pulls in werkzeug 1.0 which has changed paths for imports, breaking the intsall

[GitBox]

nytai commented on issue #9110: Superset install pulls in werkzeug 1.0 which 
has changed paths for imports, breaking the intsall
URL: 
https://github.com/apache/incubator-superset/issues/9110#issuecomment-584346777
 
 
   supersets requirements specifies `werkzeug==0.16.1` 
https://github.com/apache/incubator-superset/blob/master/requirements.txt#L82
   
   This issue appears related to your environment. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] johnseekins commented on issue #9110: Superset install pulls in werkzeug 1.0 which has changed paths for imports, breaking the intsall

[GitBox]

johnseekins commented on issue #9110: Superset install pulls in werkzeug 1.0 
which has changed paths for imports, breaking the intsall
URL: 
https://github.com/apache/incubator-superset/issues/9110#issuecomment-584337536
 
 
   ```
   pip3 uninstall werkzeug
   pip3 install werkzeug==0.16.1
   ```
   Fixed the problem.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] johnseekins opened a new issue #9110: Superset install pulls in werkzeug 1.0 which has changed paths for imports, breaking the intsall

[GitBox]

johnseekins opened a new issue #9110: Superset install pulls in werkzeug 1.0 
which has changed paths for imports, breaking the intsall
URL: https://github.com/apache/incubator-superset/issues/9110
 
 
   A clear and concise description of what the bug is.
   
   ### Expected results
   Superset runs
   
   ### Actual results
   ```root@use1-hadoop-16:/datto/monitoring/superset# 
/datto/monitoring/superset/.pyenv/versions/3.6.8/bin/superset init
   Traceback (most recent call last):
 File "/datto/monitoring/superset/.pyenv/versions/3.6.8/bin/superset", line 
21, in 
   from superset.cli import create_app
 File 
"/datto/monitoring/superset/.pyenv/versions/3.6.8/lib/python3.6/site-packages/superset/__init__.py",
 line 27, in 
   from flask_appbuilder import AppBuilder, IndexView, SQLA
 File 
"/datto/monitoring/superset/.pyenv/versions/3.6.8/lib/python3.6/site-packages/flask_appbuilder/__init__.py",
 line 5, in 
   from .api import ModelRestApi  # noqa: F401
 File 
"/datto/monitoring/superset/.pyenv/versions/3.6.8/lib/python3.6/site-packages/flask_appbuilder/api/__init__.py",
 line 10, in 
   from flask_babel import lazy_gettext as _
 File 
"/datto/monitoring/superset/.pyenv/versions/3.6.8/lib/python3.6/site-packages/flask_babel/__init__.py",
 line 19, in 
   from werkzeug import ImmutableDict
   ImportError: cannot import name 'ImmutableDict'
   ```
   root@use1-hadoop-16:/datto/monitoring/superset# 
/datto/monitoring/superset/.pyenv/versions/3.6.8/bin/superset init
   Traceback (most recent call last):
 File "/datto/monitoring/superset/.pyenv/versions/3.6.8/bin/superset", line 
21, in 
   from superset.cli import create_app
 File 
"/datto/monitoring/superset/.pyenv/versions/3.6.8/lib/python3.6/site-packages/superset/__init__.py",
 line 27, in 
   from flask_appbuilder import AppBuilder, IndexView, SQLA
 File 
"/datto/monitoring/superset/.pyenv/versions/3.6.8/lib/python3.6/site-packages/flask_appbuilder/__init__.py",
 line 5, in 
   from .api import ModelRestApi  # noqa: F401
 File 
"/datto/monitoring/superset/.pyenv/versions/3.6.8/lib/python3.6/site-packages/flask_appbuilder/api/__init__.py",
 line 10, in 
   from flask_babel import lazy_gettext as _
 File 
"/datto/monitoring/superset/.pyenv/versions/3.6.8/lib/python3.6/site-packages/flask_babel/__init__.py",
 line 19, in 
   from werkzeug import ImmutableDict
   ImportError: cannot import name 'ImmutableDict'
   
    How to reproduce the bug
   1. Install superset per regular instructions: `pip3 install apache-superset`
   2. attempt to run a superset command
   
   ### Environment
   
   - superset version: 0.35.2
   - python version: 3.6.8
   - node.js version: ? (not installed as this is a binary install)
   - npm version: ? (not installed as this is a binary install)
   
   ### Checklist
   
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [x] I have checked the superset logs for python stacktraces and included 
it here as text if there are any.
   - [x] I have reproduced the issue with at least the latest released version 
of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't 
found one similar.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] hossam-96 commented on issue #8933: utf8mb4 support - german characters

[GitBox]

hossam-96 commented on issue #8933: utf8mb4 support - german characters
URL: 
https://github.com/apache/incubator-superset/issues/8933#issuecomment-584331750
 
 
   > yes, it was a problem from the source db
   
   okay thanks. the solution was actually to just add "?charset=utf8mb4" in the 
end of the SQLALCHEMY_DATABASE_URI 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] PRamia commented on issue #8933: utf8mb4 support - german characters

[GitBox]

PRamia commented on issue #8933: utf8mb4 support - german characters
URL: 
https://github.com/apache/incubator-superset/issues/8933#issuecomment-584318585
 
 
   yes, it was a problem from the source db


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] hossam-96 commented on issue #8933: utf8mb4 support - german characters

[GitBox]

hossam-96 commented on issue #8933: utf8mb4 support - german characters
URL: 
https://github.com/apache/incubator-superset/issues/8933#issuecomment-584317215
 
 
   Did you find a solution ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] williaster commented on issue #8865: deprecate tslint in favor of eslint w/ typescript support

[GitBox]

williaster commented on issue #8865: deprecate tslint in favor of eslint w/ 
typescript support
URL: 
https://github.com/apache/incubator-superset/issues/8865#issuecomment-584315761
 
 
   standardizing on the `nimbus` build configs from `superset-ui` + 
`superset-ui-plugins` repos seems like it could be a good idea. then it's one 
thing to learn across all repos.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on issue #8658: fix: handle duplicate groupby keys

[GitBox]

mistercrunch commented on issue #8658: fix: handle duplicate groupby keys
URL: 
https://github.com/apache/incubator-superset/pull/8658#issuecomment-584308400
 
 
   Can we push this forward as it addresses a bug?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on issue #9109: [migration] metadata for dashboard filters

[GitBox]

codecov-io edited a comment on issue #9109: [migration] metadata for dashboard 
filters
URL: 
https://github.com/apache/incubator-superset/pull/9109#issuecomment-584293503
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=h1)
 Report
   > Merging 
[#9109](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/291306392443a5a0d0e2ee0cc4a95d37c56d4589?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/9109/graphs/tree.svg?width=650=KsB0fHcx6l=150=pr)](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master   #9109   +/-   ##
   ==
 Coverage59.1%   59.1%   
   ==
 Files 372 372   
 Lines   11920   11920   
 Branches 29172917   
   ==
 Hits 70457045   
 Misses   46934693   
 Partials  182 182
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=footer).
 Last update 
[2913063...9331512](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] stale[bot] closed issue #8763: npm error 68% building 3528/3594 modules 66 active ...-map/node_modules/d3-array/src/count.jsinternal/child_process.js:366 throw errnoExcep

[GitBox]

stale[bot] closed issue #8763: npm error 68% building 3528/3594 modules 66 
active ...-map/node_modules/d3-array/src/count.jsinternal/child_process.js:366  
   throw errnoException(err, 'spawn'); ^
URL: https://github.com/apache/incubator-superset/issues/8763
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] stale[bot] closed issue #8322: An unknown error occurred. Please contact your Superset administrator

[GitBox]

stale[bot] closed issue #8322: An unknown error occurred. Please contact your 
Superset administrator
URL: https://github.com/apache/incubator-superset/issues/8322
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on issue #9109: [migration] metadata for dashboard filters

[GitBox]

codecov-io edited a comment on issue #9109: [migration] metadata for dashboard 
filters
URL: 
https://github.com/apache/incubator-superset/pull/9109#issuecomment-584293503
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=h1)
 Report
   > Merging 
[#9109](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/291306392443a5a0d0e2ee0cc4a95d37c56d4589?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/9109/graphs/tree.svg?width=650=KsB0fHcx6l=150=pr)](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master   #9109   +/-   ##
   ==
 Coverage59.1%   59.1%   
   ==
 Files 372 372   
 Lines   11920   11920   
 Branches 29172917   
   ==
 Hits 70457045   
 Misses   46934693   
 Partials  182 182
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=footer).
 Last update 
[2913063...e29866a](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] Taki-Eddine commented on issue #9108: UI won't load

[GitBox]

Taki-Eddine commented on issue #9108: UI won't load
URL: 
https://github.com/apache/incubator-superset/issues/9108#issuecomment-584296185
 
 
   > what's the result of accessing superset through port 9000 ?
   
   I am unable to connect. Nothing is listening on 9000 I think.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #9109: [migration] metadata for dashboard filters

[GitBox]

codecov-io commented on issue #9109: [migration] metadata for dashboard filters
URL: 
https://github.com/apache/incubator-superset/pull/9109#issuecomment-584293503
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=h1)
 Report
   > Merging 
[#9109](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/4f06236bc4220de771465c10372b421e870ed3e8?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/9109/graphs/tree.svg?width=650=KsB0fHcx6l=150=pr)](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master   #9109   +/-   ##
   ==
 Coverage59.1%   59.1%   
   ==
 Files 372 372   
 Lines   11920   11920   
 Branches 29182917-1 
   ==
 Hits 70457045   
 Misses   46934693   
 Partials  182 182
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9109/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==)
 | | |
   | 
[.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/9109/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==)
 | | |
   | 
[...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9109/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=)
 | | |
   | 
[...assets/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9109/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0xpc3RWaWV3L1RhYmxlQ29sbGVjdGlvbi50c3g=)
 | | |
   | 
[superset/assets/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9109/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0VkaXRhYmxlVGl0bGUuanN4)
 | | |
   | 
[...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9109/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvVml6VHlwZUNvbnRyb2wuanN4)
 | | |
   | 
[...set/assets/src/dashboard/util/setPeriodicRunner.js](https://codecov.io/gh/apache/incubator-superset/pull/9109/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9zZXRQZXJpb2RpY1J1bm5lci5qcw==)
 | | |
   | 
[...t/assets/src/components/InfoTooltipWithTrigger.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9109/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0luZm9Ub29sdGlwV2l0aFRyaWdnZXIuanN4)
 | | |
   | 
[.../src/dashboard/components/UndoRedoKeylisteners.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9109/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9VbmRvUmVkb0tleWxpc3RlbmVycy5qc3g=)
 | | |
   | 
[...ts/src/explore/components/ExploreActionButtons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9109/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvRXhwbG9yZUFjdGlvbkJ1dHRvbnMuanN4)
 | | |
   | ... and [734 
more](https://codecov.io/gh/apache/incubator-superset/pull/9109/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=footer).
 Last update 
[4f06236...4af3163](https://codecov.io/gh/apache/incubator-superset/pull/9109?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] nytai edited a comment on issue #9101: [SIP-36] Proposal for standardizing use of TypeScript

[GitBox]

nytai edited a comment on issue #9101: [SIP-36] Proposal for standardizing use 
of TypeScript
URL: 
https://github.com/apache/incubator-superset/issues/9101#issuecomment-584289069
 
 
   While reason and elm are excellent languages to start new projects in and 
have a lot of benefits in terms of type safety I don't think it makes sense to 
introduce those technologies to superset (yet). Typescript is merely a superset 
of javascript, thus all javascript is valid typescript, the same cannot be said 
about elm or reason. Reason and elm are compiled languages with compiler checks 
and the code that's run in the browser can be quite different than the code 
written by the developer. From a strictly type safety perspective, you are 
correct those 2 languages provide much greater safety than typescript. However, 
introducing these technologies would mean a significantly change in the 
developer experience and workflow. At this point it's not reasonable to propose 
porting the existing codebase to reason or elm, nor does it seem reasonable to 
support 2 distinct developer experiences for the same code. 
   
   >Well, both Reason and Elm are used by much larger amounts of people, so 
that argument does not apply to them.
   
   I'm not sure this is accurate, the number of developers writing typescript 
exceeds the number of developers writing reason and elm by orders of magnitude. 
The stack [overflow developer 
survey](https://insights.stackoverflow.com/survey/2019#most-popular-technologies)
 does not even include those languages in their rankings. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] nytai commented on issue #9101: [SIP-36] Proposal for standardizing use of TypeScript

[GitBox]

nytai commented on issue #9101: [SIP-36] Proposal for standardizing use of 
TypeScript
URL: 
https://github.com/apache/incubator-superset/issues/9101#issuecomment-584289069
 
 
   While reason and elm are excellent languages to start new projects in and 
have a lot of benefits in terms of type safety I don't think it makes sense to 
introduce those technologies to superset (yet). Typescript is merely a superset 
of javascript, thus all javascript is valid typescript, the same cannot be said 
about elm or reason. Reason and elm are compiled languages with compiler checks 
and the code that's run in the browser can be quite different than the code 
written by the developer. From a strictly type safety perspective, you are 
correct those 2 languages provide much greater safety than typescript. However, 
introducing these technologies would mean a significantly change in the 
developer experience and workflow. At this point it's not reasonable to propose 
porting the existing codebase to reason or elm, nor does it seem reasonable to 
support 2 distinct developer experiences for the same code. 
   
   >Well, both Reason and Elm are used by much larger amounts of people, so 
that argument does not apply to them.
   
   I'm not sure this is accurate, the number of developers writing typescript 
exceeds the number of developers writing reason and elm by orders of magnitude. 
The stack (overflow developer 
survey)[https://insights.stackoverflow.com/survey/2019#most-popular-technologies]
 does not even include those languages in their rankings. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] IndexOutOfRange commented on issue #9108: UI won't load

[GitBox]

IndexOutOfRange commented on issue #9108: UI won't load
URL: 
https://github.com/apache/incubator-superset/issues/9108#issuecomment-584287636
 
 
   what's the result of accessing superset through port 9000 ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #9109: [migration] metadata for dashboard filters

[GitBox]

graceguo-supercat opened a new pull request #9109: [migration] metadata for 
dashboard filters
URL: https://github.com/apache/incubator-superset/pull/9109
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Migrate `filter_immune_slices` and `filter_immune_filter_fields` since we 
enabled dashboard scoped filter metadata `filter_scopes`.
   
   
   ### TEST PLAN
   We will not copy old `filter_immune_slices` and 
`filter_immune_filter_fields` metadata. If upgrade failed, users will lost 
filter immune settings in their dashboard. When system admin upgrade, please 
backup `dashboards` table.
   
   ### ADDITIONAL INFORMATION
   
   
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [x] Requires DB Migration.
   - [x] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] Taki-Eddine commented on issue #9108: UI won't load

[GitBox]

Taki-Eddine commented on issue #9108: UI won't load
URL: 
https://github.com/apache/incubator-superset/issues/9108#issuecomment-584284849
 
 
   > Hello, what is the url address you are accessing in your browser ? looks 
like you are trying to connect to the flask server directly and not the node 
one.
   
   @IndexOutOfRange  I am accessing it using localhost:8088 as specified in the 
doc. I am being prompted a login page then when I enter creds (admin:admin) I 
get the page I showed in the screenshot. I believe that `superset-node_1` was 
not able to load the UI.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] IndexOutOfRange commented on issue #9108: UI won't load

[GitBox]

IndexOutOfRange commented on issue #9108: UI won't load
URL: 
https://github.com/apache/incubator-superset/issues/9108#issuecomment-584263917
 
 
   Hello, what is the url address you are accessing in your browser ? looks 
like you are trying to connect to the flask server directly and not the node 
one.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] willbarrett commented on a change in pull request #9107: feat: add rolling window support to 'Big Number with Trendline' viz

[GitBox]

willbarrett commented on a change in pull request #9107: feat: add rolling 
window support to 'Big Number with Trendline' viz
URL: 
https://github.com/apache/incubator-superset/pull/9107#discussion_r377215997
 
 

 ##
 File path: tests/viz_tests.py
 ##
 @@ -1163,3 +1163,26 @@ def test_process_data_resample(self):
 .tolist(),
 [1.0, 2.0, np.nan, np.nan, 5.0, np.nan, 7.0],
 )
+
+def test_apply_roling(self):
 
 Review comment:
   Nit: 2 `l`s in `rolling`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] willbarrett commented on a change in pull request #9107: feat: add rolling window support to 'Big Number with Trendline' viz

[GitBox]

willbarrett commented on a change in pull request #9107: feat: add rolling 
window support to 'Big Number with Trendline' viz
URL: 
https://github.com/apache/incubator-superset/pull/9107#discussion_r377218500
 
 

 ##
 File path: tests/viz_tests.py
 ##
 @@ -1163,3 +1163,26 @@ def test_process_data_resample(self):
 .tolist(),
 [1.0, 2.0, np.nan, np.nan, 5.0, np.nan, 7.0],
 )
+
+def test_apply_roling(self):
+datasource = self.get_datasource_mock()
+df = pd.DataFrame(
+index=pd.to_datetime(
+["2019-01-01", "2019-01-02", "2019-01-05", "2019-01-07"]
+),
+data={"y": [1.0, 1.0, 1.0, 1.0]},
+)
+self.assertEqual(
+viz.BigNumberViz(
+datasource,
+{
+"metrics": ["y"],
+"rolling_type": "cumsum",
 
 Review comment:
   It would be good to test the other `rolling_type` values - this is only 
testing one branch of a nested `if` statement.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] metaperl edited a comment on issue #9101: [SIP-36] Proposal for standardizing use of TypeScript

[GitBox]

metaperl edited a comment on issue #9101: [SIP-36] Proposal for standardizing 
use of TypeScript
URL: 
https://github.com/apache/incubator-superset/issues/9101#issuecomment-584239747
 
 
   Given that [superset-ui is already 100% 
javascript](https://github.com/apache/incubator-superset/issues/9101#issuecomment-583637502),
 it appears this SIP is more about "standardizing" (enforcing type features of) 
the use of Typescript than deciding on something that meets the objectives 
stated in the overview.
   
   I.e, the overview stated:
   > We've seen significant improvements in code quality and a decrease in bugs 
by requiring Python type hints, and therefore propose to enforce a similar 
requirement for TypeScript. 
   
   And so it seems that there is a desire for type-safety. And it appears that 
such type-safety is [optional in 
Typescript](https://www.typescriptlang.org/docs/handbook/typescript-in-5-minutes.html)
 as it is in Python.
   
   and the question arises why not use 
[Reason](https://2019.stateofjs.com/javascript-flavors/reason/) or  
[Elm](https://2019.stateofjs.com/javascript-flavors/elm/) so that the language 
itself enforces type-safety?
   
   Also, from the overview, I notice that Flow was rejected because:
   > it is only used by 35% of people 
(https://2019.stateofjs.com/javascript-flavors/other-tools/) compared to 
TypeScript with > 60% 
(https://2019.stateofjs.com/javascript-flavors/typescript/)
   
   Well, both Reason and Elm are used by much larger amounts of people, so that 
argument does not apply to them.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] metaperl commented on issue #9101: [SIP-36] Proposal for standardizing use of TypeScript

[GitBox]

metaperl commented on issue #9101: [SIP-36] Proposal for standardizing use of 
TypeScript
URL: 
https://github.com/apache/incubator-superset/issues/9101#issuecomment-584239747
 
 
   Given that [superset-ui is already 100% 
javascript](https://github.com/apache/incubator-superset/issues/9101#issuecomment-583637502),
 it appears this SIP is more about standardizing the use of Typescript than 
deciding on something that meets the objectives stated in the overview.
   
   I.e, the overview stated:
   > We've seen significant improvements in code quality and a decrease in bugs 
by requiring Python type hints, and therefore propose to enforce a similar 
requirement for TypeScript. 
   
   And so it seems that there is a desire for type-safety. And it appears that 
such type-safety is [optional in 
Typescript](https://www.typescriptlang.org/docs/handbook/typescript-in-5-minutes.html)
 as it is in Python.
   
   and the question arises why not use 
[Reason](https://2019.stateofjs.com/javascript-flavors/reason/) or  
[Elm](https://2019.stateofjs.com/javascript-flavors/elm/) so that the language 
itself enforces type-safety?
   
   Also, from the overview, I notice that Flow was rejected because:
   > it is only used by 35% of people 
(https://2019.stateofjs.com/javascript-flavors/other-tools/) compared to 
TypeScript with > 60% 
(https://2019.stateofjs.com/javascript-flavors/typescript/)
   
   Well, both Reason and Elm are used by much larger amounts of people, so that 
argument does not apply to them.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] Taki-Eddine opened a new issue #9108: UI won't load

[GitBox]

Taki-Eddine opened a new issue #9108: UI won't load
URL: https://github.com/apache/incubator-superset/issues/9108
 
 
   I am using the docker image to use Apache superset, I followed the 
instructions.
   I cloned the git repository then a docker-compose up

   
   ### Expected results
   
   The UI to load
   
   ### Actual results
   
   The UI won't load, here is a screenshot
   ![Screenshot from 2020-02-10 
17-32-07](https://user-images.githubusercontent.com/20522687/74169284-5c0ecd00-4c2b-11ea-997c-8e13d9b4996b.png)
   
   
   
   
   
   
    How to reproduce the bug
   I followed the instructions to use the docker image.
   
   
   ### Checklist
   
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [* ] I have checked the superset logs for python stacktraces and included 
it here as text if there are any.
   - [ *] I have reproduced the issue with at least the latest released version 
of superset.
   - [* ] I have checked the issue tracker for the same issue and I haven't 
found one similar.
   
   ### Additional context
   
   the docker logs show that incubator-superset_superset-node_1 fails to cd 
into /app/superset-frontend/, I am getting the following error message:
   `superset-node_1| bash: line 0: cd: /app/superset-frontend/: No such 
file or directory`
   
   The problematic instruction lies in the docker-compose.yml file; line 69:
   
   `command: ["bash", "-c", "ls /app/ && cd /app/superset-frontend/ && npm 
install && npm run dev"]
   `
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] mistercrunch opened a new pull request #9107: feat: add rolling window support to 'Big Number with Trendline' viz

[GitBox]

mistercrunch opened a new pull request #9107: feat: add rolling window support 
to 'Big Number with Trendline' viz
URL: https://github.com/apache/incubator-superset/pull/9107
 
 
   ### CATEGORY
   
   ### SUMMARY
   Add support for rolling windows to the 'Big Number with Trendline' viz.
   
   - refactoring out `apply_rolling`
   - add unit test
   - some minor label changes
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   https://user-images.githubusercontent.com/487433/74168504-b6357100-4bde-11ea-9254-5f8707e2cb36.png;>
   
   
   ### TEST PLAN
   Added a unit test
   
   
   ### REVIEWERS
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] dpgaspar commented on issue #9105: I can not start superset

[GitBox]

dpgaspar commented on issue #9105: I can not start superset
URL: 
https://github.com/apache/incubator-superset/issues/9105#issuecomment-584205706
 
 
   Superset is just a flask app, you can read: 
https://flask.palletsprojects.com/en/1.1.x/deploying/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] semihmasat commented on issue #8832: Step 1/32 : ARG PY_VER=3.6.9 ERROR: Service 'superset' failed to build: Please provide a source image with `from` prior to commit

[GitBox]

semihmasat commented on issue #8832: Step 1/32 : ARG PY_VER=3.6.9 ERROR: 
Service 'superset' failed to build: Please provide a source image with `from` 
prior to commit
URL: 
https://github.com/apache/incubator-superset/issues/8832#issuecomment-584189410
 
 
   Oh. My bad. it looks like Centos, yum doesn't automaticaly updates docker. 
updated it, added docker to a usergroup and it fixed the problem. 
   
   thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #9034: [table] feat: REST API

[GitBox]

codecov-io commented on issue #9034: [table] feat: REST API
URL: 
https://github.com/apache/incubator-superset/pull/9034#issuecomment-584172248
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9034?src=pr=h1)
 Report
   > Merging 
[#9034](https://codecov.io/gh/apache/incubator-superset/pull/9034?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/1867f06b4ba434daf5155e71cbe9dca1bf5dbe4e?src=pr=desc)
 will **decrease** coverage by `0.33%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/9034/graphs/tree.svg?width=650=KsB0fHcx6l=150=pr)](https://codecov.io/gh/apache/incubator-superset/pull/9034?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #9034  +/-   ##
   =
   - Coverage   59.43%   59.1%   -0.34% 
   =
 Files 369 372   +3 
 Lines   11743   11920 +177 
 Branches 28842917  +33 
   =
   + Hits 69807045  +65 
   - Misses   45844693 +109 
   - Partials  179 182   +3
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/9034?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9034/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==)
 | | |
   | 
[.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/9034/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==)
 | | |
   | 
[...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9034/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=)
 | | |
   | 
[superset/assets/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9034/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0VkaXRhYmxlVGl0bGUuanN4)
 | | |
   | 
[...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9034/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvVml6VHlwZUNvbnRyb2wuanN4)
 | | |
   | 
[...t/assets/src/components/InfoTooltipWithTrigger.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9034/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0luZm9Ub29sdGlwV2l0aFRyaWdnZXIuanN4)
 | | |
   | 
[.../src/dashboard/components/UndoRedoKeylisteners.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9034/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9VbmRvUmVkb0tleWxpc3RlbmVycy5qc3g=)
 | | |
   | 
[.../src/dashboard/components/FilterTooltipWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9034/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9GaWx0ZXJUb29sdGlwV3JhcHBlci5qc3g=)
 | | |
   | 
[...sets/src/dashboard/components/DashboardBuilder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9034/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9EYXNoYm9hcmRCdWlsZGVyLmpzeA==)
 | | |
   | 
[...ssets/src/dashboard/components/PublishedStatus.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9034/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9QdWJsaXNoZWRTdGF0dXMuanN4)
 | | |
   | ... and [709 
more](https://codecov.io/gh/apache/incubator-superset/pull/9034/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9034?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9034?src=pr=footer).
 Last update 
[1867f06...e737516](https://codecov.io/gh/apache/incubator-superset/pull/9034?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: 

[GitHub] [incubator-superset] craig-rueda commented on issue #8832: Step 1/32 : ARG PY_VER=3.6.9 ERROR: Service 'superset' failed to build: Please provide a source image with `from` prior to commit

[GitBox]

craig-rueda commented on issue #8832: Step 1/32 : ARG PY_VER=3.6.9 ERROR: 
Service 'superset' failed to build: Please provide a source image with `from` 
prior to commit
URL: 
https://github.com/apache/incubator-superset/issues/8832#issuecomment-584171945
 
 
   Looks like you need to update Docker. `1.13` doesn't support ARGs before 
`FROM` :(


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] semihmasat edited a comment on issue #8832: Step 1/32 : ARG PY_VER=3.6.9 ERROR: Service 'superset' failed to build: Please provide a source image with `from` prior to com

[GitBox]

semihmasat edited a comment on issue #8832: Step 1/32 : ARG PY_VER=3.6.9 ERROR: 
Service 'superset' failed to build: Please provide a source image with `from` 
prior to commit
URL: 
https://github.com/apache/incubator-superset/issues/8832#issuecomment-584146712
 
 
   Hello. I am having the same problem.
   
   both docker and docker-compose is on the latest version.
   
   Docker version 1.13.1, build 4ef4b30/1.13.1
   docker-compose version 1.25.3, build d4d1b42b
   
   `
   [-superset]$ docker-compose up
   Building superset
   Step 1/32 : ARG PY_VER=3.6.9
   ERROR: Service 'superset' failed to build: Please provide a source image 
with `from` prior to commit
   `
   
   > 
   > NAME="CentOS Linux"
   > VERSION="7 (Core)"
   > ID="centos"
   > ID_LIKE="rhel fedora"
   > VERSION_ID="7"
   > PRETTY_NAME="CentOS Linux 7 (Core)"
   > ANSI_COLOR="0;31"
   > CPE_NAME="cpe:/o:centos:centos:7"
   > HOME_URL="https://www.centos.org/;
   > BUG_REPORT_URL="https://bugs.centos.org/;
   > 
   > CENTOS_MANTISBT_PROJECT="CentOS-7"
   > CENTOS_MANTISBT_PROJECT_VERSION="7"
   > REDHAT_SUPPORT_PRODUCT="centos"
   > REDHAT_SUPPORT_PRODUCT_VERSION="7"
   
   
   I also have to version of python installed 
   $ python3
   Python 3.6.8 (default, Aug  7 2019, 17:28:10) 
   [GCC 4.8.5 20150623 (Red Hat 4.8.5-39)] on linux
   
   $ python
   Python 2.7.5 (default, Aug  7 2019, 00:51:29) 
   [GCC 4.8.5 20150623 (Red Hat 4.8.5-39)] on linux2
   
   PS: I tried to update python to 3.6.9 but it yum update doesn't work.
   I also tried to change 3.6.9 to 3.6.8 on Docfile but it also didn't worked.
   
   PS2 : I also tried creating alias for python3 as python. it also didn't 
worked.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] junwansas commented on issue #9105: I can not start superset

[GitBox]

junwansas commented on issue #9105: I can not start superset
URL: 
https://github.com/apache/incubator-superset/issues/9105#issuecomment-584158015
 
 
   It looks like working now but the -h has to be an ip address. Is it possible 
to run on a dns name? like servername.cox.com? I have the servername in our dns 
server. But I used that servername in -h option to start superset. It did not 
go through. Did I missing anything?
   
   Jun Wan
   Enterprise Data Services
   O 404.269.6804
   C 404.625.2056
   CTECHA.5. 112E
   6305 Peachtree Dunwoody Rd. Atlanta, GA 30328
   [signature_976828730]
   
   From: Daniel Vaz Gaspar 
   Sent: Monday, February 10, 2020 3:52 AM
   To: apache/incubator-superset 
   Cc: Wan, Jun (CCI-Atlanta) ; Author 

   Subject: [EXTERNAL] Re: [apache/incubator-superset] I can not start superset 
(#9105)
   
   
   Hi,
   
   127.0.0.1 is localhost so your server is listening on the loopback 
interface. Try:
   
   superset run -h 0.0.0.0 -p 8088 --with-threads --reload --debugger
   
   Note: that this way of running superset is for development, do not use it in 
production
   
   —
   You are receiving this because you authored the thread.
   Reply to this email directly, view it on 
GitHub,
 or 
unsubscribe.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] semihmasat edited a comment on issue #8832: Step 1/32 : ARG PY_VER=3.6.9 ERROR: Service 'superset' failed to build: Please provide a source image with `from` prior to com

[GitBox]

semihmasat edited a comment on issue #8832: Step 1/32 : ARG PY_VER=3.6.9 ERROR: 
Service 'superset' failed to build: Please provide a source image with `from` 
prior to commit
URL: 
https://github.com/apache/incubator-superset/issues/8832#issuecomment-584146712
 
 
   Hello. I am having the same problem.
   
   both docker and docker-compose is on the latest version.
   
   Docker version 1.13.1, build 4ef4b30/1.13.1
   docker-compose version 1.25.3, build d4d1b42b
   
   `
   [-superset]$ docker-compose up
   Building superset
   Step 1/32 : ARG PY_VER=3.6.9
   ERROR: Service 'superset' failed to build: Please provide a source image 
with `from` prior to commit
   `
   
   > 
   > NAME="CentOS Linux"
   > VERSION="7 (Core)"
   > ID="centos"
   > ID_LIKE="rhel fedora"
   > VERSION_ID="7"
   > PRETTY_NAME="CentOS Linux 7 (Core)"
   > ANSI_COLOR="0;31"
   > CPE_NAME="cpe:/o:centos:centos:7"
   > HOME_URL="https://www.centos.org/;
   > BUG_REPORT_URL="https://bugs.centos.org/;
   > 
   > CENTOS_MANTISBT_PROJECT="CentOS-7"
   > CENTOS_MANTISBT_PROJECT_VERSION="7"
   > REDHAT_SUPPORT_PRODUCT="centos"
   > REDHAT_SUPPORT_PRODUCT_VERSION="7"
   
   
   I also have to version of python installed 
   $ python3
   Python 3.6.8 (default, Aug  7 2019, 17:28:10) 
   [GCC 4.8.5 20150623 (Red Hat 4.8.5-39)] on linux
   
   $ python
   Python 2.7.5 (default, Aug  7 2019, 00:51:29) 
   [GCC 4.8.5 20150623 (Red Hat 4.8.5-39)] on linux2
   
   PS: I tried to update python to 3.6.9 but it yum update doesn't work.
   I also tried to change 3.6.9 to 3.6.8 on Docfile but it also didn't worked.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] semihmasat edited a comment on issue #8832: Step 1/32 : ARG PY_VER=3.6.9 ERROR: Service 'superset' failed to build: Please provide a source image with `from` prior to com

[GitBox]

semihmasat edited a comment on issue #8832: Step 1/32 : ARG PY_VER=3.6.9 ERROR: 
Service 'superset' failed to build: Please provide a source image with `from` 
prior to commit
URL: 
https://github.com/apache/incubator-superset/issues/8832#issuecomment-584146712
 
 
   Hello. I am having the same problem.
   
   both docker and docker-compose is on the latest version.
   
   Docker version 1.13.1, build 4ef4b30/1.13.1
   docker-compose version 1.25.3, build d4d1b42b
   
   `
   [-superset]$ docker-compose up
   Building superset
   Step 1/32 : ARG PY_VER=3.6.9
   ERROR: Service 'superset' failed to build: Please provide a source image 
with `from` prior to commit
   `
   
   > 
   > NAME="CentOS Linux"
   > VERSION="7 (Core)"
   > ID="centos"
   > ID_LIKE="rhel fedora"
   > VERSION_ID="7"
   > PRETTY_NAME="CentOS Linux 7 (Core)"
   > ANSI_COLOR="0;31"
   > CPE_NAME="cpe:/o:centos:centos:7"
   > HOME_URL="https://www.centos.org/;
   > BUG_REPORT_URL="https://bugs.centos.org/;
   > 
   > CENTOS_MANTISBT_PROJECT="CentOS-7"
   > CENTOS_MANTISBT_PROJECT_VERSION="7"
   > REDHAT_SUPPORT_PRODUCT="centos"
   > REDHAT_SUPPORT_PRODUCT_VERSION="7"
   
   
   I also have to version of python installed 
   $ python3
   Python 3.6.8 (default, Aug  7 2019, 17:28:10) 
   [GCC 4.8.5 20150623 (Red Hat 4.8.5-39)] on linux
   
   $ python
   Python 2.7.5 (default, Aug  7 2019, 00:51:29) 
   [GCC 4.8.5 20150623 (Red Hat 4.8.5-39)] on linux2


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] semihmasat edited a comment on issue #8832: Step 1/32 : ARG PY_VER=3.6.9 ERROR: Service 'superset' failed to build: Please provide a source image with `from` prior to com

[GitBox]

semihmasat edited a comment on issue #8832: Step 1/32 : ARG PY_VER=3.6.9 ERROR: 
Service 'superset' failed to build: Please provide a source image with `from` 
prior to commit
URL: 
https://github.com/apache/incubator-superset/issues/8832#issuecomment-584146712
 
 
   Hello. I am having the same problem.
   
   both docker and docker-compose is on the latest version.
   
   Docker version 1.13.1, build 4ef4b30/1.13.1
   docker-compose version 1.25.3, build d4d1b42b
   
   `
   [-superset]$ docker-compose up
   Building superset
   Step 1/32 : ARG PY_VER=3.6.9
   ERROR: Service 'superset' failed to build: Please provide a source image 
with `from` prior to commit
   `
   
   > 
   > NAME="CentOS Linux"
   > VERSION="7 (Core)"
   > ID="centos"
   > ID_LIKE="rhel fedora"
   > VERSION_ID="7"
   > PRETTY_NAME="CentOS Linux 7 (Core)"
   > ANSI_COLOR="0;31"
   > CPE_NAME="cpe:/o:centos:centos:7"
   > HOME_URL="https://www.centos.org/;
   > BUG_REPORT_URL="https://bugs.centos.org/;
   > 
   > CENTOS_MANTISBT_PROJECT="CentOS-7"
   > CENTOS_MANTISBT_PROJECT_VERSION="7"
   > REDHAT_SUPPORT_PRODUCT="centos"
   > REDHAT_SUPPORT_PRODUCT_VERSION="7"


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] semihmasat edited a comment on issue #8832: Step 1/32 : ARG PY_VER=3.6.9 ERROR: Service 'superset' failed to build: Please provide a source image with `from` prior to com

[GitBox]

semihmasat edited a comment on issue #8832: Step 1/32 : ARG PY_VER=3.6.9 ERROR: 
Service 'superset' failed to build: Please provide a source image with `from` 
prior to commit
URL: 
https://github.com/apache/incubator-superset/issues/8832#issuecomment-584146712
 
 
   Hello. I am having the same problem.
   
   both docker and docker-compose is on the latest version.
   
   Docker version 1.13.1, build 4ef4b30/1.13.1
   docker-compose version 1.25.3, build d4d1b42b
   
   `
   [-superset]$ docker-compose up
   Building superset
   Step 1/32 : ARG PY_VER=3.6.9
   ERROR: Service 'superset' failed to build: Please provide a source image 
with `from` prior to commit
   `
   
   `NAME="CentOS Linux"
   VERSION="7 (Core)"
   ID="centos"
   ID_LIKE="rhel fedora"
   VERSION_ID="7"
   PRETTY_NAME="CentOS Linux 7 (Core)"
   ANSI_COLOR="0;31"
   CPE_NAME="cpe:/o:centos:centos:7"
   HOME_URL="https://www.centos.org/;
   BUG_REPORT_URL="https://bugs.centos.org/;
   
   CENTOS_MANTISBT_PROJECT="CentOS-7"
   CENTOS_MANTISBT_PROJECT_VERSION="7"
   REDHAT_SUPPORT_PRODUCT="centos"
   REDHAT_SUPPORT_PRODUCT_VERSION="7"`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] semihmasat edited a comment on issue #8832: Step 1/32 : ARG PY_VER=3.6.9 ERROR: Service 'superset' failed to build: Please provide a source image with `from` prior to com

[GitBox]

semihmasat edited a comment on issue #8832: Step 1/32 : ARG PY_VER=3.6.9 ERROR: 
Service 'superset' failed to build: Please provide a source image with `from` 
prior to commit
URL: 
https://github.com/apache/incubator-superset/issues/8832#issuecomment-584146712
 
 
   Hello. I am having the same problem.
   
   both docker and docker-compose is on the latest version.
   
   Docker version 1.13.1, build 4ef4b30/1.13.1
   docker-compose version 1.25.3, build d4d1b42b
   
   `
   [-superset]$ docker-compose up
   Building superset
   Step 1/32 : ARG PY_VER=3.6.9
   ERROR: Service 'superset' failed to build: Please provide a source image 
with `from` prior to commit
   `
   
   `
   NAME="CentOS Linux"
   VERSION="7 (Core)"
   ID="centos"
   ID_LIKE="rhel fedora"
   VERSION_ID="7"
   PRETTY_NAME="CentOS Linux 7 (Core)"
   ANSI_COLOR="0;31"
   CPE_NAME="cpe:/o:centos:centos:7"
   HOME_URL="https://www.centos.org/;
   BUG_REPORT_URL="https://bugs.centos.org/;
   
   CENTOS_MANTISBT_PROJECT="CentOS-7"
   CENTOS_MANTISBT_PROJECT_VERSION="7"
   REDHAT_SUPPORT_PRODUCT="centos"
   REDHAT_SUPPORT_PRODUCT_VERSION="7"
   `


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] semihmasat commented on issue #8832: Step 1/32 : ARG PY_VER=3.6.9 ERROR: Service 'superset' failed to build: Please provide a source image with `from` prior to commit

[GitBox]

semihmasat commented on issue #8832: Step 1/32 : ARG PY_VER=3.6.9 ERROR: 
Service 'superset' failed to build: Please provide a source image with `from` 
prior to commit
URL: 
https://github.com/apache/incubator-superset/issues/8832#issuecomment-584146712
 
 
   Hello. I am having the same problem.
   
   both docker and docker-compose is on the latest version.
   
   Docker version 1.13.1, build 4ef4b30/1.13.1
   docker-compose version 1.25.3, build d4d1b42b
   
   `
   [-superset]$ docker-compose up
   Building superset
   Step 1/32 : ARG PY_VER=3.6.9
   ERROR: Service 'superset' failed to build: Please provide a source image 
with `from` prior to commit
   [-superset]$ 
   `
   
   `NAME="CentOS Linux"
   VERSION="7 (Core)"
   ID="centos"
   ID_LIKE="rhel fedora"
   VERSION_ID="7"
   PRETTY_NAME="CentOS Linux 7 (Core)"
   ANSI_COLOR="0;31"
   CPE_NAME="cpe:/o:centos:centos:7"
   HOME_URL="https://www.centos.org/;
   BUG_REPORT_URL="https://bugs.centos.org/;
   
   CENTOS_MANTISBT_PROJECT="CentOS-7"
   CENTOS_MANTISBT_PROJECT_VERSION="7"
   REDHAT_SUPPORT_PRODUCT="centos"
   REDHAT_SUPPORT_PRODUCT_VERSION="7"`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] junwansas commented on issue #9105: I can not start superset

[GitBox]

junwansas commented on issue #9105: I can not start superset
URL: 
https://github.com/apache/incubator-superset/issues/9105#issuecomment-584143013
 
 
   Any instruction on production? That will be my next step if I can fix this 
problem.
   
   Thank you!
   
   Jun Wan
   Enterprise Data Services
   O 404.269.6804
   C 404.625.2056
   CTECHA.5. 112E
   6305 Peachtree Dunwoody Rd. Atlanta, GA 30328
   [signature_976828730]
   
   From: Daniel Vaz Gaspar 
   Sent: Monday, February 10, 2020 3:52 AM
   To: apache/incubator-superset 
   Cc: Wan, Jun (CCI-Atlanta) ; Author 

   Subject: [EXTERNAL] Re: [apache/incubator-superset] I can not start superset 
(#9105)
   
   
   Hi,
   
   127.0.0.1 is localhost so your server is listening on the loopback 
interface. Try:
   
   superset run -h 0.0.0.0 -p 8088 --with-threads --reload --debugger
   
   Note: that this way of running superset is for development, do not use it in 
production
   
   —
   You are receiving this because you authored the thread.
   Reply to this email directly, view it on 
GitHub,
 or 
unsubscribe.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] augier commented on issue #8932: Superset to use both Local authentication plus OAuth authentication

[GitBox]

augier commented on issue #8932: Superset to use both Local authentication plus 
OAuth authentication 
URL: 
https://github.com/apache/incubator-superset/issues/8932#issuecomment-584139963
 
 
   Also wondering the same. I'd like to be able to use OAUTH as primary 
mechanism but to also enable basic auth for some special users.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] villebro closed pull request #9033: feat: Add schema to function retrieval and implement for Snowflake

[GitBox]

villebro closed pull request #9033: feat: Add schema to function retrieval and 
implement for Snowflake
URL: https://github.com/apache/incubator-superset/pull/9033
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] villebro commented on issue #9033: feat: Add schema to function retrieval and implement for Snowflake

[GitBox]

villebro commented on issue #9033: feat: Add schema to function retrieval and 
implement for Snowflake
URL: 
https://github.com/apache/incubator-superset/pull/9033#issuecomment-584134159
 
 
   After reviewing this after a short break it feels the added complexity is 
difficult to justify given the very limited utility of schema specific UDFs. 
Closing this for now, will revive this at a later date if the need resurfaces.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] stale[bot] commented on issue #8808: superset db upgrade returns foreign key constraint is incorrectly formed

[GitBox]

stale[bot] commented on issue #8808: superset db upgrade returns foreign key 
constraint is incorrectly formed
URL: 
https://github.com/apache/incubator-superset/issues/8808#issuecomment-584117172
 
 
   This issue has been automatically marked as stale because it has not had 
recent activity. It will be closed if no further activity occurs. Thank you for 
your contributions. For admin, please label this issue `.pinned` to prevent 
stale bot from closing the issue.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] stale[bot] commented on issue #8822: [Question] Using the charts that are generated by superset in another web app

[GitBox]

stale[bot] commented on issue #8822: [Question] Using the charts that are 
generated by superset in another web app
URL: 
https://github.com/apache/incubator-superset/issues/8822#issuecomment-584117188
 
 
   This issue has been automatically marked as stale because it has not had 
recent activity. It will be closed if no further activity occurs. Thank you for 
your contributions. For admin, please label this issue `.pinned` to prevent 
stale bot from closing the issue.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] villebro commented on a change in pull request #9054: [database] new, select star API migration

[GitBox]

villebro commented on a change in pull request #9054: [database] new, select 
star API migration
URL: 
https://github.com/apache/incubator-superset/pull/9054#discussion_r377009499
 
 

 ##
 File path: superset/views/database/decorators.py
 ##
 @@ -0,0 +1,58 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+import functools
+
+from flask import g
+from flask_babel import lazy_gettext as _
+
+from superset.models.core import Database
+from superset.utils.core import parse_js_uri_path_item
+
+
+def check_datasource_access(f):
+"""
+A Decorator that checks if a user has datasource access
+"""
+
+def wraps(
+self, pk: int, table_name: str, schema_name: str = None
+):  # pylint: disable=invalid-name
+schema_name_parsed = parse_js_uri_path_item(schema_name, 
eval_undefined=True)
+table_name_parsed = parse_js_uri_path_item(table_name)
+if not table_name_parsed:
+return self.response_422(message=_("Table name could not be 
parsed"))
 
 Review comment:
   In practice `table_name_parsed` will only be falsy if the original 
`table_name` is `None`. So a more appropriate error message would perhaps be 
"Table name undefined" or similar.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] stale[bot] closed issue #8502: The time-thermal map shows the problem

[GitBox]

stale[bot] closed issue #8502: The time-thermal map shows the problem
URL: https://github.com/apache/incubator-superset/issues/8502
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] stale[bot] commented on issue #8811: Connection failed/refused when connecting to local PostgreSQL Database

[GitBox]

stale[bot] commented on issue #8811: Connection failed/refused when connecting 
to local PostgreSQL Database
URL: 
https://github.com/apache/incubator-superset/issues/8811#issuecomment-584050407
 
 
   This issue has been automatically marked as stale because it has not had 
recent activity. It will be closed if no further activity occurs. Thank you for 
your contributions. For admin, please label this issue `.pinned` to prevent 
stale bot from closing the issue.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] dpgaspar commented on issue #9104: Connecting to Elsaticsearch

[GitBox]

dpgaspar commented on issue #9104: Connecting to Elsaticsearch
URL: 
https://github.com/apache/incubator-superset/issues/9104#issuecomment-584019749
 
 
   Hi,
   
   Please post the output from:
   `curl -u username:password http://localhost:9200/_cat/indices`
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] [incubator-superset] dpgaspar commented on issue #9105: I can not start superset

[GitBox]

dpgaspar commented on issue #9105: I can not start superset
URL: 
https://github.com/apache/incubator-superset/issues/9105#issuecomment-584017086
 
 
   Hi,
   
   127.0.0.1 is localhost so your server is listening on the loopback 
interface. Try:
   
   `superset run -h 0.0.0.0 -p 8088 --with-threads --reload --debugger`
   
   Note: that this way of running superset is for development, do not use it in 
production
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org