[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8058: Add docstrings and typing to db_engine_specs and sql_parse

etr2460 commented on a change in pull request #8058: Add docstrings and typing to db_engine_specs and sql_parse URL: https://github.com/apache/incubator-superset/pull/8058#discussion_r316451455 ## File path: superset/db_engine_specs/base.py ## @@ -454,75 +634,93 @@ def

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8058: Add docstrings and typing to db_engine_specs and sql_parse

etr2460 commented on a change in pull request #8058: Add docstrings and typing to db_engine_specs and sql_parse URL: https://github.com/apache/incubator-superset/pull/8058#discussion_r316451230 ## File path: superset/db_engine_specs/base.py ## @@ -386,37 +499,90 @@ def

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8058: Add docstrings and typing to db_engine_specs and sql_parse

etr2460 commented on a change in pull request #8058: Add docstrings and typing to db_engine_specs and sql_parse URL: https://github.com/apache/incubator-superset/pull/8058#discussion_r316452736 ## File path: superset/db_engine_specs/presto.py ## @@ -944,30 +955,31 @@ def

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8058: Add docstrings and typing to db_engine_specs and sql_parse

etr2460 commented on a change in pull request #8058: Add docstrings and typing to db_engine_specs and sql_parse URL: https://github.com/apache/incubator-superset/pull/8058#discussion_r315417347 ## File path: superset/db_engine_specs/presto.py ## @@ -944,22 +955,22 @@ def