[GitHub] [zookeeper] arshadmohammad commented on a change in pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable

2019-09-05 Thread GitBox
arshadmohammad commented on a change in pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable URL: https://github.com/apache/zookeeper/pull/1080#discussion_r321253539 ## File path:

[GitHub] [zookeeper] arshadmohammad commented on a change in pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable

2019-09-05 Thread GitBox
arshadmohammad commented on a change in pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable URL: https://github.com/apache/zookeeper/pull/1080#discussion_r321253539 ## File path:

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable

2019-09-05 Thread GitBox
eolivelli commented on a change in pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable URL: https://github.com/apache/zookeeper/pull/1080#discussion_r321356483 ## File path:

[GitHub] [zookeeper] eolivelli commented on issue #1070: ZOOKEEPER-3528: Revisit AsyncCallback javadoc

2019-09-05 Thread GitBox
eolivelli commented on issue #1070: ZOOKEEPER-3528: Revisit AsyncCallback javadoc URL: https://github.com/apache/zookeeper/pull/1070#issuecomment-528482400 I will merge as soon as possible. If you have a chance today @hanm please go

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable

2019-09-05 Thread GitBox
eolivelli commented on a change in pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable URL: https://github.com/apache/zookeeper/pull/1080#discussion_r321357155 ## File path:

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable

2019-09-05 Thread GitBox
eolivelli commented on a change in pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable URL: https://github.com/apache/zookeeper/pull/1080#discussion_r321357025 ## File path:

[GitHub] [zookeeper] TisonKun commented on issue #1070: ZOOKEEPER-3528: Revisit AsyncCallback javadoc

2019-09-05 Thread GitBox
TisonKun commented on issue #1070: ZOOKEEPER-3528: Revisit AsyncCallback javadoc URL: https://github.com/apache/zookeeper/pull/1070#issuecomment-528469446 @eolivelli @hanm could you help finish the final job this thread? This

[GitHub] [zookeeper] asfgit closed pull request #1037: ZOOKEEPER-3492: Add weights to server side connection throttling

2019-09-05 Thread GitBox
asfgit closed pull request #1037: ZOOKEEPER-3492: Add weights to server side connection throttling URL: https://github.com/apache/zookeeper/pull/1037 This is an automated message from the Apache Git Service. To respond to

[GitHub] [zookeeper] TisonKun commented on issue #1070: ZOOKEEPER-3528: Revisit AsyncCallback javadoc

2019-09-05 Thread GitBox
TisonKun commented on issue #1070: ZOOKEEPER-3528: Revisit AsyncCallback javadoc URL: https://github.com/apache/zookeeper/pull/1070#issuecomment-528608358 thanks for your help! This is an automated message from the Apache Git

[GitHub] [zookeeper] hanm commented on issue #1042: ZOOKEEPER-3484: Improve the throughput by optimizing the synchronizat…

2019-09-05 Thread GitBox
hanm commented on issue #1042: ZOOKEEPER-3484: Improve the throughput by optimizing the synchronizat… URL: https://github.com/apache/zookeeper/pull/1042#issuecomment-528583459 looks good. need a rebase to resolve conflicts. @yisong-yue

[GitHub] [zookeeper] hanm commented on issue #1051: ZOOKEEPER-3503: Add server side large request throttling

2019-09-05 Thread GitBox
hanm commented on issue #1051: ZOOKEEPER-3503: Add server side large request throttling URL: https://github.com/apache/zookeeper/pull/1051#issuecomment-528582862 this is ready to land. just needs a rebase to resolve the documentation conflict. @jhuan31

[GitHub] [zookeeper] asfgit closed pull request #1076: ZOOKEEPER 3522: Reword Zookeeper consistency doc for clarity

2019-09-05 Thread GitBox
asfgit closed pull request #1076: ZOOKEEPER 3522: Reword Zookeeper consistency doc for clarity URL: https://github.com/apache/zookeeper/pull/1076 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] asfgit closed pull request #1070: ZOOKEEPER-3528: Revisit AsyncCallback javadoc

2019-09-05 Thread GitBox
asfgit closed pull request #1070: ZOOKEEPER-3528: Revisit AsyncCallback javadoc URL: https://github.com/apache/zookeeper/pull/1070 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [zookeeper] hanm commented on issue #1070: ZOOKEEPER-3528: Revisit AsyncCallback javadoc

2019-09-05 Thread GitBox
hanm commented on issue #1070: ZOOKEEPER-3528: Revisit AsyncCallback javadoc URL: https://github.com/apache/zookeeper/pull/1070#issuecomment-528579572 @eolivelli merged https://github.com/apache/zookeeper/commit/47385c75e0e0d0a48e71122df989effd55f0fe59

[GitHub] [zookeeper] hanm commented on a change in pull request #1034: ZOOKEEPER-3491 Specify commitLogCount value using a system property

2019-09-05 Thread GitBox
hanm commented on a change in pull request #1034: ZOOKEEPER-3491 Specify commitLogCount value using a system property URL: https://github.com/apache/zookeeper/pull/1034#discussion_r321496783 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZKDatabase.java

[GitHub] [zookeeper] hanm commented on issue #1034: ZOOKEEPER-3491 Specify commitLogCount value using a system property

2019-09-05 Thread GitBox
hanm commented on issue #1034: ZOOKEEPER-3491 Specify commitLogCount value using a system property URL: https://github.com/apache/zookeeper/pull/1034#issuecomment-528602238 looks good. please fix the check style violation (see

[GitHub] [zookeeper] eolivelli commented on issue #1075: ZOOKEEPER-3532 Provide a docker-based environment to work on a known OS

2019-09-05 Thread GitBox
eolivelli commented on issue #1075: ZOOKEEPER-3532 Provide a docker-based environment to work on a known OS URL: https://github.com/apache/zookeeper/pull/1075#issuecomment-528708737 I saw Patrick's work, it is awesome. My final take is that it is better to merge this patch, it is a

[GitHub] [zookeeper] sonymoon commented on a change in pull request #1034: ZOOKEEPER-3491 Specify commitLogCount value using a system property

2019-09-05 Thread GitBox
sonymoon commented on a change in pull request #1034: ZOOKEEPER-3491 Specify commitLogCount value using a system property URL: https://github.com/apache/zookeeper/pull/1034#discussion_r321580644 ## File path:

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable

2019-09-05 Thread GitBox
eolivelli commented on a change in pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable URL: https://github.com/apache/zookeeper/pull/1080#discussion_r321176409 ## File path:

[GitHub] [zookeeper] arshadmohammad opened a new pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable

2019-09-05 Thread GitBox
arshadmohammad opened a new pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable URL: https://github.com/apache/zookeeper/pull/1080 This is an automated message from

[GitHub] [zookeeper] symat edited a comment on issue #1078: ZOOKEEPER-3436 Enhance Mavenized Make C client

2019-09-05 Thread GitBox
symat edited a comment on issue #1078: ZOOKEEPER-3436 Enhance Mavenized Make C client URL: https://github.com/apache/zookeeper/pull/1078#issuecomment-528232115 > I have built the package on linux, the "cli_st" and "cli_mt" file lack permission of execution nice catch, I haven't

[GitHub] [zookeeper] symat commented on issue #1078: ZOOKEEPER-3436 Enhance Mavenized Make C client

2019-09-05 Thread GitBox
symat commented on issue #1078: ZOOKEEPER-3436 Enhance Mavenized Make C client URL: https://github.com/apache/zookeeper/pull/1078#issuecomment-528232115 > I have built the package on linux, the "cli_st" and "cli_mt" file lack permission of execution nice catch, I haven't checked that :)