Build failed in Jenkins: zookeeper-master-maven-jdk12 #517

See Changes: [nkalmar] ZOOKEEPER-3792: fix apidocs path -- [...truncated 206.87 KB...] [exec] libtool: link: echo "{ global:" > .libs/libzookeeper_mt.ver

[GitHub] [zookeeper] symat commented on pull request #1356: ZOOKEEPER-3829: backward compatibility fix for rolling restart without dynamic reconfig

symat commented on pull request #1356: URL: https://github.com/apache/zookeeper/pull/1356#issuecomment-632032896 @lvfangmin, @fpj - I think you also might have more background knowledge around the dynamic-reconfig. Can you please take a look on this PR?

Jenkins build is still unstable: zookeeper-master-maven-jdk14 #104

See

[GitHub] [zookeeper] nkalmar commented on pull request #1362: ZOOKEEPER-3792 - fix apidocs path

nkalmar commented on pull request #1362: URL: https://github.com/apache/zookeeper/pull/1362#issuecomment-631979901 Thanks @symat , since this is a trivial website fix I'll commit it. This is an automated message from the

Build failed in Jenkins: zookeeper-branch36-java11 #188

See Changes: [nkalmar] ZOOKEEPER-3792: fix apidocs path -- [...truncated 104.58 KB...] [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:

Build failed in Jenkins: zookeeper-master-maven-jdk13 #213

See Changes: [nkalmar] ZOOKEEPER-3792: fix apidocs path -- [...truncated 65.11 KB...] [INFO] Running org.apache.zookeeper.test.EventTypeTest [INFO] Tests run:

Jenkins build is unstable: zookeeper-master-maven-jdk14 #103

See

Jenkins build is back to normal : PreCommit-ZOOKEEPER-github-pr-build-maven #2066

See

[GitHub] [zookeeper] asfgit closed pull request #1362: ZOOKEEPER-3792 - fix apidocs path

asfgit closed pull request #1362: URL: https://github.com/apache/zookeeper/pull/1362 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [zookeeper] nkalmar commented on pull request #1362: ZOOKEEPER-3792 - fix apidocs path

nkalmar commented on pull request #1362: URL: https://github.com/apache/zookeeper/pull/1362#issuecomment-631983694 Committed to master, 3.6 and 3.5 (all active maven branch), I will fix up any previously generated link on the website repo.

Jenkins build is back to normal : zookeeper-master-maven-jdk-ea #7

See

[GitHub] [zookeeper] anmolnar commented on pull request #1353: ZOOKEEPER-3832 ZKHostnameVerifier rejects valid certificates with subjectAltNames

anmolnar commented on pull request #1353: URL: https://github.com/apache/zookeeper/pull/1353#issuecomment-632019076 retest maven build This is an automated message from the Apache Git Service. To respond to the message,

Build failed in Jenkins: zookeeper-master-maven #813

See Changes: [nkalmar] ZOOKEEPER-3792: fix apidocs path -- [...truncated 41.97 KB...] [INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 58.567

[GitHub] [zookeeper] anmolnar commented on pull request #1353: ZOOKEEPER-3832 ZKHostnameVerifier rejects valid certificates with subjectAltNames

anmolnar commented on pull request #1353: URL: https://github.com/apache/zookeeper/pull/1353#issuecomment-632045363 @eolivelli @nkalmar @symat Maven build is green now. Would you like me to add some logging before submitting?

Jenkins build is back to normal : zookeeper-master-maven #815

See

ZooKeeper_branch34_jdk8 - Build # 2169 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/2169/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 43.44 KB...] [junit] Running

[GitHub] [zookeeper] symat commented on pull request #1364: ZOOKEEPER-3832 ZKHostnameVerifier rejects valid certificates with subjectAltNames (3.5)

symat commented on pull request #1364: URL: https://github.com/apache/zookeeper/pull/1364#issuecomment-632170018 merge done, I also updated the "fixed versions" on the Jira ticket. Thanks Andor for the patch! This is an

[GitHub] [zookeeper] symat closed pull request #1364: ZOOKEEPER-3832 ZKHostnameVerifier rejects valid certificates with subjectAltNames (3.5)

symat closed pull request #1364: URL: https://github.com/apache/zookeeper/pull/1364 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

ZooKeeper_branch35_jdk8 - Build # 1839 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1839/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 229.98 KB...] [exec] Log Message Received:

[GitHub] [zookeeper] jhuan31 opened a new pull request #1365: ZOOKEEPER-3845: Add metric JVM_PAUSE_TIME

jhuan31 opened a new pull request #1365: URL: https://github.com/apache/zookeeper/pull/1365 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Jenkins build is back to normal : zookeeper-master-maven-jdk12 #519

See

[GitHub] [zookeeper] symat commented on pull request #1353: ZOOKEEPER-3832 ZKHostnameVerifier rejects valid certificates with subjectAltNames

symat commented on pull request #1353: URL: https://github.com/apache/zookeeper/pull/1353#issuecomment-632051171 I think you can push it as it is. Nice change! This is an automated message from the Apache Git Service. To

[GitHub] [zookeeper] eolivelli commented on pull request #1353: ZOOKEEPER-3832 ZKHostnameVerifier rejects valid certificates with subjectAltNames

eolivelli commented on pull request #1353: URL: https://github.com/apache/zookeeper/pull/1353#issuecomment-632055889 I have written in JIRA. Committed to master and 3.6. It does not apply to 3.5 cleanly This is an

[GitHub] [zookeeper] anmolnar commented on pull request #1353: ZOOKEEPER-3832 ZKHostnameVerifier rejects valid certificates with subjectAltNames

anmolnar commented on pull request #1353: URL: https://github.com/apache/zookeeper/pull/1353#issuecomment-632055998 I'll create separate PR. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] anmolnar opened a new pull request #1364: ZOOKEEPER-3832 ZKHostnameVerifier rejects valid certificates with subjectAltNames (3.5)

anmolnar opened a new pull request #1364: URL: https://github.com/apache/zookeeper/pull/1364 Backport to 3.5 This issue has been reported by a user who wanted to use a cert that contains SAN entries that are not of type DNS or IP. I've come across the following ticket in http

Jenkins build is back to stable : zookeeper-master-maven-jdk14 #105

See

[GitHub] [zookeeper] ctubbsii commented on a change in pull request #1357: ZOOKEEPER-3835: Deprecate IOUtils copyBytes

ctubbsii commented on a change in pull request #1357: URL: https://github.com/apache/zookeeper/pull/1357#discussion_r428643357 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/IOUtils.java ## @@ -68,6 +68,7 @@ public static void cleanup(Logger log,

[GitHub] [zookeeper] belugabehr commented on pull request #1192: ZOOKEEPER-3662: Remove NPE Possibility in Follower Class

belugabehr commented on pull request #1192: URL: https://github.com/apache/zookeeper/pull/1192#issuecomment-632091841 @nkalmar Mind taking a look at this one also? This is an automated message from the Apache Git Service. To

[GitHub] [zookeeper] belugabehr commented on pull request #1359: ZOOKEEPER-3837: Deprecate StringUtils Join

belugabehr commented on pull request #1359: URL: https://github.com/apache/zookeeper/pull/1359#issuecomment-632095051 > I would also deprecate the split to be honest. I'm not fan of implementing something so general ourselves, especially that java already is pretty good ad string

[GitHub] [zookeeper] eolivelli closed pull request #1353: ZOOKEEPER-3832 ZKHostnameVerifier rejects valid certificates with subjectAltNames

eolivelli closed pull request #1353: URL: https://github.com/apache/zookeeper/pull/1353 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Jenkins build is unstable: zookeeper-master-maven-jdk11 #520

See

[GitHub] [zookeeper] anmolnar edited a comment on pull request #1353: ZOOKEEPER-3832 ZKHostnameVerifier rejects valid certificates with subjectAltNames

anmolnar edited a comment on pull request #1353: URL: https://github.com/apache/zookeeper/pull/1353#issuecomment-632055492 Thanks @eolivelli This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] anmolnar commented on pull request #1353: ZOOKEEPER-3832 ZKHostnameVerifier rejects valid certificates with subjectAltNames

anmolnar commented on pull request #1353: URL: https://github.com/apache/zookeeper/pull/1353#issuecomment-632055492 Thanks @eolivelli Would you please cherry pick to 3.5 and 3.6? I added to the description: "Target versions: 3.5, 3.6, 3.7"

Jenkins build is back to stable : zookeeper-master-maven-jdk11 #521

See

[GitHub] [zookeeper] ctubbsii commented on a change in pull request #1357: ZOOKEEPER-3835: Deprecate IOUtils copyBytes

ctubbsii commented on a change in pull request #1357: URL: https://github.com/apache/zookeeper/pull/1357#discussion_r428644115 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/IOUtils.java ## @@ -68,6 +68,7 @@ public static void cleanup(Logger log,

[GitHub] [zookeeper] ctubbsii commented on a change in pull request #1360: ZOOKEEPER-3839: ReconfigBackupTest Remove getFileContent

ctubbsii commented on a change in pull request #1360: URL: https://github.com/apache/zookeeper/pull/1360#discussion_r428647037 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/ReconfigBackupTest.java ## @@ -93,7 +83,7 @@ public void

Build failed in Jenkins: zookeeper-master-maven #814

See Changes: [eolivelli] ZOOKEEPER-3832: ZKHostnameVerifier rejects valid certificates with -- [...truncated 318.88 KB...] [exec] ZooKeeper JMX enabled by

Build failed in Jenkins: zookeeper-master-maven-jdk12 #518

See Changes: [eolivelli] ZOOKEEPER-3832: ZKHostnameVerifier rejects valid certificates with -- [...truncated 392.94 KB...] [INFO] ---

[GitHub] [zookeeper] eolivelli commented on pull request #1353: ZOOKEEPER-3832 ZKHostnameVerifier rejects valid certificates with subjectAltNames

eolivelli commented on pull request #1353: URL: https://github.com/apache/zookeeper/pull/1353#issuecomment-632052417 Merging it now This is an automated message from the Apache Git Service. To respond to the message, please

ZooKeeper_branch35_jdk8 - Build # 1838 - Failure

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1838/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 70.76 KB...] [junit] Running

Jenkins build became unstable: zookeeper-master-maven-jdk-ea #8

See

[GitHub] [zookeeper] ctubbsii commented on a change in pull request #1358: ZOOKEEPER-3836: Use Commons and JDK Functions in ClientBase

ctubbsii commented on a change in pull request #1358: URL: https://github.com/apache/zookeeper/pull/1358#discussion_r428642068 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/test/AtomicFileOutputStreamTest.java ## @@ -64,7 +66,7 @@ public void

[GitHub] [zookeeper] nkalmar commented on pull request #1353: ZOOKEEPER-3832 ZKHostnameVerifier rejects valid certificates with subjectAltNames

nkalmar commented on pull request #1353: URL: https://github.com/apache/zookeeper/pull/1353#issuecomment-632078228 NVM, it's already committed :) This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] ctubbsii commented on a change in pull request #1359: ZOOKEEPER-3837: Deprecate StringUtils Join

ctubbsii commented on a change in pull request #1359: URL: https://github.com/apache/zookeeper/pull/1359#discussion_r428645551 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/StringUtils.java ## @@ -48,6 +48,12 @@ private StringUtils() {/** non

Jenkins build is back to normal : zookeeper-master-maven-jdk13 #214

See

[GitHub] [zookeeper] nkalmar commented on a change in pull request #1358: ZOOKEEPER-3836: Use Commons and JDK Functions in ClientBase

nkalmar commented on a change in pull request #1358: URL: https://github.com/apache/zookeeper/pull/1358#discussion_r428645512 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/test/AtomicFileOutputStreamTest.java ## @@ -64,7 +66,7 @@ public void

[GitHub] [zookeeper] belugabehr commented on a change in pull request #1358: ZOOKEEPER-3836: Use Commons and JDK Functions in ClientBase

belugabehr commented on a change in pull request #1358: URL: https://github.com/apache/zookeeper/pull/1358#discussion_r428648076 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/test/AtomicFileOutputStreamTest.java ## @@ -64,7 +66,7 @@ public void

[GitHub] [zookeeper] ctubbsii commented on a change in pull request #1358: ZOOKEEPER-3836: Use Commons and JDK Functions in ClientBase

ctubbsii commented on a change in pull request #1358: URL: https://github.com/apache/zookeeper/pull/1358#discussion_r428651295 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/test/AtomicFileOutputStreamTest.java ## @@ -64,7 +66,7 @@ public void

Jenkins build is back to normal : zookeeper-branch36-java11 #189

See

[GitHub] [zookeeper] belugabehr commented on pull request #1358: ZOOKEEPER-3836: Use Commons and JDK Functions in ClientBase

belugabehr commented on pull request #1358: URL: https://github.com/apache/zookeeper/pull/1358#issuecomment-632090776 Sorry for the churn. My coffee has NOT kicked in this morning obviously. This is an automated message

[GitHub] [zookeeper] shralex commented on a change in pull request #1356: ZOOKEEPER-3829: backward compatibility fix for rolling restart without dynamic reconfig

shralex commented on a change in pull request #1356: URL: https://github.com/apache/zookeeper/pull/1356#discussion_r428720677 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java ## @@ -614,7 +614,7 @@ void lead() throws IOException,

[GitHub] [zookeeper] symat commented on a change in pull request #1356: ZOOKEEPER-3829: backward compatibility fix for rolling restart without dynamic reconfig

symat commented on a change in pull request #1356: URL: https://github.com/apache/zookeeper/pull/1356#discussion_r428731977 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java ## @@ -614,7 +614,7 @@ void lead() throws IOException,

[GitHub] [zookeeper] symat commented on pull request #1356: ZOOKEEPER-3829: backward compatibility fix for rolling restart without dynamic reconfig

symat commented on pull request #1356: URL: https://github.com/apache/zookeeper/pull/1356#issuecomment-632163372 well, this is a very good question. Ideally I would say it should be enabled with a rolling restart. I think this is how people do all static config changes in production if

[GitHub] [zookeeper] eolivelli edited a comment on pull request #1364: ZOOKEEPER-3832 ZKHostnameVerifier rejects valid certificates with subjectAltNames (3.5)

eolivelli edited a comment on pull request #1364: URL: https://github.com/apache/zookeeper/pull/1364#issuecomment-632164874 Please merge. I can't do it now This is an automated message from the Apache Git Service. To respond

[GitHub] [zookeeper] eolivelli commented on pull request #1364: ZOOKEEPER-3832 ZKHostnameVerifier rejects valid certificates with subjectAltNames (3.5)

eolivelli commented on pull request #1364: URL: https://github.com/apache/zookeeper/pull/1364#issuecomment-632164874 Please merge. I can't do it know This is an automated message from the Apache Git Service. To respond to

[GitHub] [zookeeper] symat commented on pull request #1364: ZOOKEEPER-3832 ZKHostnameVerifier rejects valid certificates with subjectAltNames (3.5)

symat commented on pull request #1364: URL: https://github.com/apache/zookeeper/pull/1364#issuecomment-632165452 I'll merge it now This is an automated message from the Apache Git Service. To respond to the message, please

Build failed in Jenkins: zookeeper-master-maven-jdk-ea #9

See Changes: -- [...truncated 282.78 KB...] [exec] Starting zookeeper ... STARTED [exec] ZooKeeper JMX enabled by default [exec] Using config:

[GitHub] [zookeeper] belugabehr commented on a change in pull request #1359: ZOOKEEPER-3837: Deprecate StringUtils Functions

belugabehr commented on a change in pull request #1359: URL: https://github.com/apache/zookeeper/pull/1359#discussion_r428674068 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/StringUtils.java ## @@ -48,6 +48,12 @@ private StringUtils() {/** non

Build failed in Jenkins: zookeeper-branch36-java8 #191

See Changes: -- [...truncated 530.77 KB...] [exec] Using config: