[GitHub] [zookeeper] sonatype-lift[bot] commented on a diff in pull request #1902: ZOOKEEPER-4566: Create tool for recursive snapshot analysis

sonatype-lift[bot] commented on code in PR #1902: URL: https://github.com/apache/zookeeper/pull/1902#discussion_r918634205 ## bin/zkSnapshotRecursiveSummaryToolkit.sh: ## @@ -0,0 +1,38 @@ +#!/usr/bin/env bash + +# Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [zookeeper] BukrosSzabolcs commented on a diff in pull request #1902: ZOOKEEPER-4566: Create tool for recursive snapshot analysis

BukrosSzabolcs commented on code in PR #1902: URL: https://github.com/apache/zookeeper/pull/1902#discussion_r918634107 ## bin/zkSnapshotRecursiveSummaryToolkit.sh: ## @@ -0,0 +1,38 @@ +#!/usr/bin/env bash + +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [zookeeper] tisonkun commented on pull request #1904: ZOOKEEPER-4573: Encapsulate request bytebuffer in Request

tisonkun commented on PR #1904: URL: https://github.com/apache/zookeeper/pull/1904#issuecomment-1181612439 @symat I agree we can merge this patch and close #1903 , later review two related JIRA tickets. I changed the description of this patch to close #1903 and you can help merge

[GitHub] [zookeeper] BukrosSzabolcs commented on pull request #1902: ZOOKEEPER-4566: Create tool for recursive snapshot analysis

BukrosSzabolcs commented on PR #1902: URL: https://github.com/apache/zookeeper/pull/1902#issuecomment-1181412284 @symat I have fixed the spotbug issues. The test failure looks unrelated. Should we re-run it? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] symat commented on pull request #1904: ZOOKEEPER-4573: Encapsulate request bytebuffer in Request

symat commented on PR #1904: URL: https://github.com/apache/zookeeper/pull/1904#issuecomment-1181620812 > I changed the description of this patch to close https://github.com/apache/zookeeper/pull/1903 and you can help merge this. I'm not a committer of ZK and thus don't have the privilege

[GitHub] [zookeeper] anmolnar commented on a diff in pull request #1902: ZOOKEEPER-4566: Create tool for recursive snapshot analysis

anmolnar commented on code in PR #1902: URL: https://github.com/apache/zookeeper/pull/1902#discussion_r918829491 ## bin/zkSnapshotRecursiveSummaryToolkit.sh: ## @@ -0,0 +1,38 @@ +#!/usr/bin/env bash + +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [zookeeper] asfgit closed pull request #1903: ZOOKEEPER-4572: Encapsulate processConnectRequest not to take bytebuffer

asfgit closed pull request #1903: ZOOKEEPER-4572: Encapsulate processConnectRequest not to take bytebuffer URL: https://github.com/apache/zookeeper/pull/1903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [zookeeper] asfgit closed pull request #1904: ZOOKEEPER-4573: Encapsulate request bytebuffer in Request

asfgit closed pull request #1904: ZOOKEEPER-4573: Encapsulate request bytebuffer in Request URL: https://github.com/apache/zookeeper/pull/1904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zookeeper] symat commented on pull request #1902: ZOOKEEPER-4566: Create tool for recursive snapshot analysis

symat commented on PR #1902: URL: https://github.com/apache/zookeeper/pull/1902#issuecomment-1181530846 > @symat I have fixed the spotbug issues. The test failure looks unrelated. Should we re-run it? I don't think we need to re-run. Seems to be a flaky test (and totally

[GitHub] [zookeeper] symat commented on pull request #1898: ZOOKEEPER-4400 Zookeeper not getting Graceful Termination

symat commented on PR #1898: URL: https://github.com/apache/zookeeper/pull/1898#issuecomment-1181614447 Thank you @luke-sterkowicz for the contribution!! I re-triggered the CI, but don't worry about it (you were hitting a known flaky test, it is unrelated to your PR) >

[GitHub] [zookeeper] tisonkun commented on pull request #1904: ZOOKEEPER-4573: Encapsulate request bytebuffer in Request

tisonkun commented on PR #1904: URL: https://github.com/apache/zookeeper/pull/1904#issuecomment-1181625219 Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [zookeeper] BukrosSzabolcs commented on a diff in pull request #1902: ZOOKEEPER-4566: Create tool for recursive snapshot analysis

BukrosSzabolcs commented on code in PR #1902: URL: https://github.com/apache/zookeeper/pull/1902#discussion_r918839961 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/SnapshotRecursiveSummary.java: ## @@ -0,0 +1,138 @@ +/** + * Licensed to the Apache Software

[GitHub] [zookeeper] anmolnar commented on a diff in pull request #1902: ZOOKEEPER-4566: Create tool for recursive snapshot analysis

anmolnar commented on code in PR #1902: URL: https://github.com/apache/zookeeper/pull/1902#discussion_r918968567 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/SnapshotRecursiveSummary.java: ## @@ -0,0 +1,138 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [zookeeper] BukrosSzabolcs commented on a diff in pull request #1902: ZOOKEEPER-4566: Create tool for recursive snapshot analysis

BukrosSzabolcs commented on code in PR #1902: URL: https://github.com/apache/zookeeper/pull/1902#discussion_r918862079 ## bin/zkSnapshotRecursiveSummaryToolkit.sh: ## @@ -0,0 +1,38 @@ +#!/usr/bin/env bash + +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [zookeeper] BukrosSzabolcs commented on a diff in pull request #1902: ZOOKEEPER-4566: Create tool for recursive snapshot analysis

BukrosSzabolcs commented on code in PR #1902: URL: https://github.com/apache/zookeeper/pull/1902#discussion_r918860894 ## bin/zkSnapshotRecursiveSummaryToolkit.sh: ## @@ -0,0 +1,38 @@ +#!/usr/bin/env bash + +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [zookeeper] BukrosSzabolcs commented on a diff in pull request #1902: ZOOKEEPER-4566: Create tool for recursive snapshot analysis

BukrosSzabolcs commented on code in PR #1902: URL: https://github.com/apache/zookeeper/pull/1902#discussion_r918979226 ## bin/zkSnapshotRecursiveSummaryToolkit.sh: ## @@ -0,0 +1,38 @@ +#!/usr/bin/env bash + +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [zookeeper] anmolnar commented on a diff in pull request #1902: ZOOKEEPER-4566: Create tool for recursive snapshot analysis

anmolnar commented on code in PR #1902: URL: https://github.com/apache/zookeeper/pull/1902#discussion_r918967194 ## bin/zkSnapshotRecursiveSummaryToolkit.sh: ## @@ -0,0 +1,38 @@ +#!/usr/bin/env bash + +# Licensed to the Apache Software Foundation (ASF) under one or more +#