[GitHub] [zookeeper] jonmv commented on pull request #1925: ZOOKEEPER-4541 Ephemeral znode owned by closed session visible in 1 of 3 servers

jonmv commented on PR #1925: URL: https://github.com/apache/zookeeper/pull/1925#issuecomment-1263579500 We've had this running for almost a week now, without any issues, and the data inconsistencies have not been observed. The sample size isn't large enough to conclude, though :)

[GitHub] [zookeeper] jonmv commented on pull request #1925: ZOOKEEPER-4541 Ephemeral znode owned by closed session visible in 1 of 3 servers

jonmv commented on PR #1925: URL: https://github.com/apache/zookeeper/pull/1925#issuecomment-1263585329 The symptom of the bug fixed in the first of these two commits is that the learner crashes with an NPE during sync, and then, when it restarts, it typically writes a duplicated series of

[GitHub] [zookeeper] sonatype-lift[bot] commented on pull request #1925: ZOOKEEPER-4541 Ephemeral znode owned by closed session visible in 1 of 3 servers

sonatype-lift[bot] commented on PR #1925: URL: https://github.com/apache/zookeeper/pull/1925#issuecomment-1263584517 :warning: **52 God Classes** were detected by Lift in this project. [Visit the Lift web

[GitHub] [zookeeper] sonatype-lift[bot] commented on pull request #1930: ZOOKEEPER-4394

sonatype-lift[bot] commented on PR #1930: URL: https://github.com/apache/zookeeper/pull/1930#issuecomment-1263687608 :warning: **52 God Classes** were detected by Lift in this project. [Visit the Lift web

[GitHub] [zookeeper] jeffrey-xiao commented on pull request #1925: ZOOKEEPER-4541 Ephemeral znode owned by closed session visible in 1 of 3 servers

jeffrey-xiao commented on PR #1925: URL: https://github.com/apache/zookeeper/pull/1925#issuecomment-1263716744 Ah, I think we raced -- I just minted a [PR](https://github.com/apache/zookeeper/pull/1930) to resolve [ZOOKEEPER-4394](https://issues.apache.org/jira/browse/ZOOKEEPER-4394) which

[GitHub] [zookeeper] jeffrey-xiao opened a new pull request, #1930: ZOOKEEPER-4394

jeffrey-xiao opened a new pull request, #1930: URL: https://github.com/apache/zookeeper/pull/1930 This PR resolves ZOOKEEPER-4394. The first commit adds a failing test that demonstrates that a leader sending an outstanding proposal during a DIFF will cause an NPE if the commit to the

[GitHub] [zookeeper] jonmv commented on a diff in pull request #1925: ZOOKEEPER-4541 Ephemeral znode owned by closed session visible in 1 of 3 servers

jonmv commented on code in PR #1925: URL: https://github.com/apache/zookeeper/pull/1925#discussion_r984913970 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java: ## @@ -758,8 +759,9 @@ protected void syncWithLeader(long newLeaderZxid) throws