[GitHub] [zookeeper] li4wang commented on a diff in pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

li4wang commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1038419979 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java: ## @@ -496,6 +506,87 @@ public CommandResponse run(ZooKeeperServer zkServer, Map

[GitHub] [zookeeper] li4wang commented on a diff in pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

li4wang commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1038390377 ## zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md: ## @@ -1208,7 +1208,32 @@ property, when available, is noted below. The default value is

[GitHub] [zookeeper] li4wang commented on a diff in pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

li4wang commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1038401440 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/auth/IPAuthenticationProvider.java: ## @@ -128,4 +131,18 @@ public boolean isValid(String id) {

[GitHub] [zookeeper] PapaCharlie opened a new pull request, #1950: Communicate the Zxid that triggered a WatchEvent to fire

PapaCharlie opened a new pull request, #1950: URL: https://github.com/apache/zookeeper/pull/1950 With the recent addition of persistent watches, many doors have opened up to significantly more performant and intuitive local caches of remote state, but the actual implementation can be

[GitHub] [zookeeper] li4wang commented on pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

li4wang commented on PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#issuecomment-1335567224 > this is a great contribution, thank you @li4wang ! Also thanks for @maoling for his previous works in this topic! > > I think many people / projects will benefit from it.

[GitHub] [zookeeper] li4wang commented on a diff in pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

li4wang commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1038469137 ## zookeeper-server/src/test/java/org/apache/zookeeper/server/util/RateLimiterTest.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [zookeeper] li4wang commented on a diff in pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

li4wang commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1038390377 ## zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md: ## @@ -1208,7 +1208,32 @@ property, when available, is noted below. The default value is

[GitHub] [zookeeper] li4wang commented on a diff in pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

li4wang commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1038424755 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/util/RateLimiter.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [zookeeper] li4wang commented on pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

li4wang commented on PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#issuecomment-1335785734 @anmolnar thanks a lot for the comments. They have been addressed. Would you mind taking a quick look at them? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [zookeeper] li4wang commented on a diff in pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

li4wang commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1038390377 ## zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md: ## @@ -1208,7 +1208,32 @@ property, when available, is noted below. The default value is

[GitHub] [zookeeper] li4wang commented on a diff in pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

li4wang commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1038390377 ## zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md: ## @@ -1208,7 +1208,32 @@ property, when available, is noted below. The default value is

[GitHub] [zookeeper] PapaCharlie commented on pull request #1950: Communicate the Zxid that triggered a WatchEvent to fire

PapaCharlie commented on PR #1950: URL: https://github.com/apache/zookeeper/pull/1950#issuecomment-1335638463 Sorry I can't open a ticket for this. I emailed the mailing list already -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [zookeeper] li4wang commented on a diff in pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

li4wang commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1038417361 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/StreamOutputter.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [zookeeper] symat commented on pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

symat commented on PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#issuecomment-1334912500 CI failed with unit test error: > [ERROR] Errors: > [ERROR] ConnectionMetricsTest.testRevalidateCount:65 » NullPointer possibly some flaky issue, I re-triggered --

[GitHub] [zookeeper] anmolnar commented on a diff in pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

anmolnar commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1038044021 ## zookeeper-server/src/main/java/org/apache/zookeeper/server/util/RateLimiter.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [zookeeper] eolivelli commented on pull request #1917: ZOOKEEPER-4293: Lock Contention in ClientCnxnSocketNetty

eolivelli commented on PR #1917: URL: https://github.com/apache/zookeeper/pull/1917#issuecomment-1335116169 it looks some test related to this patch failed on CI 

[GitHub] [zookeeper] anmolnar commented on a diff in pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

anmolnar commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1038076604 ## zookeeper-server/src/test/java/org/apache/zookeeper/server/util/RateLimiterTest.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [zookeeper] anmolnar commented on a diff in pull request #1943: ZOOKEEPER-4570: Admin server API for taking snapshot and stream out data

anmolnar commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1038021488 ## zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md: ## @@ -1208,7 +1208,32 @@ property, when available, is noted below. The default value is