eolivelli commented on issue #1163: ZOOKEEPER-3636: find back the missing
configuration properties in the zookeeperAdmin page when moving from xml to
markdown
URL: https://github.com/apache/zookeeper/pull/1163#issuecomment-561554287
@enixon @nkalmar @anmolnar
I looking for another bind
eolivelli commented on issue #1059: [ZOOKEEPER-3512] Real time data consistency
check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#issuecomment-56155
@lvfangmin I will checkout locally the branch and try to
understand/reproduce the spotbugs problem
---
eolivelli commented on issue #1059: [ZOOKEEPER-3512] Real time data consistency
check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#issuecomment-561557520
@lvfangmin I have the same error when I build your branch:
`mvn clean install spotbugs:check -DskipTes
eolivelli commented on issue #1059: [ZOOKEEPER-3512] Real time data consistency
check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#issuecomment-561558155
This is the problem:
Unsynchronized access at DataNode.java:[line 208]
Unsynchronized access at PrepReq
eolivelli edited a comment on issue #1059: [ZOOKEEPER-3512] Real time data
consistency check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#issuecomment-561557520
@lvfangmin I have the same error when I build your branch:
```
mvn -v
Apache Maven 3.6.3
asf-ci commented on issue #1131: ZOOKEEPER-3599: cli.c: Resuscitate "old-style"
argument parsing
URL: https://github.com/apache/zookeeper/pull/1131#issuecomment-561565321
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommi
asf-ci commented on issue #1162: ZOOKEEPER-3635 Use Docker and Maven Release
Plugin to prepare ZooKeeper releases
URL: https://github.com/apache/zookeeper/pull/1162#issuecomment-561586375
Refer to this link for build results (access rights to CI server needed):
https://builds.apache
asfgit closed pull request #1162: ZOOKEEPER-3635 Use Docker and Maven Release
Plugin to prepare ZooKeeper releases
URL: https://github.com/apache/zookeeper/pull/1162
This is an automated message from the Apache Git Service.
nkalmar commented on issue #1162: ZOOKEEPER-3635 Use Docker and Maven Release
Plugin to prepare ZooKeeper releases
URL: https://github.com/apache/zookeeper/pull/1162#issuecomment-561610333
Merged to master. Thanks @eolivelli !
---
symat commented on issue #1131: ZOOKEEPER-3599: cli.c: Resuscitate "old-style"
argument parsing
URL: https://github.com/apache/zookeeper/pull/1131#issuecomment-561631843
looks great, thank you!
I did some testing with your patch and I am not sure if it is caused by this
PR or not, b
KimRasak commented on issue #1164: Fix haveDelivered wrong implementation.
URL: https://github.com/apache/zookeeper/pull/1164#issuecomment-561656541
> @KimRasak
>
> * Your analysis looks reasonable. Think further, it may not affect the
correctness of the program. That's why the suspi
KimRasak commented on issue #1164: Fix haveDelivered wrong implementation.
URL: https://github.com/apache/zookeeper/pull/1164#issuecomment-561718148
> * sendNotifications();
if s3 and s4 send notifications to each other successfully,
`sendNotifications();` won't be called...I'm kind
KimRasak commented on issue #1164: Fix haveDelivered wrong implementation.
URL: https://github.com/apache/zookeeper/pull/1164#issuecomment-561718420
> > * sendNotifications();
>
> if s3 and s4 send notifications to each other successfully,
`sendNotifications();` won't be called...I'm
KimRasak closed pull request #1164: Fix haveDelivered wrong implementation.
URL: https://github.com/apache/zookeeper/pull/1164
This is an automated message from the Apache Git Service.
To respond to the message, please log on
KimRasak opened a new pull request #1164: Fix haveDelivered wrong
implementation.
URL: https://github.com/apache/zookeeper/pull/1164
# Original implementation and mine
- The original implementation of `QuorumCnxManager::haveDelivered` returns
true once it finds a queue is empty, and ret
maoling commented on issue #1164: Fix haveDelivered wrong implementation.
URL: https://github.com/apache/zookeeper/pull/1164#issuecomment-562080962
@KimRasak
I create a [JIRA](https://issues.apache.org/jira/browse/ZOOKEEPER-3637) for
this PR, just change this PR's github description to
coheigea opened a new pull request #1165: ZOOKEEPER-3638 - Update Jetty to
9.4.24.v20191120
URL: https://github.com/apache/zookeeper/pull/1165
This is an automated message from the Apache Git Service.
To respond to the messa
asf-ci commented on issue #1165: ZOOKEEPER-3638 - Update Jetty to
9.4.24.v20191120
URL: https://github.com/apache/zookeeper/pull/1165#issuecomment-562273636
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-gi
anmolnar commented on issue #1135: ZOOKEEPER-3601:introduce the fault injection
framework: Byteman for ZooKeeper
URL: https://github.com/apache/zookeeper/pull/1135#issuecomment-562337714
@maoling I like the idea of introducing fault injection fw for ZooKeeper,
but is that it? I mean we onl
sangitanalkar opened a new pull request #1166: Add s390x support for Travis
build
URL: https://github.com/apache/zookeeper/pull/1166
As Travis CI [officially
supports](https://blog.travis-ci.com/2019-11-12-multi-cpu-architecture-ibm-power-ibm-z)
s390x builds, adding support for same.
---
asf-ci commented on issue #1166: Add s390x support for Travis build
URL: https://github.com/apache/zookeeper/pull/1166#issuecomment-562502656
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build-ma
symat commented on issue #1164: Fix haveDelivered wrong implementation.
URL: https://github.com/apache/zookeeper/pull/1164#issuecomment-562530438
@KimRasak
Thanks for trying to fix this issue!
I was about to to dig into the code to understand your point, when I
realized that the
KimRasak commented on issue #1164: Fix haveDelivered wrong implementation.
URL: https://github.com/apache/zookeeper/pull/1164#issuecomment-562532502
> @KimRasak
> Thanks for trying to fix this issue!
>
> I was about to to dig into the code to understand your point, when I
realized
KimRasak opened a new pull request #1167: Fix haveDelivered wrong
implementation.
URL: https://github.com/apache/zookeeper/pull/1167
# Original implementation and mine
- The original implementation of `QuorumCnxManager::haveDelivered` returns
true once it finds a queue is empty, and ret
asf-ci commented on issue #1167: Fix haveDelivered wrong implementation.
URL: https://github.com/apache/zookeeper/pull/1167#issuecomment-562541502
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-bu
KimRasak commented on issue #1167: Fix haveDelivered wrong implementation.
URL: https://github.com/apache/zookeeper/pull/1167#issuecomment-562567026
I still think there's sth wrong with the
`QuorumCnxManager.haveDelivered()`or
```
if(manager.haveDelivered()){
sendNotifications()
asf-ci commented on issue #1167: Fix haveDelivered wrong implementation.
URL: https://github.com/apache/zookeeper/pull/1167#issuecomment-562567813
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-bui
KimRasak commented on issue #1167: Fix haveDelivered wrong implementation.
URL: https://github.com/apache/zookeeper/pull/1167#issuecomment-562572920
Is is possible that there are 4 servers (s1, s2, s3, s4),
1. In the beginning, (s2, s3, s4) can establish links with s1, while the
network
KimRasak edited a comment on issue #1167: Fix haveDelivered wrong
implementation.
URL: https://github.com/apache/zookeeper/pull/1167#issuecomment-562567026
I still think there's sth wrong with the
`QuorumCnxManager.haveDelivered()`or
```
if(manager.haveDelivered()){
sendNotific
KimRasak commented on issue #1164: Fix haveDelivered wrong implementation.
URL: https://github.com/apache/zookeeper/pull/1164#issuecomment-562574281
> Thanks for writing a detailed explanation.
>
> Are you able to demonstrate a case in which existing code fails?
>
> A test case
KimRasak edited a comment on issue #1167: Fix haveDelivered wrong
implementation.
URL: https://github.com/apache/zookeeper/pull/1167#issuecomment-562572920
Is is possible that there are 4 servers (s1, s2, s3, s4),
1. In the beginning, (s2, s3, s4) can establish links with s1, while the
anmolnar commented on issue #994: ZOOKEEPER-3432 Improving zookeeper trace for
performance and scalability
URL: https://github.com/apache/zookeeper/pull/994#issuecomment-562845949
I'm probably already a dinosaur, because logging in general, especially
logging to a separate process/server i
anmolnar commented on issue #1010: ZOOKEEPER-3425: ranking the ttl by
expireTime asc for the performance
URL: https://github.com/apache/zookeeper/pull/1010#issuecomment-562884713
If this patch is purely performance optimisation (I absolutely support that
a single patch should focus on a si
anmolnar commented on issue #1010: ZOOKEEPER-3425: ranking the ttl by
expireTime asc for the performance
URL: https://github.com/apache/zookeeper/pull/1010#issuecomment-562886709
I second @Randgalt 's concern: I don't like that we have to synchronise on
entire `TTLManager`. Hence I'd like
anmolnar commented on issue #1010: ZOOKEEPER-3425: ranking the ttl by
expireTime asc for the performance
URL: https://github.com/apache/zookeeper/pull/1010#issuecomment-562886989
On the other hand - and I'm not sure about this -, but if writes in
ZooKeeper are serialised, do we need to car
Randgalt commented on issue #1010: ZOOKEEPER-3425: ranking the ttl by
expireTime asc for the performance
URL: https://github.com/apache/zookeeper/pull/1010#issuecomment-562887176
> if writes in ZooKeeper are serialised, do we need to care about
synchronisation?
I've wondered about t
hanm commented on a change in pull request #1059: [ZOOKEEPER-3512] Real time
data consistency check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#discussion_r355150282
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServe
hanm commented on a change in pull request #1059: [ZOOKEEPER-3512] Real time
data consistency check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#discussion_r355150282
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServe
hanm commented on a change in pull request #1059: [ZOOKEEPER-3512] Real time
data consistency check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#discussion_r355151895
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServe
hanm commented on a change in pull request #1059: [ZOOKEEPER-3512] Real time
data consistency check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#discussion_r355153267
##
File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md
##
hanm commented on a change in pull request #1059: [ZOOKEEPER-3512] Real time
data consistency check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#discussion_r355152475
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestPro
hanm commented on a change in pull request #1059: [ZOOKEEPER-3512] Real time
data consistency check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#discussion_r355152690
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestPro
hanm commented on a change in pull request #1059: [ZOOKEEPER-3512] Real time
data consistency check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#discussion_r355152171
##
File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md
##
hanm commented on a change in pull request #1059: [ZOOKEEPER-3512] Real time
data consistency check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#discussion_r355152003
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/DigestCalculat
hanm commented on a change in pull request #1059: [ZOOKEEPER-3512] Real time
data consistency check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#discussion_r355152970
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/Fi
hanm commented on issue #1059: [ZOOKEEPER-3512] Real time data consistency
check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#issuecomment-562903481
regarding the spot check complains - one way to fix it is to change the
`DataNode.getData` to `public synchronize
lvfangmin commented on a change in pull request #1059: [ZOOKEEPER-3512] Real
time data consistency check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#discussion_r355199180
##
File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md
###
lvfangmin commented on a change in pull request #1059: [ZOOKEEPER-3512] Real
time data consistency check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#discussion_r355199915
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepReque
lvfangmin commented on a change in pull request #1059: [ZOOKEEPER-3512] Real
time data consistency check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#discussion_r355200253
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/persisten
lvfangmin commented on a change in pull request #1059: [ZOOKEEPER-3512] Real
time data consistency check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#discussion_r355199981
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeper
lvfangmin commented on a change in pull request #1059: [ZOOKEEPER-3512] Real
time data consistency check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#discussion_r355199104
##
File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md
###
lvfangmin commented on issue #1059: [ZOOKEEPER-3512] Real time data consistency
check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#issuecomment-562972445
Thanks @eolivelli @hanm for checking, I think I didn't get that spotbugs
error locally might because I didn'
asf-ci commented on issue #1059: [ZOOKEEPER-3512] Real time data consistency
check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#issuecomment-562974087
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job
asf-ci commented on issue #1059: [ZOOKEEPER-3512] Real time data consistency
check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#issuecomment-562978838
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job
asf-ci commented on issue #1059: [ZOOKEEPER-3512] Real time data consistency
check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#issuecomment-562985937
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/
hanm commented on issue #1059: [ZOOKEEPER-3512] Real time data consistency
check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#issuecomment-563006339
@anmolnar - would you please double check if this PR addressed your previous
review concerns, since you left a "r
maoling edited a comment on issue #1141: ZOOKEEPER-3606: add JMXHOSTNAME to
zkServer.sh to enable user to chan…
URL: https://github.com/apache/zookeeper/pull/1141#issuecomment-558422709
ping @eolivelli @lvfangmin @hanm @anmolnar
maoling commented on issue #1142: ZOOKEEPER-3582:refactor the async api call to
lambda style
URL: https://github.com/apache/zookeeper/pull/1142#issuecomment-563028974
ping @anmolnar @eolivelli @hanm
This is an automated mes
maoling commented on issue #1167: Fix haveDelivered wrong implementation.
URL: https://github.com/apache/zookeeper/pull/1167#issuecomment-563037199
@KimRasak
- The logic only affects the `queueSendMap` which some queue is empty and
others is not empty. In this case, the origin logic ent
xy24 opened a new pull request #1168: ZOOKEEPER-3057: Fix IPv6 literal usage
URL: https://github.com/apache/zookeeper/pull/1168
This commit backports #548 to branch-3.5.
I cherry picked all the changes except the file (NetUtils.java) where
modification were already made by other back
asf-ci commented on issue #1168: ZOOKEEPER-3057: Fix IPv6 literal usage
URL: https://github.com/apache/zookeeper/pull/1168#issuecomment-563096774
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-buil
xy24 commented on issue #548: [ZOOKEEPER-3057] Fix IPv6 literal usage
URL: https://github.com/apache/zookeeper/pull/548#issuecomment-563102472
@anmolnar @maoling
I've cherry picked this change and created a pr for branch-3.5.
Would you please review it for me? Thanks
#1168
--
ztzg commented on issue #1131: ZOOKEEPER-3599: cli.c: Resuscitate "old-style"
argument parsing
URL: https://github.com/apache/zookeeper/pull/1131#issuecomment-563119768
Hi @symat,
Thank you for the test, and report. That was a bit puzzling... but it turns
out that "batch mode" has
ztzg edited a comment on issue #1131: ZOOKEEPER-3599: cli.c: Resuscitate
"old-style" argument parsing
URL: https://github.com/apache/zookeeper/pull/1131#issuecomment-563119768
Hi @symat,
Thank you for the test, and report. Nice catch! That was a bit puzzling...
but it turns out th
symat commented on issue #1131: ZOOKEEPER-3599: cli.c: Resuscitate "old-style"
argument parsing
URL: https://github.com/apache/zookeeper/pull/1131#issuecomment-563123252
yep, thanks for clarifying :)
otherwise it looks good to me. (but I am not a committer to officially +1 it)
@nk
ztzg commented on issue #1131: ZOOKEEPER-3599: cli.c: Resuscitate "old-style"
argument parsing
URL: https://github.com/apache/zookeeper/pull/1131#issuecomment-563129058
Okay—Thanks!
This is an automated message from the Apach
ztzg opened a new pull request #1169: ZOOKEEPER-3641: New ZOO_VERSION define
breaks Perl & Python contribs
URL: https://github.com/apache/zookeeper/pull/1169
[ZOOKEEPER-3635](https://issues.apache.org/jira/browse/ZOOKEEPER-3635)
changed the versioning scheme for the C client from integer-v
asf-ci commented on issue #1169: ZOOKEEPER-3641: New ZOO_VERSION define breaks
Perl & Python contribs
URL: https://github.com/apache/zookeeper/pull/1169#issuecomment-563169398
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Pre
ztzg commented on issue #1169: ZOOKEEPER-3641: New ZOO_VERSION define breaks
Perl & Python contribs
URL: https://github.com/apache/zookeeper/pull/1169#issuecomment-563266706
Hi @eolivelli,
(Github tells me you "requested changes," but I cannot find review notes.
Is it only about th
symat commented on issue #1169: ZOOKEEPER-3641: New ZOO_VERSION define breaks
Perl & Python contribs
URL: https://github.com/apache/zookeeper/pull/1169#issuecomment-563280006
> Is there any way to create a script (or use Maven) to build these modules
in Travis?
in https://github.com
eolivelli commented on issue #1169: ZOOKEEPER-3641: New ZOO_VERSION define
breaks Perl & Python contribs
URL: https://github.com/apache/zookeeper/pull/1169#issuecomment-563290813
@nkalmar PTAL and merge if you approve this patch
-
ztzg commented on issue #1169: ZOOKEEPER-3641: New ZOO_VERSION define breaks
Perl & Python contribs
URL: https://github.com/apache/zookeeper/pull/1169#issuecomment-563294346
> > Is there any way to create a script (or use Maven) to build these
modules in Travis?
>
> in #1121 I did s
eolivelli commented on issue #1169: ZOOKEEPER-3641: New ZOO_VERSION define
breaks Perl & Python contribs
URL: https://github.com/apache/zookeeper/pull/1169#issuecomment-563314230
It is better to use Travis.
With travis you can install your dependencies, like we do for cppunit
--
ztzg commented on issue #1169: ZOOKEEPER-3641: New ZOO_VERSION define breaks
Perl & Python contribs
URL: https://github.com/apache/zookeeper/pull/1169#issuecomment-563325788
Okay—noted!
This is an automated message from the A
asf-ci commented on issue #1059: [ZOOKEEPER-3512] Real time data consistency
check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#issuecomment-563403241
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/
asf-ci commented on issue #1144: ZOOKEEPER-3614: Limiting the number of
ephemeral nodes per session
URL: https://github.com/apache/zookeeper/pull/1144#issuecomment-563557022
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreC
asf-ci commented on issue #1144: ZOOKEEPER-3614: Limiting the number of
ephemeral nodes per session
URL: https://github.com/apache/zookeeper/pull/1144#issuecomment-563569771
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreC
asf-ci commented on issue #1144: ZOOKEEPER-3614: Limiting the number of
ephemeral nodes per session
URL: https://github.com/apache/zookeeper/pull/1144#issuecomment-563607118
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreC
anmolnar commented on issue #944: ZOOKEEPER-3388: Allow client port to support
plaintext and encrypted …
URL: https://github.com/apache/zookeeper/pull/944#issuecomment-563963844
@eolivelli @enixon @hanm Do you mind if I backport this feature to 3.5?
anmolnar commented on issue #934: ZOOKEEPER-3301:Enforce the quota limit
URL: https://github.com/apache/zookeeper/pull/934#issuecomment-563964747
@maoling Do you still work on this patch?
Please rebase.
This is an automated
asfgit closed pull request #1169: ZOOKEEPER-3641: New ZOO_VERSION define breaks
Perl & Python contribs
URL: https://github.com/apache/zookeeper/pull/1169
This is an automated message from the Apache Git Service.
To respond t
nkalmar commented on issue #1169: ZOOKEEPER-3641: New ZOO_VERSION define breaks
Perl & Python contribs
URL: https://github.com/apache/zookeeper/pull/1169#issuecomment-563988994
Thanks @ztzg , merged to master (3.6.0)
This is
nkalmar edited a comment on issue #1169: ZOOKEEPER-3641: New ZOO_VERSION define
breaks Perl & Python contribs
URL: https://github.com/apache/zookeeper/pull/1169#issuecomment-563988994
Thanks @ztzg , merged to master (3.6.0)
The travis integration can be done in a separate Jira.
eolivelli commented on issue #944: ZOOKEEPER-3388: Allow client port to support
plaintext and encrypted …
URL: https://github.com/apache/zookeeper/pull/944#issuecomment-563993477
@anmolnar ok
This is an automated message from
symat opened a new pull request #1170: ZOOKEEPER-3643: Testing and documenting
secure and unsecure ZK client connections
URL: https://github.com/apache/zookeeper/pull/1170
We are working in the ZooKeeper SSL integration in HBase. By default, one
can enable ZooKeeper SSL client connections
ravowlga123 opened a new pull request #1171: ZOOKEEPER-2083 Remove deprecated
class AuthFastLeaderElection
URL: https://github.com/apache/zookeeper/pull/1171
As per [ZOOKEEPER-2083](https://jira.apache.org/jira/browse/ZOOKEEPER-2083)
we need to remove class AuthFastLeaderElection.java so I
eolivelli commented on a change in pull request #1170: ZOOKEEPER-3643: Testing
and documenting secure and unsecure ZK client connections
URL: https://github.com/apache/zookeeper/pull/1170#discussion_r356120687
##
File path:
zookeeper-server/src/test/java/org/apache/zookeeper/test/C
vladimirivic opened a new pull request #1172: ZOOKEEPER-3594: Ability to skip
proposing requests with error transactions
URL: https://github.com/apache/zookeeper/pull/1172
Ensembles that have a high write request rate could be skipping proposing
requests that contain errors instead of havi
asf-ci commented on issue #1172: ZOOKEEPER-3594: Ability to skip proposing
requests with error transactions
URL: https://github.com/apache/zookeeper/pull/1172#issuecomment-564298530
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/
maoling commented on issue #934: ZOOKEEPER-3301:Enforce the quota limit
URL: https://github.com/apache/zookeeper/pull/934#issuecomment-564339639
@anmolnar I will rebase it this weekend
This is an automated message from the Apa
maoling commented on issue #1168: ZOOKEEPER-3057: Fix IPv6 literal usage
URL: https://github.com/apache/zookeeper/pull/1168#issuecomment-564341891
@xy24 Thanks for this work.
I cannot make sure whether it needs to backport to branch3.5. Let's listen
to @anmolnar's viewpoint, then we can
maoling commented on a change in pull request #1171: ZOOKEEPER-2083 Remove
deprecated class AuthFastLeaderElection
URL: https://github.com/apache/zookeeper/pull/1171#discussion_r356376518
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.jav
xy24 commented on issue #1168: ZOOKEEPER-3057: Fix IPv6 literal usage
URL: https://github.com/apache/zookeeper/pull/1168#issuecomment-564357942
> @xy24 Thanks for this work.
> I cannot make sure whether it needs to backport to branch3.5. Let's listen
to @anmolnar's viewpoint, then we can
hanm edited a comment on issue #944: ZOOKEEPER-3388: Allow client port to
support plaintext and encrypted …
URL: https://github.com/apache/zookeeper/pull/944#issuecomment-564373176
>> Do you mind if I backport this feature to 3.5?
+1
-
hanm commented on issue #944: ZOOKEEPER-3388: Allow client port to support
plaintext and encrypted …
URL: https://github.com/apache/zookeeper/pull/944#issuecomment-564373176
>> Do you mind if I backport this feature to 3.5?
+1
ztzg opened a new pull request #1173: ZOOKEEPER-3640: Implement "batch mode" in
cli_mt (WIP)
URL: https://github.com/apache/zookeeper/pull/1173
Batch mode never was implemented in `cli_mt`. This WIP patch seems to work,
but:
1. There may be a cleaner way of waiting for the completi
asf-ci commented on issue #1173: ZOOKEEPER-3640: Implement "batch mode" in
cli_mt
URL: https://github.com/apache/zookeeper/pull/1173#issuecomment-564439967
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-git
asf-ci commented on issue #1173: ZOOKEEPER-3640: Implement "batch mode" in
cli_mt
URL: https://github.com/apache/zookeeper/pull/1173#issuecomment-564453435
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-gi
ztzg commented on issue #1173: ZOOKEEPER-3640: Implement "batch mode" in cli_mt
URL: https://github.com/apache/zookeeper/pull/1173#issuecomment-564471752
retest maven build
This is an automated message from the Apache Git Serv
symat commented on issue #1173: ZOOKEEPER-3640: Implement "batch mode" in cli_mt
URL: https://github.com/apache/zookeeper/pull/1173#issuecomment-564476887
I quickly tested the patch, and it seems working now both for `cli_mt` and
`cli_st`. I haven't tested it on windows yet (that takes more
901 - 1000 of 9616 matches
Mail list logo
