[GitHub] [accumulo] milleruntime commented on pull request #1614: Create max tablets property in new bulk import

2020-05-21 Thread GitBox
milleruntime commented on pull request #1614: URL: https://github.com/apache/accumulo/pull/1614#issuecomment-632282696 @EdColeman @keith-turner I made some improvements based on your feedback. I had to move the check inside the computeMapping methods so it would fail fast on a single file

[GitHub] [accumulo] milleruntime commented on a change in pull request #1614: Create max tablets property in new bulk import

2020-05-21 Thread GitBox
milleruntime commented on a change in pull request #1614: URL: https://github.com/apache/accumulo/pull/1614#discussion_r428850037 ## File path: core/src/main/java/org/apache/accumulo/core/clientImpl/bulk/BulkImport.java ## @@ -133,6 +134,14 @@ public void load() SortedM

[GitHub] [accumulo] milleruntime commented on a change in pull request #1614: Create max tablets property in new bulk import

2020-05-21 Thread GitBox
milleruntime commented on a change in pull request #1614: URL: https://github.com/apache/accumulo/pull/1614#discussion_r428851706 ## File path: core/src/main/java/org/apache/accumulo/core/clientImpl/bulk/BulkImport.java ## @@ -576,7 +587,12 @@ private Text toText(byte[] row) {

[GitHub] [accumulo] keith-turner commented on a change in pull request #1614: Create max tablets property in new bulk import

2020-05-21 Thread GitBox
keith-turner commented on a change in pull request #1614: URL: https://github.com/apache/accumulo/pull/1614#discussion_r428932975 ## File path: core/src/main/java/org/apache/accumulo/core/clientImpl/bulk/BulkImport.java ## @@ -576,7 +587,12 @@ private Text toText(byte[] row) {

[GitHub] [accumulo] keith-turner commented on a change in pull request #1614: Create max tablets property in new bulk import

2020-05-21 Thread GitBox
keith-turner commented on a change in pull request #1614: URL: https://github.com/apache/accumulo/pull/1614#discussion_r428933667 ## File path: core/src/main/java/org/apache/accumulo/core/clientImpl/bulk/BulkImport.java ## @@ -576,7 +587,12 @@ private Text toText(byte[] row) {

[GitHub] [accumulo] keith-turner commented on a change in pull request #1614: Create max tablets property in new bulk import

2020-05-21 Thread GitBox
keith-turner commented on a change in pull request #1614: URL: https://github.com/apache/accumulo/pull/1614#discussion_r428935251 ## File path: core/src/main/java/org/apache/accumulo/core/clientImpl/bulk/BulkImport.java ## @@ -576,7 +587,12 @@ private Text toText(byte[] row) {

[GitHub] [accumulo] keith-turner commented on a change in pull request #1614: Create max tablets property in new bulk import

2020-05-21 Thread GitBox
keith-turner commented on a change in pull request #1614: URL: https://github.com/apache/accumulo/pull/1614#discussion_r428938795 ## File path: test/src/main/java/org/apache/accumulo/test/functional/BulkNewIT.java ## @@ -186,18 +186,26 @@ public void testSingleTabletSingleFileO