LY-GO commented on pull request #2465:
URL: https://github.com/apache/apisix/pull/2465#issuecomment-712625105
> > > @LY-GO you can make a try with this PR
> > > 2.i modify the code of limit-conn according to your repair.But the
response code is 500
> > >
This is an automated email from the ASF dual-hosted git repository.
wenming pushed a change to tag 2.0
in repository https://gitbox.apache.org/repos/asf/apisix.git.
at 79be83d (commit)
No new revisions were added by this update.
juzhiyuan commented on a change in pull request #564:
URL: https://github.com/apache/apisix-dashboard/pull/564#discussion_r508257873
##
File path: .github/workflows/api_ci.yml
##
@@ -4,9 +4,11 @@ on:
push:
branches:
- master
+ - refactor
Review comment:
nirvanareborn opened a new issue #2473:
URL: https://github.com/apache/apisix/issues/2473
### Issue description
In the third step of editing routing in the new version of dashboard, the
configuration item of proxy rewrite is missing in normal mode
### Environment
* apisix
juzhiyuan commented on issue #565:
URL:
https://github.com/apache/apisix-dashboard/issues/565#issuecomment-712655935
Will be added in the release soon
This is an automated message from the Apache Git Service.
To respond to
LY-GO opened a new issue #2477:
URL: https://github.com/apache/apisix/issues/2477
### Issue description
i want to add key for limit-plugin;it can accomplish limit according to
service_id;If i want to implement the function,you can give some
suggestion.Thanks!
### Environment
nic-chen opened a new issue #568:
URL: https://github.com/apache/apisix-dashboard/issues/568
now it response normal.
here is an example:
```
$ curl http://127.0.0.1:8080/apisix/admin/services/1 -X PUT -i -d '
{
"upstream": {
"nodes": {
moonming commented on a change in pull request #564:
URL: https://github.com/apache/apisix-dashboard/pull/564#discussion_r508319160
##
File path: api/build-tools/json.lua
##
@@ -0,0 +1,400 @@
+--
+-- json.lua
+--
+-- Copyright (c) 2020 rxi
Review comment:
fixed, I add
This is an automated email from the ASF dual-hosted git repository.
chenjunxu pushed a change to branch refactor
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from 2088156 feat: compatible with HTTP status of `admin api` (#563)
add be1edf6 fix: check
This is an automated email from the ASF dual-hosted git repository.
chenjunxu pushed a change to branch refactor
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from 2088156 feat: compatible with HTTP status of `admin api` (#563)
add be1edf6 fix: check
Yiyiyimu commented on issue #2428:
URL: https://github.com/apache/apisix/issues/2428#issuecomment-712652309
@whatsmore Welcome adding what you found to documentation, in order to help
other people who might come across this problem in the future.
sshniro edited a comment on issue #2428:
URL: https://github.com/apache/apisix/issues/2428#issuecomment-710362912
If you can rephrase in EN I can help you with this.
This is an automated message from the Apache Git
moonming commented on a change in pull request #564:
URL: https://github.com/apache/apisix-dashboard/pull/564#discussion_r508346498
##
File path: api/internal/core/store/validate_mock.go
##
@@ -0,0 +1,24 @@
+// Code generated by mockery v1.0.0. DO NOT EDIT.
Review comment:
This is an automated email from the ASF dual-hosted git repository.
wenming pushed a change to branch refactor
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from 496d390 Merge branch 'refactor' of github.com:apache/apisix-dashboard
into refactor
add 1b19a94
idbeta commented on pull request #2368:
URL: https://github.com/apache/apisix/pull/2368#issuecomment-712621569
This PR only contained URI fuzzing test, but I add some code about monitor
the resource occupation
`def get_workerres(pid):
... ...`
As for long-term testing, I
nic-chen opened a new pull request #564:
URL: https://github.com/apache/apisix-dashboard/pull/564
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bug fix
- [x] New feature provided
- [x] Improve performance
___
This is an automated email from the ASF dual-hosted git repository.
chenjunxu pushed a change to branch refactor
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from be1edf6 fix: check input.ID before using it
add 5b24ece fix: host should not be required
membphis commented on issue #2468:
URL: https://github.com/apache/apisix/issues/2468#issuecomment-712639245
can you provide a real example of your case? we need to confirm it ^_^
This is an automated message from the Apache
XXMY commented on issue #2319:
URL: https://github.com/apache/apisix/issues/2319#issuecomment-712644314
There is a default yaml file of configmap:
https://github.com/apache/apisix/blob/master/conf/config-default.yaml
This
nirvanareborn opened a new issue #565:
URL: https://github.com/apache/apisix-dashboard/issues/565
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [ ] Bug
- [ ] Requirem1ents
- [ ] Feature or
juzhiyuan closed issue #565:
URL: https://github.com/apache/apisix-dashboard/issues/565
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
nic-chen commented on pull request #564:
URL: https://github.com/apache/apisix-dashboard/pull/564#issuecomment-712681096
> ```
> ? github.com/apisix/manager-api [no test files]
> ? github.com/apisix/manager-api/conf [no test files]
> ?
membphis commented on issue #1574:
URL: https://github.com/apache/apisix/issues/1574#issuecomment-712698575
@tzssangglass welcome PR to fix this bug.
if we need to https://github.com/api7/lua-resty-radixtree , welcome to
create a new issue first at `radixtree`.
tzssangglass commented on issue #1574:
URL: https://github.com/apache/apisix/issues/1574#issuecomment-712714437
> @tzssangglass welcome PR to fix this bug.
>
> if we need to https://github.com/api7/lua-resty-radixtree , welcome to
create a new issue first at `radixtree`.
ok,
moonming commented on a change in pull request #564:
URL: https://github.com/apache/apisix-dashboard/pull/564#discussion_r508350981
##
File path: api/internal/core/store/selector_test.go
##
@@ -0,0 +1,285 @@
+/*
Review comment:
Is this test case file copy from other
moonming commented on a change in pull request #564:
URL: https://github.com/apache/apisix-dashboard/pull/564#discussion_r508350413
##
File path: api/internal/core/store/selector.go
##
@@ -0,0 +1,144 @@
+/*
Review comment:
where is this file come from? please give the
gy09535 closed issue #2471:
URL: https://github.com/apache/apisix/issues/2471
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
This is an automated email from the ASF dual-hosted git repository.
chenjunxu pushed a change to branch master-20201020
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
at 6375d15 fix(i18n): update error key in requestConfigView.tsx (#526)
No new revisions were
nic-chen commented on pull request #564:
URL: https://github.com/apache/apisix-dashboard/pull/564#issuecomment-712673411
> @nic-chen do you check licenses for all go dependencies?
here is the result:
```
gopkg.in/yaml.v2,Unknown,Apache-2.0
membphis commented on issue #2441:
URL: https://github.com/apache/apisix/issues/2441#issuecomment-712678179
> My suggestion is to put `metadata`/`consumer` into the arguments, if the
argument is missing, choice the default plain `schema`.
this way is much better. agree +1
moonming commented on pull request #564:
URL: https://github.com/apache/apisix-dashboard/pull/564#issuecomment-712703880
>
github.com/davecgh/go-spew/spew,https://github.com/davecgh/go-spew/blob/master/spew/LICENSE,ISC
>
spacewander opened a new pull request #2476:
URL: https://github.com/apache/apisix/pull/2476
### What this PR does / why we need it:
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features
have been added?
* [x]
This is an automated email from the ASF dual-hosted git repository.
wenming pushed a change to branch refactor
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from 63f8f17 fix: remove useless dependences
add 162c0d9 add license for json.lua
add 496d390
moonming commented on a change in pull request #564:
URL: https://github.com/apache/apisix-dashboard/pull/564#discussion_r508346174
##
File path: api/internal/core/storage/storage_mock.go
##
@@ -0,0 +1,116 @@
+// Code generated by mockery v1.0.0. DO NOT EDIT.
Review comment:
moonming commented on a change in pull request #564:
URL: https://github.com/apache/apisix-dashboard/pull/564#discussion_r508346174
##
File path: api/internal/core/storage/storage_mock.go
##
@@ -0,0 +1,116 @@
+// Code generated by mockery v1.0.0. DO NOT EDIT.
Review comment:
This is an automated email from the ASF dual-hosted git repository.
wenming pushed a change to branch refactor
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from 63f8f17 fix: remove useless dependences
add 162c0d9 add license for json.lua
add 496d390
moonming commented on a change in pull request #564:
URL: https://github.com/apache/apisix-dashboard/pull/564#discussion_r508349535
##
File path: api/internal/core/store/query.go
##
@@ -0,0 +1,151 @@
+/*
Review comment:
where is this file come from? please giave the
LY-GO commented on pull request #2465:
URL: https://github.com/apache/apisix/pull/2465#issuecomment-712621681
> @LY-GO you can make a try with this PR
I test the plugin,i find it don't work;now every request can success,even
if number of request over concurrency limit.I just copy
LY-GO removed a comment on pull request #2465:
URL: https://github.com/apache/apisix/pull/2465#issuecomment-712621681
> @LY-GO you can make a try with this PR
I test the plugin,i find it don't work;now every request can success,even
if number of request over concurrency limit.I
longshang opened a new issue #2474:
URL: https://github.com/apache/apisix/issues/2474
### Issue description
Can you tell me how to add a plug-in with the number of interface calls for
an application，THX!
### Environment
* apisix version (cmd: `apisix version`):
* OS:
moonming commented on pull request #564:
URL: https://github.com/apache/apisix-dashboard/pull/564#issuecomment-712651441
```
?github.com/apisix/manager-api [no test files]
?github.com/apisix/manager-api/conf [no test files]
?github.com/apisix/manager-api/filter
nic-chen commented on a change in pull request #564:
URL: https://github.com/apache/apisix-dashboard/pull/564#discussion_r508290471
##
File path: api/filter/authentication.go
##
@@ -17,49 +17,55 @@
package filter
import (
- "github.com/apisix/manager-api/conf"
-
membphis commented on issue #2410:
URL: https://github.com/apache/apisix/issues/2410#issuecomment-712674971
yes, that is the right way. ^_^
This is an automated message from the Apache Git Service.
To respond to the message,
membphis commented on pull request #2475:
URL: https://github.com/apache/apisix/pull/2475#issuecomment-712709404
you need to fix the error message which prints by CI:
https://github.com/apache/apisix/pull/2475/checks?check_run_id=1279803708#step:9:124
LY-GO opened a new pull request #2475:
URL: https://github.com/apache/apisix/pull/2475
### What this PR does / why we need it:
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features
have been added?
* [ ] Have you
moonming commented on a change in pull request #564:
URL: https://github.com/apache/apisix-dashboard/pull/564#discussion_r508348027
##
File path: api/internal/core/entity/query.go
##
@@ -0,0 +1,153 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
This is an automated email from the ASF dual-hosted git repository.
wenming pushed a change to branch refactor
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from 496d390 Merge branch 'refactor' of github.com:apache/apisix-dashboard
into refactor
add 1b19a94
spacewander opened a new pull request #2478:
URL: https://github.com/apache/apisix/pull/2478
Close #2472.
### What this PR does / why we need it:
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features
have been
This is an automated email from the ASF dual-hosted git repository.
wenming pushed a change to branch refactor
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from 1b19a94 fix license issue
add 2269b53 remove
No new revisions were added by this update.
nic-chen opened a new issue #566:
URL: https://github.com/apache/apisix-dashboard/issues/566
like:
https://github.com/apache/apisix/blob/master/t/admin/services.t#L381
other apis(route, upstream, ssl) have this issue too.
This is an automated email from the ASF dual-hosted git repository.
chenjunxu pushed a change to branch refactor
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from 2269b53 remove
add a985337 fix: remove viper that depend github.com/hashicorp/hcl
No new
LY-GO commented on pull request #2465:
URL: https://github.com/apache/apisix/pull/2465#issuecomment-712767911
> > > > @LY-GO you can make a try with this PR
> > > > 2.i modify the code of limit-conn according to your repair.But the
response code is 500
> > > >
This is an automated email from the ASF dual-hosted git repository.
chenjunxu pushed a change to branch refactor
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from 9dbfaa0 Merge branch 'master' into refactor
add e0f13fb fix: remove CI branch
add 63f8f17
nic-chen commented on a change in pull request #564:
URL: https://github.com/apache/apisix-dashboard/pull/564#discussion_r508357948
##
File path: api/internal/core/store/query.go
##
@@ -0,0 +1,151 @@
+/*
Review comment:
some code from:
nic-chen commented on a change in pull request #564:
URL: https://github.com/apache/apisix-dashboard/pull/564#discussion_r508358111
##
File path: api/internal/core/store/selector.go
##
@@ -0,0 +1,144 @@
+/*
Review comment:
some code from:
Miss-you commented on issue #2362:
URL: https://github.com/apache/apisix/issues/2362#issuecomment-712728248
Hi, thanks for the advice.
The Prometheus metrics usually use another port to expose the service
instead of a business port, such as controller, scheduler, ingress, etc., which
This is an automated email from the ASF dual-hosted git repository.
wenming pushed a change to branch refactor
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from a985337 fix: remove viper that depend github.com/hashicorp/hcl
add 394a864 fix license issue
nic-chen commented on pull request #564:
URL: https://github.com/apache/apisix-dashboard/pull/564#issuecomment-712728600
> >
github.com/davecgh/go-spew/spew,https://github.com/davecgh/go-spew/blob/master/spew/LICENSE,ISC
> >
nic-chen commented on a change in pull request #564:
URL: https://github.com/apache/apisix-dashboard/pull/564#discussion_r508358358
##
File path: api/internal/core/store/selector_test.go
##
@@ -0,0 +1,285 @@
+/*
Review comment:
some code from:
Miss-you edited a comment on issue #2362:
URL: https://github.com/apache/apisix/issues/2362#issuecomment-712728248
Hi, thanks for the advice.
The Prometheus metrics usually use another port to expose the service
instead of a business port, such as controller, scheduler, ingress, etc.,
membphis commented on issue #2474:
URL: https://github.com/apache/apisix/issues/2474#issuecomment-712737744
Do you need a plugin that counts the number of API calls?
if yes, we can implement this feature by a new plugin.
1. time window.
2. Calculation of the number of API
longshang commented on issue #2474:
URL: https://github.com/apache/apisix/issues/2474#issuecomment-712742229
> Do you need a plugin that counts the number of API calls?
>
> if yes, we can implement this feature by a new plugin.
>
> 1. time window.
> 2. Calculation of the
liuxiran opened a new issue #2479:
URL: https://github.com/apache/apisix/issues/2479
### Issue description
refer to https://github.com/apache/apisix/pull/1655
route name should be unique, actually I can create two routes with the same
name.
### Environment
* apisix
Caelebs commented on issue #2428:
URL: https://github.com/apache/apisix/issues/2428#issuecomment-712810169
@whatsmore 铁子怎么搞的 围观围观？
This is an automated message from the Apache Git Service.
To respond to the message, please
liuxiran commented on issue #2479:
URL: https://github.com/apache/apisix/issues/2479#issuecomment-712813560
> you can take the `name` as `id`, for example:
> `http://127.0.0.1:9080/apisix/admin/routes/test1`
test result：
1. create a route id: user1,name:test1
membphis commented on issue #2466:
URL: https://github.com/apache/apisix/issues/2466#issuecomment-712725364
close this issue first. please feel free to reopen this issue if you need
help with this issue.
This is an
membphis closed issue #2466:
URL: https://github.com/apache/apisix/issues/2466
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
nic-chen opened a new issue #567:
URL: https://github.com/apache/apisix-dashboard/issues/567
In APISIX ID could be int or string:
https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L28
do we need to support int as ID after refactored?
liuxiran commented on issue #2479:
URL: https://github.com/apache/apisix/issues/2479#issuecomment-712782620
I feel that it is a bug that affects the user experience, it would be better
to solve before2.0, how about your options @membphis @nic-chen @moonming
@juzhiyuan
moonming commented on issue #2479:
URL: https://github.com/apache/apisix/issues/2479#issuecomment-712786714
you can take the `name` as `id`, for example:
```http://127.0.0.1:9080/apisix/admin/routes/test1```
This is an
spacewander merged pull request #2478:
URL: https://github.com/apache/apisix/pull/2478
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
spacewander closed issue #2472:
URL: https://github.com/apache/apisix/issues/2472
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
moonming commented on issue #2479:
URL: https://github.com/apache/apisix/issues/2479#issuecomment-712894195
you used the `PUT` method, so it will update the exist one.
you can try the `POST` method.
Thanks,
Ming Wen
Twitter: _WenMing
liuxiran 于2020年10月20日周二
liuxiran commented on issue #2479:
URL: https://github.com/apache/apisix/issues/2479#issuecomment-712908195
> you used the `PUT` method, so it will update the exist one. you can try
the `POST` method. Thanks, Ming Wen Twitter:
I also tried `POST` method, the result:
```shell
RocFang opened a new pull request #2480:
URL: https://github.com/apache/apisix/pull/2480
### What this PR does / why we need it:
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features
have been added?
* [ ] Have
This is an automated email from the ASF dual-hosted git repository.
chenjunxu pushed a change to branch refactor
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from 228086f Merge branch 'refactor' of github.com:apache/apisix-dashboard
into refactor
add
juzhiyuan commented on pull request #521:
URL: https://github.com/apache/apisix-dashboard/pull/521#issuecomment-712946049
ping @moonming @liuxiran
This is an automated message from the Apache Git Service.
To respond to the
nic-chen opened a new issue #570:
URL: https://github.com/apache/apisix-dashboard/issues/570
PATCH method doesn't support subpath and embedded struct.
example:
```
$ curl http://127.0.0.1:8080/apisix/admin/routes/1/upstream/nodes -X PATCH
-i -d '
{
juzhiyuan merged pull request #564:
URL: https://github.com/apache/apisix-dashboard/pull/564
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a change to branch fe-refactor
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from 43af140 feat: codes clean
add a1f96d4 feat: refactor `manager api` (#564)
add 985f3f5
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from 6375d15 fix(i18n): update error key in requestConfigView.tsx (#526)
add a1f96d4 feat: refactor
moonming commented on issue #2479:
URL: https://github.com/apache/apisix/issues/2479#issuecomment-712932263
@membphis please take a look
This is an automated message from the Apache Git Service.
To respond to the message,
juzhiyuan commented on issue #570:
URL:
https://github.com/apache/apisix-dashboard/issues/570#issuecomment-712951151
added to milestone 1.6 now, feel free to remove them if needed.
This is an automated message from the
juzhiyuan commented on issue #2473:
URL: https://github.com/apache/apisix/issues/2473#issuecomment-712950103
duplicate as https://github.com/apache/apisix-dashboard/issues/565
This is an automated message from the Apache Git
juzhiyuan closed issue #2473:
URL: https://github.com/apache/apisix/issues/2473
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
juzhiyuan edited a comment on issue #572:
URL:
https://github.com/apache/apisix-dashboard/issues/572#issuecomment-712958070
it looks like there have some unused files 樂
This is an automated message from the Apache Git
juzhiyuan commented on issue #572:
URL:
https://github.com/apache/apisix-dashboard/issues/572#issuecomment-712958070
it looks there have some unused files 樂
This is an automated message from the Apache Git Service.
To
juzhiyuan opened a new issue #572:
URL: https://github.com/apache/apisix-dashboard/issues/572
https://github.com/apache/apisix-dashboard/runs/1281941323
This is an automated message from the Apache Git Service.
To respond to
nic-chen commented on issue #568:
URL:
https://github.com/apache/apisix-dashboard/issues/568#issuecomment-712942988
@ShiningRush please take a look~
This is an automated message from the Apache Git Service.
To respond to
nic-chen opened a new issue #571:
URL: https://github.com/apache/apisix-dashboard/issues/571
here is the list:
/apisix/admin/schema/*
/apisix/admin/plugin_metadata
/apisix/admin/global_rules
/apisix/admin/plugins/*
/apisix/admin/stream_routes
not used in dashboard, but
moonming closed issue #1617:
URL: https://github.com/apache/apisix/issues/1617
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
moonming commented on pull request #1989:
URL: https://github.com/apache/apisix/pull/1989#issuecomment-713272299
@frank0417 @membphis ping
This is an automated message from the Apache Git Service.
To respond to the message,
moonming commented on issue #2467:
URL: https://github.com/apache/apisix/issues/2467#issuecomment-713272710
I don't think this the job of Apache APISIX
This is an automated message from the Apache Git Service.
To respond to
moonming opened a new pull request #2481:
URL: https://github.com/apache/apisix/pull/2481
### What this PR does / why we need it:
Using this script we can generate the release package more quickly
### Pre-submission checklist:
* [ ] Did you explain what problem does
membphis commented on issue #2482:
URL: https://github.com/apache/apisix/issues/2482#issuecomment-713315308
@spacewander do you have time to look at this issue?
This is an automated message from the Apache Git Service.
To
membphis commented on issue #2467:
URL: https://github.com/apache/apisix/issues/2467#issuecomment-713322581
> if user limits too small(like 1024), APISIX should prompt to modify,
otherwise, the performance is low
We need this kind of prompt.
If CLI can find some environment
moonming closed pull request #1376:
URL: https://github.com/apache/apisix/pull/1376
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
moonming commented on pull request #2225:
URL: https://github.com/apache/apisix/pull/2225#issuecomment-713267619
@EnableAsync any update?
This is an automated message from the Apache Git Service.
To respond to the message,
moonming merged pull request #2480:
URL: https://github.com/apache/apisix/pull/2480
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
wenming pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new a5f5c1f doc: Consule=>Consul (#2480)
a5f5c1f
1 - 100 of 148 matches
Mail list logo
