Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Dmitry Lychagin has submitted this change and it was merged.
Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in
TypeComputeUtils.getResultType()
..
[ASTERIXDB-2445][COMP] Nullable category handling in
TypeComputeUtils.getResultType()
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- TypeComputeUtils.getResultType() currently makes the output type unknownable
when
nullable category is passed. It should make it nullable instead
Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2932
Sonar-Qube: Jenkins
Tested-by: Jenkins
Contrib: Jenkins
Integration-Tests: Jenkins
Reviewed-by: abdullah alamoudi
---
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Anon. E. Moose #1000171:
abdullah alamoudi: Looks good to me, approved
Jenkins: Verified; No violations found; ; Verified
diff --git
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java
index 448ab4c..f1f1be3 100644
---
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java
+++
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java
@@ -168,8 +168,9 @@
}
IAType resultType = type;
if ((category & NULLABLE) != 0 || (category & NULL) != 0) {
-resultType = AUnionType.createUnknownableType(resultType);
-} else if ((category & MISSABLE) != 0 || (category & MISSING) != 0) {
+resultType = AUnionType.createNullableType(resultType);
+}
+if ((category & MISSABLE) != 0 || (category & MISSING) != 0) {
resultType = AUnionType.createMissableType(resultType);
}
return resultType;
--
To view, visit https://asterix-gerrit.ics.uci.edu/2932
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
abdullah alamoudi has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 2: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/1yYA2K : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7248/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 2: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3632/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3632/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4775/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4334/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7248/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/3CGhVR : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4643/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4813/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/612/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8361/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4981/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2435/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4424/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/687/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4389/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4423/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9900/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Hello Anon. E. Moose #1000171, abdullah alamoudi, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2932 to look at the new patch set (#2). Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() - user model changes: no - storage format changes: no - interface changes: no Details: - TypeComputeUtils.getResultType() currently makes the output type unknownable when nullable category is passed. It should make it nullable instead Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 --- M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/32/2932/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
abdullah alamoudi has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Somehow, I am surprised it passed. but I am glad that it did too -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
abdullah alamoudi has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7239/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/dGHkoh : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3630/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3630/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4767/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/ibjeG8 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4326/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7239/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4416/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4415/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8353/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4805/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9892/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4973/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/685/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4635/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/610/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2427/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Dmitry Lychagin has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2932
Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in
TypeComputeUtils.getResultType()
..
[ASTERIXDB-2445][COMP] Nullable category handling in
TypeComputeUtils.getResultType()
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- TypeComputeUtils.getResultType() currently makes the output type unknowable
when
nullable category is passed. It should make it nullable instead
Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1
---
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/32/2932/1
diff --git
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java
index 448ab4c..f1f1be3 100644
---
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java
+++
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java
@@ -168,8 +168,9 @@
}
IAType resultType = type;
if ((category & NULLABLE) != 0 || (category & NULL) != 0) {
-resultType = AUnionType.createUnknownableType(resultType);
-} else if ((category & MISSABLE) != 0 || (category & MISSING) != 0) {
+resultType = AUnionType.createNullableType(resultType);
+}
+if ((category & MISSABLE) != 0 || (category & MISSING) != 0) {
resultType = AUnionType.createMissableType(resultType);
}
return resultType;
--
To view, visit https://asterix-gerrit.ics.uci.edu/2932
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin
Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in TypeComputeUtils.getResultType() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4381/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
