Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 3: Analytics Compatibility Tests Successful https://goo.gl/niSben : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Murtadha Hubail has submitted this change and it was merged.
Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
..
[NO ISSUE][OTR] Eliminate Per Tuple Object Creation
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Replace unneeded LinkedList by ArrayList in
ChainedLSMDiskComponentBulkLoader and eliminate
iterator creation per tuple.
- Eliminate iterator creation per tuple in LSMHarness.
Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2587
Sonar-Qube: Jenkins
Reviewed-by: Murtadha Hubail
Integration-Tests: Jenkins
Tested-by: Jenkins
Contrib: Jenkins
Reviewed-by: Michael Blow
---
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ChainedLSMDiskComponentBulkLoader.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
A
hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/annotations/CriticalPath.java
3 files changed, 69 insertions(+), 20 deletions(-)
Approvals:
Jenkins: Verified; No violations found; ; Verified
Michael Blow: Looks good to me, approved
Murtadha Hubail: Looks good to me, but someone else must approve
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ChainedLSMDiskComponentBulkLoader.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ChainedLSMDiskComponentBulkLoader.java
index f38614c..abb0c76 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ChainedLSMDiskComponentBulkLoader.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ChainedLSMDiskComponentBulkLoader.java
@@ -18,20 +18,21 @@
*/
package org.apache.hyracks.storage.am.lsm.common.impls;
-import java.util.LinkedList;
+import java.util.ArrayList;
import java.util.List;
import org.apache.hyracks.api.exceptions.HyracksDataException;
import org.apache.hyracks.dataflow.common.data.accessors.ITupleReference;
import org.apache.hyracks.storage.am.lsm.common.api.ILSMDiskComponent;
import
org.apache.hyracks.storage.am.lsm.common.api.ILSMDiskComponentBulkLoader;
+import org.apache.hyracks.util.annotations.CriticalPath;
/**
* Class encapsulates a chain of operations, happening during an LSM disk
component bulkload
*/
public class ChainedLSMDiskComponentBulkLoader implements
ILSMDiskComponentBulkLoader {
-private List bulkloaderChain = new
LinkedList<>();
+private List bulkloaderChain = new
ArrayList<>();
private boolean isEmptyComponent = true;
private boolean cleanedUpArtifacts = false;
private final ILSMDiskComponent diskComponent;
@@ -47,11 +48,13 @@
}
@Override
+@CriticalPath
public void add(ITupleReference tuple) throws HyracksDataException {
try {
ITupleReference t = tuple;
-for (IChainedComponentBulkLoader lsmBulkloader : bulkloaderChain) {
-t = lsmBulkloader.add(t);
+final int bulkloadersCount = bulkloaderChain.size();
+for (int i = 0; i < bulkloadersCount; i++) {
+t = bulkloaderChain.get(i).add(t);
}
} catch (Exception e) {
cleanupArtifacts();
@@ -63,11 +66,13 @@
}
@Override
+@CriticalPath
public void delete(ITupleReference tuple) throws HyracksDataException {
try {
ITupleReference t = tuple;
-for (IChainedComponentBulkLoader lsmOperation : bulkloaderChain) {
-t = lsmOperation.delete(t);
+final int bulkloadersCount = bulkloaderChain.size();
+for (int i = 0; i < bulkloadersCount; i++) {
+t = bulkloaderChain.get(i).delete(t);
}
} catch (Exception e) {
cleanupArtifacts();
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
index 59f48d4..1dbaa3c 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
@@ -54,6 +54,7 @@
import org.apache.hyracks.storage.am.lsm.common.util.IOOperationUtils;
import org.apache.hyracks.storage.common.IIndexCursor;
import org.apache.hyrack
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Michael Blow has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 3: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 3: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3056/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 3: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3056/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 3: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6224/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 3: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 2: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/y8PqjR : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 3: Analytics Compatibility Compilation Successful https://goo.gl/Jmv5gQ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6224/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3801/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3564/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Murtadha Hubail has posted comments on this change.
Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
..
Patch Set 1:
(6 comments)
https://asterix-gerrit.ics.uci.edu/#/c/2587/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ChainedLSMDiskComponentBulkLoader.java
File
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ChainedLSMDiskComponentBulkLoader.java:
PS1, Line 55: for (int i = 0; i < bulkloaderChain.size(); i++) {
: t = bulkloaderChain.get(i).add(t);
: }
> can we make IChainedComponentBulkLoader.add() not throw checked exceptions?
Done. ForEach() will still create an iterator.
PS1, Line 72: for (int i = 0; i < bulkloaderChain.size(); i++) {
: t = bulkloaderChain.get(i).delete(t);
: }
> can we make IChainedComponentBulkLoader.delete() not throw checked exceptio
Done. ForEach() will still create an iterator.
https://asterix-gerrit.ics.uci.edu/#/c/2587/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
File
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java:
PS1, Line 192: components.size()
> make invariant
Done
PS1, Line 208: components.size()
> make invariant
Done
PS1, Line 379: ctx.getComponentHolder()
> extract local
Done
PS1, Line 379: ctx.getComponentHolder().size()
> make loop invariant
Done
--
To view, visit https://asterix-gerrit.ics.uci.edu/2587
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: Murtadha Hubail
Gerrit-Reviewer: Till Westmann
Gerrit-Reviewer: abdullah alamoudi
Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4063/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3880/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1356/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3780/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2587 to look at the new patch set (#3). Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. [NO ISSUE][OTR] Eliminate Per Tuple Object Creation - user model changes: no - storage format changes: no - interface changes: no Details: - Replace unneeded LinkedList by ArrayList in ChainedLSMDiskComponentBulkLoader and eliminate iterator creation per tuple. - Eliminate iterator creation per tuple in LSMHarness. Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 --- M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ChainedLSMDiskComponentBulkLoader.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java A hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/annotations/CriticalPath.java 3 files changed, 69 insertions(+), 20 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/87/2587/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3337/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3308/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3261/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3349/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7294/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8812/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6223/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/CE3d6q : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3779/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3879/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3336/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2587 to look at the new patch set (#2). Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. [NO ISSUE][OTR] Eliminate Per Tuple Object Creation - user model changes: no - storage format changes: no - interface changes: no Details: - Replace unneeded LinkedList by ArrayList in ChainedLSMDiskComponentBulkLoader and eliminate iterator creation per tuple. - Eliminate iterator creation per tuple in LSMHarness. Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 --- M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ChainedLSMDiskComponentBulkLoader.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java A hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/annotations/CriticalPath.java 3 files changed, 67 insertions(+), 19 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/87/2587/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8811/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7293/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3307/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3800/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3348/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3260/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3563/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1355/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4062/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Michael Blow has posted comments on this change.
Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
..
Patch Set 1:
(6 comments)
https://asterix-gerrit.ics.uci.edu/#/c/2587/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ChainedLSMDiskComponentBulkLoader.java
File
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ChainedLSMDiskComponentBulkLoader.java:
PS1, Line 55: for (int i = 0; i < bulkloaderChain.size(); i++) {
: t = bulkloaderChain.get(i).add(t);
: }
can we make IChainedComponentBulkLoader.add() not throw checked exceptions?
then we can use bulkloaderChain.forEach(). Otherwise, let's at least make
size() a loop invariant.
PS1, Line 72: for (int i = 0; i < bulkloaderChain.size(); i++) {
: t = bulkloaderChain.get(i).delete(t);
: }
can we make IChainedComponentBulkLoader.delete() not throw checked exceptions?
then we can use bulkloaderChain.forEach(). Otherwise, let's at least make
size() a loop invariant.
https://asterix-gerrit.ics.uci.edu/#/c/2587/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
File
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java:
PS1, Line 192: components.size()
make invariant
PS1, Line 208: components.size()
make invariant
PS1, Line 379: ctx.getComponentHolder()
extract local
PS1, Line 379: ctx.getComponentHolder().size()
make loop invariant
--
To view, visit https://asterix-gerrit.ics.uci.edu/2587
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: Murtadha Hubail
Gerrit-Reviewer: Till Westmann
Gerrit-Reviewer: abdullah alamoudi
Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 1: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6217/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3053/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/xJHsPT : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3053/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/9eMeGK : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6217/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4055/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3253/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3328/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3794/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3772/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7286/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1348/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8804/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3872/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3341/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3556/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Murtadha Hubail has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2587
Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
..
[NO ISSUE][OTR] Eliminate Per Tuple Object Creation
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Replace unneeded LinkedList by ArrayList in
ChainedLSMDiskComponentBulkLoader and eliminate
iterator creation per tuple.
- Eliminate iterator creation per tuple in LSMHarness.
Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119
---
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ChainedLSMDiskComponentBulkLoader.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
A
hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/annotations/CriticalPath.java
3 files changed, 61 insertions(+), 18 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/87/2587/1
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ChainedLSMDiskComponentBulkLoader.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ChainedLSMDiskComponentBulkLoader.java
index f38614c..8da6909 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ChainedLSMDiskComponentBulkLoader.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ChainedLSMDiskComponentBulkLoader.java
@@ -18,20 +18,21 @@
*/
package org.apache.hyracks.storage.am.lsm.common.impls;
-import java.util.LinkedList;
+import java.util.ArrayList;
import java.util.List;
import org.apache.hyracks.api.exceptions.HyracksDataException;
import org.apache.hyracks.dataflow.common.data.accessors.ITupleReference;
import org.apache.hyracks.storage.am.lsm.common.api.ILSMDiskComponent;
import
org.apache.hyracks.storage.am.lsm.common.api.ILSMDiskComponentBulkLoader;
+import org.apache.hyracks.util.annotations.CriticalPath;
/**
* Class encapsulates a chain of operations, happening during an LSM disk
component bulkload
*/
public class ChainedLSMDiskComponentBulkLoader implements
ILSMDiskComponentBulkLoader {
-private List bulkloaderChain = new
LinkedList<>();
+private List bulkloaderChain = new
ArrayList<>();
private boolean isEmptyComponent = true;
private boolean cleanedUpArtifacts = false;
private final ILSMDiskComponent diskComponent;
@@ -47,11 +48,12 @@
}
@Override
+@CriticalPath
public void add(ITupleReference tuple) throws HyracksDataException {
try {
ITupleReference t = tuple;
-for (IChainedComponentBulkLoader lsmBulkloader : bulkloaderChain) {
-t = lsmBulkloader.add(t);
+for (int i = 0; i < bulkloaderChain.size(); i++) {
+t = bulkloaderChain.get(i).add(t);
}
} catch (Exception e) {
cleanupArtifacts();
@@ -63,11 +65,12 @@
}
@Override
+@CriticalPath
public void delete(ITupleReference tuple) throws HyracksDataException {
try {
ITupleReference t = tuple;
-for (IChainedComponentBulkLoader lsmOperation : bulkloaderChain) {
-t = lsmOperation.delete(t);
+for (int i = 0; i < bulkloaderChain.size(); i++) {
+t = bulkloaderChain.get(i).delete(t);
}
} catch (Exception e) {
cleanupArtifacts();
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
index 59f48d4..cae10ba 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
@@ -54,6 +54,7 @@
import org.apache.hyracks.storage.am.lsm.common.util.IOOperationUtils;
import org.apache.hyracks.storage.common.IIndexCursor;
import org.apache.hyracks.storage.common.ISearchPredicate;
+import org.apache.hyracks.util.annotations.CriticalPath;
import org.apache.hyracks.util.trace.ITracer;
import org.apache.hyracks.util.trace.ITracer.Scope;
import org.apache.logging.log4j.Level;
@@ -180,6 +181,7 @@
}
}
+@CriticalPath
protected boolean enterComponents(ILSMIndexOperationContext ctx,
LSMOperati
Change in asterixdb[master]: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3300/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
