Change in asterixdb[master]: Fix ASTERIXDB-1776

[Ian Maxon (Code Review)]

Ian Maxon has submitted this change and it was merged.

Change subject: Fix ASTERIXDB-1776
..


Fix ASTERIXDB-1776

The source of the issue was a deprecated method that failed when two
IODevices share a common prefix in their absolute path

Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1489
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
BAD: Jenkins 
Reviewed-by: Yingyi Bu 
Integration-Tests: Jenkins 
---
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java
M hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-common-test/pom.xml
A 
hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-common-test/src/test/java/org/apache/hyracks/storage/common/IOManagerPathTest.java
5 files changed, 85 insertions(+), 1 deletion(-)

Approvals:
  Yingyi Bu: Looks good to me, approved
  Jenkins: Verified; No violations found; No violations found; Verified



diff --git 
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
 
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
index 963e123..d094368 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
@@ -47,6 +47,8 @@
 public static final int NO_SUCH_NODE = 10;
 public static final int CLASS_LOADING_ISSUE = 11;
 public static final int ILLEGAL_WRITE_AFTER_FLUSH_ATTEMPT = 12;
+public static final int DUPLICATE_IODEVICE = 13;
+public static final int NESTED_IODEVICES = 14;
 
 // Compilation error codes.
 public static final int RULECOLLECTION_NOT_INSTANCE_OF_LIST = 10001;
diff --git 
a/hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
 
b/hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
index 6b74b54..72f7c65 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
+++ 
b/hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
@@ -31,5 +31,7 @@
 10 = Node %1$s does not exist
 11 = Class loading issue: %1$s
 12 = Invalid attempt to write to a flushed append only metadata page
+13 = Duplicate IODevices are not allowed
+14 = IODevices should not be nested within each other
 
 1 = The given rule collection %1$s is not an instance of the List class.
diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java
index 05c9f07..5ccdaa8 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java
@@ -23,6 +23,8 @@
 import java.io.IOException;
 import java.nio.ByteBuffer;
 import java.nio.channels.FileChannel;
+import java.nio.file.Path;
+import java.nio.file.Paths;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
@@ -62,6 +64,7 @@
 
 public IOManager(List devices) throws HyracksDataException 
{
 this.ioDevices = Collections.unmodifiableList(devices);
+checkDeviceValidity(devices);
 workspaces = new ArrayList<>();
 for (IODeviceHandle d : ioDevices) {
 if (d.getWorkspace() != null) {
@@ -74,6 +77,23 @@
 }
 workspaceIndex = 0;
 deviceComputer = new DefaultDeviceComputer(this);
+}
+
+private void checkDeviceValidity(List devices) throws 
HyracksDataException {
+for (IODeviceHandle d : devices) {
+Path p = Paths.get(d.getMount().toURI());
+for (IODeviceHandle e : devices) {
+if (e != d) {
+Path q = Paths.get(e.getMount().toURI());
+if (p.equals(q)) {
+throw 
HyracksDataException.create(ErrorCode.DUPLICATE_IODEVICE);
+} else if (p.startsWith(q)) {
+throw 
HyracksDataException.create(ErrorCode.NESTED_IODEVICES);
+}
+}
+}
+
+}
 }
 
 @Override
@@ -350,8 +370,9 @@
 }
 
 public IODeviceHandle 

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Ian Maxon (Code Review)]

Ian Maxon has uploaded a new patch set (#6).

Change subject: Fix ASTERIXDB-1776
..

Fix ASTERIXDB-1776

The source of the issue was a deprecated method that failed when two
IODevices share a common prefix in their absolute path

Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
---
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java
M hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-common-test/pom.xml
A 
hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-common-test/src/test/java/org/apache/hyracks/storage/common/IOManagerPathTest.java
5 files changed, 85 insertions(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/89/1489/6
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 6: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1828/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 6:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1828/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 6:

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1827/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 6:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1827/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 6: Integration-Tests-1

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1824/ 
: ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 6:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1824/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 6: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/492/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 6:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/492/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4209/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Ian Maxon (Code Review)]

Hello abdullah alamoudi, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1489

to look at the new patch set (#6).

Change subject: Fix ASTERIXDB-1776
..

Fix ASTERIXDB-1776

The source of the issue was a deprecated method that failed when two
IODevices share a common prefix in their absolute path

Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
---
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java
M hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-common-test/pom.xml
A 
hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-common-test/src/test/java/org/apache/hyracks/storage/common/IOManagerPathTest.java
5 files changed, 85 insertions(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/89/1489/6
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Ian Maxon (Code Review)]

Ian Maxon has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 4:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1489/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java:

PS4, Line 86: e
> flip the condition such that you only need one if branch and do not need "c
Done


PS4, Line 91: HyracksDataException
> Use error code.
Done


PS4, Line 93: HyracksDataException
> Use error code
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Ian Maxon (Code Review)]

Hello abdullah alamoudi, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1489

to look at the new patch set (#5).

Change subject: Fix ASTERIXDB-1776
..

Fix ASTERIXDB-1776

The source of the issue was a deprecated method that failed when two
IODevices share a common prefix in their absolute path

Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
---
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java
M hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-common-test/pom.xml
A 
hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-common-test/src/test/java/org/apache/hyracks/storage/common/IOManagerPathTest.java
5 files changed, 86 insertions(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/89/1489/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4208/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 4:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1489/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java:

PS4, Line 91: HyracksDataException
Use error code.


PS4, Line 93: HyracksDataException
Use error code


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 4: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1818/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 4: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/486/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1818/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 4:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/486/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1776

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4202/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Ian Maxon (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1489

to look at the new patch set (#4).

Change subject: Fix ASTERIXDB-1776
..

Fix ASTERIXDB-1776

The source of the issue was a deprecated method that failed when two
IODevices share a common prefix in their absolute path

Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java
M hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-common-test/pom.xml
A 
hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-common-test/src/test/java/org/apache/hyracks/storage/common/IOManagerPathTest.java
3 files changed, 83 insertions(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/89/1489/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Ian Maxon (Code Review)]

Ian Maxon has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 2:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1489/2/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java:

PS2, Line 70: (e.equals(d)
> I am pretty sure having two IO devices with the same mount points will crea
That is true. Fixed.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4201/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Ian Maxon (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1489

to look at the new patch set (#3).

Change subject: Fix ASTERIXDB-1776
..

Fix ASTERIXDB-1776

The source of the issue was a deprecated method that failed when two
IODevices share a common prefix in their absolute path

Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java
A 
hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-common-test/src/test/java/org/apache/hyracks/storage/common/IOManagerPathTest.java
2 files changed, 79 insertions(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/89/1489/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1814/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1776

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 2:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1489/2/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java:

PS2, Line 70: (e.equals(d)
> I didn't look at it when I wrote this, I just sort of asserted it did the "
I am pretty sure having two IO devices with the same mount points will create a 
lot of issues.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 2: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/482/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/482/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1814/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Ian Maxon (Code Review)]

Ian Maxon has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 2:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1489/2/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java:

PS2, Line 70: (e.equals(d)
> should we make this e == d instead.
I didn't look at it when I wrote this, I just sort of asserted it did the 
"right" thing. However it doesn't seem too bad to me? Either the objects are 
identical or the mountpoints are the same string value, which is also fine. All 
I want to check for here is that there aren't two mount points that are like 
/mnt/sda/ and /mnt/sda/sdb/ , which is possible.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fix ASTERIXDB-1776

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 2:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1489/2/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java:

PS2, Line 70: (e.equals(d)
should we make this e == d instead.
This way we ensure that no two IO devices have the exact same path?
Look at the equals implementation.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4197/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix ASTERIXDB-1776
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4196/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Ian Maxon (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1489

to look at the new patch set (#2).

Change subject: Fix ASTERIXDB-1776
..

Fix ASTERIXDB-1776

The source of the issue was a deprecated method that failed when two
IODevices share a common prefix in their absolute path

Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java
A 
hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-common-test/src/test/java/org/apache/hyracks/storage/common/IOManagerPathTest.java
2 files changed, 59 insertions(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/89/1489/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Fix ASTERIXDB-1776

[Ian Maxon (Code Review)]

Ian Maxon has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1489

Change subject: Fix ASTERIXDB-1776
..

Fix ASTERIXDB-1776

The source of the issue was a deprecated method that failed when two
IODevices share a common prefix in their absolute path

Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java
A 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/test/java/org/apache/hyracks/storage/am/common/IOManagerPathTest.java
2 files changed, 41 insertions(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/89/1489/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java
index 05c9f07..93790c2 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java
@@ -23,6 +23,8 @@
 import java.io.IOException;
 import java.nio.ByteBuffer;
 import java.nio.channels.FileChannel;
+import java.nio.file.Path;
+import java.nio.file.Paths;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
@@ -62,6 +64,20 @@
 
 public IOManager(List devices) throws HyracksDataException 
{
 this.ioDevices = Collections.unmodifiableList(devices);
+for (IODeviceHandle d : ioDevices) {
+Path p = Paths.get(d.getMount().toURI());
+for (IODeviceHandle e : ioDevices) {
+if (e.equals(d)) {
+continue;
+} else {
+Path q = Paths.get(e.getMount().toURI());
+if (p.startsWith(q)) {
+throw new HyracksDataException("IODevices shouldn't be 
on a union mount.");
+}
+}
+}
+
+}
 workspaces = new ArrayList<>();
 for (IODeviceHandle d : ioDevices) {
 if (d.getWorkspace() != null) {
@@ -350,8 +366,9 @@
 }
 
 public IODeviceHandle getDevice(String fullPath) {
+Path full = Paths.get(fullPath);
 for (IODeviceHandle d : ioDevices) {
-if (fullPath.startsWith(d.getMount().getAbsolutePath())) {
+if (full.startsWith(Paths.get(d.getMount().getAbsolutePath( {
 return d;
 }
 }
diff --git 
a/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/test/java/org/apache/hyracks/storage/am/common/IOManagerPathTest.java
 
b/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/test/java/org/apache/hyracks/storage/am/common/IOManagerPathTest.java
new file mode 100644
index 000..59cb8c1
--- /dev/null
+++ 
b/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/test/java/org/apache/hyracks/storage/am/common/IOManagerPathTest.java
@@ -0,0 +1,23 @@
+package org.apache.hyracks.storage.am.common;
+
+import org.apache.hyracks.api.exceptions.HyracksDataException;
+import org.apache.hyracks.api.io.FileReference;
+import org.apache.hyracks.api.io.IODeviceHandle;
+import org.apache.hyracks.control.nc.io.IOManager;
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.io.File;
+import java.util.ArrayList;
+import java.util.Arrays;
+
+public class IOManagerPathTest {
+@Test
+public void test() throws HyracksDataException {
+IODeviceHandle shorter = new IODeviceHandle(new File("/tmp/1"), 
"storage");
+IODeviceHandle longer = new IODeviceHandle(new File("/tmp/11"), 
"storage");
+IOManager ioManager = new IOManager(Arrays.asList(new IODeviceHandle[] 
{ shorter, longer }));
+FileReference f = 
ioManager.resolveAbsolutePath("/tmp/11/storage/Foo_idx_foo/my_btree");
+Assert.assertEquals("/tmp/11/storage/Foo_idx_foo/my_btree", 
f.getAbsolutePath());
+}
+}

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon