[GitHub] rnewson commented on a change in pull request #721: Save migrated replicator checkpoint documents immediately

2017-07-31 Thread git
rnewson commented on a change in pull request #721: Save migrated replicator checkpoint documents immediately URL: https://github.com/apache/couchdb/pull/721#discussion_r130389135 ## File path: src/couch_replicator/src/couch_replicator_scheduler_job.erl ## @@ -632,11

[GitHub] nickva commented on issue #726: Provide a more accurate size check for max_document_size limit

2017-07-31 Thread git
nickva commented on issue #726: Provide a more accurate size check for max_document_size limit URL: https://github.com/apache/couchdb/pull/726#issuecomment-319113373 @tonysun83 It really needs some benchmarking to get an idea what impact it has. If it has a serious impact the idea

[GitHub] tonysun83 commented on issue #726: Provide a more accurate size check for max_document_size limit

2017-07-31 Thread git
tonysun83 commented on issue #726: Provide a more accurate size check for max_document_size limit URL: https://github.com/apache/couchdb/pull/726#issuecomment-319101463 Great starting point Nick! So IIUC, the current assumption is that this new module is slower than jiffy...but it

[GitHub] nickva commented on a change in pull request #721: Save migrated replicator checkpoint documents immediately

2017-07-31 Thread git
nickva commented on a change in pull request #721: Save migrated replicator checkpoint documents immediately URL: https://github.com/apache/couchdb/pull/721#discussion_r130390772 ## File path: src/couch_replicator/src/couch_replicator_scheduler_job.erl ## @@ -632,11

[GitHub] rnewson commented on a change in pull request #605: Add Prefer: return=minimal support

2017-07-31 Thread git
rnewson commented on a change in pull request #605: Add Prefer: return=minimal support URL: https://github.com/apache/couchdb/pull/605#discussion_r130332401 ## File path: src/chttpd/src/chttpd_prefer_header.erl ## @@ -0,0 +1,54 @@ +% Licensed under the Apache License,

[GitHub] rnewson commented on a change in pull request #605: Add Prefer: return=minimal support

2017-07-31 Thread git
rnewson commented on a change in pull request #605: Add Prefer: return=minimal support URL: https://github.com/apache/couchdb/pull/605#discussion_r130332309 ## File path: rel/overlay/etc/default.ini ## @@ -57,6 +57,9 @@ backlog = 512 docroot = {{fauxton_root}}

[GitHub] garrensmith commented on a change in pull request #938: Refactor CORS tests to run with Jest and Enzyme

2017-07-31 Thread git
garrensmith commented on a change in pull request #938: Refactor CORS tests to run with Jest and Enzyme URL: https://github.com/apache/couchdb-fauxton/pull/938#discussion_r130361730 ## File path: app/addons/cors/__tests__/components.test.js ## @@ -0,0 +1,215 @@ +//

[GitHub] garrensmith commented on a change in pull request #938: Refactor CORS tests to run with Jest and Enzyme

2017-07-31 Thread git
garrensmith commented on a change in pull request #938: Refactor CORS tests to run with Jest and Enzyme URL: https://github.com/apache/couchdb-fauxton/pull/938#discussion_r130361313 ## File path: app/addons/cors/__tests__/components.test.js ## @@ -0,0 +1,215 @@ +//

[GitHub] garrensmith commented on a change in pull request #938: Refactor CORS tests to run with Jest and Enzyme

2017-07-31 Thread git
garrensmith commented on a change in pull request #938: Refactor CORS tests to run with Jest and Enzyme URL: https://github.com/apache/couchdb-fauxton/pull/938#discussion_r130362139 ## File path: app/addons/cors/__tests__/resources.test.js ## @@ -13,32 +13,32 @@ import

[GitHub] garrensmith commented on a change in pull request #938: Refactor CORS tests to run with Jest and Enzyme

2017-07-31 Thread git
garrensmith commented on a change in pull request #938: Refactor CORS tests to run with Jest and Enzyme URL: https://github.com/apache/couchdb-fauxton/pull/938#discussion_r130361381 ## File path: app/addons/cors/__tests__/components.test.js ## @@ -0,0 +1,215 @@ +//

[GitHub] garrensmith commented on a change in pull request #938: Refactor CORS tests to run with Jest and Enzyme

2017-07-31 Thread git
garrensmith commented on a change in pull request #938: Refactor CORS tests to run with Jest and Enzyme URL: https://github.com/apache/couchdb-fauxton/pull/938#discussion_r130362652 ## File path: app/addons/cors/components.js ## @@ -334,6 +334,7 @@ var CORSController =

[GitHub] garrensmith commented on a change in pull request #938: Refactor CORS tests to run with Jest and Enzyme

2017-07-31 Thread git
garrensmith commented on a change in pull request #938: Refactor CORS tests to run with Jest and Enzyme URL: https://github.com/apache/couchdb-fauxton/pull/938#discussion_r130361585 ## File path: app/addons/cors/__tests__/components.test.js ## @@ -0,0 +1,215 @@ +//

[GitHub] garrensmith commented on a change in pull request #938: Refactor CORS tests to run with Jest and Enzyme

2017-07-31 Thread git
garrensmith commented on a change in pull request #938: Refactor CORS tests to run with Jest and Enzyme URL: https://github.com/apache/couchdb-fauxton/pull/938#discussion_r130362276 ## File path: app/addons/cors/__tests__/stores.test.js ## @@ -14,30 +14,30 @@ import

[GitHub] wohali closed issue #727: Make couchdb 2 cross compile friendly

2017-07-31 Thread git
wohali closed issue #727: Make couchdb 2 cross compile friendly URL: https://github.com/apache/couchdb/issues/727 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] wohali commented on issue #727: Make couchdb 2 cross compile friendly

2017-07-31 Thread git
wohali commented on issue #727: Make couchdb 2 cross compile friendly URL: https://github.com/apache/couchdb/issues/727#issuecomment-319094325 This is basically a duplicate of #546. This is an automated message from the

[GitHub] Antonio-Maranhao commented on issue #938: Refactor CORS tests to run with Jest and Enzyme

2017-07-31 Thread git
Antonio-Maranhao commented on issue #938: Refactor CORS tests to run with Jest and Enzyme URL: https://github.com/apache/couchdb-fauxton/pull/938#issuecomment-319060611 @garrensmith all done. Ready for review. This is an

[GitHub] Schoumi opened a new issue #727: Make couchdb 2 cross compile friendly

2017-07-31 Thread git
Schoumi opened a new issue #727: Make couchdb 2 cross compile friendly URL: https://github.com/apache/couchdb/issues/727 Couchdb can't be cross-compile at this time (or haven't found the way to do so) and this is very unfortunate. It make not simple or impossible to build package for

[GitHub] nickva opened a new pull request #726: Provide a more accurate size check for max_document_size limit

2017-07-31 Thread git
nickva opened a new pull request #726: Provide a more accurate size check for max_document_size limit URL: https://github.com/apache/couchdb/pull/726 max_document_size currently checks document sizes based on Erlang's external term size of the jiffy-decoded document body. This makes

[GitHub] nickva closed pull request #728: Increase timeouts in replicator compactor tests

2017-07-31 Thread git
nickva closed pull request #728: Increase timeouts in replicator compactor tests URL: https://github.com/apache/couchdb/pull/728 This is an automated message from the Apache Git Service. To respond to the message, please

[Jenkins] FAILURE: CouchDB » master #28

2017-07-31 Thread Apache Jenkins Server
Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/28/

[GitHub] nickva closed issue #725: Replicator compact test timing out

2017-07-31 Thread git
nickva closed issue #725: Replicator compact test timing out URL: https://github.com/apache/couchdb/issues/725 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[Jenkins] FAILURE: CouchDB » master #25

2017-07-31 Thread Apache Jenkins Server
Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/25/

[GitHub] Antonio-Maranhao commented on a change in pull request #938: Refactor CORS tests to run with Jest and Enzyme

2017-07-31 Thread git
Antonio-Maranhao commented on a change in pull request #938: Refactor CORS tests to run with Jest and Enzyme URL: https://github.com/apache/couchdb-fauxton/pull/938#discussion_r130439687 ## File path: app/addons/cors/components.js ## @@ -334,6 +334,7 @@ var CORSController

[GitHub] davisp closed pull request #635: Stop indexing activity on ddoc update

2017-07-31 Thread git
davisp closed pull request #635: Stop indexing activity on ddoc update URL: https://github.com/apache/couchdb/pull/635 This is an automated message from the Apache Git Service. To respond to the message, please log on

[Jenkins] FAILURE: CouchDB » master #27

2017-07-31 Thread Apache Jenkins Server
Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/27/

[GitHub] davisp commented on a change in pull request #605: Add Prefer: return=minimal support

2017-07-31 Thread git
davisp commented on a change in pull request #605: Add Prefer: return=minimal support URL: https://github.com/apache/couchdb/pull/605#discussion_r130407831 ## File path: rel/overlay/etc/default.ini ## @@ -57,6 +57,9 @@ backlog = 512 docroot = {{fauxton_root}}

[GitHub] nickva opened a new pull request #728: Increase timeouts in replicator compactor tests

2017-07-31 Thread git
nickva opened a new pull request #728: Increase timeouts in replicator compactor tests URL: https://github.com/apache/couchdb/pull/728 Also decrease number of rounds from 5 to 3. With: `VBoxManage bandwidthctl ${VM} set Limit --limit 100K` It needed over 400 seconds

[GitHub] wohali commented on issue #728: Increase timeouts in replicator compactor tests

2017-07-31 Thread git
wohali commented on issue #728: Increase timeouts in replicator compactor tests URL: https://github.com/apache/couchdb/pull/728#issuecomment-319160466 +1 if tests pass. This is an automated message from the Apache Git

[Jenkins] FAILURE: CouchDB » master #23

2017-07-31 Thread Apache Jenkins Server
Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/23/

[Jenkins] FAILURE: CouchDB » master #24

2017-07-31 Thread Apache Jenkins Server
Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/24/

[Jenkins] FAILURE: CouchDB » master #26

2017-07-31 Thread Apache Jenkins Server
Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/26/

[GitHub] davisp commented on a change in pull request #726: Provide a more accurate size check for max_document_size limit

2017-07-31 Thread git
davisp commented on a change in pull request #726: Provide a more accurate size check for max_document_size limit URL: https://github.com/apache/couchdb/pull/726#discussion_r130408060 ## File path: src/couch/src/couch_ejson_size.erl ## @@ -0,0 +1,55 @@

[GitHub] davisp commented on a change in pull request #726: Provide a more accurate size check for max_document_size limit

2017-07-31 Thread git
davisp commented on a change in pull request #726: Provide a more accurate size check for max_document_size limit URL: https://github.com/apache/couchdb/pull/726#discussion_r130408000 ## File path: src/couch/src/couch_ejson_size.erl ## @@ -0,0 +1,55 @@

[GitHub] Thijxx opened a new issue #729: Hostname is illegal

2017-07-31 Thread git
Thijxx opened a new issue #729: Hostname is illegal URL: https://github.com/apache/couchdb/issues/729 The hostname is always illegal, no matter what I set it to in vm.args. ## Expected Behavior Accept this option in vm.args: `-sname couchdb@pizerogrijs` ## Current

[GitHub] nickva opened a new pull request #730: Fix timeout in couch auth test

2017-07-31 Thread git
nickva opened a new pull request #730: Fix timeout in couch auth test URL: https://github.com/apache/couchdb/pull/730 The test was racy. Use test_util:wait/1 function there just like other places like couch_index_compaction_tests Fixes #724

[GitHub] wohali commented on issue #729: Hostname is illegal

2017-07-31 Thread git
wohali commented on issue #729: Hostname is illegal URL: https://github.com/apache/couchdb/issues/729#issuecomment-319202529 Try using `-name` instead of `-sname` in your `vm.args` file. Then - do you intend to run these in a cluster? Then you need to ensure that the portion that follows

[GitHub] nickva closed pull request #721: Save migrated replicator checkpoint documents immediately

2017-07-31 Thread git
nickva closed pull request #721: Save migrated replicator checkpoint documents immediately URL: https://github.com/apache/couchdb/pull/721 This is an automated message from the Apache Git Service. To respond to the

[Jenkins] FAILURE: CouchDB » master #29

2017-07-31 Thread Apache Jenkins Server
Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/29/

[Jenkins] FAILURE: CouchDB » master #30

2017-07-31 Thread Apache Jenkins Server
Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/30/

[GitHub] nickva closed pull request #689: Make replication ID generation more robust.

2017-07-31 Thread git
nickva closed pull request #689: Make replication ID generation more robust. URL: https://github.com/apache/couchdb/pull/689 This is an automated message from the Apache Git Service. To respond to the message, please log

[Jenkins] FAILURE: CouchDB » master #31

2017-07-31 Thread Apache Jenkins Server
Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/31/

[Jenkins] FAILURE: CouchDB » master #32

2017-07-31 Thread Apache Jenkins Server
Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/32/

[Jenkins] FAILURE: CouchDB » master #33

2017-07-31 Thread Apache Jenkins Server
Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/33/

[GitHub] wohali closed issue #729: Hostname is illegal

2017-07-31 Thread git
wohali closed issue #729: Hostname is illegal URL: https://github.com/apache/couchdb/issues/729 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above

[GitHub] wohali opened a new issue #731: couch epi test failure

2017-07-31 Thread git
wohali opened a new issue #731: couch epi test failure URL: https://github.com/apache/couchdb/issues/731 ``` epi reload tests Check reload for: data_file couch_epi_tests:494: ensure_reload_if_manually_triggered...[0.067 s] ok couch_epi_tests:504:

[Jenkins] FAILURE: CouchDB » 2.1.x #2

2017-07-31 Thread Apache Jenkins Server
Boo, we failed. https://builds.apache.org/job/CouchDB/job/2.1.x/2/