[GitHub] Antonio-Maranhao closed pull request #986: Refactor map/reduce views to use Redux

2017-10-02 Thread git
Antonio-Maranhao closed pull request #986: Refactor map/reduce views to use Redux URL: https://github.com/apache/couchdb-fauxton/pull/986 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] wohali commented on issue #861: Replace deprecated crypto:rand_bytes call

2017-10-02 Thread git
wohali commented on issue #861: Replace deprecated crypto:rand_bytes call URL: https://github.com/apache/couchdb/pull/861#issuecomment-333672660 +1 This is an automated message from the Apache Git Service. To respond to the

[GitHub] couchdb-khash issue #8: Fix iterator expiry test

2017-10-02 Thread wohali
Github user wohali commented on the issue: https://github.com/apache/couchdb-khash/pull/8 +1 once Travis passes ---

[GitHub] wohali commented on issue #860: Remove usage of deprecated random module.

2017-10-02 Thread git
wohali commented on issue #860: Remove usage of deprecated random module. URL: https://github.com/apache/couchdb/pull/860#issuecomment-333688367 +1 but I defer to @rnewson who just recently removed `couch_crypto` about the reasonableness of sticking these function in `couch_util`. Probably

[GitHub] couchdb-khash pull request #8: Fix iterator expiry test

2017-10-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/couchdb-khash/pull/8 ---

[GitHub] Antonio-Maranhao opened a new pull request #986: Refactor map/reduce views to use Redux

2017-10-02 Thread git
Antonio-Maranhao opened a new pull request #986: Refactor map/reduce views to use Redux URL: https://github.com/apache/couchdb-fauxton/pull/986 ## Overview - [x] Updated map/reduce views to use Redux version of IndexResults components - [x] Removed non-Redux components

[GitHub] nickva closed pull request #861: Replace deprecated crypto:rand_bytes call

2017-10-02 Thread git
nickva closed pull request #861: Replace deprecated crypto:rand_bytes call URL: https://github.com/apache/couchdb/pull/861 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] couchdb-khash pull request #8: Fix iterator expiry test

2017-10-02 Thread nickva
GitHub user nickva opened a pull request: https://github.com/apache/couchdb-khash/pull/8 Fix iterator expiry test This test started failing with Erlang 20.0 release. The reason is that opaaque NIF resources stopped being identifed as empty binaries in Erlang so previously

[GitHub] Antonio-Maranhao closed pull request #986: Refactor map/reduce views to use Redux

2017-10-02 Thread git
Antonio-Maranhao closed pull request #986: Refactor map/reduce views to use Redux URL: https://github.com/apache/couchdb-fauxton/pull/986 This is an automated message from the Apache Git Service. To respond to the message,

[Jenkins] FAILURE: CouchDB » master #95

2017-10-02 Thread Apache Jenkins Server
Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/95/

[GitHub] Antonio-Maranhao closed pull request #986: Refactor map/reduce views to use Redux

2017-10-02 Thread git
Antonio-Maranhao closed pull request #986: Refactor map/reduce views to use Redux URL: https://github.com/apache/couchdb-fauxton/pull/986 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] nickva commented on a change in pull request #862: [WIP] Configurably whitelist certain db/docids as valid

2017-10-02 Thread git
nickva commented on a change in pull request #862: [WIP] Configurably whitelist certain db/docids as valid URL: https://github.com/apache/couchdb/pull/862#discussion_r142310651 ## File path: rel/overlay/etc/default.ini ## @@ -49,9 +49,12 @@

[GitHub] Antonio-Maranhao commented on issue #986: Refactor map/reduce views to use Redux

2017-10-02 Thread git
Antonio-Maranhao commented on issue #986: Refactor map/reduce views to use Redux URL: https://github.com/apache/couchdb-fauxton/pull/986#issuecomment-333729669 @garrensmith finally got it to pass. Fixed issue #914 as well since I was modifying that page.

[GitHub] kocolosk commented on issue #602: Security objects cannot be synced if nodes are in maintenance mode

2017-10-02 Thread git
kocolosk commented on issue #602: Security objects cannot be synced if nodes are in maintenance mode URL: https://github.com/apache/couchdb/issues/602#issuecomment-333706653 @janl no, that wasn't what I was suggesting; I was only explaining why this sort of thing tends to not crop up in

[GitHub] Antonio-Maranhao opened a new pull request #986: Refactor map/reduce views to use Redux

2017-10-02 Thread git
Antonio-Maranhao opened a new pull request #986: Refactor map/reduce views to use Redux URL: https://github.com/apache/couchdb-fauxton/pull/986 ## Overview - [x] Updated map/reduce views to use Redux version of IndexResults components - [x] Removed non-Redux components from

[GitHub] Antonio-Maranhao closed pull request #986: Refactor map/reduce views to use Redux

2017-10-02 Thread git
Antonio-Maranhao closed pull request #986: Refactor map/reduce views to use Redux URL: https://github.com/apache/couchdb-fauxton/pull/986 This is an automated message from the Apache Git Service. To respond to the message,

[Jenkins] SUCCESS: CouchDB » master #96

2017-10-02 Thread Apache Jenkins Server
Yay, we passed. https://builds.apache.org/job/CouchDB/job/master/96/

[GitHub] wohali opened a new pull request #862: [WIP] Configurably whitelist certain db/docids as valid

2017-10-02 Thread git
wohali opened a new pull request #862: [WIP] Configurably whitelist certain db/docids as valid URL: https://github.com/apache/couchdb/pull/862 Currently, it is impossible to `PUT/POST` these documents: * `_dbs/_users` * `_dbs/_replicator` * `_dbs/_global_changes` because

[GitHub] garrensmith closed issue #974: Fauxton doesn't handle well all design docs names (with special characters)

2017-10-02 Thread git
garrensmith closed issue #974: Fauxton doesn't handle well all design docs names (with special characters) URL: https://github.com/apache/couchdb-fauxton/issues/974 This is an automated message from the Apache Git Service.

[GitHub] garrensmith closed issue #964: Add back animation to Create database button

2017-10-02 Thread git
garrensmith closed issue #964: Add back animation to Create database button URL: https://github.com/apache/couchdb-fauxton/issues/964 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] garrensmith commented on issue #985: Update React to 15.6.2 (MIT-licensed)

2017-10-02 Thread git
garrensmith commented on issue #985: Update React to 15.6.2 (MIT-licensed) URL: https://github.com/apache/couchdb-fauxton/pull/985#issuecomment-333449236 +1. We can do all the other upgrades when we move to React 16 This is

[GitHub] garrensmith closed issue #966: Fix Modals

2017-10-02 Thread git
garrensmith closed issue #966: Fix Modals URL: https://github.com/apache/couchdb-fauxton/issues/966 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] garrensmith closed issue #970: Fix notification messages

2017-10-02 Thread git
garrensmith closed issue #970: Fix notification messages URL: https://github.com/apache/couchdb-fauxton/issues/970 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] garrensmith closed pull request #985: Update React to 15.6.2 (MIT-licensed)

2017-10-02 Thread git
garrensmith closed pull request #985: Update React to 15.6.2 (MIT-licensed) URL: https://github.com/apache/couchdb-fauxton/pull/985 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] garrensmith closed issue #965: Get Jest tests working with Preact

2017-10-02 Thread git
garrensmith closed issue #965: Get Jest tests working with Preact URL: https://github.com/apache/couchdb-fauxton/issues/965 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] garrensmith closed issue #967: Add back animation in Changes feed

2017-10-02 Thread git
garrensmith closed issue #967: Add back animation in Changes feed URL: https://github.com/apache/couchdb-fauxton/issues/967 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] garrensmith closed issue #969: Remove React from devDependencies

2017-10-02 Thread git
garrensmith closed issue #969: Remove React from devDependencies URL: https://github.com/apache/couchdb-fauxton/issues/969 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] garrensmith closed pull request #968: Move from Reactjs to Preactjs

2017-10-02 Thread git
garrensmith closed pull request #968: Move from Reactjs to Preactjs URL: https://github.com/apache/couchdb-fauxton/pull/968 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] garrensmith closed issue #916: Navigating back to Mango query from result document should preserve Mango query

2017-10-02 Thread git
garrensmith closed issue #916: Navigating back to Mango query from result document should preserve Mango query URL: https://github.com/apache/couchdb-fauxton/issues/916 This is an automated message from the Apache Git

[GitHub] garrensmith commented on issue #916: Navigating back to Mango query from result document should preserve Mango query

2017-10-02 Thread git
garrensmith commented on issue #916: Navigating back to Mango query from result document should preserve Mango query URL: https://github.com/apache/couchdb-fauxton/issues/916#issuecomment-333449427 We now have a list of previously used mango queries you can choose from. And the going back

[GitHub] garrensmith commented on issue #987: Update code editor's contents when a new document is loaded

2017-10-02 Thread git
garrensmith commented on issue #987: Update code editor's contents when a new document is loaded URL: https://github.com/apache/couchdb-fauxton/pull/987#issuecomment-333451548 +1 this looks great. Thanks This is an

[GitHub] garrensmith commented on a change in pull request #986: Refactor map/reduce views to use Redux

2017-10-02 Thread git
garrensmith commented on a change in pull request #986: Refactor map/reduce views to use Redux URL: https://github.com/apache/couchdb-fauxton/pull/986#discussion_r142065354 ## File path: app/addons/documents/index-editor/components/IndexEditor.js ## @@ -0,0 +1,170 @@ +//

[GitHub] garrensmith commented on a change in pull request #986: Refactor map/reduce views to use Redux

2017-10-02 Thread git
garrensmith commented on a change in pull request #986: Refactor map/reduce views to use Redux URL: https://github.com/apache/couchdb-fauxton/pull/986#discussion_r142065307 ## File path: app/addons/documents/index-editor/components/IndexEditor.js ## @@ -0,0 +1,170 @@ +//

[GitHub] garrensmith commented on a change in pull request #986: Refactor map/reduce views to use Redux

2017-10-02 Thread git
garrensmith commented on a change in pull request #986: Refactor map/reduce views to use Redux URL: https://github.com/apache/couchdb-fauxton/pull/986#discussion_r142065413 ## File path: app/addons/documents/index-editor/components/ReduceEditor.js ## @@ -0,0 +1,124 @@ +//

[GitHub] garrensmith commented on a change in pull request #986: Refactor map/reduce views to use Redux

2017-10-02 Thread git
garrensmith commented on a change in pull request #986: Refactor map/reduce views to use Redux URL: https://github.com/apache/couchdb-fauxton/pull/986#discussion_r142067322 ## File path: app/addons/documents/tests/document-test-helper.js ## @@ -26,15 +26,6 @@ function

[GitHub] garrensmith commented on a change in pull request #986: Refactor map/reduce views to use Redux

2017-10-02 Thread git
garrensmith commented on a change in pull request #986: Refactor map/reduce views to use Redux URL: https://github.com/apache/couchdb-fauxton/pull/986#discussion_r142065276 ## File path: app/addons/documents/index-editor/components/IndexEditor.js ## @@ -0,0 +1,170 @@ +//

[GitHub] calonso commented on issue #823: Healthcheck endpoint authentication should be optional

2017-10-02 Thread git
calonso commented on issue #823: Healthcheck endpoint authentication should be optional URL: https://github.com/apache/couchdb/issues/823#issuecomment-333489119 Amazing, thanks!! This is an automated message from the Apache

[GitHub] garrensmith closed pull request #987: Update code editor's contents when a new document is loaded

2017-10-02 Thread git
garrensmith closed pull request #987: Update code editor's contents when a new document is loaded URL: https://github.com/apache/couchdb-fauxton/pull/987 This is an automated message from the Apache Git Service. To respond

[GitHub] natcohen opened a new issue #857: Fuzzy, aggregation and other cool query functions

2017-10-02 Thread git
natcohen opened a new issue #857: Fuzzy, aggregation and other cool query functions URL: https://github.com/apache/couchdb/issues/857 Databases are not only used to store data, they are used to query it very quickly. IMHO one of the weakest point of CouchDB vs MongoDB (even though they

[GitHub] garrensmith commented on a change in pull request #986: Refactor map/reduce views to use Redux

2017-10-02 Thread git
garrensmith commented on a change in pull request #986: Refactor map/reduce views to use Redux URL: https://github.com/apache/couchdb-fauxton/pull/986#discussion_r142065141 ## File path: app/addons/documents/index-editor/components/IndexEditor.js ## @@ -0,0 +1,170 @@ +//

[GitHub] garrensmith commented on a change in pull request #986: Refactor map/reduce views to use Redux

2017-10-02 Thread git
garrensmith commented on a change in pull request #986: Refactor map/reduce views to use Redux URL: https://github.com/apache/couchdb-fauxton/pull/986#discussion_r142064928 ## File path: app/addons/documents/index-editor/components/DesignDocSelector.js ## @@ -0,0 +1,116

[GitHub] garrensmith commented on a change in pull request #986: Refactor map/reduce views to use Redux

2017-10-02 Thread git
garrensmith commented on a change in pull request #986: Refactor map/reduce views to use Redux URL: https://github.com/apache/couchdb-fauxton/pull/986#discussion_r142064808 ## File path: app/addons/documents/index-editor/components.js ## @@ -10,364 +10,15 @@ // License

[GitHub] garrensmith commented on a change in pull request #986: Refactor map/reduce views to use Redux

2017-10-02 Thread git
garrensmith commented on a change in pull request #986: Refactor map/reduce views to use Redux URL: https://github.com/apache/couchdb-fauxton/pull/986#discussion_r142065605 ## File path: app/addons/documents/index-results/api.js ## @@ -17,6 +17,41 @@ import Constants from

[GitHub] garrensmith commented on a change in pull request #986: Refactor map/reduce views to use Redux

2017-10-02 Thread git
garrensmith commented on a change in pull request #986: Refactor map/reduce views to use Redux URL: https://github.com/apache/couchdb-fauxton/pull/986#discussion_r142067253 ## File path: app/addons/documents/sidebar/SidebarControllerContainer.js ## @@ -0,0 +1,126 @@ +//

[GitHub] garrensmith commented on a change in pull request #986: Refactor map/reduce views to use Redux

2017-10-02 Thread git
garrensmith commented on a change in pull request #986: Refactor map/reduce views to use Redux URL: https://github.com/apache/couchdb-fauxton/pull/986#discussion_r142064985 ## File path: app/addons/documents/index-editor/components/DesignDocSelector.js ## @@ -0,0 +1,116

[GitHub] Antonio-Maranhao commented on issue #988: Basic upgrades in preparation for React 16

2017-10-02 Thread git
Antonio-Maranhao commented on issue #988: Basic upgrades in preparation for React 16 URL: https://github.com/apache/couchdb-fauxton/pull/988#issuecomment-333552843 +1 @garrensmith This is an automated message from the

[jira] [Commented] (COUCHDB-3338) rexi_server timeout

2017-10-02 Thread Wilhelm Uschtrin (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-3338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187894#comment-16187894 ] Wilhelm Uschtrin commented on COUCHDB-3338: --- [~tiago.pereira] Did you ever solve this? >

[GitHub] GeorgeAppleton commented on issue #776: Error status zero, Index shutdown by monitor notice for db

2017-10-02 Thread git
GeorgeAppleton commented on issue #776: Error status zero, Index shutdown by monitor notice for db URL: https://github.com/apache/couchdb/issues/776#issuecomment-333525878 Hi wohali, > Root cause that replication fails is that you can't access CouchDB from off-machine. That

[GitHub] GeorgeAppleton closed issue #776: Error status zero, Index shutdown by monitor notice for db

2017-10-02 Thread git
GeorgeAppleton closed issue #776: Error status zero, Index shutdown by monitor notice for db URL: https://github.com/apache/couchdb/issues/776 This is an automated message from the Apache Git Service. To respond to the

[GitHub] garrensmith opened a new pull request #988: Basic upgrades in preparation for React 16

2017-10-02 Thread git
garrensmith opened a new pull request #988: Basic upgrades in preparation for React 16 URL: https://github.com/apache/couchdb-fauxton/pull/988 Some smaller library changes so that we can start preparing to move to React 16.

[GitHub] wohali commented on issue #856: Bypass authentication check for /_up

2017-10-02 Thread git
wohali commented on issue #856: Bypass authentication check for /_up URL: https://github.com/apache/couchdb/pull/856#issuecomment-333575446 from IRC: ```irc 11:41 <+rnewson> hm, yes, I see your point. 11:41 <+Wohali> if i don't punch a hole through

[GitHub] garrensmith closed pull request #988: Basic upgrades in preparation for React 16

2017-10-02 Thread git
garrensmith closed pull request #988: Basic upgrades in preparation for React 16 URL: https://github.com/apache/couchdb-fauxton/pull/988 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] wohali commented on issue #857: Fuzzy, aggregation and other cool query functions

2017-10-02 Thread git
wohali commented on issue #857: Fuzzy, aggregation and other cool query functions URL: https://github.com/apache/couchdb/issues/857#issuecomment-333562139 This is a really broad request for a single "bug" report. We can't provide any meaningful response here. If you're looking to

[GitHub] wohali closed issue #857: Fuzzy, aggregation and other cool query functions

2017-10-02 Thread git
wohali closed issue #857: Fuzzy, aggregation and other cool query functions URL: https://github.com/apache/couchdb/issues/857 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] wohali opened a new issue #858: Cannot change shard map for system databases

2017-10-02 Thread git
wohali opened a new issue #858: Cannot change shard map for system databases URL: https://github.com/apache/couchdb/issues/858 Ported over from [COUCHDB-3221](https://issues.apache.org/jira/browse/COUCHDB-3221) ## Expected Behaviour Should be able to update the shard map for

[GitHub] nickva opened a new pull request #861: Replace deprecated crypto:rand_bytes call

2017-10-02 Thread git
nickva opened a new pull request #861: Replace deprecated crypto:rand_bytes call URL: https://github.com/apache/couchdb/pull/861 Replaced with crypto:strong_rand_bytes Also fixed a missing newline at the end of file.

[GitHub] couchdb-khash pull request #7: Replace deprecated random module

2017-10-02 Thread nickva
GitHub user nickva opened a pull request: https://github.com/apache/couchdb-khash/pull/7 Replace deprecated random module Replaced with crypto:rand_uniform functions. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] couchdb-khash issue #7: Replace deprecated random module

2017-10-02 Thread wohali
Github user wohali commented on the issue: https://github.com/apache/couchdb-khash/pull/7 Would you mind tweaking `.travis.yml` in this PR to drop the R14 builds so the checks pass please? Assuming everything passes once you do so, +1 ---

[GitHub] couchdb-khash issue #7: Replace deprecated random module

2017-10-02 Thread nickva
Github user nickva commented on the issue: https://github.com/apache/couchdb-khash/pull/7 Will do! Good idea. I just noticed it was wonky ---

[jira] [Closed] (COUCHDB-3221) Shard maps for reserved database names cannot be updated

2017-10-02 Thread Joan Touzet (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-3221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joan Touzet closed COUCHDB-3221. Resolution: Auto Closed Migrated to https://github.com/apache/couchdb/issues/858 > Shard maps

[GitHub] wohali commented on issue #858: Cannot change shard map for system databases

2017-10-02 Thread git
wohali commented on issue #858: Cannot change shard map for system databases URL: https://github.com/apache/couchdb/issues/858#issuecomment-333579565 Original context: > I'm still seeing the same problem as described in COUCHDB-2424 with CouchDB 2.0.0 (Ubuntu) but it doesn't appear

[GitHub] uschtwill opened a new issue #859: Various error messages and breakage

2017-10-02 Thread git
uschtwill opened a new issue #859: Various error messages and breakage URL: https://github.com/apache/couchdb/issues/859 I do realise this is (probably) not a bug report, but I had to write down all of this somewhere, right? And I feel like it would be nice to document the

[GitHub] wohali commented on issue #859: Various error messages and breakage

2017-10-02 Thread git
wohali commented on issue #859: Various error messages and breakage URL: https://github.com/apache/couchdb/issues/859#issuecomment-333616984 Please try again with the apache/couchdb:2.1.0 image and see if this helps. The klaemo/couchdb images are deprecated.

[GitHub] Antonio-Maranhao commented on issue #872: Invalid map/reduce functions do not show an error to the user

2017-10-02 Thread git
Antonio-Maranhao commented on issue #872: Invalid map/reduce functions do not show an error to the user URL: https://github.com/apache/couchdb-fauxton/issues/872#issuecomment-333618928 @garrensmith This works now. The UI shows the error notification.

[GitHub] nickva opened a new pull request #860: Remove usage of deprecated random module.

2017-10-02 Thread git
nickva opened a new pull request #860: Remove usage of deprecated random module. URL: https://github.com/apache/couchdb/pull/860 Replace with util compatibility functions which use `crypto:rand_uniform/2` `crypto:rand_uniform/2` will also be deprecated in the future, hopefully by

[GitHub] couchdb-khash pull request #7: Replace deprecated random module

2017-10-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/couchdb-khash/pull/7 ---

[GitHub] Antonio-Maranhao commented on issue #954: Save document does not prompt invalid JSON

2017-10-02 Thread git
Antonio-Maranhao commented on issue #954: Save document does not prompt invalid JSON URL: https://github.com/apache/couchdb-fauxton/issues/954#issuecomment-333641366 The error message is displayed on the latest version in master using Firefox 56 (64bit) on Mac. Ctrl+S also triggers the

[GitHub] Antonio-Maranhao commented on issue #986: Refactor map/reduce views to use Redux

2017-10-02 Thread git
Antonio-Maranhao commented on issue #986: Refactor map/reduce views to use Redux URL: https://github.com/apache/couchdb-fauxton/pull/986#issuecomment-333641627 @garrensmith This is an automated message from the Apache Git

[GitHub] Antonio-Maranhao closed pull request #986: Refactor map/reduce views to use Redux

2017-10-02 Thread git
Antonio-Maranhao closed pull request #986: Refactor map/reduce views to use Redux URL: https://github.com/apache/couchdb-fauxton/pull/986 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] nickva commented on issue #860: Remove usage of deprecated random module.

2017-10-02 Thread git
nickva commented on issue #860: Remove usage of deprecated random module. URL: https://github.com/apache/couchdb/pull/860#issuecomment-333671154 Turns out crypto:rand_uniform/2 is also deprecated but docs don't show it. Only shows up during compiling. Will go a different route and do a

[GitHub] Antonio-Maranhao opened a new pull request #986: Refactor map/reduce views to use Redux

2017-10-02 Thread git
Antonio-Maranhao opened a new pull request #986: Refactor map/reduce views to use Redux URL: https://github.com/apache/couchdb-fauxton/pull/986 ## Overview - [x] Updated map/reduce views to use Redux version of IndexResults components - [x] Removed non-Redux components

[GitHub] Antonio-Maranhao closed pull request #986: Refactor map/reduce views to use Redux

2017-10-02 Thread git
Antonio-Maranhao closed pull request #986: Refactor map/reduce views to use Redux URL: https://github.com/apache/couchdb-fauxton/pull/986 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] Antonio-Maranhao opened a new pull request #989: Basic validation of key values provided in the Query Options panel

2017-10-02 Thread git
Antonio-Maranhao opened a new pull request #989: Basic validation of key values provided in the Query Options panel URL: https://github.com/apache/couchdb-fauxton/pull/989 ## Overview A common (newbiew) user mistake is to forget to include double quotes in the By Keys and