[GitHub] couchdb-couch-replicator pull request: Add Exponential Backoff for...

2016-05-30 Thread tonysun83
Github user tonysun83 commented on the pull request: https://github.com/apache/couchdb-couch-replicator/pull/40#issuecomment-222566243 @nickva thanks for all the feedback. I've cleaned up the syntax for some of your suggestions. I'm going to start testing this, but I still need to

[GitHub] couchdb-couch-replicator pull request: Add Exponential Backoff for...

2016-05-27 Thread nickva
Github user nickva commented on a diff in the pull request: https://github.com/apache/couchdb-couch-replicator/pull/40#discussion_r64970642 --- Diff: src/couch_replicator_httpc.erl --- @@ -162,6 +165,9 @@ process_stream_response(ReqId, Worker, HttpDb, Params, Callback) ->

[GitHub] couchdb-couch-replicator pull request: Add Exponential Backoff for...

2016-05-27 Thread nickva
Github user nickva commented on a diff in the pull request: https://github.com/apache/couchdb-couch-replicator/pull/40#discussion_r64961577 --- Diff: src/couch_replicator_httpc.erl --- @@ -138,6 +139,8 @@ process_response({ibrowse_req_id, ReqId}, Worker, HttpDb, Params, Callback)

[GitHub] couchdb-couch-replicator pull request: Add Exponential Backoff for...

2016-05-27 Thread nickva
Github user nickva commented on a diff in the pull request: https://github.com/apache/couchdb-couch-replicator/pull/40#discussion_r64961411 --- Diff: src/couch_replicator_httpc.erl --- @@ -251,18 +257,42 @@ clean_mailbox(_, Count) when Count > 0 -> maybe_retry(Error, Worker,

[GitHub] couchdb-couch-replicator pull request: Add Exponential Backoff for...

2016-05-27 Thread nickva
Github user nickva commented on a diff in the pull request: https://github.com/apache/couchdb-couch-replicator/pull/40#discussion_r64961202 --- Diff: src/couch_replicator_httpc.erl --- @@ -251,18 +257,42 @@ clean_mailbox(_, Count) when Count > 0 -> maybe_retry(Error, Worker,

[GitHub] couchdb-couch-replicator pull request: Add Exponential Backoff for...

2016-05-27 Thread tonysun83
GitHub user tonysun83 opened a pull request: https://github.com/apache/couchdb-couch-replicator/pull/40 Add Exponential Backoff for 429 errors. When we encounter a 429, we retry with a different set of retries and timeout. This will theoretically reduce client replication