AlexStocks merged pull request #1250:
URL: https://github.com/apache/dubbo-go/pull/1250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
AlexStocks commented on a change in pull request #1257:
URL: https://github.com/apache/dubbo-go/pull/1257#discussion_r650817093
##
File path: filter/filter_impl/graceful_shutdown_filter.go
##
@@ -71,11 +65,17 @@ func (gf *gracefulShutdownFilter) OnResponse(ctx
AlexStocks commented on a change in pull request #1257:
URL: https://github.com/apache/dubbo-go/pull/1257#discussion_r650816357
##
File path: config/config_loader_test.go
##
@@ -18,6 +18,9 @@
package config
import (
+ "context"
+
AlexStocks merged pull request #126:
URL: https://github.com/apache/dubbo-go-samples/pull/126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
codecov-commenter edited a comment on pull request #1257:
URL: https://github.com/apache/dubbo-go/pull/1257#issuecomment-860172454
#
codecov-commenter edited a comment on pull request #1257:
URL: https://github.com/apache/dubbo-go/pull/1257#issuecomment-860172454
#
AlexStocks commented on a change in pull request #171:
URL: https://github.com/apache/dubbo-go-pixiu/pull/171#discussion_r650813740
##
File path: pkg/registry/zookeeper_test.go
##
@@ -18,6 +18,7 @@ package registry
import (
"fmt"
+ gxzookeeper
AlexStocks commented on a change in pull request #171:
URL: https://github.com/apache/dubbo-go-pixiu/pull/171#discussion_r650813546
##
File path: pkg/registry/zookeeper.go
##
@@ -17,14 +17,14 @@
package registry
import (
+ gxzookeeper
codecov-commenter edited a comment on pull request #1257:
URL: https://github.com/apache/dubbo-go/pull/1257#issuecomment-860172454
#
AlexStocks merged pull request #133:
URL: https://github.com/apache/dubbo-go-samples/pull/133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
codecov-commenter edited a comment on pull request #1257:
URL: https://github.com/apache/dubbo-go/pull/1257#issuecomment-860172454
#
AlexStocks merged pull request #1253:
URL: https://github.com/apache/dubbo-go/pull/1253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
AlexStocks merged pull request #1258:
URL: https://github.com/apache/dubbo-go/pull/1258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
xavier-niu commented on a change in pull request #1257:
URL: https://github.com/apache/dubbo-go/pull/1257#discussion_r651453400
##
File path: config/graceful_shutdown_config.go
##
@@ -54,7 +58,7 @@ type ShutdownConfig struct {
RejectRequest bool
// true -> all
win5do commented on a change in pull request #1257:
URL: https://github.com/apache/dubbo-go/pull/1257#discussion_r651421610
##
File path: config/graceful_shutdown_config.go
##
@@ -54,7 +58,7 @@ type ShutdownConfig struct {
RejectRequest bool
// true -> all
codecov-commenter edited a comment on pull request #1257:
URL: https://github.com/apache/dubbo-go/pull/1257#issuecomment-860172454
#
AlexStocks merged pull request #124:
URL: https://github.com/apache/dubbo-go-samples/pull/124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
xavier-niu commented on a change in pull request #1257:
URL: https://github.com/apache/dubbo-go/pull/1257#discussion_r651453018
##
File path: filter/filter_impl/graceful_shutdown_filter.go
##
@@ -61,7 +55,7 @@ func (gf *gracefulShutdownFilter) Invoke(ctx context.Context,
codecov-commenter edited a comment on pull request #1257:
URL: https://github.com/apache/dubbo-go/pull/1257#issuecomment-860172454
#
xavier-niu commented on a change in pull request #1257:
URL: https://github.com/apache/dubbo-go/pull/1257#discussion_r651453018
##
File path: filter/filter_impl/graceful_shutdown_filter.go
##
@@ -61,7 +55,7 @@ func (gf *gracefulShutdownFilter) Invoke(ctx context.Context,
win5do commented on a change in pull request #1254:
URL: https://github.com/apache/dubbo-go/pull/1254#discussion_r650462930
##
File path: config/graceful_shutdown.go
##
@@ -163,6 +163,7 @@ func waitForReceivingRequests() {
// ignore this step
zhaoyunxing92 closed pull request #1256:
URL: https://github.com/apache/dubbo-go/pull/1256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
AlexStocks merged pull request #1249:
URL: https://github.com/apache/dubbo-go/pull/1249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
LaurenceLiZhixin merged pull request #137:
URL: https://github.com/apache/dubbo-go-samples/pull/137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about
LaurenceLiZhixin commented on a change in pull request #139:
URL: https://github.com/apache/dubbo-go-samples/pull/139#discussion_r650675719
##
File path: general/dubbo3/hessian2/go-server/conf/client.yml
##
@@ -29,4 +29,4 @@ references:
registry: "demoZk"
protocol:
mark4z commented on a change in pull request #171:
URL: https://github.com/apache/dubbo-go-pixiu/pull/171#discussion_r650386312
##
File path: pkg/config/api_config.go
##
@@ -67,64 +80,116 @@ func LoadAPIConfigFromFile(path string) (*fc.APIConfig,
error) {
// LoadAPIConfig
ztelur commented on a change in pull request #171:
URL: https://github.com/apache/dubbo-go-pixiu/pull/171#discussion_r650506770
##
File path: pkg/config/api_config.go
##
@@ -67,64 +80,116 @@ func LoadAPIConfigFromFile(path string) (*fc.APIConfig,
error) {
// LoadAPIConfig
codecov-commenter edited a comment on pull request #171:
URL: https://github.com/apache/dubbo-go-pixiu/pull/171#issuecomment-843910604
#
LaurenceLiZhixin opened a new pull request #138:
URL: https://github.com/apache/dubbo-go-samples/pull/138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries
zhaoyunxing92 opened a new pull request #137:
URL: https://github.com/apache/dubbo-go-samples/pull/137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about
AlexStocks commented on pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169#issuecomment-860135380
pls fix the go.mod confliction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
LaurenceLiZhixin merged pull request #123:
URL: https://github.com/apache/dubbo-go-samples/pull/123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about
xavier-niu commented on pull request #1254:
URL: https://github.com/apache/dubbo-go/pull/1254#issuecomment-860154929
>
https://github.com/xavier-niu/dubbo-go/blob/f1879b4cd72d06bed0e69f4e58d4c2ce3b19fd38/filter/filter_impl/graceful_shutdown_filter.go#L36
>
> init 时拿到的 shutdownConfig
zhaoyunxing92 opened a new pull request #1256:
URL: https://github.com/apache/dubbo-go/pull/1256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
AlexStocks merged pull request #1254:
URL: https://github.com/apache/dubbo-go/pull/1254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
xavier-niu commented on a change in pull request #1254:
URL: https://github.com/apache/dubbo-go/pull/1254#discussion_r650463862
##
File path: config/graceful_shutdown.go
##
@@ -163,6 +163,7 @@ func waitForReceivingRequests() {
// ignore this step
LaurenceLiZhixin merged pull request #1242:
URL: https://github.com/apache/dubbo-go/pull/1242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
xavier-niu closed pull request #135:
URL: https://github.com/apache/dubbo-go-samples/pull/135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
zhaoyunxing92 opened a new pull request #1255:
URL: https://github.com/apache/dubbo-go/pull/1255
**What this PR does**:
* 主要优化nacos连接
**Which issue(s) this PR fixes**:
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing
zouyx merged pull request #128:
URL: https://github.com/apache/dubbo-go-samples/pull/128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
codecov-commenter commented on pull request #1254:
URL: https://github.com/apache/dubbo-go/pull/1254#issuecomment-859382015
#
zhaoyunxing92 closed pull request #1241:
URL: https://github.com/apache/dubbo-go/pull/1241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
AlexStocks closed issue #1214:
URL: https://github.com/apache/dubbo-go/issues/1214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
williamfeng323 commented on a change in pull request #171:
URL: https://github.com/apache/dubbo-go-pixiu/pull/171#discussion_r649641858
##
File path: pkg/config/api_config.go
##
@@ -67,64 +80,116 @@ func LoadAPIConfigFromFile(path string) (*fc.APIConfig,
error) {
//
xavier-niu commented on pull request #135:
URL: https://github.com/apache/dubbo-go-samples/pull/135#issuecomment-859212013
same as #134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
codecov-commenter edited a comment on pull request #1254:
URL: https://github.com/apache/dubbo-go/pull/1254#issuecomment-859382015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
AlexStocks merged pull request #127:
URL: https://github.com/apache/dubbo-go-samples/pull/127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
codecov-commenter commented on pull request #1255:
URL: https://github.com/apache/dubbo-go/pull/1255#issuecomment-860149880
#
codecov-commenter edited a comment on pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169#issuecomment-842065553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
xavier-niu opened a new pull request #1257:
URL: https://github.com/apache/dubbo-go/pull/1257
**What this PR does**:
- Fix data race for `RequestsFinished`
- Retrieve the ShutdownConfig after config.Load() was performed
- See also #1254
**Which issue(s) this PR
LaurenceLiZhixin commented on pull request #138:
URL: https://github.com/apache/dubbo-go-samples/pull/138#issuecomment-860415452
>
>
> Pls change Id to ID.
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
LaurenceLiZhixin opened a new pull request #1258:
URL: https://github.com/apache/dubbo-go/pull/1258
**What this PR does**:
**Which issue(s) this PR fixes**:
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
AlexStocks merged pull request #1221:
URL: https://github.com/apache/dubbo-go/pull/1221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
LaurenceLiZhixin opened a new pull request #1253:
URL: https://github.com/apache/dubbo-go/pull/1253
**What this PR does**:
**Which issue(s) this PR fixes**:
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
codecov-commenter commented on pull request #1253:
URL: https://github.com/apache/dubbo-go/pull/1253#issuecomment-859373587
#
xavier-niu opened a new pull request #1254:
URL: https://github.com/apache/dubbo-go/pull/1254
**What this PR does**:
- Cancel calling exporter.Unexport() in registryProtocol.Destory()
- Close zkListener before closing zkClient
**Which issue(s) this PR fixes**:
codecov-commenter commented on pull request #1257:
URL: https://github.com/apache/dubbo-go/pull/1257#issuecomment-860172454
#
LaurenceLiZhixin commented on a change in pull request #134:
URL: https://github.com/apache/dubbo-go-samples/pull/134#discussion_r650489806
##
File path: general/dubbo3/hessian2/go-server/pkg/greeter.go
##
@@ -36,14 +35,15 @@ type User struct {
Id string
Name
codecov-commenter commented on pull request #1258:
URL: https://github.com/apache/dubbo-go/pull/1258#issuecomment-860171200
#
AlexStocks merged pull request #1256:
URL: https://github.com/apache/dubbo-go/pull/1256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
zhaoyunxing92 opened a new pull request #136:
URL: https://github.com/apache/dubbo-go-samples/pull/136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about
LaurenceLiZhixin opened a new pull request #139:
URL: https://github.com/apache/dubbo-go-samples/pull/139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries
LaurenceLiZhixin commented on a change in pull request #138:
URL: https://github.com/apache/dubbo-go-samples/pull/138#discussion_r650678527
##
File path: general/dubbo3/codec-extension/go-server/codec/codec.go
##
@@ -0,0 +1,25 @@
+package codec
+
+import (
+
AlexStocks merged pull request #138:
URL: https://github.com/apache/dubbo-go-samples/pull/138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
zouyx commented on a change in pull request #138:
URL: https://github.com/apache/dubbo-go-samples/pull/138#discussion_r650644722
##
File path: general/dubbo3/codec-extension/go-server/codec/codec.go
##
@@ -0,0 +1,25 @@
+package codec
+
+import (
+ "encoding/json"
+
win5do commented on pull request #1254:
URL: https://github.com/apache/dubbo-go/pull/1254#issuecomment-860145272
https://github.com/xavier-niu/dubbo-go/blob/f1879b4cd72d06bed0e69f4e58d4c2ce3b19fd38/filter/filter_impl/graceful_shutdown_filter.go#L36
init 时拿到的 shutdownConfig 总是 nil。
AlexStocks merged pull request #1255:
URL: https://github.com/apache/dubbo-go/pull/1255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
zhaoyunxing92 closed pull request #136:
URL: https://github.com/apache/dubbo-go-samples/pull/136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
fangyincheng commented on pull request #1196:
URL: https://github.com/apache/dubbo-go/pull/1196#issuecomment-860165869
please fix ut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
AlexStocks commented on pull request #138:
URL: https://github.com/apache/dubbo-go-samples/pull/138#issuecomment-860378650
Pls change Id to ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
zouyx commented on a change in pull request #139:
URL: https://github.com/apache/dubbo-go-samples/pull/139#discussion_r650645133
##
File path: general/dubbo3/hessian2/go-server/conf/client.yml
##
@@ -29,4 +29,4 @@ references:
registry: "demoZk"
protocol: "tri"
71 matches
Mail list logo