[GitHub] [geode] pivotal-eshu closed pull request #2571: GEODE-5828: fixes replicates miss transaction commit.

2018-10-05 Thread GitHub
[ pull request closed by pivotal-eshu ] [ Full content available at: https://github.com/apache/geode/pull/2571 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #2571: GEODE-5828: fixes replicates miss transaction commit.

2018-10-05 Thread GitHub
it would be better to just use the "distributionManager" parameter. At some point we may find that this class no longer needs to keep a reference to the dm in an instance field. [ Full content available at: https://github.com/apache/geode/pull/2571 ] This message was relayed via

[GitHub] [geode] pivotal-eshu commented on pull request #2571: GEODE-5828: fixes replicates miss transaction commit.

2018-10-05 Thread GitHub
txTracker.commitProcessReceived method no longer need distribution manager anymore. [ Full content available at: https://github.com/apache/geode/pull/2571 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] mmartell closed pull request #369: GEODE-5638: Organize/Cleanup the geode-native project structure

2018-10-05 Thread GitHub
[ pull request closed by mmartell ] [ Full content available at: https://github.com/apache/geode-native/pull/369 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pivotal-jbarrett closed pull request #366: GEODE-5025: Uses templates to define Cacheable types

2018-10-05 Thread GitHub
[ pull request closed by pivotal-jbarrett ] [ Full content available at: https://github.com/apache/geode-native/pull/366 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] upthewaterspout opened pull request #2572: GEODE-5424: Changing all awaitility calls to use consistent timings

2018-10-05 Thread GitHub
We have a lot of Awaitility calls in our tests. Each test was picking its own timeout. That lead to some tests picking too small of a timeout and failing spuriously. With this change, all tests will use a new factory, GeodeAwaility.await(), rather than Awaitility.await(). This new factory sets a

[GitHub] [geode] dschneider-pivotal closed pull request #2535: GEODE-5780: LoggingThreadGroup is no longer used.

2018-10-05 Thread GitHub
[ pull request closed by dschneider-pivotal ] [ Full content available at: https://github.com/apache/geode/pull/2535 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on issue #2567: GEODE-5820: upgrade jetty to fix jetty tests in java10

2018-10-05 Thread GitHub
we can change it to java 9+ [ Full content available at: https://github.com/apache/geode/pull/2567 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal opened pull request #2577: GEODE-5794: fix failing JMXMBeanReconnectDUnitTest

2018-10-05 Thread GitHub
Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has

[GitHub] [geode] jdeppe-pivotal opened pull request #2578: GEODE-5829: Do not bind to both localhost and the actual address of the host

2018-10-05 Thread GitHub
- There is a subtle, low-level networking issue on Windows. See here https://stackoverflow.com/questions/52653506/udp-socket-binding-and-sending-behavior-on-windows-1709 and here https://serverfault.com/questions/934207/socket-binding-and-sending-on-different-addresses Thank you for

[GitHub] [geode] dhemery opened pull request #2579: GEODE-5501: Disconnect only current test's server

2018-10-05 Thread GitHub
* Disconnect would wait until there was a system, then disconnect it. Sometimes it would wait until the next test started a new instance, then immediately disconnect it. * Wait for the member to finish disconnecting before ending the test. * Remove the listener at the end of the test, so that it

[GitHub] [geode] kirklund closed pull request #2573: GEODE-2644: Cleanup logging classes and tests

2018-10-05 Thread GitHub
[ pull request closed by kirklund ] [ Full content available at: https://github.com/apache/geode/pull/2573 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode]

2018-10-05 Thread GitHub
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] rhoughton-pivot commented on pull request #2569: GEODE-5804: Improve checkPom task

2018-10-05 Thread GitHub
Why does the expected file need to exist in order to update/place. We could use this task to generate the baseline for a newly-minted module. [ Full content available at: https://github.com/apache/geode/pull/2569 ] This message was relayed via gitbox.apache.org for

[GitHub] [geode] PurelyApplied commented on pull request #2569: GEODE-5804: Improve checkPom task

2018-10-05 Thread GitHub
I suppose it doesn't! [ Full content available at: https://github.com/apache/geode/pull/2569 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal opened pull request #2574: GEODE-5212: Also use the host's canonical (fully qualified) name as a…

2018-10-05 Thread GitHub
… SAN in the certificate Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the

[GitHub] [geode] PurelyApplied commented on issue #2569: GEODE-5804: Improve checkPom task

2018-10-05 Thread GitHub
It seems like the actual `checkPom` task is only examining `` blocks and not any other data. So, on the one hand, the existing behavior was "copy the actual pom to the expected pom" is what's happening, but a developer will then need to examine which difference should actually be added to

[GitHub] [geode] kirklund opened pull request #2573: GEODE-2644: Cleanup logging classes and tests

2018-10-05 Thread GitHub
This is divided up into smaller commits: GEODE-2644: Add LogWriterLevel enum and test GEODE-2644: Cleanup LogLevel and expand LogLevelTest GEODE-2644: Cleanup custom log4j2 config logging tests GEODE-2644: Cleanup Marker Filter logging tests GEODE-2644: Cleanup logging tests GEODE-2644: Cleanup

[GitHub] [geode] jchen21 closed pull request #2556: GEODE-5711: Gfsh prompt for JNDI username and password

2018-10-05 Thread GitHub
[ pull request closed by jchen21 ] [ Full content available at: https://github.com/apache/geode/pull/2556 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on issue #2569: GEODE-5804: Improve checkPom task

2018-10-05 Thread GitHub
I had been poking at it to make sure it's still good. I was getting some strange behavior where `./gradlew uEP` updates the assembly pom with ``` diff --git a/geode-assembly/src/test/resources/expected-pom.xml b/geode-assembly/src/test/resources/expected-pom.xml index 3f8abf5e57..b22bc8f393

[GitHub] [geode] jinmeiliao closed pull request #2567: GEODE-5820: upgrade jetty to fix jetty tests in java10

2018-10-05 Thread GitHub
[ pull request closed by jinmeiliao ] [ Full content available at: https://github.com/apache/geode/pull/2567 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao opened pull request #2576: GEODE-5821: exclude geode 1.4 when testing with java 9+

2018-10-05 Thread GitHub
Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has

[GitHub] [geode] dschneider-pivotal opened pull request #2575: refactor RegionMapDestroy

2018-10-05 Thread GitHub
This branch started out as work on unit test coverage for RegionMapDestroy. That test coverage has been checked in with a different pull request. This pull request has the refactoring that was done while writing the unit tests. Thank you for submitting a contribution to Apache Geode. In order