[GitHub] [geode] jujoramos commented on a change in pull request #5466: GEODE-8119: Threads hangs when offline disk store command is invoked

jujoramos commented on a change in pull request #5466: URL: https://github.com/apache/geode/pull/5466#discussion_r474009698 ## File path: geode-gfsh/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java ## @@ -519,6 +520,25

[GitHub] [geode-native] pdxcodemonkey merged pull request #637: GEODE-8344: Fix Windows build

pdxcodemonkey merged pull request #637: URL: https://github.com/apache/geode-native/pull/637 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] jujoramos closed pull request #5463: [WIP]: GEM-2931

jujoramos closed pull request #5463: URL: https://github.com/apache/geode/pull/5463 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode-native] pdxcodemonkey merged pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

pdxcodemonkey merged pull request #635: URL: https://github.com/apache/geode-native/pull/635 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] jujoramos commented on a change in pull request #5466: GEODE-8119: Threads hangs when offline disk store command is invoked

jujoramos commented on a change in pull request #5466: URL: https://github.com/apache/geode/pull/5466#discussion_r474010363 ## File path: geode-gfsh/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java ## @@ -519,6 +520,25

[GitHub] [geode-native] alb3rtobr commented on a change in pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

alb3rtobr commented on a change in pull request #635: URL: https://github.com/apache/geode-native/pull/635#discussion_r473716608 ## File path: cppcache/src/PdxTypeRegistry.cpp ## @@ -89,8 +89,8 @@ int32_t PdxTypeRegistry::getPDXIdForType(std::shared_ptr nType, typeId =

[GitHub] [geode-native] alb3rtobr commented on a change in pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

alb3rtobr commented on a change in pull request #635: URL: https://github.com/apache/geode-native/pull/635#discussion_r473746105 ## File path: cppcache/src/PdxTypeRegistry.cpp ## @@ -89,8 +89,8 @@ int32_t PdxTypeRegistry::getPDXIdForType(std::shared_ptr nType, typeId =

[GitHub] [geode-native] alb3rtobr commented on a change in pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

alb3rtobr commented on a change in pull request #635: URL: https://github.com/apache/geode-native/pull/635#discussion_r473716608 ## File path: cppcache/src/PdxTypeRegistry.cpp ## @@ -89,8 +89,8 @@ int32_t PdxTypeRegistry::getPDXIdForType(std::shared_ptr nType, typeId =

[GitHub] [geode-native] alb3rtobr commented on pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

alb3rtobr commented on pull request #635: URL: https://github.com/apache/geode-native/pull/635#issuecomment-677451250 > > I'm also hitting this on Windows builds now, though it appears to have come in with yesterday's PR for GatewaySenderEventCallbackArgument: > >

[GitHub] [geode] mivanac merged pull request #5460: GEODE-8433: added inheritance of off-heap attribute

mivanac merged pull request #5460: URL: https://github.com/apache/geode/pull/5460 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode-native] pdxcodemonkey merged pull request #638: GEODE-8443: Disable Windows SNI test as intended

pdxcodemonkey merged pull request #638: URL: https://github.com/apache/geode-native/pull/638 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode-native] pdxcodemonkey opened a new pull request #638: GEODE-8443: Disable Windows SNI test as intended

pdxcodemonkey opened a new pull request #638: URL: https://github.com/apache/geode-native/pull/638 - It's being run in the test suite due to a typo This is an automated message from the Apache Git Service. To respond to the

[GitHub] [geode] jujoramos commented on a change in pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

jujoramos commented on a change in pull request #5175: URL: https://github.com/apache/geode/pull/5175#discussion_r472878920 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java ## @@ -2318,7 +2318,7 @@ void close(boolean destroy) {

[GitHub] [geode] jujoramos commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

jujoramos commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-677529060 Sounds good @mkevo, thanks for the update and sorry for all the back and forth, I wish I have had spotted the single line fix before to spare you some time :-/. Once the `PR`

[GitHub] [geode-native] alb3rtobr edited a comment on pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

alb3rtobr edited a comment on pull request #635: URL: https://github.com/apache/geode-native/pull/635#issuecomment-677451250 > > I'm also hitting this on Windows builds now, though it appears to have come in with yesterday's PR for GatewaySenderEventCallbackArgument: > >

[GitHub] [geode-native] alb3rtobr opened a new pull request #637: GEODE-8344: Fix Windows build

alb3rtobr opened a new pull request #637: URL: https://github.com/apache/geode-native/pull/637 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [geode] mkevo commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

mkevo commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-677527803 > I'm still not sure that the changes within the `DiskStoreCommandUtils` class are needed to address the problem. I've opened a draft

[GitHub] [geode] mkevo opened a new pull request #5466: GEODE-8119: Threads hangs when offline disk store command is invoked

mkevo opened a new pull request #5466: URL: https://github.com/apache/geode/pull/5466 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] mkevo commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

mkevo commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-677581744 Hi @jujoramos , I wish that I spotted it earlier so you don't waste your time on this. Thanks again for a help! New [PR](https://github.com/apache/geode/pull/5466) is

[GitHub] [geode] mkevo closed pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

mkevo closed pull request #5175: URL: https://github.com/apache/geode/pull/5175 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the