[jira] [Commented] (GROOVY-8163) Groovy scripts can disable java security manager and escape sandbox

2017-05-13 Thread Dimitry Polivaev (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009353#comment-16009353 ] Dimitry Polivaev commented on GROOVY-8163: -- [~blackdrag] I would appreciate any feedback about

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365210 --- Diff: src/main/org/codehaus/groovy/reflection/CachedField.java --- @@ -51,6 +52,12 @@ public int getModifiers() { */ public

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365112 --- Diff: src/main/org/codehaus/groovy/reflection/AccessPermissionChecker.java --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365147 --- Diff: src/main/org/codehaus/groovy/reflection/AccessPermissionChecker.java --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365223 --- Diff: src/main/org/codehaus/groovy/reflection/CachedField.java --- @@ -65,6 +72,12 @@ public Object getProperty(final Object object) { *

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365151 --- Diff: src/main/org/codehaus/groovy/reflection/AccessPermissionChecker.java --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365514 --- Diff: src/main/org/codehaus/groovy/reflection/CachedMethod.java --- @@ -324,6 +337,12 @@ else if (o2 instanceof CachedMethod) }

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365503 --- Diff: src/main/org/codehaus/groovy/reflection/CachedMethod.java --- @@ -124,6 +131,12 @@ public String getSignature() { }

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365354 --- Diff: src/main/org/codehaus/groovy/reflection/CachedMethod.java --- @@ -90,6 +91,12 @@ public CachedClass getDeclaringClass() {

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365638 --- Diff: src/main/org/codehaus/groovy/reflection/AccessPermissionChecker.java --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (GROOVY-8163) Groovy scripts can disable java security manager and escape sandbox

2017-05-13 Thread Jochen Theodorou (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009412#comment-16009412 ] Jochen Theodorou commented on GROOVY-8163: -- +1 > Groovy scripts can disable java security

[GitHub] groovy pull request #533: GROOVY-7840: Verifier#makeDescriptorWithoutReturnT...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/533#discussion_r116363829 --- Diff: src/main/org/apache/groovy/ast/tools/MethodNodeUtils.java --- @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] groovy pull request #533: GROOVY-7840: Verifier#makeDescriptorWithoutReturnT...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/533#discussion_r116363767 --- Diff: src/main/org/apache/groovy/ast/tools/ClassNodeUtils.java --- @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] groovy pull request #533: GROOVY-7840: Verifier#makeDescriptorWithoutReturnT...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/533#discussion_r116363909 --- Diff: src/main/org/apache/groovy/ast/tools/MethodNodeUtils.java --- @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (GROOVY-7840) Verifier#makeDescriptorWithoutReturnType uses ClassNode#toString with generics

2017-05-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009458#comment-16009458 ] ASF GitHub Bot commented on GROOVY-7840: Github user jwagenleitner commented on a diff in the

[jira] [Commented] (GROOVY-7840) Verifier#makeDescriptorWithoutReturnType uses ClassNode#toString with generics

2017-05-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009457#comment-16009457 ] ASF GitHub Bot commented on GROOVY-7840: Github user jwagenleitner commented on a diff in the

[jira] [Commented] (GROOVY-7840) Verifier#makeDescriptorWithoutReturnType uses ClassNode#toString with generics

2017-05-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009459#comment-16009459 ] ASF GitHub Bot commented on GROOVY-7840: Github user jwagenleitner commented on a diff in the

[GitHub] groovy pull request #540: GROOVY-7535: Groovy category throwing MissingMetho...

2017-05-13 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/540 GROOVY-7535: Groovy category throwing MissingMethodException and Miss… …ingPropertyException when using multiple threads You can merge this pull request into a Git repository by running:

[jira] [Commented] (GROOVY-7535) Groovy category throwing MissingMethodException and MissingPropertyException when using multiple threads

2017-05-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009598#comment-16009598 ] ASF GitHub Bot commented on GROOVY-7535: GitHub user jwagenleitner opened a pull request:

[jira] [Commented] (GROOVY-8163) Groovy scripts can disable java security manager and escape sandbox

2017-05-13 Thread John Wagenleitner (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009515#comment-16009515 ] John Wagenleitner commented on GROOVY-8163: --- By wrapping the {{Eval}} in the {{doPrivileged}}