[jira] [Commented] (GROOVY-8520) Replace commons-cli with picocli in CliBuilder

2018-04-16 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439675#comment-16439675 ] Remko Popma commented on GROOVY-8520: - I now believe the remaining failing test is really the result

[jira] [Commented] (GROOVY-8546) Parrot Parser: multiple Reader instances opened from SourceUnit; many left open

2018-04-16 Thread Eric Milles (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439816#comment-16439816 ] Eric Milles commented on GROOVY-8546: - It would help if you linked to the relevant source code since

[jira] [Reopened] (GROOVY-8546) Parrot Parser: multiple Reader instances opened from SourceUnit; many left open

2018-04-16 Thread Eric Milles (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles reopened GROOVY-8546: - Issue was never resolved. It would be nice if you gave the submitter a chance to evaluate before

[jira] [Comment Edited] (GROOVY-7971) @CS flow typing incorrectly casting to map at runtime

2018-04-16 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439303#comment-16439303 ] Paul King edited comment on GROOVY-7971 at 4/16/18 11:33 AM: - A slightly

[jira] [Commented] (GROOVY-4606) Exteremely bad performance of .unique() and .unique {closure}

2018-04-16 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439357#comment-16439357 ] Paul King commented on GROOVY-4606: --- Given that we now have methods like {{DGM#toUnique(List,

[jira] [Commented] (GROOVY-7971) @CS flow typing incorrectly casting to map at runtime

2018-04-16 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439303#comment-16439303 ] Paul King commented on GROOVY-7971: --- A slightly simpler example: {code} import groovy.json.* import

[jira] [Commented] (GROOVY-6429) flow typing detects unexpected error at if-else flow

2018-04-16 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439328#comment-16439328 ] Paul King commented on GROOVY-6429: --- After GROOVY-8523, test2 now works but test3 still doesn't

[jira] [Updated] (GROOVY-5502) If/else branch does not always infer the variable type

2018-04-16 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-5502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King updated GROOVY-5502: -- Summary: If/else branch does not always infer the variable type (was: If/else brach does not always

[jira] [Closed] (GROOVY-6236) CompileStatic with negated instanceof check causes compilation to fail

2018-04-16 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-6236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King closed GROOVY-6236. - Resolution: Invalid Assignee: Paul King Some instanceof issues were fixed in 2.4.13. The example

[jira] [Commented] (GROOVY-8267) NPE in StaticVerifier

2018-04-16 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439343#comment-16439343 ] Paul King commented on GROOVY-8267: --- Can you supply a little bit more of your example. When I try this:

[jira] [Commented] (GROOVY-8267) NPE in StaticVerifier

2018-04-16 Thread Eric Milles (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439882#comment-16439882 ] Eric Milles commented on GROOVY-8267: - I'm looking now to see if I can re-find the class that

[jira] [Commented] (GROOVY-7971) @CS flow typing incorrectly casting to map at runtime

2018-04-16 Thread Jochen Theodorou (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439919#comment-16439919 ] Jochen Theodorou commented on GROOVY-7971: -- I think it is ok to support only if the instanceof

[jira] [Commented] (GROOVY-7971) @CS flow typing incorrectly casting to map at runtime

2018-04-16 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440025#comment-16440025 ] Paul King commented on GROOVY-7971: --- Giving a compiler STC error would be better - treating it as a Map

[jira] [Commented] (GROOVY-8520) Replace commons-cli with picocli in CliBuilder

2018-04-16 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440035#comment-16440035 ] Paul King commented on GROOVY-8520: --- The first I think is safe to ignore as a commons-cli "feature". I

[jira] [Commented] (GROOVY-8520) Replace commons-cli with picocli in CliBuilder

2018-04-16 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440038#comment-16440038 ] Paul King commented on GROOVY-8520: --- Can you also rebase against a recent version of the Groovy master

[jira] [Commented] (GROOVY-8267) NPE in StaticVerifier

2018-04-16 Thread Eric Milles (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440251#comment-16440251 ] Eric Milles commented on GROOVY-8267: - I found the original source that caused this issue and was

[jira] [Closed] (GROOVY-8267) NPE in StaticVerifier

2018-04-16 Thread Eric Milles (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles closed GROOVY-8267. --- Resolution: Cannot Reproduce > NPE in StaticVerifier > - > >

[jira] [Commented] (GROOVY-8546) Parrot Parser: multiple Reader instances opened from SourceUnit; many left open

2018-04-16 Thread Daniel Sun (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440281#comment-16440281 ] Daniel Sun commented on GROOVY-8546: {quote}It would help if you linked to the relevant source code

[jira] [Closed] (GROOVY-6214) Problem With CompileStatic And instanceof

2018-04-16 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King closed GROOVY-6214. - Resolution: Duplicate Assignee: Paul King This appears fixed in 2.4.13, probably a duplicate of