[GitHub] [groovy] danielsun1106 commented on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-05 Thread GitBox
danielsun1106 commented on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-570908778 Jochen, I'm using the JDK 11: ``` C:\Users\Daniel.LAPTOP-H7RKNSIS>java -version openjdk version "11.0.5" 2019-10-15

[GitHub] [groovy] danielsun1106 commented on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-05 Thread GitBox
danielsun1106 commented on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-570900509 Jochen, as you found, the regular case the most inefficient one. So in the latest commit I introduce a threshold to control

[GitHub] [groovy] danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-05 Thread GitBox
danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-570900509 Jochen, as you found, the regular case is the most inefficient one. So in the latest commit I introduce a threshold

[GitHub] [groovy] danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-05 Thread GitBox
danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-570900509 Jochen, as you found, the regular case is the most inefficient one. So in the latest commit I introduce a threshold

[GitHub] [groovy] blackdrag commented on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-05 Thread GitBox
blackdrag commented on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-570908249 @danielsun1106 which version of Java are you using for your tests? In my test CS was slower for the first case than indy1, in

[GitHub] [groovy] blackdrag edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-05 Thread GitBox
blackdrag edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-570908249 @danielsun1106 which version of Java are you using for your tests? In my test CS was slower for the first case than

[GitHub] [groovy] blackdrag edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-05 Thread GitBox
blackdrag edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-570908249 @danielsun1106 which version of Java are you using for your tests? In my test CS was slower for the first case than

[GitHub] [groovy] danielsun1106 commented on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-05 Thread GitBox
danielsun1106 commented on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-570964021 @blackdrag Jochen, `setTarget` is executed twice when `threshold` is `0`: one for `next`(i.e. i++) and another for

[GitHub] [groovy] danielsun1106 commented on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-05 Thread GitBox
danielsun1106 commented on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-570983832 Here is an edge case: we set `groovy.indy.optimize.threshold` to `0`, and the target of callsite `toString` will be set

[GitHub] [groovy] danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-05 Thread GitBox
danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-570983832 Here is an edge case: we set `groovy.indy.optimize.threshold` to `0`, and the target of callsite `toString` will be