trevorflanagan commented on this pull request.
>super(builder);
}
public static Properties defaultProperties() {
Properties properties =
DimensionDataCloudControlApiMetadata.defaultProperties();
+ properties.setProperty(PROPERTY_REGIONS, "na,eu,au,mea,ap,canada");
nacx commented on this pull request.
Almost there! :)
>super(builder);
}
public static Properties defaultProperties() {
Properties properties =
DimensionDataCloudControlApiMetadata.defaultProperties();
+ properties.setProperty(PROPERTY_REGIONS,
Appreciate all the help with this one @nacx , I've learnt alot about jclouds
working on it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/433#issuecomment-382742915
trevorflanagan commented on this pull request.
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.dimensiondata.cloudcontrol.options;
nacx commented on this pull request.
>
- @Nullable
- public abstract List deviceOrDisks();
Oh, I see now that inheritance here was there not only to reuse fields but
because the API returns collections with different object types in it.
To avoid having a `List`, which makes the API hard
nacx commented on this pull request.
Thanks, @trevorflanagan! Looks great. Just one comment about code reuse and I
think it's good to merge!
> + this.queryParameters.put("datacenterId", checkNotNull(datacenterId,
> "datacenterId"));
+ }
+ return this;
+ }
+
+ public
nacx commented on this pull request.
Just couple comments I've spotted. It looks great.
Thanks for all your work on this!
>super(builder);
}
public static Properties defaultProperties() {
Properties properties =
DimensionDataCloudControlApiMetadata.defaultProperties();
[
https://issues.apache.org/jira/browse/JCLOUDS-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445238#comment-16445238
]
Jim Sermersheim commented on JCLOUDS-1389:
--
Here's what I've found:
This problem can be
[
https://issues.apache.org/jira/browse/JCLOUDS-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Sermersheim updated JCLOUDS-1389:
-
Attachment: 0001-JCLOUDS-1389-Populate-storageClass-in-destination-fr.patch
> Multipart
[
https://issues.apache.org/jira/browse/JCLOUDS-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445271#comment-16445271
]
Jim Sermersheim edited comment on JCLOUDS-1389 at 4/20/18 5:47 AM:
---
In
[
https://issues.apache.org/jira/browse/JCLOUDS-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445271#comment-16445271
]
Jim Sermersheim edited comment on JCLOUDS-1389 at 4/20/18 4:16 AM:
---
In
[
https://issues.apache.org/jira/browse/JCLOUDS-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445137#comment-16445137
]
Jim Sermersheim commented on JCLOUDS-1389:
--
I'm running into this as well. It happens
[
https://issues.apache.org/jira/browse/JCLOUDS-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445271#comment-16445271
]
Jim Sermersheim commented on JCLOUDS-1389:
--
In the error case, I see that in
[
https://issues.apache.org/jira/browse/JCLOUDS-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Sermersheim updated JCLOUDS-1389:
-
Attachment: 0001-JCLOUDS-1389-Populate-storageClass-in-destination-fr.patch
> Multipart
[
https://issues.apache.org/jira/browse/JCLOUDS-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Sermersheim updated JCLOUDS-1389:
-
Attachment: (was:
0001-JCLOUDS-1389-Populate-storageClass-in-destination-fr.patch)
[
https://issues.apache.org/jira/browse/JCLOUDS-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera resolved JCLOUDS-1406.
-
Resolution: Fixed
> Add default location configuration to dimension data provider
>
Pushed to
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/60c3323c)
and
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/5c97ea45).
Thanks @trevorflanagan!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly
trevorflanagan commented on this pull request.
>super(builder);
}
public static Properties defaultProperties() {
Properties properties =
DimensionDataCloudControlApiMetadata.defaultProperties();
+ properties.setProperty(PROPERTY_REGIONS, "na,eu,au,mea,ap,canada");
Closed #433.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/433#event-1584059937
[
https://issues.apache.org/jira/browse/JCLOUDS-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444182#comment-16444182
]
ASF subversion and git services commented on JCLOUDS-1406:
--
Commit
btrishkin commented on this pull request.
>
- @Nullable
- public abstract List deviceOrDisks();
Yes, AbstractDrive will help a lot in ServerToHardware function implementation
for a new ServerApi version. Gonna keep it then.
--
You are receiving this because you are subscribed to this
Suggested changes made @nacx, thanks. I have also re-based onto master and
squashed commits.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/433#issuecomment-382696716
[
https://issues.apache.org/jira/browse/JCLOUDS-1412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444328#comment-16444328
]
Russell Klopfer edited comment on JCLOUDS-1412 at 4/19/18 4:17 PM:
---
[
https://issues.apache.org/jira/browse/JCLOUDS-1412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444328#comment-16444328
]
Russell Klopfer commented on JCLOUDS-1412:
--
{quote}What symptoms do you experience?
{quote} #
24 matches
Mail list logo
