Thanks for the review comments @nacx ! I do need to add (back) the code to
actually use the keyvaultidAndSecret, will do that. Will address the other
comments as well.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Hello @nacx - need your input on implementation for keyvault support. The azure
compute adapter code was refactored to use the VirtualMachineAPI instead of the
deployment API. As a result, keyvaults cannot be accessed merely by reference
(as we could in the deployment template). So - I think
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/398
-- Commit Summary --
* add back support for azure customData and keyvault for ssh keys
* bas64 encode user data templates
-- File Changes --
M
This got dropped for a while - basically there is some test (mock) code to be
redone and some formatting. I will address them shortly, hopefully.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1232
-- Commit Summary --
* JCLOUDS-1387: Add support for c5 instance types in AWS ec2
-- File Changes --
M
@danielestevez thanks for the review.. no, this PR is for a different set of
instance types (m5) than #1232 (c5)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1233
-- Commit Summary --
* JCLOUDS-1436: Add support for aws ec2 m5 instance types
-- File Changes --
M
@VRanga000 pushed 1 commit.
97d37f7 fix: remove duplicate imports
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1233/files/9ef582d31af1ea284c6020f80f6463c1c51bb266..97d37f74fb693e5f5f79c444208fac6cfb35aea1
Vikas Rangarajan created JCLOUDS-893:
Summary: Support compute API extension Servers with scheduler
hints
Key: JCLOUDS-893
URL: https://issues.apache.org/jira/browse/JCLOUDS-893
Project: jclouds
[
https://issues.apache.org/jira/browse/JCLOUDS-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526875#comment-14526875
]
Vikas Rangarajan commented on JCLOUDS-893:
--
Pull request submitted: https
Vikas Rangarajan created JCLOUDS-1304:
-
Summary: Azure: Support for custom data during VM creation to
support the injection of cloud-init user-data
Key: JCLOUDS-1304
URL: https://issues.apache.org/jira/browse
Vikas Rangarajan created JCLOUDS-1305:
-
Summary: Azure: Support storing of public ssh keys in azure
keyvault
Key: JCLOUDS-1305
URL: https://issues.apache.org/jira/browse/JCLOUDS-1305
Project
Vikas Rangarajan created JCLOUDS-1372:
-
Summary: Add support for R4 instance types in AWS ec2
Key: JCLOUDS-1372
URL: https://issues.apache.org/jira/browse/JCLOUDS-1372
Project: jclouds
[
https://issues.apache.org/jira/browse/JCLOUDS-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vikas Rangarajan updated JCLOUDS-1436:
--
Docs Text:
Amazon recently introduced a new set of price-performance-optimized
Vikas Rangarajan created JCLOUDS-1436:
-
Summary: Add support for m5 instance types in AWS ec2
Key: JCLOUDS-1436
URL: https://issues.apache.org/jira/browse/JCLOUDS-1436
Project: jclouds
[
https://issues.apache.org/jira/browse/JCLOUDS-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562477#comment-16562477
]
Vikas Rangarajan commented on JCLOUDS-1387:
---
PR (better late than never): https://github.com
[
https://issues.apache.org/jira/browse/JCLOUDS-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564407#comment-16564407
]
Vikas Rangarajan commented on JCLOUDS-1436:
---
https://github.com/jclouds/jclouds/pull/1233
[
https://issues.apache.org/jira/browse/JCLOUDS-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578751#comment-16578751
]
Vikas Rangarajan edited comment on JCLOUDS-1440 at 8/13/18 6:21 PM
[
https://issues.apache.org/jira/browse/JCLOUDS-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578751#comment-16578751
]
Vikas Rangarajan edited comment on JCLOUDS-1440 at 8/13/18 6:21 PM
[
https://issues.apache.org/jira/browse/JCLOUDS-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578751#comment-16578751
]
Vikas Rangarajan commented on JCLOUDS-1440:
---
The work for this should be virtually identical
Vikas Rangarajan created JCLOUDS-1440:
-
Summary: Add support for r5 instance types in AWS ec2
Key: JCLOUDS-1440
URL: https://issues.apache.org/jira/browse/JCLOUDS-1440
Project: jclouds
[
https://issues.apache.org/jira/browse/JCLOUDS-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vikas Rangarajan updated JCLOUDS-1440:
--
Docs Text:
Amazon recently introduced a new set of price-performance-optimized EC2
[
https://issues.apache.org/jira/browse/JCLOUDS-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vikas Rangarajan updated JCLOUDS-1440:
--
Description: As a jclouds client targeting AWS EC2 as one of the deployment
cloud
[
https://issues.apache.org/jira/browse/JCLOUDS-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vikas Rangarajan updated JCLOUDS-1440:
--
Docs Text:
Amazon recently introduced a new set of price-performance-optimized EC2
[
https://issues.apache.org/jira/browse/JCLOUDS-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vikas Rangarajan updated JCLOUDS-1440:
--
Docs Text:
Amazon recently introduced a new set of price-performance-optimized EC2
Vikas Rangarajan created JCLOUDS-1387:
-
Summary: Add support for c5 instance types in AWS ec2
Key: JCLOUDS-1387
URL: https://issues.apache.org/jira/browse/JCLOUDS-1387
Project: jclouds
[
https://issues.apache.org/jira/browse/JCLOUDS-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vikas Rangarajan updated JCLOUDS-1387:
--
Description: As a jclouds client targeting AWS EC2 as one of the deployment
cloud
[
https://issues.apache.org/jira/browse/JCLOUDS-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vikas Rangarajan updated JCLOUDS-1387:
--
Description: As a jclouds client targeting AWS EC2 as one of the deployment
cloud
[
https://issues.apache.org/jira/browse/JCLOUDS-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vikas Rangarajan updated JCLOUDS-1387:
--
Docs Text:
Amazon recently introduced a new set of cpu-optimized EC2 instance types
29 matches
Mail list logo