The GitHub Actions job "Install stable version using pip" on libcloud.git has
succeeded.
Run started by GitHub user Kami (triggered by Kami).
Head commit for run:
32a3f1505e4e8c6eb14383b3d93e77e60a2b73de / Tomaz Muraus
Merge pull request #2002 from
codecov-commenter commented on PR #2004:
URL: https://github.com/apache/libcloud/pull/2004#issuecomment-2080684986
##
[Codecov](https://app.codecov.io/gh/apache/libcloud/pull/2004?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
Kami merged PR #2004:
URL: https://github.com/apache/libcloud/pull/2004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
codecov-commenter commented on PR #1983:
URL: https://github.com/apache/libcloud/pull/1983#issuecomment-2080694604
##
[Codecov](https://app.codecov.io/gh/apache/libcloud/pull/1983?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
This is an automated email from the ASF dual-hosted git repository.
tomaz pushed a change to branch dependabot/pip/libvirt-python-10.2.0
in repository https://gitbox.apache.org/repos/asf/libcloud.git
was 6edd71fbc Merge branch 'trunk' into
dependabot/pip/libvirt-python-10.2.0
The
This is an automated email from the ASF dual-hosted git repository.
tomaz pushed a change to branch trunk
in repository https://gitbox.apache.org/repos/asf/libcloud.git
from ee7768f21 Merge pull request #2003 from
apache/dependabot/github_actions/codecov/codecov-action-4.3.0
add
This is an automated email from the ASF dual-hosted git repository.
tomaz pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/libcloud.git
commit 6f1f83d57fb6bbf7d932ea2c4e312ba5fd86fb81
Merge: ee7768f21 6edd71fbc
Author: Tomaz Muraus
AuthorDate: Sat Apr 27
This is an automated email from the ASF dual-hosted git repository.
tomaz pushed a change to branch
dependabot/github_actions/codecov/codecov-action-4.3.0
in repository https://gitbox.apache.org/repos/asf/libcloud.git
was fab9914b9 Bump codecov/codecov-action from 3.1.4 to 4.3.0
The
This is an automated email from the ASF dual-hosted git repository.
tomaz pushed a change to branch trunk
in repository https://gitbox.apache.org/repos/asf/libcloud.git
from 32a3f1505 Merge pull request #2002 from
apache/dependabot/github_actions/actions/cache-4
add fab9914b9 Bump
Kami merged PR #2003:
URL: https://github.com/apache/libcloud/pull/2003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
tomaz pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/libcloud.git
commit ee7768f21293bd1bd94e728d08843eaaa48156b5
Merge: 32a3f1505 fab9914b9
Author: Tomaz Muraus
AuthorDate: Sat Apr 27
This is an automated email from the ASF dual-hosted git repository.
tomaz pushed a change to branch dependabot/pip/libvirt-python-10.2.0
in repository https://gitbox.apache.org/repos/asf/libcloud.git
from 1120fd122 Bump libvirt-python from 9.6.0 to 10.2.0
add 4f21dbf0a Bump
Kami commented on code in PR #1983:
URL: https://github.com/apache/libcloud/pull/1983#discussion_r1581833632
##
libcloud/compute/drivers/kubevirt.py:
##
@@ -179,125 +245,103 @@ def destroy_node(self, node):
except Exception:
raise
-# only has
Kami commented on code in PR #1983:
URL: https://github.com/apache/libcloud/pull/1983#discussion_r1581834132
##
libcloud/compute/drivers/kubevirt.py:
##
@@ -391,63 +772,162 @@ def create_node(
)
raise KeyError(msg)
+
Kami commented on code in PR #1983:
URL: https://github.com/apache/libcloud/pull/1983#discussion_r1581833987
##
libcloud/compute/drivers/kubevirt.py:
##
@@ -391,63 +772,162 @@ def create_node(
)
raise KeyError(msg)
+
Kami commented on code in PR #1983:
URL: https://github.com/apache/libcloud/pull/1983#discussion_r1581834223
##
libcloud/compute/drivers/kubevirt.py:
##
@@ -1231,3 +1719,151 @@ def ex_delete_service(self, namespace, service_name):
except Exception:
raise
Kami commented on PR #1983:
URL: https://github.com/apache/libcloud/pull/1983#issuecomment-2080723773
@cdfmlr Thanks.
I had a look again. It mostly looks good, but there are a couple of
improvements which can be made:
* `_create_node()` functionality could be refactored into
Kami commented on PR #1868:
URL: https://github.com/apache/libcloud/pull/1868#issuecomment-2080724844
Closing stale PR. If it's still relevant, free to re-open or create a new
PR. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Kami closed pull request #1868: Google Cloud improvements
URL: https://github.com/apache/libcloud/pull/1868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
Kami commented on code in PR #1983:
URL: https://github.com/apache/libcloud/pull/1983#discussion_r1581834020
##
libcloud/compute/drivers/kubevirt.py:
##
@@ -391,63 +772,162 @@ def create_node(
)
raise KeyError(msg)
+
Kami commented on code in PR #1983:
URL: https://github.com/apache/libcloud/pull/1983#discussion_r1581834280
##
libcloud/compute/drivers/kubevirt.py:
##
@@ -1231,3 +1719,151 @@ def ex_delete_service(self, namespace, service_name):
except Exception:
raise
cdfmlr commented on PR #1983:
URL: https://github.com/apache/libcloud/pull/1983#issuecomment-2080812212
@Kami Thank you for the review. Indeed, the `create_node()` looks clumsy.
I've actually started refactoring it, but recent higher priority tasks have
delayed its completion.
Also,
22 matches
Mail list logo
