[jira] [Commented] (OFBIZ-10331) Improve Order
[ https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713677#comment-16713677 ] Michael Brohl commented on OFBIZ-10331: --- Hi [~Dennis Balkir], please check and update the two patches so we can close this issue, thanks! > Improve Order > - > > Key: OFBIZ-10331 > URL: https://issues.apache.org/jira/browse/OFBIZ-10331 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Deepak Dixit >Priority: Minor > Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221_common-theme.template.includes.GenericLink.patch, > OFBIZ-10221_order.template.entry.CheckInits.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, > OFBIZ-10221_order.template.entry.OrderAgreements.patch, > OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, > OFBIZ-10221_order.template.entry.OrderShortcuts.patch, > OFBIZ-10221_order.template.entry.cart.ShowCart.patch, > OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, > OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, > OFBIZ-10221_order.template.order.FindOrders.patch, > OFBIZ-10221_order.template.order.OrderList.patch, > OFBIZ-10221_order.template.order.OrderStats.patch, > OFBIZ-10331_order.template.entry.cart.PromoCode.patch, > OFBiz-10221_order.template.order.OrderContactInfo.patch, > OFBiz-10221_order.template.order.OrderInfo.patch, > OFBiz-10221_order.template.order.OrderItems.patch, > OFBiz-10221_order.template.order.OrderPaymentInfo.patch, > OFBiz-10221_order.template.order.OrderShippingInfo.patch, Sélection_156.png > > > All improvements for layout and structure for the Order-Application -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10331) Improve Order
[ https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547513#comment-16547513 ] Deepak Dixit commented on OFBIZ-10331: -- Thanks [~Dennis Balkir] > Improve Order > - > > Key: OFBIZ-10331 > URL: https://issues.apache.org/jira/browse/OFBIZ-10331 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Deepak Dixit >Priority: Minor > Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221_common-theme.template.includes.GenericLink.patch, > OFBIZ-10221_order.template.entry.CheckInits.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, > OFBIZ-10221_order.template.entry.OrderAgreements.patch, > OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, > OFBIZ-10221_order.template.entry.OrderShortcuts.patch, > OFBIZ-10221_order.template.entry.cart.ShowCart.patch, > OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, > OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, > OFBIZ-10221_order.template.order.FindOrders.patch, > OFBIZ-10221_order.template.order.OrderList.patch, > OFBIZ-10221_order.template.order.OrderStats.patch, > OFBIZ-10331_order.template.entry.cart.PromoCode.patch, > OFBiz-10221_order.template.order.OrderContactInfo.patch, > OFBiz-10221_order.template.order.OrderInfo.patch, > OFBiz-10221_order.template.order.OrderItems.patch, > OFBiz-10221_order.template.order.OrderPaymentInfo.patch, > OFBiz-10221_order.template.order.OrderShippingInfo.patch, Sélection_156.png > > > All improvements for layout and structure for the Order-Application -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10331) Improve Order
[ https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547509#comment-16547509 ] Dennis Balkir commented on OFBIZ-10331: --- Hi Deepak, I will take another look at the patch for ShowCart and provide a better solution, if necessary, asap. Thanks > Improve Order > - > > Key: OFBIZ-10331 > URL: https://issues.apache.org/jira/browse/OFBIZ-10331 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Deepak Dixit >Priority: Minor > Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221_common-theme.template.includes.GenericLink.patch, > OFBIZ-10221_order.template.entry.CheckInits.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, > OFBIZ-10221_order.template.entry.OrderAgreements.patch, > OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, > OFBIZ-10221_order.template.entry.OrderShortcuts.patch, > OFBIZ-10221_order.template.entry.cart.ShowCart.patch, > OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, > OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, > OFBIZ-10221_order.template.order.FindOrders.patch, > OFBIZ-10221_order.template.order.OrderList.patch, > OFBIZ-10221_order.template.order.OrderStats.patch, > OFBIZ-10331_order.template.entry.cart.PromoCode.patch, > OFBiz-10221_order.template.order.OrderContactInfo.patch, > OFBiz-10221_order.template.order.OrderInfo.patch, > OFBiz-10221_order.template.order.OrderItems.patch, > OFBiz-10221_order.template.order.OrderPaymentInfo.patch, > OFBiz-10221_order.template.order.OrderShippingInfo.patch, Sélection_156.png > > > All improvements for layout and structure for the Order-Application -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10331) Improve Order
[ https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544139#comment-16544139 ] Deepak Dixit commented on OFBIZ-10331: -- Thanks [~Dennis Balkir] for your contribution. I excluded following patches - OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch: After applying this UX got not looks good. - OFBIZ-10221_order.template.entry.cart.ShowCart.patch: This patch has some markup issue, form inside table is not implemented correctly. Apart from able patches, slightly modified patches has been committed at r#1835889 > Improve Order > - > > Key: OFBIZ-10331 > URL: https://issues.apache.org/jira/browse/OFBIZ-10331 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Deepak Dixit >Priority: Minor > Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221_common-theme.template.includes.GenericLink.patch, > OFBIZ-10221_order.template.entry.CheckInits.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, > OFBIZ-10221_order.template.entry.OrderAgreements.patch, > OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, > OFBIZ-10221_order.template.entry.OrderShortcuts.patch, > OFBIZ-10221_order.template.entry.cart.ShowCart.patch, > OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, > OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, > OFBIZ-10221_order.template.order.FindOrders.patch, > OFBIZ-10221_order.template.order.OrderList.patch, > OFBIZ-10221_order.template.order.OrderStats.patch, > OFBIZ-10331_order.template.entry.cart.PromoCode.patch, > OFBiz-10221_order.template.order.OrderContactInfo.patch, > OFBiz-10221_order.template.order.OrderInfo.patch, > OFBiz-10221_order.template.order.OrderItems.patch, > OFBiz-10221_order.template.order.OrderPaymentInfo.patch, > OFBiz-10221_order.template.order.OrderShippingInfo.patch, Sélection_156.png > > > All improvements for layout and structure for the Order-Application -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10331) Improve Order
[ https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538378#comment-16538378 ] Dennis Balkir commented on OFBIZ-10331: --- I noticed another mistake, somehow one closing div container went missing. I uploaded a new patch for OrderEntryTabBar, which is slightly bigger too, since I already formatted it correctly and it shows the change of position for now more indented lines of code. I hope this is still understandable > Improve Order > - > > Key: OFBIZ-10331 > URL: https://issues.apache.org/jira/browse/OFBIZ-10331 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Deepak Dixit >Priority: Minor > Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221_common-theme.template.includes.GenericLink.patch, > OFBIZ-10221_order.template.entry.CheckInits.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, > OFBIZ-10221_order.template.entry.OrderAgreements.patch, > OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, > OFBIZ-10221_order.template.entry.OrderShortcuts.patch, > OFBIZ-10221_order.template.entry.cart.ShowCart.patch, > OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, > OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, > OFBIZ-10221_order.template.order.FindOrders.patch, > OFBIZ-10221_order.template.order.OrderList.patch, > OFBIZ-10221_order.template.order.OrderStats.patch, > OFBIZ-10331_order.template.entry.cart.PromoCode.patch, > OFBiz-10221_order.template.order.OrderContactInfo.patch, > OFBiz-10221_order.template.order.OrderInfo.patch, > OFBiz-10221_order.template.order.OrderItems.patch, > OFBiz-10221_order.template.order.OrderPaymentInfo.patch, > OFBiz-10221_order.template.order.OrderShippingInfo.patch, Sélection_156.png > > > All improvements for layout and structure for the Order-Application -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10331) Improve Order
[ https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534968#comment-16534968 ] Dennis Balkir commented on OFBIZ-10331: --- I also added a new patch, for promo codes. It's not much, but there was an unnecessary hardcoded whitespace in it, which I removed > Improve Order > - > > Key: OFBIZ-10331 > URL: https://issues.apache.org/jira/browse/OFBIZ-10331 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Deepak Dixit >Priority: Minor > Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221_common-theme.template.includes.GenericLink.patch, > OFBIZ-10221_order.template.entry.CheckInits.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, > OFBIZ-10221_order.template.entry.OrderAgreements.patch, > OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, > OFBIZ-10221_order.template.entry.OrderShortcuts.patch, > OFBIZ-10221_order.template.entry.cart.ShowCart.patch, > OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, > OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, > OFBIZ-10221_order.template.order.FindOrders.patch, > OFBIZ-10221_order.template.order.OrderList.patch, > OFBIZ-10221_order.template.order.OrderStats.patch, > OFBIZ-10331_order.template.entry.cart.PromoCode.patch, > OFBiz-10221_order.template.order.OrderContactInfo.patch, > OFBiz-10221_order.template.order.OrderInfo.patch, > OFBiz-10221_order.template.order.OrderItems.patch, > OFBiz-10221_order.template.order.OrderPaymentInfo.patch, > OFBiz-10221_order.template.order.OrderShippingInfo.patch, Sélection_156.png > > > All improvements for layout and structure for the Order-Application -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10331) Improve Order
[ https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534963#comment-16534963 ] Dennis Balkir commented on OFBIZ-10331: --- Hi [~soledad], I checked the patches and found you're right, I am sorry. The two patches with problems were in fact not correct patchfiles, I made new ones and removed the old files, this time tested them beforehand. About OrderHeaderInfo, I found, that after applying the patch, I had the same issues. Somehow my cache must have tricked me last time. I suggest to remove this one completely, since it would not have any real purpose anymore Thanks > Improve Order > - > > Key: OFBIZ-10331 > URL: https://issues.apache.org/jira/browse/OFBIZ-10331 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Deepak Dixit >Priority: Minor > Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221_common-theme.template.includes.GenericLink.patch, > OFBIZ-10221_order.template.entry.CheckInits.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, > OFBIZ-10221_order.template.entry.OrderAgreements.patch, > OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, > OFBIZ-10221_order.template.entry.OrderShortcuts.patch, > OFBIZ-10221_order.template.entry.cart.ShowCart.patch, > OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, > OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, > OFBIZ-10221_order.template.order.FindOrders.patch, > OFBIZ-10221_order.template.order.OrderList.patch, > OFBIZ-10221_order.template.order.OrderStats.patch, > OFBIZ-10331_order.template.entry.cart.PromoCode.patch, > OFBiz-10221_order.template.order.OrderContactInfo.patch, > OFBiz-10221_order.template.order.OrderInfo.patch, > OFBiz-10221_order.template.order.OrderItems.patch, > OFBiz-10221_order.template.order.OrderPaymentInfo.patch, > OFBiz-10221_order.template.order.OrderShippingInfo.patch, Sélection_156.png > > > All improvements for layout and structure for the Order-Application -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10331) Improve Order
[
https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457426#comment-16457426
]
Nicolas Malin commented on OFBIZ-10331:
---
Hi Dennis, I checked some patches and I have a issue with
[^OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch] with display the form
!Sélection_156.png!
I didn't know if it the waiting result.
A little problem for with patch
OFBIZ-10221_order.template.order.FindOrders.patch
{code:java}
poveglia$ patch -p1 <
~/Téléchargements/OFBIZ-10221_order.template.order.FindOrders.patch
patching file applications/order/template/order/FindOrders.ftl
patch: malformed patch at line 434:
{code}
and patch OFBiz-10221_order.template.order.OrderInfo.patch
{code:java}
poveglia$ svn info
Révision : 1830238
poveglia$ patch -p1 <
~/Téléchargements/OFBiz-10221_order.template.order.OrderInfo.patch
patching file applications/order/template/order/OrderInfo.ftl
Hunk #1 succeeded at 96 (offset -4 lines).
...
Hunk #8 succeeded at 223 (offset -4 lines).
Hunk #9 FAILED at 236.
Hunk #10 FAILED at 253.
Hunk #11 FAILED at 270.
Hunk #12 succeeded at 285 (offset -5 lines).
3 out of 12 hunks FAILED -- saving rejects to file
applications/order/template/order/OrderInfo.ftl.rej{code}
I will continue the review later for other patches
thanks for your thorough work
> Improve Order
> -
>
> Key: OFBIZ-10331
> URL: https://issues.apache.org/jira/browse/OFBIZ-10331
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch,
> OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch,
> OFBIZ-10221_common-theme.template.includes.GenericLink.patch,
> OFBIZ-10221_order.template.entry.CheckInits.patch,
> OFBIZ-10221_order.template.entry.ChooseCatalog.patch,
> OFBIZ-10221_order.template.entry.ChooseCatalog2.patch,
> OFBIZ-10221_order.template.entry.OrderAgreements.patch,
> OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch,
> OFBIZ-10221_order.template.entry.OrderShortcuts.patch,
> OFBIZ-10221_order.template.entry.cart.ShowCart.patch,
> OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch,
> OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch,
> OFBIZ-10221_order.template.order.FindOrders.patch,
> OFBIZ-10221_order.template.order.OrderList.patch,
> OFBIZ-10221_order.template.order.OrderStats.patch,
> OFBiz-10221_order.template.order.OrderContactInfo.patch,
> OFBiz-10221_order.template.order.OrderInfo.patch,
> OFBiz-10221_order.template.order.OrderItems.patch,
> OFBiz-10221_order.template.order.OrderPaymentInfo.patch,
> OFBiz-10221_order.template.order.OrderShippingInfo.patch, Sélection_156.png
>
>
> All improvements for layout and structure for the Order-Application
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10331) Improve Order
[ https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430637#comment-16430637 ] Dennis Balkir commented on OFBIZ-10331: --- I added a new patch and this should fix this error > Improve Order > - > > Key: OFBIZ-10331 > URL: https://issues.apache.org/jira/browse/OFBIZ-10331 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221_common-theme.template.includes.GenericLink.patch, > OFBIZ-10221_order.template.entry.CheckInits.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, > OFBIZ-10221_order.template.entry.OrderAgreements.patch, > OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, > OFBIZ-10221_order.template.entry.OrderShortcuts.patch, > OFBIZ-10221_order.template.entry.cart.ShowCart.patch, > OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, > OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, > OFBIZ-10221_order.template.order.FindOrders.patch, > OFBIZ-10221_order.template.order.OrderList.patch, > OFBIZ-10221_order.template.order.OrderStats.patch, > OFBiz-10221_order.template.order.OrderContactInfo.patch, > OFBiz-10221_order.template.order.OrderInfo.patch, > OFBiz-10221_order.template.order.OrderItems.patch, > OFBiz-10221_order.template.order.OrderPaymentInfo.patch, > OFBiz-10221_order.template.order.OrderShippingInfo.patch > > > All improvements for layout and structure for the Order-Application -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10331) Improve Order
[
https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430497#comment-16430497
]
Deepak Dixit commented on OFBIZ-10331:
--
HI [~Dennis Balkir]
I am talking about following code snippet , you can your markup
[here|https://validator.w3.org]
{code:java}
+
+
+
+
+
+ ${uiLabelMap.OrderOrderName}:
+
+
{code}
> Improve Order
> -
>
> Key: OFBIZ-10331
> URL: https://issues.apache.org/jira/browse/OFBIZ-10331
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch,
> OFBIZ-10221_common-theme.template.includes.GenericLink.patch,
> OFBIZ-10221_order.template.entry.CheckInits.patch,
> OFBIZ-10221_order.template.entry.ChooseCatalog.patch,
> OFBIZ-10221_order.template.entry.ChooseCatalog2.patch,
> OFBIZ-10221_order.template.entry.OrderAgreements.patch,
> OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch,
> OFBIZ-10221_order.template.entry.OrderShortcuts.patch,
> OFBIZ-10221_order.template.entry.cart.ShowCart.patch,
> OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch,
> OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch,
> OFBIZ-10221_order.template.order.FindOrders.patch,
> OFBIZ-10221_order.template.order.OrderList.patch,
> OFBIZ-10221_order.template.order.OrderStats.patch,
> OFBiz-10221_order.template.order.OrderContactInfo.patch,
> OFBiz-10221_order.template.order.OrderInfo.patch,
> OFBiz-10221_order.template.order.OrderItems.patch,
> OFBiz-10221_order.template.order.OrderPaymentInfo.patch,
> OFBiz-10221_order.template.order.OrderShippingInfo.patch
>
>
> All improvements for layout and structure for the Order-Application
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10331) Improve Order
[
https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430456#comment-16430456
]
Dennis Balkir commented on OFBIZ-10331:
---
Hi Deepak Dixit,
can you specify what you mean? I am maybe overlooking the problem at the
moment, but I don't really know where {{form}} is a child of {{table}}
> Improve Order
> -
>
> Key: OFBIZ-10331
> URL: https://issues.apache.org/jira/browse/OFBIZ-10331
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch,
> OFBIZ-10221_common-theme.template.includes.GenericLink.patch,
> OFBIZ-10221_order.template.entry.CheckInits.patch,
> OFBIZ-10221_order.template.entry.ChooseCatalog.patch,
> OFBIZ-10221_order.template.entry.ChooseCatalog2.patch,
> OFBIZ-10221_order.template.entry.OrderAgreements.patch,
> OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch,
> OFBIZ-10221_order.template.entry.OrderShortcuts.patch,
> OFBIZ-10221_order.template.entry.cart.ShowCart.patch,
> OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch,
> OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch,
> OFBIZ-10221_order.template.order.FindOrders.patch,
> OFBIZ-10221_order.template.order.OrderList.patch,
> OFBIZ-10221_order.template.order.OrderStats.patch,
> OFBiz-10221_order.template.order.OrderContactInfo.patch,
> OFBiz-10221_order.template.order.OrderInfo.patch,
> OFBiz-10221_order.template.order.OrderItems.patch,
> OFBiz-10221_order.template.order.OrderPaymentInfo.patch,
> OFBiz-10221_order.template.order.OrderShippingInfo.patch
>
>
> All improvements for layout and structure for the Order-Application
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10331) Improve Order
[ https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430440#comment-16430440 ] Deepak Dixit commented on OFBIZ-10331: -- Hi Dennis Balkir , I reviewed OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, in this patch you used form inside table and its semantically incorrect markup, and form is not a valid child of table, To fix UX pattern we can't use semantically incorrect markup. > Improve Order > - > > Key: OFBIZ-10331 > URL: https://issues.apache.org/jira/browse/OFBIZ-10331 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221_common-theme.template.includes.GenericLink.patch, > OFBIZ-10221_order.template.entry.CheckInits.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, > OFBIZ-10221_order.template.entry.OrderAgreements.patch, > OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, > OFBIZ-10221_order.template.entry.OrderShortcuts.patch, > OFBIZ-10221_order.template.entry.cart.ShowCart.patch, > OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, > OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, > OFBIZ-10221_order.template.order.FindOrders.patch, > OFBIZ-10221_order.template.order.OrderList.patch, > OFBIZ-10221_order.template.order.OrderStats.patch, > OFBiz-10221_order.template.order.OrderContactInfo.patch, > OFBiz-10221_order.template.order.OrderInfo.patch, > OFBiz-10221_order.template.order.OrderItems.patch, > OFBiz-10221_order.template.order.OrderPaymentInfo.patch, > OFBiz-10221_order.template.order.OrderShippingInfo.patch > > > All improvements for layout and structure for the Order-Application -- This message was sent by Atlassian JIRA (v7.6.3#76005)
