[jira] [Commented] (OFBIZ-10969) Unable to create Employments

2019-05-20 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844135#comment-16844135
 ] 

Jacques Le Roux commented on OFBIZ-10969:
-

Thanks Olivier,

>From what I understand it suffices to commit the patch at OFBIZ-11028 and then 
>both tickets can be closed. This implies, as you wrote above, that:

bq.  In the HR test scenario, I start by create an employee and after an 
employment, so all works ! In the recruitment test scenario I will create a 
Party (without role EMPLOYEE) and after selection process I will test 
createEmployment to check if it do the EMPLOYEE role creation.
For now, I have added in the createEmployment service the call to 
ensurePartyRoleTo service, so now it works, even if before, partyTo is'nt 
associated to roleType EMPLOYEE.

In other words, currently if an employment is created for a non employee this 
non employee will got an Employee role and so will be an employee. I tested 
this scenario, it works (a pay history is also created and editable) and it 
seems sound to me. In other words you don't need to create an employe from an 
existing person before creating an employment for this person. 

I commited the fix from OFBIZ-11028 in trunk at revision: 1859571

By default we always try to backport bugs fixes, so I did so here (actually in 
OFBIZ-11028)
R18 r1859572
R17 r1859573
R17 r1859574 (conflict in HumanResServices.xml handled by hand)

> Unable to create Employments
> 
>
> Key: OFBIZ-10969
> URL: https://issues.apache.org/jira/browse/OFBIZ-10969
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: Image1.png
>
>
> Steps to regenerate:
>  # Login to the URL: 
> [https://demo-trunk.ofbiz.apache.org/humanres/control/main]
>  # Click on Employments
>  # Click on New Employments
>  # Click on Create
> Actual: Error message is displayed. Please refer attachment: Image1



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10969) Unable to create Employments

2019-05-18 Thread Olivier Heintz (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843123#comment-16843123
 ] 

Olivier Heintz commented on OFBIZ-10969:


Hi Jacques,

One more time, I'm not clear.

I don't want to *not* follow OFBiz community standard process.
My remark was : For this Jira and it's sub-task, I have proposed a solution and 
I think it solve the problem ;)
In other Jira/task I done some UI Test Scenario associated with documentation, 
I think it's not needed to link the Jiras, so this Jira can be commit.

on other hand, if for this Jira and sub-task (but only them) , it's necessary 
to do more actions to solve it, give me the detail of what it's needed, and I 
will try to do it.

 

Yes it's a bug, but like a missing function, so solution add a new function, so 
I don't know If it's necessary to backport it.
Currently I have not test in other releases.
Say me, I need to do it (and create patch if there are difference).

Thank you for your review

> Unable to create Employments
> 
>
> Key: OFBIZ-10969
> URL: https://issues.apache.org/jira/browse/OFBIZ-10969
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: Image1.png
>
>
> Steps to regenerate:
>  # Login to the URL: 
> [https://demo-trunk.ofbiz.apache.org/humanres/control/main]
>  # Click on Employments
>  # Click on New Employments
>  # Click on Create
> Actual: Error message is displayed. Please refer attachment: Image1



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10969) Unable to create Employments

2019-05-17 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842321#comment-16842321
 ] 

Jacques Le Roux commented on OFBIZ-10969:
-

Hi Olivier,

I, for one, am not strictly against. But I don't very like to commit temporary 
things in order to help a contributor. I already seen such things not ending 
very well. Of course that could be discussed in dev ML and a community 
agreement would remove this issue on my side, and would make it more known, not 
only by you and me.

BTW, you say:
bq. because without commit  I cannot use the current test (Employee Training 
and Development) on OFBiz demo.

Can't you work on your side without commiting in trunk? What does block you? 
Can't you have several instances with different settings running in parallel on 
your own machine?

BTW as it's a bug this will need to be backported. I guess all supported 
releases are concerned, right?

> Unable to create Employments
> 
>
> Key: OFBIZ-10969
> URL: https://issues.apache.org/jira/browse/OFBIZ-10969
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: Image1.png
>
>
> Steps to regenerate:
>  # Login to the URL: 
> [https://demo-trunk.ofbiz.apache.org/humanres/control/main]
>  # Click on Employments
>  # Click on New Employments
>  # Click on Create
> Actual: Error message is displayed. Please refer attachment: Image1



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10969) Unable to create Employments

2019-05-17 Thread Olivier Heintz (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842168#comment-16842168
 ] 

Olivier Heintz commented on OFBIZ-10969:


If possible not waiting, 
because without commit  I cannot use the current test (Employee Training and 
Development) on OFBiz demo.

I prefer working on the same time on documentation and tests realization

Recruitment is the last of the HR process, and it seem it will need some other 
corrections :(

> Unable to create Employments
> 
>
> Key: OFBIZ-10969
> URL: https://issues.apache.org/jira/browse/OFBIZ-10969
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: Image1.png
>
>
> Steps to regenerate:
>  # Login to the URL: 
> [https://demo-trunk.ofbiz.apache.org/humanres/control/main]
>  # Click on Employments
>  # Click on New Employments
>  # Click on Create
> Actual: Error message is displayed. Please refer attachment: Image1



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10969) Unable to create Employments

2019-05-16 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841406#comment-16841406
 ] 

Jacques Le Roux commented on OFBIZ-10969:
-

Thanks Olivier,

That all makes sense. It seems to me that we should wait for recruitment test 
scenario to be enforced before committing, right?

> Unable to create Employments
> 
>
> Key: OFBIZ-10969
> URL: https://issues.apache.org/jira/browse/OFBIZ-10969
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: Image1.png
>
>
> Steps to regenerate:
>  # Login to the URL: 
> [https://demo-trunk.ofbiz.apache.org/humanres/control/main]
>  # Click on Employments
>  # Click on New Employments
>  # Click on Create
> Actual: Error message is displayed. Please refer attachment: Image1



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10969) Unable to create Employments

2019-05-16 Thread Olivier Heintz (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841341#comment-16841341
 ] 

Olivier Heintz commented on OFBIZ-10969:


In the HR test scenario, I start by create an employee and after an employment, 
so all works !

In the recruitment test scenario I will create a Party (without role EMPLOYEE) 
and after selection process I will test createEmployment to check if it do the 
EMPLOYEE role creation.

For now, I have added in the createEmployment service the call to 
ensurePartyRoleTo service, so now it works, even if before, partyTo is'nt 
associated to roleType EMPLOYEE.
And update the OFBIZ-11028 patch

Jacques, thank you for the test.

> Unable to create Employments
> 
>
> Key: OFBIZ-10969
> URL: https://issues.apache.org/jira/browse/OFBIZ-10969
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: Image1.png
>
>
> Steps to regenerate:
>  # Login to the URL: 
> [https://demo-trunk.ofbiz.apache.org/humanres/control/main]
>  # Click on Employments
>  # Click on New Employments
>  # Click on Create
> Actual: Error message is displayed. Please refer attachment: Image1



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10969) Unable to create Employments

2019-05-15 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840277#comment-16840277
 ] 

Jacques Le Roux commented on OFBIZ-10969:
-

Oivier,

I tried to create an employment for DemoCustAgent, AUTHOR_BIGAL, AcctBuyer (all 
persons) and got these errors


{noformat}
2019-05-15 12:01:33,657 |jsse-nio-8443-exec-8 |GenericDelegator  
|E| Failure in create operation for entity [Employment]: 
org.apache.ofbiz.entity.GenericEntityException: Error while inserting: 
[GenericEntity:Employment][creat
edStamp,2019-05-15 12:01:33.596(java.sql.Timestamp)][createdTxStamp,2019-05-15 
12:01:33.472(java.sql.Timestamp)][fromDate,2019-05-15 
12:01:05.0(java.sql.Timestamp)][lastUpdatedStamp,2019-05-15 
12:01:33.596(java.sql.Timestamp)][lastUpdate
dTxStamp,2019-05-15 
12:01:33.472(java.sql.Timestamp)][partyIdFrom,Enterprise(java.lang.String)][partyIdTo,DemoCustAgent(java.lang.String)][roleTypeIdFrom,INTERNAL_ORGANIZATIO(java.lang.String)][roleTypeIdTo,EMPLOYEE(java.lang.String)]
 (S
QL Exception while executing the following:INSERT INTO OFBIZ.EMPLOYMENT 
(ROLE_TYPE_ID_FROM, ROLE_TYPE_ID_TO, PARTY_ID_FROM, PARTY_ID_TO, FROM_DATE, 
THRU_DATE, TERMINATION_REASON_ID, TERMINATION_TYPE_ID, LAST_UPDATED_STAMP, 
LAST_UPDATED_T
X_STAMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 
?, ?) (INSERT on table 'EMPLOYMENT' caused a violation of foreign key 
constraint 'EMPLMNT_TPTRL' for key (DemoCustAgent,EMPLOYEE).  The statement has 
been ro

2019-05-15 12:02:33,011 |jsse-nio-8443-exec-6 |GenericDelegator  
|E| Failure in create operation for entity [Employment]: 
org.apache.ofbiz.entity.GenericEntityException: Error while inserting: 
[GenericEntity:Employment][creat
edStamp,2019-05-15 12:02:33.009(java.sql.Timestamp)][createdTxStamp,2019-05-15 
12:02:32.932(java.sql.Timestamp)][fromDate,2019-05-15 
12:01:05.0(java.sql.Timestamp)][lastUpdatedStamp,2019-05-15 
12:02:33.009(java.sql.Timestamp)][lastUpdate
dTxStamp,2019-05-15 
12:02:32.932(java.sql.Timestamp)][partyIdFrom,Enterprise(java.lang.String)][partyIdTo,AUTHOR_BIGAL(java.lang.String)][roleTypeIdFrom,INTERNAL_ORGANIZATIO(java.lang.String)][roleTypeIdTo,EMPLOYEE(java.lang.String)]
 (SQ
L Exception while executing the following:INSERT INTO OFBIZ.EMPLOYMENT 
(ROLE_TYPE_ID_FROM, ROLE_TYPE_ID_TO, PARTY_ID_FROM, PARTY_ID_TO, FROM_DATE, 
THRU_DATE, TERMINATION_REASON_ID, TERMINATION_TYPE_ID, LAST_UPDATED_STAMP, 
LAST_UPDATED_TX
_STAMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 
?, ?) (INSERT on table 'EMPLOYMENT' caused a violation of foreign key 
constraint 'EMPLMNT_TPTRL' for key (AUTHOR_BIGAL,EMPLOYEE).  The statement has 
been roll
ed back.)). Rolling back transaction.

2019-05-15 12:03:01,726 |jsse-nio-8443-exec-4 |GenericDelegator  
|E| Failure in create operation for entity [Employment]: 
org.apache.ofbiz.entity.GenericEntityException: Error while inserting: 
[GenericEntity:Employment][creat
edStamp,2019-05-15 12:03:01.724(java.sql.Timestamp)][createdTxStamp,2019-05-15 
12:03:01.704(java.sql.Timestamp)][fromDate,2019-05-15 
12:01:05.0(java.sql.Timestamp)][lastUpdatedStamp,2019-05-15 
12:03:01.724(java.sql.Timestamp)][lastUpdate
dTxStamp,2019-05-15 
12:03:01.704(java.sql.Timestamp)][partyIdFrom,Enterprise(java.lang.String)][partyIdTo,AcctBuyer(java.lang.String)][roleTypeIdFrom,INTERNAL_ORGANIZATIO(java.lang.String)][roleTypeIdTo,EMPLOYEE(java.lang.String)]
 (SQL E
xception while executing the following:INSERT INTO OFBIZ.EMPLOYMENT 
(ROLE_TYPE_ID_FROM, ROLE_TYPE_ID_TO, PARTY_ID_FROM, PARTY_ID_TO, FROM_DATE, 
THRU_DATE, TERMINATION_REASON_ID, TERMINATION_TYPE_ID, LAST_UPDATED_STAMP, 
LAST_UPDATED_TX_ST
AMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 
?) (INSERT on table 'EMPLOYMENT' caused a violation of foreign key constraint 
'EMPLMNT_TPTRL' for key (AcctBuyer,EMPLOYEE).  The statement has been rolled bac
{noformat}

It works for DemoEmployee because s/he is already an employee and the 
payHistory is then updated. So it needs to work also for new employees...

> Unable to create Employments
> 
>
> Key: OFBIZ-10969
> URL: https://issues.apache.org/jira/browse/OFBIZ-10969
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: Image1.png
>
>
> Steps to regenerate:
>  # Login to the URL: 
> [https://demo-trunk.ofbiz.apache.org/humanres/control/main]
>  # Click on Employments
>  # Click on New Employments
>  # Click on Create
> Actual: Error message is displayed. Please refer attachment: Image1



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10969) Unable to create Employments

2019-05-15 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840258#comment-16840258
 ] 

Jacques Le Roux commented on OFBIZ-10969:
-

No worries, to clarifiy I removed them and make this issue 
dependent-on/blocked-by OFBIZ-11028

> Unable to create Employments
> 
>
> Key: OFBIZ-10969
> URL: https://issues.apache.org/jira/browse/OFBIZ-10969
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: Image1.png
>
>
> Steps to regenerate:
>  # Login to the URL: 
> [https://demo-trunk.ofbiz.apache.org/humanres/control/main]
>  # Click on Employments
>  # Click on New Employments
>  # Click on Create
> Actual: Error message is displayed. Please refer attachment: Image1



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10969) Unable to create Employments

2019-05-15 Thread Olivier Heintz (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840227#comment-16840227
 ] 

Olivier Heintz commented on OFBIZ-10969:


Yes, and the two patch are included in OFBIZ-11028 so it's not needed to 
install them.

Apologize for added patch in this task

> Unable to create Employments
> 
>
> Key: OFBIZ-10969
> URL: https://issues.apache.org/jira/browse/OFBIZ-10969
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: Image1.png, OFBIZ-10969.HumanResServices.xml.patch, 
> OFBIZ-10969.services.xml.patch
>
>
> Steps to regenerate:
>  # Login to the URL: 
> [https://demo-trunk.ofbiz.apache.org/humanres/control/main]
>  # Click on Employments
>  # Click on New Employments
>  # Click on Create
> Actual: Error message is displayed. Please refer attachment: Image1



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10969) Unable to create Employments

2019-05-15 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840113#comment-16840113
 ] 

Jacques Le Roux commented on OFBIZ-10969:
-

I guess OFBIZ-11028 patch should be applied before, right? (It applies)

> Unable to create Employments
> 
>
> Key: OFBIZ-10969
> URL: https://issues.apache.org/jira/browse/OFBIZ-10969
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: Image1.png, OFBIZ-10969.HumanResServices.xml.patch, 
> OFBIZ-10969.services.xml.patch
>
>
> Steps to regenerate:
>  # Login to the URL: 
> [https://demo-trunk.ofbiz.apache.org/humanres/control/main]
>  # Click on Employments
>  # Click on New Employments
>  # Click on Create
> Actual: Error message is displayed. Please refer attachment: Image1



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10969) Unable to create Employments

2019-05-15 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840109#comment-16840109
 ] 

Jacques Le Roux commented on OFBIZ-10969:
-

Sorry Olivier,

Your patches don't apply on trunk HEAD. I guess you need to upgrade before 
creating the patches...

> Unable to create Employments
> 
>
> Key: OFBIZ-10969
> URL: https://issues.apache.org/jira/browse/OFBIZ-10969
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: Image1.png, OFBIZ-10969.HumanResServices.xml.patch, 
> OFBIZ-10969.services.xml.patch
>
>
> Steps to regenerate:
>  # Login to the URL: 
> [https://demo-trunk.ofbiz.apache.org/humanres/control/main]
>  # Click on Employments
>  # Click on New Employments
>  # Click on Create
> Actual: Error message is displayed. Please refer attachment: Image1



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10969) Unable to create Employments

2019-05-13 Thread Olivier Heintz (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838589#comment-16838589
 ] 

Olivier Heintz commented on OFBIZ-10969:


Employment is associated with PayHistory, and there is a problem in PayHistory 
entity definition in OFBiz,

In PayHistory, the field fromDate from Employment is confused with fromDate 
about the current record.
I have created a sub-task of this task to add the field emplFromDate to 
PayHistory and update associated services.

The current patch HumanResServices.xml need the new field.

> Unable to create Employments
> 
>
> Key: OFBIZ-10969
> URL: https://issues.apache.org/jira/browse/OFBIZ-10969
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Priority: Major
> Attachments: Image1.png, OFBIZ-10969.HumanResServices.xml.patch, 
> OFBIZ-10969.services.xml.patch
>
>
> Steps to regenerate:
>  # Login to the URL: 
> [https://demo-trunk.ofbiz.apache.org/humanres/control/main]
>  # Click on Employments
>  # Click on New Employments
>  # Click on Create
> Actual: Error message is displayed. Please refer attachment: Image1



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)