[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660756#comment-16660756 ] ASF GitHub Bot commented on RYA-405: Github user ejwhite922 commented on the issue: https://github.com/apache/incubator-rya/pull/291 @jomach This will be in the next published release of Rya (4.0.0). It is not available on any repo yet. Until then the source can be built locally from master. > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Assignee: Eric White >Priority: Major > Fix For: 4.0.0 > > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660249#comment-16660249 ] ASF GitHub Bot commented on RYA-405: Github user jomach commented on the issue: https://github.com/apache/incubator-rya/pull/291 which version of rya is this pr in ? Is it on mvnrepository.com ? > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Assignee: Eric White >Priority: Major > Fix For: 4.0.0 > > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451088#comment-16451088 ] ASF GitHub Bot commented on RYA-405: Github user jomach closed the pull request at: https://github.com/apache/incubator-rya/pull/245 > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Assignee: Eric White >Priority: Major > Fix For: 4.0.0 > > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450382#comment-16450382 ] ASF GitHub Bot commented on RYA-405: Github user ejwhite922 commented on the issue: https://github.com/apache/incubator-rya/pull/245 @jomach could you close this PR when you have a chance? It's a duplicate of [PR-291](https://github.com/apache/incubator-rya/pull/291) which has been pulled in and closed. Thanks. > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Assignee: Eric White >Priority: Major > Fix For: 4.0.0 > > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450356#comment-16450356 ] ASF GitHub Bot commented on RYA-405: Github user kchilton2 commented on the issue: https://github.com/apache/incubator-rya/pull/245 This can be closed. Eric finished this work and it has been pulled into master. > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Assignee: Eric White >Priority: Major > Fix For: 4.0.0 > > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448138#comment-16448138 ] ASF GitHub Bot commented on RYA-405: Github user asfgit closed the pull request at: https://github.com/apache/incubator-rya/pull/291 > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Assignee: Eric White >Priority: Major > Fix For: 4.0.0 > > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446442#comment-16446442 ] ASF GitHub Bot commented on RYA-405: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/291 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/738/ > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Assignee: Eric White >Priority: Major > Fix For: 4.0.0 > > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446124#comment-16446124 ] ASF GitHub Bot commented on RYA-405: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/291 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/737/ > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Assignee: Eric White >Priority: Major > Fix For: 4.0.0 > > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446046#comment-16446046 ] ASF GitHub Bot commented on RYA-405: Github user kchilton2 commented on the issue: https://github.com/apache/incubator-rya/pull/291 I'd say ship it. > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Assignee: Eric White >Priority: Major > Fix For: 4.0.0 > > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444945#comment-16444945 ] ASF GitHub Bot commented on RYA-405: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/291 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/735/ > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Assignee: Eric White >Priority: Major > Fix For: 4.0.0 > > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444740#comment-16444740
]
ASF GitHub Bot commented on RYA-405:
Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/291#discussion_r182874363
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/domain/VarNameUtils.java ---
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.rya.api.domain;
+
+import org.apache.commons.lang.StringUtils;
+import org.eclipse.rdf4j.model.Value;
+import org.eclipse.rdf4j.model.ValueFactory;
+import org.eclipse.rdf4j.model.impl.SimpleValueFactory;
+import org.eclipse.rdf4j.query.algebra.Var;
+import org.eclipse.rdf4j.query.algebra.helpers.TupleExprs;
+
+/**
+ * Utility methods and constants for RDF {@link Var} names.
+ */
+public final class VarNameUtils {
+private static final ValueFactory VF =
SimpleValueFactory.getInstance();
+
+/**
+ * Prepended to the start of constant var names.
+ */
+public static final String CONSTANT_PREFIX = "_const_";
+private static final String LEGACY_CONSTANT_PREFIX = "-const-";
+
+/**
+ * Prepended to the start of anonymous var names.
+ */
+public static final String ANONYMOUS_PREFIX = "_anon_";
+private static final String LEGACY_ANONYMOUS_PREFIX = "-anon-";
+
+/**
+ * Private constructor to prevent instantiation.
+ */
+private VarNameUtils() {
+}
+
+/**
+ * Prepends the constant prefix to the specified value.
+ * @param value the value to add the constant prefix to.
+ * @return the value with the constant prefix attached before it.
+ */
+public static String prependConstant(final String value) {
--- End diff --
Done
> Migrate from Sesame to rdf4j libs
> --
>
> Key: RYA-405
> URL: https://issues.apache.org/jira/browse/RYA-405
> Project: Rya
> Issue Type: Improvement
>Affects Versions: 3.2.12
>Reporter: Jorge Machado
>Assignee: Eric White
>Priority: Major
> Fix For: 4.0.0
>
>
> I have migrated all the project to the newer libs from rdf4j instead of using
> the old ones.
> Can someone take a look ?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444718#comment-16444718 ] ASF GitHub Bot commented on RYA-405: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/291 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/734/ > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Assignee: Eric White >Priority: Major > Fix For: 4.0.0 > > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444717#comment-16444717 ] ASF GitHub Bot commented on RYA-405: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/291 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/733/ > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Assignee: Eric White >Priority: Major > Fix For: 4.0.0 > > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444651#comment-16444651
]
ASF GitHub Bot commented on RYA-405:
Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/291#discussion_r182854497
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/domain/VarNameUtils.java ---
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.rya.api.domain;
+
+import org.apache.commons.lang.StringUtils;
+import org.eclipse.rdf4j.model.Value;
+import org.eclipse.rdf4j.model.ValueFactory;
+import org.eclipse.rdf4j.model.impl.SimpleValueFactory;
+import org.eclipse.rdf4j.query.algebra.Var;
+import org.eclipse.rdf4j.query.algebra.helpers.TupleExprs;
+
+/**
+ * Utility methods and constants for RDF {@link Var} names.
+ */
+public final class VarNameUtils {
--- End diff --
Yea, this was the biggest obstacle to get our stuff working with RDF4J.
They changed the tags used to mark constant and anonymous var names ("-const-"
to "_const_" and "-anon-" to "_anon_"). And our code had tons of checks for
the old tags using hard-coded strings everywhere. Now everything at least
references this class so it won't be hard to see what calls its methods. I
tried to mimic the old functionality with this but maybe we can eventually
deprecate if there's another way (I didn't see one in RDF4J that handled
Strings).
> Migrate from Sesame to rdf4j libs
> --
>
> Key: RYA-405
> URL: https://issues.apache.org/jira/browse/RYA-405
> Project: Rya
> Issue Type: Improvement
>Affects Versions: 3.2.12
>Reporter: Jorge Machado
>Assignee: Eric White
>Priority: Major
> Fix For: 4.0.0
>
>
> I have migrated all the project to the newer libs from rdf4j instead of using
> the old ones.
> Can someone take a look ?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444616#comment-16444616 ] ASF GitHub Bot commented on RYA-405: Github user ejwhite922 commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/291#discussion_r182849235 --- Diff: extras/vagrantExample/src/main/vagrant/Vagrantfile --- @@ -52,8 +52,8 @@ Vagrant.configure(2) do |config| export ACCUMULO_VERSION=1.6.5 ###export ACCUMULO_VERSION=1.7.1 export HADOOP_VERSION=2.7.2 -export RYA_EXAMPLE_VERSION=3.2.10-SNAPSHOT -export SESAME_VERSION=2.7.6 +export RYA_EXAMPLE_VERSION=3.2.13-SNAPSHOT --- End diff -- Changed > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Assignee: Eric White >Priority: Major > Fix For: 4.0.0 > > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444618#comment-16444618
]
ASF GitHub Bot commented on RYA-405:
Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/291#discussion_r182849348
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/persist/index/RyaSecondaryIndexer.java
---
@@ -19,31 +19,29 @@
* under the License.
*/
-
import java.io.Closeable;
import java.io.Flushable;
import java.io.IOException;
import java.util.Collection;
import java.util.Set;
import org.apache.hadoop.conf.Configurable;
-import org.openrdf.model.URI;
-
import org.apache.rya.api.domain.RyaStatement;
import org.apache.rya.api.domain.RyaURI;
+import org.eclipse.rdf4j.model.IRI;
public interface RyaSecondaryIndexer extends Closeable, Flushable,
Configurable {
/**
* initialize after setting configuration.
*/
-public void init();
+ public void init();
--- End diff --
Fixed
> Migrate from Sesame to rdf4j libs
> --
>
> Key: RYA-405
> URL: https://issues.apache.org/jira/browse/RYA-405
> Project: Rya
> Issue Type: Improvement
>Affects Versions: 3.2.12
>Reporter: Jorge Machado
>Assignee: Eric White
>Priority: Major
> Fix For: 4.0.0
>
>
> I have migrated all the project to the newer libs from rdf4j instead of using
> the old ones.
> Can someone take a look ?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444617#comment-16444617
]
ASF GitHub Bot commented on RYA-405:
Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/291#discussion_r182849296
--- Diff: dao/accumulo.rya/pom.xml ---
@@ -43,25 +43,30 @@ under the License.
-org.openrdf.sesame
-sesame-rio-ntriples
+org.eclipse.rdf4j
+rdf4j-rio-ntriples
-org.openrdf.sesame
-sesame-rio-nquads
+org.eclipse.rdf4j
+rdf4j-rio-nquads
-org.openrdf.sesame
-sesame-queryalgebra-evaluation
+org.eclipse.rdf4j
+rdf4j-queryalgebra-evaluation
+
+
+org.eclipse.rdf4j
+rdf4j-sail-api
+${org.eclipse.rdf4j.version}
--- End diff --
Done
> Migrate from Sesame to rdf4j libs
> --
>
> Key: RYA-405
> URL: https://issues.apache.org/jira/browse/RYA-405
> Project: Rya
> Issue Type: Improvement
>Affects Versions: 3.2.12
>Reporter: Jorge Machado
>Assignee: Eric White
>Priority: Major
> Fix For: 4.0.0
>
>
> I have migrated all the project to the newer libs from rdf4j instead of using
> the old ones.
> Can someone take a look ?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444615#comment-16444615
]
ASF GitHub Bot commented on RYA-405:
Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/291#discussion_r182849095
--- Diff:
extras/indexing/src/main/java/org/apache/rya/indexing/IndexPlanValidator/ThreshholdPlanSelector.java
---
@@ -111,9 +110,9 @@ public double getCost(TupleExpr te, double indexWeight,
double commonVarWeight,
double dirProductScale;
if(queryNodeCount > nodeCount) {
-dirProductScale = 1/((double)(queryNodeCount - nodeCount));
+dirProductScale = 1/ (queryNodeCount - nodeCount);
--- End diff --
nodeCount is a double so java forces the divisor here to be a double as
well so there's no precision lost. Casting it to a double would only be needed
if queryNodeCount and nodeCount were both int's (or other less precise number
types).
> Migrate from Sesame to rdf4j libs
> --
>
> Key: RYA-405
> URL: https://issues.apache.org/jira/browse/RYA-405
> Project: Rya
> Issue Type: Improvement
>Affects Versions: 3.2.12
>Reporter: Jorge Machado
>Assignee: Eric White
>Priority: Major
> Fix For: 4.0.0
>
>
> I have migrated all the project to the newer libs from rdf4j instead of using
> the old ones.
> Can someone take a look ?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444590#comment-16444590
]
ASF GitHub Bot commented on RYA-405:
Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/291#discussion_r182846009
--- Diff:
extras/indexing/src/main/java/org/apache/rya/indexing/FilterFunctionOptimizer.java
---
@@ -157,18 +156,18 @@ private void buildQuery(final TupleExpr tupleExpr,
final StatementPattern matchS
tupleExpr.visit(fVisitor);
final List results = Lists.newArrayList();
for(int i = 0; i < fVisitor.func.size(); i++){
-results.add(new IndexingExpr(fVisitor.func.get(i),
matchStatement, fVisitor.args.get(i)));
+results.add(new IndexingExpr(fVisitor.func.get(i),
matchStatement, Arrays.stream(fVisitor.args.get(i)).toArray()));
--- End diff --
Got rid of a warning about not matching the varargs parameter type.
> Migrate from Sesame to rdf4j libs
> --
>
> Key: RYA-405
> URL: https://issues.apache.org/jira/browse/RYA-405
> Project: Rya
> Issue Type: Improvement
>Affects Versions: 3.2.12
>Reporter: Jorge Machado
>Assignee: Eric White
>Priority: Major
> Fix For: 4.0.0
>
>
> I have migrated all the project to the newer libs from rdf4j instead of using
> the old ones.
> Can someone take a look ?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444579#comment-16444579 ] ASF GitHub Bot commented on RYA-405: Github user ejwhite922 commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/291#discussion_r182844645 --- Diff: common/rya.api/src/main/java/org/apache/rya/api/domain/Node.java --- @@ -21,14 +21,14 @@ -import org.openrdf.model.impl.URIImpl; +import org.eclipse.rdf4j.model.impl.SimpleIRI; /** * A Node is an expected node in the global graph. This typing of the URI allows us to dictate the difference between a * URI that is just an Attribute on the subject vs. a URI that is another subject Node in the global graph. It does not --- End diff -- Done. I'll try to find more in javadocs. > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Assignee: Eric White >Priority: Major > Fix For: 4.0.0 > > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444577#comment-16444577 ] ASF GitHub Bot commented on RYA-405: Github user ejwhite922 commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/291#discussion_r182844330 --- Diff: common/rya.api/src/main/java/org/apache/rya/api/domain/Node.java --- @@ -21,14 +21,14 @@ -import org.openrdf.model.impl.URIImpl; +import org.eclipse.rdf4j.model.impl.SimpleIRI; /** * A Node is an expected node in the global graph. This typing of the URI allows us to dictate the difference between a --- End diff -- Done > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Assignee: Eric White >Priority: Major > Fix For: 4.0.0 > > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1676#comment-1676
]
ASF GitHub Bot commented on RYA-405:
Github user kchilton2 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/291#discussion_r182601712
--- Diff: dao/accumulo.rya/pom.xml ---
@@ -43,25 +43,30 @@ under the License.
-org.openrdf.sesame
-sesame-rio-ntriples
+org.eclipse.rdf4j
+rdf4j-rio-ntriples
-org.openrdf.sesame
-sesame-rio-nquads
+org.eclipse.rdf4j
+rdf4j-rio-nquads
-org.openrdf.sesame
-sesame-queryalgebra-evaluation
+org.eclipse.rdf4j
+rdf4j-queryalgebra-evaluation
+
+
+org.eclipse.rdf4j
+rdf4j-sail-api
+${org.eclipse.rdf4j.version}
--- End diff --
Add to rya-project dependency management
> Migrate from Sesame to rdf4j libs
> --
>
> Key: RYA-405
> URL: https://issues.apache.org/jira/browse/RYA-405
> Project: Rya
> Issue Type: Improvement
>Affects Versions: 3.2.12
>Reporter: Jorge Machado
>Assignee: Eric White
>Priority: Major
> Fix For: 4.0.0
>
>
> I have migrated all the project to the newer libs from rdf4j instead of using
> the old ones.
> Can someone take a look ?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1672#comment-1672
]
ASF GitHub Bot commented on RYA-405:
Github user kchilton2 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/291#discussion_r182596490
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/domain/VarNameUtils.java ---
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.rya.api.domain;
+
+import org.apache.commons.lang.StringUtils;
+import org.eclipse.rdf4j.model.Value;
+import org.eclipse.rdf4j.model.ValueFactory;
+import org.eclipse.rdf4j.model.impl.SimpleValueFactory;
+import org.eclipse.rdf4j.query.algebra.Var;
+import org.eclipse.rdf4j.query.algebra.helpers.TupleExprs;
+
+/**
+ * Utility methods and constants for RDF {@link Var} names.
+ */
+public final class VarNameUtils {
+private static final ValueFactory VF =
SimpleValueFactory.getInstance();
+
+/**
+ * Prepended to the start of constant var names.
+ */
+public static final String CONSTANT_PREFIX = "_const_";
+private static final String LEGACY_CONSTANT_PREFIX = "-const-";
+
+/**
+ * Prepended to the start of anonymous var names.
+ */
+public static final String ANONYMOUS_PREFIX = "_anon_";
+private static final String LEGACY_ANONYMOUS_PREFIX = "-anon-";
+
+/**
+ * Private constructor to prevent instantiation.
+ */
+private VarNameUtils() {
+}
+
+/**
+ * Prepends the constant prefix to the specified value.
+ * @param value the value to add the constant prefix to.
+ * @return the value with the constant prefix attached before it.
+ */
+public static String prependConstant(final String value) {
--- End diff --
Params and return type are @ Nullable
> Migrate from Sesame to rdf4j libs
> --
>
> Key: RYA-405
> URL: https://issues.apache.org/jira/browse/RYA-405
> Project: Rya
> Issue Type: Improvement
>Affects Versions: 3.2.12
>Reporter: Jorge Machado
>Assignee: Eric White
>Priority: Major
> Fix For: 4.0.0
>
>
> I have migrated all the project to the newer libs from rdf4j instead of using
> the old ones.
> Can someone take a look ?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1674#comment-1674
]
ASF GitHub Bot commented on RYA-405:
Github user kchilton2 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/291#discussion_r182602289
--- Diff:
extras/indexing/src/main/java/org/apache/rya/indexing/FilterFunctionOptimizer.java
---
@@ -157,18 +156,18 @@ private void buildQuery(final TupleExpr tupleExpr,
final StatementPattern matchS
tupleExpr.visit(fVisitor);
final List results = Lists.newArrayList();
for(int i = 0; i < fVisitor.func.size(); i++){
-results.add(new IndexingExpr(fVisitor.func.get(i),
matchStatement, fVisitor.args.get(i)));
+results.add(new IndexingExpr(fVisitor.func.get(i),
matchStatement, Arrays.stream(fVisitor.args.get(i)).toArray()));
--- End diff --
This is kind of a weird change.
> Migrate from Sesame to rdf4j libs
> --
>
> Key: RYA-405
> URL: https://issues.apache.org/jira/browse/RYA-405
> Project: Rya
> Issue Type: Improvement
>Affects Versions: 3.2.12
>Reporter: Jorge Machado
>Assignee: Eric White
>Priority: Major
> Fix For: 4.0.0
>
>
> I have migrated all the project to the newer libs from rdf4j instead of using
> the old ones.
> Can someone take a look ?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1668#comment-1668 ] ASF GitHub Bot commented on RYA-405: Github user kchilton2 commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/291#discussion_r182596150 --- Diff: common/rya.api/src/main/java/org/apache/rya/api/domain/Node.java --- @@ -21,14 +21,14 @@ -import org.openrdf.model.impl.URIImpl; +import org.eclipse.rdf4j.model.impl.SimpleIRI; /** * A Node is an expected node in the global graph. This typing of the URI allows us to dictate the difference between a --- End diff -- "This typing of the [IRI] ..." > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Assignee: Eric White >Priority: Major > Fix For: 4.0.0 > > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1671#comment-1671
]
ASF GitHub Bot commented on RYA-405:
Github user kchilton2 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/291#discussion_r182596798
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/persist/index/RyaSecondaryIndexer.java
---
@@ -19,31 +19,29 @@
* under the License.
*/
-
import java.io.Closeable;
import java.io.Flushable;
import java.io.IOException;
import java.util.Collection;
import java.util.Set;
import org.apache.hadoop.conf.Configurable;
-import org.openrdf.model.URI;
-
import org.apache.rya.api.domain.RyaStatement;
import org.apache.rya.api.domain.RyaURI;
+import org.eclipse.rdf4j.model.IRI;
public interface RyaSecondaryIndexer extends Closeable, Flushable,
Configurable {
/**
* initialize after setting configuration.
*/
-public void init();
+ public void init();
--- End diff --
Tab
> Migrate from Sesame to rdf4j libs
> --
>
> Key: RYA-405
> URL: https://issues.apache.org/jira/browse/RYA-405
> Project: Rya
> Issue Type: Improvement
>Affects Versions: 3.2.12
>Reporter: Jorge Machado
>Assignee: Eric White
>Priority: Major
> Fix For: 4.0.0
>
>
> I have migrated all the project to the newer libs from rdf4j instead of using
> the old ones.
> Can someone take a look ?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1670#comment-1670 ] ASF GitHub Bot commented on RYA-405: Github user kchilton2 commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/291#discussion_r182596172 --- Diff: common/rya.api/src/main/java/org/apache/rya/api/domain/Node.java --- @@ -21,14 +21,14 @@ -import org.openrdf.model.impl.URIImpl; +import org.eclipse.rdf4j.model.impl.SimpleIRI; /** * A Node is an expected node in the global graph. This typing of the URI allows us to dictate the difference between a * URI that is just an Attribute on the subject vs. a URI that is another subject Node in the global graph. It does not --- End diff -- IRI > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Assignee: Eric White >Priority: Major > Fix For: 4.0.0 > > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1673#comment-1673
]
ASF GitHub Bot commented on RYA-405:
Github user kchilton2 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/291#discussion_r182602468
--- Diff:
extras/indexing/src/main/java/org/apache/rya/indexing/IndexPlanValidator/ThreshholdPlanSelector.java
---
@@ -111,9 +110,9 @@ public double getCost(TupleExpr te, double indexWeight,
double commonVarWeight,
double dirProductScale;
if(queryNodeCount > nodeCount) {
-dirProductScale = 1/((double)(queryNodeCount - nodeCount));
+dirProductScale = 1/ (queryNodeCount - nodeCount);
--- End diff --
Are we sure about getting rid of the double casts here? We don't lose
precision in the division?
> Migrate from Sesame to rdf4j libs
> --
>
> Key: RYA-405
> URL: https://issues.apache.org/jira/browse/RYA-405
> Project: Rya
> Issue Type: Improvement
>Affects Versions: 3.2.12
>Reporter: Jorge Machado
>Assignee: Eric White
>Priority: Major
> Fix For: 4.0.0
>
>
> I have migrated all the project to the newer libs from rdf4j instead of using
> the old ones.
> Can someone take a look ?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1675#comment-1675 ] ASF GitHub Bot commented on RYA-405: Github user kchilton2 commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/291#discussion_r182825471 --- Diff: extras/vagrantExample/src/main/vagrant/Vagrantfile --- @@ -52,8 +52,8 @@ Vagrant.configure(2) do |config| export ACCUMULO_VERSION=1.6.5 ###export ACCUMULO_VERSION=1.7.1 export HADOOP_VERSION=2.7.2 -export RYA_EXAMPLE_VERSION=3.2.10-SNAPSHOT -export SESAME_VERSION=2.7.6 +export RYA_EXAMPLE_VERSION=3.2.13-SNAPSHOT --- End diff -- This will need to be 4.0.0. This commit should be after the version update commit. > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Assignee: Eric White >Priority: Major > Fix For: 4.0.0 > > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1669#comment-1669
]
ASF GitHub Bot commented on RYA-405:
Github user kchilton2 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/291#discussion_r182596437
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/domain/VarNameUtils.java ---
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.rya.api.domain;
+
+import org.apache.commons.lang.StringUtils;
+import org.eclipse.rdf4j.model.Value;
+import org.eclipse.rdf4j.model.ValueFactory;
+import org.eclipse.rdf4j.model.impl.SimpleValueFactory;
+import org.eclipse.rdf4j.query.algebra.Var;
+import org.eclipse.rdf4j.query.algebra.helpers.TupleExprs;
+
+/**
+ * Utility methods and constants for RDF {@link Var} names.
+ */
+public final class VarNameUtils {
--- End diff --
Us needing this class at all is kind of a smell. Maybe note that this is
discouraged if there's any other way to figure out if your Var is constant or
anonymous. I think there are methods that tell you that information.
> Migrate from Sesame to rdf4j libs
> --
>
> Key: RYA-405
> URL: https://issues.apache.org/jira/browse/RYA-405
> Project: Rya
> Issue Type: Improvement
>Affects Versions: 3.2.12
>Reporter: Jorge Machado
>Assignee: Eric White
>Priority: Major
> Fix For: 4.0.0
>
>
> I have migrated all the project to the newer libs from rdf4j instead of using
> the old ones.
> Can someone take a look ?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443150#comment-16443150 ] ASF GitHub Bot commented on RYA-405: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/291 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/732/ > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Assignee: Eric White >Priority: Major > Fix For: 4.0.0 > > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443074#comment-16443074 ] ASF GitHub Bot commented on RYA-405: Github user ejwhite922 commented on the issue: https://github.com/apache/incubator-rya/pull/245 This can be closed. New PR under my branch is opened for it [here](https://github.com/apache/incubator-rya/pull/291) (PR-291) > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Assignee: Eric White >Priority: Major > Fix For: 4.0.0 > > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443070#comment-16443070
]
ASF GitHub Bot commented on RYA-405:
GitHub user ejwhite922 opened a pull request:
https://github.com/apache/incubator-rya/pull/291
RYA-405 Migration of OpenRDF Sesame libraries to RDF4J
## Description
Continued from [PR-245](https://github.com/apache/incubator-rya/pull/245).
This updates Rya from OpenRDF Sesame 2.7.6 to RDF4J 2.3.1.
Some notes on what's changed and what to look for when reviewing:
- A Sesame to RDF4J migration guide can be found
[here](http://docs.rdf4j.org/migration/)
- The new libraries changed constant var names from using "-const-" to
"\_const\_{a\_unique\_hex\_string}\_{type\_info}" (See
org.eclipse.rdf4j.query.algebra.helper.TupleExprs#getConstVarName(Value)).
This broke a lot of our code but is now resolved through a new class we added
named **VarNameUtils**. All hard-coded "-const-" strings were removed.
- We added another new class, **RdfFormatUtils**, to handle the deprecation
of RDFFormat#valueOf(String).
- NumericLiteralImpl was deprecated. So, we replaced its use with
AbstractValueFactory#createLiteral(BigInteger). I'm not sure I like this as
it's a little unintuitive for creating an int with type XMLSchema.INTEGER
instead of XMLSchema.INT. An alternative could be to use
AbstractValueFactory#createLiteral(String, XMLSchema.INTEGER) which isn't much
better but makes it clear that it must be XMLSchema.INTEGER.
- META-INF/services files had their names updated from
org.openrdf.sesame... to org.eclipse.rdf4j...
- More accepted classes were added to the deserialize() methods for the
following classes (not sure on these but they passed):
-
org.apache.rya.indexing.pcj.fluo.app.AggregationResultUpdater.ObjectSerializationAggregationStateSerDe
- org.apache.rya.indexing.pcj.storage.accumulo.VisibilityBindingSetSerDe
- SPIN Construct Rules accept more rules since less bnodes are produced
from consequent patterns. This typically leads to more inferences being used
but the same results being produced.
- Vagrant file updated
- Updated org.apache.rya.api.path.PathUtils check for secure directory when
adding RyaShellHistoryProvider file (Windows only fix / works for Linux). Not
sure if there was a defect for this already.
### Tests
Build
Unit Tests
### Links
[Jira](https://issues.apache.org/jira/browse/RYA-405)
### Checklist
- [ ] Code Review
- [ ] Squash Commits
People To Review
@isper3at
@kchilton2
@pujav65
@DLotts
@meiercaleb
@amihalik
@jessehatfield
@jomach
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ejwhite922/incubator-rya
RYA-405_MigrateSesameToRDF4J_Update
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rya/pull/291.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #291
commit 434105eab297de4fe7417df8beaa9941639fc667
Author: Jorge Machado
Date: 2017-10-18T09:32:39Z
RYA-405 Migration of OpenRDF Sesame libraries to RDF4J
Co-authored-by: eric.white
Co-authored-by: Jorge Machado
> Migrate from Sesame to rdf4j libs
> --
>
> Key: RYA-405
> URL: https://issues.apache.org/jira/browse/RYA-405
> Project: Rya
> Issue Type: Improvement
>Affects Versions: 3.2.12
>Reporter: Jorge Machado
>Assignee: Eric White
>Priority: Major
> Fix For: 4.0.0
>
>
> I have migrated all the project to the newer libs from rdf4j instead of using
> the old ones.
> Can someone take a look ?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441152#comment-16441152 ] ASF GitHub Bot commented on RYA-405: Github user kchilton2 commented on the issue: https://github.com/apache/incubator-rya/pull/245 @ejwhite922 Are you able to squash down the history where it makes sense so that this won't be messy when it goes in? > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Assignee: Eric White >Priority: Major > Fix For: 4.0.0 > > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440895#comment-16440895 ] ASF GitHub Bot commented on RYA-405: Github user ejwhite922 commented on the issue: https://github.com/apache/incubator-rya/pull/245 @jomach Thanks, but just waiting to hear if the dev list wants this in 3.2.13 or 4.0. Either way the updated PR is ready and should be up as soon as that issue is resolved. Hopefully this PR can get pulled in this week or next after it's been reviewed. > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Priority: Major > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440490#comment-16440490 ] ASF GitHub Bot commented on RYA-405: Github user jomach commented on the issue: https://github.com/apache/incubator-rya/pull/245 @ejwhite922 need any help ? > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Priority: Major > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430791#comment-16430791 ] ASF GitHub Bot commented on RYA-405: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/245 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/726/ > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Priority: Major > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430720#comment-16430720 ] ASF GitHub Bot commented on RYA-405: Github user ejwhite922 commented on the issue: https://github.com/apache/incubator-rya/pull/245 @theRealImy Sorry for the late reply; I just starting looking at this PR again. This PR will be a part of this release. I will start getting this updated with the latest commits since it was last worked on so it can be pulled in. > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Priority: Major > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374534#comment-16374534 ] ASF GitHub Bot commented on RYA-405: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/245 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/697/ > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Priority: Major > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374461#comment-16374461 ] ASF GitHub Bot commented on RYA-405: Github user theRealImy commented on the issue: https://github.com/apache/incubator-rya/pull/245 Hi there, this is interesting work and in my company we are looking forward to test out Apache Rya. However we use rdf4j already. Any idea when a new release in sight? I saw it was not added in the last RC. > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Priority: Major > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251043#comment-16251043 ] ASF GitHub Bot commented on RYA-405: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/245 SUCCESS > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251044#comment-16251044 ] ASF GitHub Bot commented on RYA-405: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/245 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/553/ > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246494#comment-16246494 ] ASF GitHub Bot commented on RYA-405: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/245 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/551/Build result: FAILURE[...truncated 521.84 KB...][ERROR] location: class org.apache.rya.api.client.accumulo.AccumuloLoadStatements[ERROR] /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/indexing/src/main/java/org/apache/rya/api/client/accumulo/AccumuloLoadStatements.java:[103,32] cannot find symbol[ERROR] symbol: class RepositoryException[ERROR] location: class org.apache.rya.api.client.accumulo.AccumuloLoadStatements[ERROR] /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/indexing/src/main/java/org/apache/rya/api/client/accumulo/AccumuloLoadStatements.java:[110,32] cannot find symbol[ERROR] symbol: class RepositoryException[ERROR] location: class org.apache.rya.api.client.accumulo.AccumuloLoadStatements[ERROR] /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/indexing/src/main/java/org/apache/rya/api/client/accumulo/AccumuloLoadStatements.java:[117,32] cannot find symbol[ERROR] symbol: class SailException[ERROR] location: class org.apache.rya.api.client.accumulo.AccumuloLoadStatements[ERROR] -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn -rf :rya.indexingchannel stoppedSetting status of 46499cba9b8efbb5fb4479e411252b4d7a47bc2f to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/551/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246465#comment-16246465 ] ASF GitHub Bot commented on RYA-405: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/245 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/550/ > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246267#comment-16246267 ] ASF GitHub Bot commented on RYA-405: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/245 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/549/ > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239499#comment-16239499 ] ASF GitHub Bot commented on RYA-405: Github user jomach commented on the issue: https://github.com/apache/incubator-rya/pull/245 nice work @ejwhite922 looks better now. > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16233707#comment-16233707 ] ASF GitHub Bot commented on RYA-405: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/245 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/547/ > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado >Priority: Major > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223298#comment-16223298 ] ASF GitHub Bot commented on RYA-405: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/245 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/546/Failed Tests: 3incubator-rya-master-with-optionals-pull-requests/org.apache.rya:rya.indexing.example: 3ExamplesTest.RyaDirectExampleTestExamplesTest.MongoRyaDirectExampleTestExamplesTest.EntityDirectExampleTest > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222016#comment-16222016 ] ASF GitHub Bot commented on RYA-405: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/245 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/545/Failed Tests: 16incubator-rya-master-with-optionals-pull-requests/org.apache.rya:rya.indexing: 10org.apache.rya.indexing.IndexPlanValidator.TupleExecutionPlanGeneratorTest.testThreeNodeOrderFilterorg.apache.rya.indexing.IndexPlanValidator.TupleExecutionPlanGeneratorTest.testThreeNodeOrderorg.apache.rya.indexing.IndexPlanValidator.TupleExecutionPlanGeneratorTest.testTwoNodeOrderorg.apache.rya.indexing.external.PrecompJoinOptimizerVarToConstTest.testGeoIndexFunctionorg.apache.rya.indexing.external.PrecompJoinOptimizerVarToConstTest.testFreeTestIndexFunctionorg.apache.rya.indexing.external.PrecompJoinOptimizerVarToConstTest.testFourIndexGeoFreeCompareFilterMixorg.apache.rya.indexing.external.PrecompJoinOptimizerVarToConstTest.testContextFilterFourIndexorg.apache.rya.indexing.external.PrecompJoinOptimizerVarToConstTest.testThreeIndexGeoFreeCompareFilterMixorg.apache.rya.indexing.external.tupleSet.VarConstQueryVariableNormalizerTest.queryCompoundFilterMatchorg.apache.rya.indexing.external.tupleSet.VarConstQueryVariableNormalizerTest.queryConstGeoFilterincubator-rya-master-with-optionals-pull-requests/org.apache.rya:rya.indexing.example: 3ExamplesTest.RyaDirectExampleTestExamplesTest.MongoRyaDirectExampleTestExamplesTest.EntityDirectExampleTestincubator-rya-master-with-optionals-pull-requests/org.apache.rya:rya.shell: 3org.apache.rya.shell.RyaCommandsTest.testLoadDataorg.apache.rya.shell.RyaCommandsTest.testLoadData_specifyInvalidFilenameFormatorg.apache.rya.shell.RyaCommandsTest.testLoadData_specifyInvalidFormat > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220231#comment-16220231 ] ASF GitHub Bot commented on RYA-405: Github user jomach commented on the issue: https://github.com/apache/incubator-rya/pull/245 @ejwhite922 can you make a PR into my branch ? then it will land here. There are a lot of errors still with accumulo on 1.6.1 > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218513#comment-16218513 ] ASF GitHub Bot commented on RYA-405: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/245 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/540/Build result: FAILURE[...truncated 2.17 MB...][INFO] Finished at: 2017-10-25T12:32:43+00:00[INFO] Final Memory: 206M/2538M[INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2:compile (default-compile) on project rya.mapreduce: Compilation failure: Compilation failure:[ERROR] /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/mapreduce/src/main/java/org/apache/rya/accumulo/mr/AccumuloHDFSFileInputFormat.java:[124,48] cannot find symbol[ERROR] symbol: method newScanReaderBuilder()[ERROR] location: variable fileOperations of type org.apache.accumulo.core.file.FileOperations[ERROR] /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/mapreduce/src/main/java/org/apache/rya/accumulo/mr/RyaInputFormat.java:[74,12] org.apache.rya.accumulo.mr.RyaInputFormat.RyaStatementRecordReader is not abstract and does not override abstract method setupIterators(org.apache.hadoop.mapreduce.TaskAttemptContext,org.apache.accumulo.core.client.Scanner,java.lang.String,org.apache.accumulo.core.client.mapreduce.RangeInputSplit) in org.apache.accumulo.core.client.mapreduce.AbstractInputFormat.AbstractRecordReader[ERROR] /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/mapreduce/src/main/java/org/apache/rya/accumulo/mr/RyaInputFormat.java:[78,9] method does not override or implement a method from a supertype[ERROR] -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn -rf :rya.mapreducechannel stoppedSetting status of c3ef8c9ff52a5fa14f2ab8d788094b1470a36a0d to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/540/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217702#comment-16217702 ] ASF GitHub Bot commented on RYA-405: Github user jomach commented on the issue: https://github.com/apache/incubator-rya/pull/245 Ok. Will try that > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216488#comment-16216488 ] ASF GitHub Bot commented on RYA-405: Github user jomach commented on the issue: https://github.com/apache/incubator-rya/pull/245 so rya is forced to run on Accumulo 1.6.1 ? > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212551#comment-16212551
]
ASF GitHub Bot commented on RYA-405:
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/245
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/535/Build
result: ABORTED[...truncated 1.27 MB...]2017-10-20 10:02:24 INFO
EmbeddedMongoFactory:42 - 2017-10-20T10:02:24.994+ I COMMAND [conn2]
dropDatabase testDB finished[mongod output] 2017-10-20 10:02:25 INFO
EmbeddedMongoFactory:42 - 2017-10-20T10:02:25.796+ I COMMAND [conn2]
command testDB.entity-types command: insert { insert: "entity-types", ordered:
true, documents: [ { _id: "urn:person", propertyNames: [ "urn:name", "urn:age",
"urn:eye" ] } ] } ninserted:1 keyUpdates:0 writeConflicts:0 numYields:0
reslen:40 locks:{ Global: { acquireCount: { r: 2, w: 2 } }, Database: {
acquireCount: { w: 1, W: 1 } }, Collection: { acquireCount: { W: 1 } } }
protocol:op_query 768ms[mongod output] 2017-10-20 10:02:26 INFO
EmbeddedMongoFactory:42 - 2017-10-20T10:02:26.007+ I COMMAND [conn2]
command testDB.entity-entities command: insert { insert: "entity-entities",
ordered: true, documents: [ { _id: "urn:SSN:111-11-", explicitTypeIds: [
"urn:person" ], properties: { urn:person: { urn:eye: { dataType:
"http://www.w3.org/2001/XMLSchema#string;, value: "blue" }, urn:name: {
dataType: "http://www.w3.org/2001/XMLSchema#string;, value: "bob" }, urn:age: {
dataType: "http://www.w3.org/2001/XMLSchema#string;, value: "25" } } },
version: 0, smartUri:
"urn://SSN:111-11-?ryaTypes=urn%3A%2F%2FentityTypeMap%3Furn%253Aperson%3Dperson=blue=bob=25"
} ] } ninserted:1 keyUpdates:0 writeConflicts:0 numYields:0 reslen:40 locks:{
Global: { acquireCount: { r: 2, w: 2 } }, Database: { acquireCount: { w: 1, W:
1 } }, Collection: { acquireCount: { w: 1, W: 1 } } } protocol:op_query
203ms[mongod output] 2017-10-20 10:02:26 INFO EmbeddedMongoFactory:42 -
2017-10-20T10:02:26.053+ I COMMAND [conn2] dropDatabase testDB
starting[mongod output] 2017-10-20 10:02:26 INFO EmbeddedMongoFactory:42 -
2017-10-20T10:02:26.054+ I COMMAND [conn2] dropDatabase testDB
finished[mongod output] 2017-10-20 10:02:26 INFO EmbeddedMongoFactory:42 -
2017-10-20T10:02:26.300+ I COMMAND [conn2] command testDB.entity-types
command: insert { insert: "entity-types", ordered: true, documents: [ { _id:
"urn:person", propertyNames: [ "urn:name", "urn:age", "urn:eye" ] } ] }
ninserted:1 keyUpdates:0 writeConflicts:0 numYields:0 reslen:40 locks:{ Global:
{ acquireCount: { r: 2, w: 2 } }, Database: { acquireCount: { w: 1, W: 1 } },
Collection: { acquireCount: { W: 1 } } } protocol:op_query 214ms[mongod output]
2017-10-20 10:02:26 INFO EmbeddedMongoFactory:42 -
2017-10-20T10:02:26.544+ I COMMAND [conn2] command testDB.entity-entities
command: insert { insert: "entity-entities", ordered: true, documents: [ { _id:
"urn:SSN:111-11-", explicitTypeIds: [ "urn:person" ], properties: {
urn:person: { urn:eye: { dataType: "http://www.w3.org/2001/XMLSchema#string;,
value: "blue" }, urn:name: { dataType:
"http://www.w3.org/2001/XMLSchema#string;, value: "bob" }, urn:age: { dataType:
"http://www.w3.org/2001/XMLSchema#string;, value: "25" } } }, version: 0,
smartUri:
"urn://SSN:111-11-?ryaTypes=urn%3A%2F%2FentityTypeMap%3Furn%253Aperson%3Dperson=blue=bob=25"
} ] } ninserted:1 keyUpdates:0 writeConflicts:0 numYields:0 reslen:40 locks:{
Global: { acquireCount: { r: 2, w: 2 } }, Database: { acquireCount: { w: 1, W:
1 } }, Collection: { acquireCount: { w: 1, W: 1 } } } protocol:op_query
234ms[mongod output] 2017-10-20 10:02:26 INFO EmbeddedMongoFactory:42 -
2017-10-20T10:02:26.552+ I COMMAND [conn2] dropDatabase testDB
starting[mongod output] 2017-10-20 10:02:26 INFO EmbeddedMongoFactory:42 -
2017-10-20T10:02:26.552+ I COMMAND [conn2] dropDatabase testDB
finished[mongod output] 2017-10-20 10:02:26 INFO EmbeddedMongoFactory:42 -
2017-10-20T10:02:26.796+ I COMMAND [conn2] command testDB.entity-types
command: insert { insert: "entity-types", ordered: true, documents: [ { _id:
"urn:person", propertyNames: [ "urn:name", "urn:age", "urn:eye" ] } ] }
ninserted:1 keyUpdates:0 writeConflicts:0 numYields:0 reslen:40 locks:{ Global:
{ acquireCount: { r: 2, w: 2 } }, Database: { acquireCount: { w: 1, W: 1 } },
Collection: { acquireCount: { W: 1 } } } protocol:op_query 208ms[mongod output]
2017-10-20 10:02:27 INFO EmbeddedMongoFactory:42 -
2017-10-20T10:02:27.047+ I COMMAND [conn2] command testDB.entity-entities
command: insert { insert: "entity-entities", ordered: true, documents: [ { _id:
"urn:SSN:111-11-", explicitTypeIds: [ "urn:person" ], properties: {
urn:person: {
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212263#comment-16212263 ] ASF GitHub Bot commented on RYA-405: Github user jomach commented on the issue: https://github.com/apache/incubator-rya/pull/245 Can someone Help me with DocumentIndexIntersectingIteratorTest ? It seems not and I don't know why. Just make a PR against my fork. > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212257#comment-16212257
]
ASF GitHub Bot commented on RYA-405:
Github user jomach commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/245#discussion_r145888515
--- Diff:
extras/indexing/src/main/java/org/apache/rya/indexing/IndexPlanValidator/ValidIndexCombinationGenerator.java
---
@@ -86,11 +81,8 @@ public boolean hasNext() {
}
- } else if (isEmpty) {
- return false;
- } else {
- return true;
- }
+ } else
+return !isEmpty;
--- End diff --
This was my idea. Sorry
> Migrate from Sesame to rdf4j libs
> --
>
> Key: RYA-405
> URL: https://issues.apache.org/jira/browse/RYA-405
> Project: Rya
> Issue Type: Improvement
>Affects Versions: 3.2.12
>Reporter: Jorge Machado
>
> I have migrated all the project to the newer libs from rdf4j instead of using
> the old ones.
> Can someone take a look ?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211570#comment-16211570 ] ASF GitHub Bot commented on RYA-405: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/245 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/533/Build result: FAILURE[...truncated 2.28 MB...][INFO] Apache Rya Spark Support ... SKIPPED[INFO] Apache Rya Web Projects SKIPPED[INFO] Apache Rya Web Implementation .. SKIPPED[INFO] [INFO] BUILD FAILURE[INFO] [INFO] Total time: 01:08 h[INFO] Finished at: 2017-10-19T19:12:03+00:00[INFO] Final Memory: 230M/3357M[INFO] [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check (check-licenses) on project rya.pcj.functions.geo: Too many files with unapproved license: 1 See RAT report in: /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/rya.pcj.fluo/rya.pcj.functions.geo/target/rat.txt -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn -rf :rya.pcj.functions.geochannel stoppedSetting status of 0b13fdb3b439ece720c9f899059f975a8751cc10 to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/533/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211493#comment-16211493 ] ASF GitHub Bot commented on RYA-405: Github user isper3at commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/245#discussion_r145781632 --- Diff: extras/indexing/src/main/java/org/apache/rya/api/client/accumulo/AccumuloExecuteSparqlQuery.java --- @@ -37,21 +37,15 @@ import org.apache.rya.api.persist.RyaDAOException; import org.apache.rya.rdftriplestore.inference.InferenceEngineException; import org.apache.rya.sail.config.RyaSailFactory; -import org.openrdf.query.BindingSet; -import org.openrdf.query.MalformedQueryException; -import org.openrdf.query.QueryEvaluationException; -import org.openrdf.query.QueryLanguage; -import org.openrdf.query.TupleQuery; -import org.openrdf.query.TupleQueryResultHandlerException; -import org.openrdf.query.resultio.text.csv.SPARQLResultsCSVWriter; -import org.openrdf.repository.RepositoryException; -import org.openrdf.repository.sail.SailRepository; -import org.openrdf.repository.sail.SailRepositoryConnection; -import org.openrdf.sail.Sail; -import org.openrdf.sail.SailException; +import org.eclipse.rdf4j.query.*; +import org.eclipse.rdf4j.query.resultio.text.csv.SPARQLResultsCSVWriter; +import org.eclipse.rdf4j.repository.RepositoryException; +import org.eclipse.rdf4j.repository.sail.SailRepository; +import org.eclipse.rdf4j.repository.sail.SailRepositoryConnection; +import org.eclipse.rdf4j.sail.Sail; +import org.eclipse.rdf4j.sail.SailException; -import edu.umd.cs.findbugs.annotations.DefaultAnnotation; -import edu.umd.cs.findbugs.annotations.NonNull; +import static java.util.Objects.requireNonNull; --- End diff -- same > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211491#comment-16211491
]
ASF GitHub Bot commented on RYA-405:
Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/245#discussion_r145780360
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/resolver/RyaTypeResolver.java
---
@@ -23,28 +23,27 @@
import org.apache.rya.api.domain.RyaRange;
import org.apache.rya.api.domain.RyaType;
-import org.apache.rya.api.domain.RyaTypeRange;
-import org.openrdf.model.URI;
+import org.eclipse.rdf4j.model.IRI;
/**
* Date: 7/16/12
* Time: 12:08 PM
*/
public interface RyaTypeResolver {
-public byte[] serialize(RyaType ryaType) throws
RyaTypeResolverException;
-public byte[][] serializeType(RyaType ryaType) throws
RyaTypeResolverException;
+byte[] serialize(RyaType ryaType) throws RyaTypeResolverException;
--- End diff --
why are you changing the access level to a lot of these interfaces?
> Migrate from Sesame to rdf4j libs
> --
>
> Key: RYA-405
> URL: https://issues.apache.org/jira/browse/RYA-405
> Project: Rya
> Issue Type: Improvement
>Affects Versions: 3.2.12
>Reporter: Jorge Machado
>
> I have migrated all the project to the newer libs from rdf4j instead of using
> the old ones.
> Can someone take a look ?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211490#comment-16211490 ] ASF GitHub Bot commented on RYA-405: Github user isper3at commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/245#discussion_r145780275 --- Diff: common/rya.api/src/main/java/org/apache/rya/api/resolver/RyaTripleContext.java --- @@ -19,28 +19,20 @@ * under the License. */ - - import java.util.ArrayList; import java.util.List; import java.util.Map; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; - import org.apache.rya.api.RdfCloudTripleStoreConfiguration; import org.apache.rya.api.RdfCloudTripleStoreConstants; import org.apache.rya.api.RdfCloudTripleStoreConstants.TABLE_LAYOUT; import org.apache.rya.api.domain.RyaStatement; import org.apache.rya.api.domain.RyaType; import org.apache.rya.api.domain.RyaURI; import org.apache.rya.api.query.strategy.TriplePatternStrategy; -import org.apache.rya.api.query.strategy.wholerow.HashedPoWholeRowTriplePatternStrategy; -import org.apache.rya.api.query.strategy.wholerow.HashedSpoWholeRowTriplePatternStrategy; -import org.apache.rya.api.query.strategy.wholerow.NullRowTriplePatternStrategy; -import org.apache.rya.api.query.strategy.wholerow.OspWholeRowTriplePatternStrategy; -import org.apache.rya.api.query.strategy.wholerow.PoWholeRowTriplePatternStrategy; -import org.apache.rya.api.query.strategy.wholerow.SpoWholeRowTriplePatternStrategy; +import org.apache.rya.api.query.strategy.wholerow.*; --- End diff -- don't use wildcard imports > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211494#comment-16211494
]
ASF GitHub Bot commented on RYA-405:
Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/245#discussion_r145782313
--- Diff:
extras/indexing/src/main/java/org/apache/rya/indexing/IndexPlanValidator/ValidIndexCombinationGenerator.java
---
@@ -86,11 +81,8 @@ public boolean hasNext() {
}
- } else if (isEmpty) {
- return false;
- } else {
- return true;
- }
+ } else
+return !isEmpty;
--- End diff --
do not remove curly braces around the else
> Migrate from Sesame to rdf4j libs
> --
>
> Key: RYA-405
> URL: https://issues.apache.org/jira/browse/RYA-405
> Project: Rya
> Issue Type: Improvement
>Affects Versions: 3.2.12
>Reporter: Jorge Machado
>
> I have migrated all the project to the newer libs from rdf4j instead of using
> the old ones.
> Can someone take a look ?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211489#comment-16211489 ] ASF GitHub Bot commented on RYA-405: Github user isper3at commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/245#discussion_r145781500 --- Diff: extras/indexing/src/main/java/org/apache/rya/api/client/accumulo/AccumuloCreatePeriodicPCJ.java --- @@ -45,12 +44,12 @@ import org.apache.rya.periodic.notification.notification.CommandNotification; import org.apache.rya.periodic.notification.registration.KafkaNotificationRegistrationClient; import org.apache.rya.periodic.notification.serialization.CommandNotificationSerializer; -import org.openrdf.query.MalformedQueryException; -import org.openrdf.query.QueryEvaluationException; -import org.openrdf.repository.RepositoryException; -import org.openrdf.sail.SailException; +import org.eclipse.rdf4j.query.MalformedQueryException; +import org.eclipse.rdf4j.query.QueryEvaluationException; +import org.eclipse.rdf4j.repository.RepositoryException; +import org.eclipse.rdf4j.sail.SailException; -import com.google.common.base.Optional; +import static java.util.Objects.requireNonNull; --- End diff -- nit: put the static imports above the non-static imports > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211488#comment-16211488
]
ASF GitHub Bot commented on RYA-405:
Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/245#discussion_r145780732
--- Diff:
common/rya.api/src/test/java/org/apache/rya/api/query/strategy/wholerow/MockRdfConfiguration.java
---
@@ -22,7 +22,7 @@
import org.apache.rya.api.RdfCloudTripleStoreConfiguration;
-public class MockRdfCloudConfiguration extends
RdfCloudTripleStoreConfiguration {
+public class MockRdfConfiguration extends RdfCloudTripleStoreConfiguration
{
--- End diff --
why the rename?
> Migrate from Sesame to rdf4j libs
> --
>
> Key: RYA-405
> URL: https://issues.apache.org/jira/browse/RYA-405
> Project: Rya
> Issue Type: Improvement
>Affects Versions: 3.2.12
>Reporter: Jorge Machado
>
> I have migrated all the project to the newer libs from rdf4j instead of using
> the old ones.
> Can someone take a look ?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211492#comment-16211492 ] ASF GitHub Bot commented on RYA-405: Github user isper3at commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/245#discussion_r145781552 --- Diff: extras/indexing/src/main/java/org/apache/rya/api/client/accumulo/AccumuloDeletePeriodicPCJ.java --- @@ -43,11 +42,11 @@ import org.apache.rya.periodic.notification.notification.CommandNotification; import org.apache.rya.periodic.notification.registration.KafkaNotificationRegistrationClient; import org.apache.rya.periodic.notification.serialization.CommandNotificationSerializer; -import org.openrdf.query.MalformedQueryException; +import org.eclipse.rdf4j.query.MalformedQueryException; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import com.google.common.base.Optional; +import static java.util.Objects.requireNonNull; --- End diff -- same > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211458#comment-16211458 ] ASF GitHub Bot commented on RYA-405: Github user isper3at commented on the issue: https://github.com/apache/incubator-rya/pull/245 sure, something of this scale, it would be nice to have it split up into smaller commits. Do you not have create issue rights on Jira? If not, let me know which tickets need making and I'll link you to them all > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211454#comment-16211454 ] ASF GitHub Bot commented on RYA-405: Github user isper3at commented on the issue: https://github.com/apache/incubator-rya/pull/245 the complexity of the changes shouldn't matter to git, I was able to squash all the commits into 1 with no conflicts. I am still seeing compile errors in GeoFunctionsIT > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211441#comment-16211441 ] ASF GitHub Bot commented on RYA-405: Github user jomach commented on the issue: https://github.com/apache/incubator-rya/pull/245 Can we create tasks for each point that need change ? > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211430#comment-16211430
]
ASF GitHub Bot commented on RYA-405:
Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/245#discussion_r145771544
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/persist/index/RyaSecondaryIndexer.java
---
@@ -19,48 +19,46 @@
* under the License.
*/
-
import java.io.Closeable;
import java.io.Flushable;
import java.io.IOException;
import java.util.Collection;
import java.util.Set;
import org.apache.hadoop.conf.Configurable;
-import org.openrdf.model.URI;
-
import org.apache.rya.api.domain.RyaStatement;
import org.apache.rya.api.domain.RyaURI;
+import org.eclipse.rdf4j.model.IRI;
public interface RyaSecondaryIndexer extends Closeable, Flushable,
Configurable {
--- End diff --
Switching all these interface methods to default access level is making the
review rather large (which will still be public anyways).
> Migrate from Sesame to rdf4j libs
> --
>
> Key: RYA-405
> URL: https://issues.apache.org/jira/browse/RYA-405
> Project: Rya
> Issue Type: Improvement
>Affects Versions: 3.2.12
>Reporter: Jorge Machado
>
> I have migrated all the project to the newer libs from rdf4j instead of using
> the old ones.
> Can someone take a look ?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211431#comment-16211431 ] ASF GitHub Bot commented on RYA-405: Github user ejwhite922 commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/245#discussion_r145766853 --- Diff: pom.xml --- @@ -69,14 +70,14 @@ under the License. web -2.7.6 +2.2.2 -1.6.4 -2.5.0 +1.8.1 --- End diff -- I'd leave these dependency versions as they were if possible > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211429#comment-16211429
]
ASF GitHub Bot commented on RYA-405:
Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/245#discussion_r145724613
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/RdfCloudTripleStoreConfigurationBuilder.java
---
@@ -123,7 +123,7 @@ public B setDisplayQueryPlan(boolean displayPlan) {
/**
*
- * @return {@link RdfCloudTripleStoreConfiguration} object with
specified parameters set
+ * @return {@link RdfCloudTripleStoreUtils} object with specified
parameters set
--- End diff --
The original javadocs were right.
> Migrate from Sesame to rdf4j libs
> --
>
> Key: RYA-405
> URL: https://issues.apache.org/jira/browse/RYA-405
> Project: Rya
> Issue Type: Improvement
>Affects Versions: 3.2.12
>Reporter: Jorge Machado
>
> I have migrated all the project to the newer libs from rdf4j instead of using
> the old ones.
> Can someone take a look ?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211427#comment-16211427
]
ASF GitHub Bot commented on RYA-405:
Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/245#discussion_r145724742
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/RdfCloudTripleStoreConfigurationBuilder.java
---
@@ -88,8 +88,8 @@ public B setAuths(String auths) {
*- visibilities assigned to any triples inserted into Rya
* @return B - concrete builder class for chaining method invocations
*/
-public B setVisibilities(String visibilites) {
-this.visibilities = visibilites;
+public B setVisibilities(String visibilities) {
--- End diff --
Thanks
> Migrate from Sesame to rdf4j libs
> --
>
> Key: RYA-405
> URL: https://issues.apache.org/jira/browse/RYA-405
> Project: Rya
> Issue Type: Improvement
>Affects Versions: 3.2.12
>Reporter: Jorge Machado
>
> I have migrated all the project to the newer libs from rdf4j instead of using
> the old ones.
> Can someone take a look ?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211428#comment-16211428
]
ASF GitHub Bot commented on RYA-405:
Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/245#discussion_r145731794
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/domain/StatementMetadata.java
---
@@ -23,26 +23,16 @@
import java.util.HashMap;
import java.util.Map;
-import org.apache.rya.api.persist.RdfDAOException;
-import org.openrdf.model.impl.URIImpl;
-
import com.google.common.base.Preconditions;
import com.google.common.reflect.TypeToken;
-import com.google.gson.Gson;
-import com.google.gson.GsonBuilder;
-import com.google.gson.JsonDeserializationContext;
-import com.google.gson.JsonDeserializer;
-import com.google.gson.JsonElement;
-import com.google.gson.JsonObject;
-import com.google.gson.JsonParseException;
-import com.google.gson.JsonPrimitive;
-import com.google.gson.JsonSerializationContext;
-import com.google.gson.JsonSerializer;
+import com.google.gson.*;
+import org.apache.rya.api.persist.RdfDAOException;
+import org.eclipse.rdf4j.model.impl.URIImpl;
public class StatementMetadata {
private static Gson gson = new
GsonBuilder().enableComplexMapKeySerialization()
-.registerTypeHierarchyAdapter(RyaType.class, new
RyaTypeAdapter()).create();;
--- End diff --
Good catch
> Migrate from Sesame to rdf4j libs
> --
>
> Key: RYA-405
> URL: https://issues.apache.org/jira/browse/RYA-405
> Project: Rya
> Issue Type: Improvement
>Affects Versions: 3.2.12
>Reporter: Jorge Machado
>
> I have migrated all the project to the newer libs from rdf4j instead of using
> the old ones.
> Can someone take a look ?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211423#comment-16211423 ] ASF GitHub Bot commented on RYA-405: Github user jomach commented on the issue: https://github.com/apache/incubator-rya/pull/245 Because The changes are not trivial... > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211415#comment-16211415 ] ASF GitHub Bot commented on RYA-405: Github user isper3at commented on the issue: https://github.com/apache/incubator-rya/pull/245 I'm still confused as to why your commits are overlapping so much and why you can't squash the commits. > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211412#comment-16211412 ] ASF GitHub Bot commented on RYA-405: Github user jomach commented on the issue: https://github.com/apache/incubator-rya/pull/245 So I found why. I tested the minicluster in a new project alone and it works fine. Seems to be the Pom.xml I will push my other commits that are local until now > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211376#comment-16211376 ] ASF GitHub Bot commented on RYA-405: Github user isper3at commented on the issue: https://github.com/apache/incubator-rya/pull/245 I'm checking out your commit now to see why geoindexing would give you grief. I don't think a new PR is required, we can just not do the review until after it builds, change the title to start with [WIP] > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211367#comment-16211367 ] ASF GitHub Bot commented on RYA-405: Github user jomach commented on the issue: https://github.com/apache/incubator-rya/pull/245 @isper3at Sorry I cannot undo that. This is taking a lot more effort that I initially thought because of the geoindexing. I'm thinking about closing this PR and open a new one when I have this compiling. I think we should create a new branch for this. What do you think ? > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211327#comment-16211327 ] ASF GitHub Bot commented on RYA-405: Github user isper3at commented on the issue: https://github.com/apache/incubator-rya/pull/245 you have 2 commits that have the same message with different hashes, can you clean that up and get this to build? > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209504#comment-16209504 ] ASF GitHub Bot commented on RYA-405: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/245 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/531/ > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209487#comment-16209487 ] ASF GitHub Bot commented on RYA-405: Github user amihalik commented on the issue: https://github.com/apache/incubator-rya/pull/245 ok to test > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-405) Migrate from Sesame to rdf4j libs
[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209477#comment-16209477 ] ASF GitHub Bot commented on RYA-405: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/245 Can one of the admins verify this patch? > Migrate from Sesame to rdf4j libs > -- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Jorge Machado > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
