[jira] [Commented] (RYA-410) Add geo profile dependency management to the rya-project pom file.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/RYA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16330746#comment-16330746
 ] 

ASF GitHub Bot commented on RYA-410:


Github user asfgit closed the pull request at:

https://github.com/apache/incubator-rya/pull/252


> Add geo profile dependency management to the rya-project pom file.
> --
>
> Key: RYA-410
> URL: https://issues.apache.org/jira/browse/RYA-410
> Project: Rya
>  Issue Type: Improvement
>Reporter: Kevin Chilton
>Assignee: Kevin Chilton
>Priority: Major
>
> Right now the geo indexing feature of Rya is an optional portion of Rya that 
> is not built by default because it is not compatible with the Apache license. 
> However, geo dependencies are declared at the top of the project as if it all 
> builds depend on them. The top level pom file needs to be updated to include 
> the geoindexing profile and all artifacts related to that build need to be 
> moved to that profile's dependency management section.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RYA-410) Add geo profile dependency management to the rya-project pom file.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/RYA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319514#comment-16319514
 ] 

ASF GitHub Bot commented on RYA-410:


Github user asfgit commented on the issue:

https://github.com/apache/incubator-rya/pull/252
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/645/



> Add geo profile dependency management to the rya-project pom file.
> --
>
> Key: RYA-410
> URL: https://issues.apache.org/jira/browse/RYA-410
> Project: Rya
>  Issue Type: Improvement
>Reporter: Kevin Chilton
>Assignee: Kevin Chilton
>
> Right now the geo indexing feature of Rya is an optional portion of Rya that 
> is not built by default because it is not compatible with the Apache license. 
> However, geo dependencies are declared at the top of the project as if it all 
> builds depend on them. The top level pom file needs to be updated to include 
> the geoindexing profile and all artifacts related to that build need to be 
> moved to that profile's dependency management section.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (RYA-410) Add geo profile dependency management to the rya-project pom file.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/RYA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319498#comment-16319498
 ] 

ASF GitHub Bot commented on RYA-410:


Github user asfgit commented on the issue:

https://github.com/apache/incubator-rya/pull/252
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/644/



> Add geo profile dependency management to the rya-project pom file.
> --
>
> Key: RYA-410
> URL: https://issues.apache.org/jira/browse/RYA-410
> Project: Rya
>  Issue Type: Improvement
>Reporter: Kevin Chilton
>Assignee: Kevin Chilton
>
> Right now the geo indexing feature of Rya is an optional portion of Rya that 
> is not built by default because it is not compatible with the Apache license. 
> However, geo dependencies are declared at the top of the project as if it all 
> builds depend on them. The top level pom file needs to be updated to include 
> the geoindexing profile and all artifacts related to that build need to be 
> moved to that profile's dependency management section.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (RYA-410) Add geo profile dependency management to the rya-project pom file.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/RYA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319479#comment-16319479
 ] 

ASF GitHub Bot commented on RYA-410:


Github user asfgit commented on the issue:

https://github.com/apache/incubator-rya/pull/252
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/643/



> Add geo profile dependency management to the rya-project pom file.
> --
>
> Key: RYA-410
> URL: https://issues.apache.org/jira/browse/RYA-410
> Project: Rya
>  Issue Type: Improvement
>Reporter: Kevin Chilton
>Assignee: Kevin Chilton
>
> Right now the geo indexing feature of Rya is an optional portion of Rya that 
> is not built by default because it is not compatible with the Apache license. 
> However, geo dependencies are declared at the top of the project as if it all 
> builds depend on them. The top level pom file needs to be updated to include 
> the geoindexing profile and all artifacts related to that build need to be 
> moved to that profile's dependency management section.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (RYA-410) Add geo profile dependency management to the rya-project pom file.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/RYA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319458#comment-16319458
 ] 

ASF GitHub Bot commented on RYA-410:


Github user kchilton2 commented on a diff in the pull request:

https://github.com/apache/incubator-rya/pull/252#discussion_r160563035
  
--- Diff: pom.xml ---
@@ -144,7 +141,83 @@ under the License.
 true  
 
 
+
 
+
+geoindexing
+
+1.3.0-m1 
+0.9.3 
+1.13
+
+
--- End diff --

I'm not worried about the eclipse problem since as you said, you can 
trivially tell eclipse to resolve using the geoindexing profile.

The transitive dependency problem exists regardless of how dependency 
management is defined since the management section only defines dependencies 
that CAN be used, not the dependencies that ARE used. Actual dependencies are 
required to change that. If we're pulling down different transitive 
dependencies between geo on and geo off, that's already happening sans this 
patch.


> Add geo profile dependency management to the rya-project pom file.
> --
>
> Key: RYA-410
> URL: https://issues.apache.org/jira/browse/RYA-410
> Project: Rya
>  Issue Type: Improvement
>Reporter: Kevin Chilton
>Assignee: Kevin Chilton
>
> Right now the geo indexing feature of Rya is an optional portion of Rya that 
> is not built by default because it is not compatible with the Apache license. 
> However, geo dependencies are declared at the top of the project as if it all 
> builds depend on them. The top level pom file needs to be updated to include 
> the geoindexing profile and all artifacts related to that build need to be 
> moved to that profile's dependency management section.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (RYA-410) Add geo profile dependency management to the rya-project pom file.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/RYA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311666#comment-16311666
 ] 

ASF GitHub Bot commented on RYA-410:


Github user jdasch commented on a diff in the pull request:

https://github.com/apache/incubator-rya/pull/252#discussion_r159702629
  
--- Diff: pom.xml ---
@@ -144,7 +141,83 @@ under the License.
 true  
 
 
+
 
+
+geoindexing
+
+1.3.0-m1 
+0.9.3 
+1.13
+
+
--- End diff --

I'm not sure how I feel about this.  On the one hand, it does a nice job of 
separating out geoindexing specific dependencies out of the 
dependencyManagement section.  But this causes all sorts of eclipse pom parsing 
errors.  These eclipse errors can be resolved by Right-Clicking the maven 
project, say rya.geo.common, in the Package Explorer: Maven > Select Maven 
profiles... and checking geoindexing.  So that part is trivial enough.  My 
larger concern is we might introduce a different tree of transitive 
dependencies by changing the project's dependencyManagement in this way, which 
could cause subtle transitive dependency versioning issues.  IE.  a non-geo 
function works one way if built with geoindexing profile, and works another way 
if not built with the geoindexing profile.  Maybe @amihalik can weigh in on 
this.


> Add geo profile dependency management to the rya-project pom file.
> --
>
> Key: RYA-410
> URL: https://issues.apache.org/jira/browse/RYA-410
> Project: Rya
>  Issue Type: Improvement
>Reporter: Kevin Chilton
>Assignee: Kevin Chilton
>
> Right now the geo indexing feature of Rya is an optional portion of Rya that 
> is not built by default because it is not compatible with the Apache license. 
> However, geo dependencies are declared at the top of the project as if it all 
> builds depend on them. The top level pom file needs to be updated to include 
> the geoindexing profile and all artifacts related to that build need to be 
> moved to that profile's dependency management section.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (RYA-410) Add geo profile dependency management to the rya-project pom file.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/RYA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279188#comment-16279188
 ] 

ASF GitHub Bot commented on RYA-410:


Github user kchilton2 commented on the issue:

https://github.com/apache/incubator-rya/pull/252
  
https://issues.apache.org/jira/browse/RYA-411


> Add geo profile dependency management to the rya-project pom file.
> --
>
> Key: RYA-410
> URL: https://issues.apache.org/jira/browse/RYA-410
> Project: Rya
>  Issue Type: Improvement
>Reporter: Kevin Chilton
>Assignee: Kevin Chilton
>
> Right now the geo indexing feature of Rya is an optional portion of Rya that 
> is not built by default because it is not compatible with the Apache license. 
> However, geo dependencies are declared at the top of the project as if it all 
> builds depend on them. The top level pom file needs to be updated to include 
> the geoindexing profile and all artifacts related to that build need to be 
> moved to that profile's dependency management section.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (RYA-410) Add geo profile dependency management to the rya-project pom file.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/RYA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279178#comment-16279178
 ] 

ASF GitHub Bot commented on RYA-410:


Github user kchilton2 commented on a diff in the pull request:

https://github.com/apache/incubator-rya/pull/252#discussion_r155076044
  
--- Diff: extras/rya.geoindexing/pom.xml ---
@@ -1,206 +1,51 @@
 
-
-
-
+
 http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
-  4.0.0
-  
-org.apache.rya
-rya.extras
-3.2.12-incubating-SNAPSHOT
-  
-  rya.geoindexing
-  pom
-  Apache Rya Geo Indexing Projects
-  This parent has several alternative implementations using 
different libraries or versions of the same library.  
-  Specifically 
-  Geomesa depends on geotools v5.1 and 
-  GeoWave depends on geotools v6.
-  See the module poms for the actual versions.
-  
+4.0.0
+
+
+org.apache.rya
+rya.extras
+3.2.12-incubating-SNAPSHOT
+
+
+rya.geoindexing
+pom
+
+Apache Rya Geo Indexing Projects
+
+This parent has several alternative implementations using 
different libraries or versions of the same library.  
+Specifically 
+Geomesa depends on geotools v5.1 and 
+GeoWave depends on geotools v6.
+See the module poms for the actual versions.
+ 
+
  
 
-
-
-
-   geo.common
-   geo.geomesa
-   geo.geowave
-   geo.mongo
- 
-
-UTF-8
-
-
-   
-   
-   com.vividsolutions
-   jts
-   1.13
-   
-   
-  org.apache.accumulo
-accumulo-minicluster
-test
-
-
-
-org.apache.rya
-rya.sail
-
-
-hsqldb
-hsqldb
-
-
-
-
-org.apache.rya
-rya.indexing
-
-
-org.apache.rya
-accumulo.rya
-
-
-org.apache.rya
-mongodb.rya
-
-
-org.apache.rya
-rya.prospector
-
-
-
-
-org.apache.lucene
-lucene-core
-
-
-org.apache.lucene
-lucene-analyzers
-
-
-
-commons-codec
-commons-codec
-
-
-   
-   junit
-   junit
-   test
-   
-   
-   org.mockito
-   mockito-all
-   test
-   
-
-org.apache.rya
-accumulo.rya
-test-jar
-test
-
-
-org.apache.rya
-mongodb.rya
-test-jar
-test
-
-
-   
-   
-   
-   
-   org.apache.rat
-   
apache-rat-plugin
-   
-   
-   
-   
**/*.ttl
-
-   
-   
**/resources/META-INF/services/**
--- End diff --

They seem to be unnecessary. I ran a build with rat enabled and no files 
failed the rat test.


> Add geo profile dependency management to the rya-project pom file.
> --
>
> Key: RYA-410
> URL: https://issues.apache.org/jira/browse/RYA-410
> Project: Rya
>  Issue Type: Improvement
>Reporter: Kevin Chilton
>Assignee: Kevin Chilton
>
> Right now the geo indexing feature of Rya is an optional portion of Rya that 
> is not built by default because it is not compatible with the Apache license. 
> However, geo dependencies are declared at the top of the project as if it 

[jira] [Commented] (RYA-410) Add geo profile dependency management to the rya-project pom file.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/RYA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279182#comment-16279182
 ] 

ASF GitHub Bot commented on RYA-410:


Github user kchilton2 commented on the issue:

https://github.com/apache/incubator-rya/pull/252
  
I'll create a jira ticket for adding Geo functions to the Fluo app.


> Add geo profile dependency management to the rya-project pom file.
> --
>
> Key: RYA-410
> URL: https://issues.apache.org/jira/browse/RYA-410
> Project: Rya
>  Issue Type: Improvement
>Reporter: Kevin Chilton
>Assignee: Kevin Chilton
>
> Right now the geo indexing feature of Rya is an optional portion of Rya that 
> is not built by default because it is not compatible with the Apache license. 
> However, geo dependencies are declared at the top of the project as if it all 
> builds depend on them. The top level pom file needs to be updated to include 
> the geoindexing profile and all artifacts related to that build need to be 
> moved to that profile's dependency management section.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (RYA-410) Add geo profile dependency management to the rya-project pom file.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/RYA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278987#comment-16278987
 ] 

ASF GitHub Bot commented on RYA-410:


Github user DLotts commented on a diff in the pull request:

https://github.com/apache/incubator-rya/pull/252#discussion_r155017824
  
--- Diff: extras/rya.geoindexing/pom.xml ---
@@ -1,206 +1,51 @@
 
-
-
-
+
 http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
-  4.0.0
-  
-org.apache.rya
-rya.extras
-3.2.12-incubating-SNAPSHOT
-  
-  rya.geoindexing
-  pom
-  Apache Rya Geo Indexing Projects
-  This parent has several alternative implementations using 
different libraries or versions of the same library.  
-  Specifically 
-  Geomesa depends on geotools v5.1 and 
-  GeoWave depends on geotools v6.
-  See the module poms for the actual versions.
-  
+4.0.0
+
+
+org.apache.rya
+rya.extras
+3.2.12-incubating-SNAPSHOT
+
+
+rya.geoindexing
+pom
+
+Apache Rya Geo Indexing Projects
+
+This parent has several alternative implementations using 
different libraries or versions of the same library.  
+Specifically 
+Geomesa depends on geotools v5.1 and 
+GeoWave depends on geotools v6.
+See the module poms for the actual versions.
+ 
+
  
 
-
-
-
-   geo.common
-   geo.geomesa
-   geo.geowave
-   geo.mongo
- 
-
-UTF-8
-
-
-   
-   
-   com.vividsolutions
-   jts
-   1.13
-   
-   
-  org.apache.accumulo
-accumulo-minicluster
-test
-
-
-
-org.apache.rya
-rya.sail
-
-
-hsqldb
-hsqldb
-
-
-
-
-org.apache.rya
-rya.indexing
-
-
-org.apache.rya
-accumulo.rya
-
-
-org.apache.rya
-mongodb.rya
-
-
-org.apache.rya
-rya.prospector
-
-
-
-
-org.apache.lucene
-lucene-core
-
-
-org.apache.lucene
-lucene-analyzers
-
-
-
-commons-codec
-commons-codec
-
-
-   
-   junit
-   junit
-   test
-   
-   
-   org.mockito
-   mockito-all
-   test
-   
-
-org.apache.rya
-accumulo.rya
-test-jar
-test
-
-
-org.apache.rya
-mongodb.rya
-test-jar
-test
-
-
-   
-   
-   
-   
-   org.apache.rat
-   
apache-rat-plugin
-   
-   
-   
-   
**/*.ttl
-
-   
-   
**/resources/META-INF/services/**
--- End diff --

Where did these RAT exclusions move to?


> Add geo profile dependency management to the rya-project pom file.
> --
>
> Key: RYA-410
> URL: https://issues.apache.org/jira/browse/RYA-410
> Project: Rya
>  Issue Type: Improvement
>Reporter: Kevin Chilton
>Assignee: Kevin Chilton
>
> Right now the geo indexing feature of Rya is an optional portion of Rya that 
> is not built by default because it is not compatible with the Apache license. 
> However, geo dependencies are declared at the top of the project as if it all 
> builds depend on them. The top level pom file needs 

[jira] [Commented] (RYA-410) Add geo profile dependency management to the rya-project pom file.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/RYA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277606#comment-16277606
 ] 

ASF GitHub Bot commented on RYA-410:


Github user asfgit commented on the issue:

https://github.com/apache/incubator-rya/pull/252
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/559/



> Add geo profile dependency management to the rya-project pom file.
> --
>
> Key: RYA-410
> URL: https://issues.apache.org/jira/browse/RYA-410
> Project: Rya
>  Issue Type: Improvement
>Reporter: Kevin Chilton
>Assignee: Kevin Chilton
>
> Right now the geo indexing feature of Rya is an optional portion of Rya that 
> is not built by default because it is not compatible with the Apache license. 
> However, geo dependencies are declared at the top of the project as if it all 
> builds depend on them. The top level pom file needs to be updated to include 
> the geoindexing profile and all artifacts related to that build need to be 
> moved to that profile's dependency management section.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (RYA-410) Add geo profile dependency management to the rya-project pom file.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/RYA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277494#comment-16277494
 ] 

ASF GitHub Bot commented on RYA-410:


GitHub user kchilton2 opened a pull request:

https://github.com/apache/incubator-rya/pull/252

RYA-410 Add geo profile dependency management to the rya-project pom file.

## Description
There is a top level geoindexing profile in the rya-project parent pom that 
defines the dependencies that are specific to geoindexing modules as well as 
which modules we publish.

### Tests
Ran all integration tests with geoindexing turned on and everything passes.

### Links
[Jira](https://issues.apache.org/jira/browse/RYA-410)

### Checklist
- [ ] Code Review
- [ ] Squash Commits


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kchilton2/incubator-rya RYA-410

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-rya/pull/252.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #252


commit dd4f794e19947739162ca707eead8c5b34eec624
Author: kchilton2 
Date:   2017-12-04T19:41:27Z

RYA-410 Add geo profile dependency management to the rya-project pom file.




> Add geo profile dependency management to the rya-project pom file.
> --
>
> Key: RYA-410
> URL: https://issues.apache.org/jira/browse/RYA-410
> Project: Rya
>  Issue Type: Improvement
>Reporter: Kevin Chilton
>Assignee: Kevin Chilton
>
> Right now the geo indexing feature of Rya is an optional portion of Rya that 
> is not built by default because it is not compatible with the Apache license. 
> However, geo dependencies are declared at the top of the project as if it all 
> builds depend on them. The top level pom file needs to be updated to include 
> the geoindexing profile and all artifacts related to that build need to be 
> moved to that profile's dependency management section.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)