[GitHub] [incubator-shardingsphere] betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements

betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-521883965 OK. I understand what you said. The current situation is : - The highest

[GitHub] [incubator-shardingsphere] betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements

betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-521611015 There is no 'ActiveSpan' in io.opentracing:0.31.0. The shardingsphere where throw an

[GitHub] [incubator-shardingsphere] betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements

betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-521565698 @tuohai666 I tested it for SkyWalking with sharding-jdbc and sharding-proxy. But the

[GitHub] [incubator-shardingsphere] betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements

betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-521160526 Not yet. I just have tested success for unit tests. I will test that later.

[GitHub] [incubator-shardingsphere] betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements

betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-520160038 should I add SkywalkingTracer as default implement?

[GitHub] [incubator-shardingsphere] betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements

betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-520152044 I would like try to do this in a few days.