[GitHub] [skywalking] wu-sheng commented on a change in pull request #3475: Add feature to control the maximum agent log files

2019-09-17 Thread GitBox
wu-sheng commented on a change in pull request #3475: Add feature to control the maximum agent log files URL: https://github.com/apache/skywalking/pull/3475#discussion_r325057533 ## File path:

[skywalking] branch master updated: agent support custom properties. (#3367)

2019-09-17 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 6c347a1 agent support custom properties.

[skywalking] branch service_props deleted (was 7ea14fb)

2019-09-17 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch service_props in repository https://gitbox.apache.org/repos/asf/skywalking.git. was 7ea14fb fix minor bug. The revisions that were on this branch are still contained in other references;

[GitHub] [skywalking] wu-sheng merged pull request #3367: agent support custom properties.

2019-09-17 Thread GitBox
wu-sheng merged pull request #3367: agent support custom properties. URL: https://github.com/apache/skywalking/pull/3367 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [skywalking] wu-sheng commented on issue #3475: Add feature to control the maximum agent log files

2019-09-17 Thread GitBox
wu-sheng commented on issue #3475: Add feature to control the maximum agent log files URL: https://github.com/apache/skywalking/pull/3475#issuecomment-532129825 /run ci This is an automated message from the Apache Git

[GitHub] [skywalking] wu-sheng commented on issue #3475: Add feature to control the maximum agent log files

2019-09-17 Thread GitBox
wu-sheng commented on issue #3475: Add feature to control the maximum agent log files URL: https://github.com/apache/skywalking/pull/3475#issuecomment-532129879 /run e2e This is an automated message from the Apache Git

[GitHub] [skywalking] codelipenghui opened a new pull request #3476: [WIP]Add pulsar apm plugin

2019-09-17 Thread GitBox
codelipenghui opened a new pull request #3476: [WIP]Add pulsar apm plugin URL: https://github.com/apache/skywalking/pull/3476 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x ] New feature provided - [ ] Improve

[GitHub] [skywalking] wu-sheng commented on issue #3476: [WIP]Add pulsar apm plugin

2019-09-17 Thread GitBox
wu-sheng commented on issue #3476: [WIP]Add pulsar apm plugin URL: https://github.com/apache/skywalking/pull/3476#issuecomment-532179273 @dmsolr Feel free to join. This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] liangxp opened a new issue #3477: org.apache.skywalking.oap.server.starter.OAPServerStartUp - 55 [main] ERROR [] - ScopeDefine fieldName = All not found.

2019-09-17 Thread GitBox
liangxp opened a new issue #3477: org.apache.skywalking.oap.server.starter.OAPServerStartUp - 55 [main] ERROR [] - ScopeDefine fieldName = All not found. URL: https://github.com/apache/skywalking/issues/3477 - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug

[GitHub] [skywalking] liangxp commented on issue #3258: ScopeDefine name = All not found

2019-09-17 Thread GitBox
liangxp commented on issue #3258: ScopeDefine name = All not found URL: https://github.com/apache/skywalking/issues/3258#issuecomment-532181845 JDK8 也是一样的问题,不知道具体原因,求解 This is an automated message from the Apache Git Service.

[GitHub] [skywalking] stalary commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-17 Thread GitBox
stalary commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-532216054 @wu-sheng When spring-kafka exists, how can I enable spring-kafka-plugin by not launching the kafka plugin,I need a little

[GitHub] [skywalking] haodut opened a new issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-17 Thread GitBox
haodut opened a new issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [x] Bug -

[GitHub] [skywalking] stalary commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-17 Thread GitBox
stalary commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-532211047 > @stalary do you have interest to enhance this part? Ok, I will solve it soon

[GitHub] [skywalking] wu-sheng commented on issue #3477: org.apache.skywalking.oap.server.starter.OAPServerStartUp - 55 [main] ERROR [] - ScopeDefine fieldName = All not found.

2019-09-17 Thread GitBox
wu-sheng commented on issue #3477: org.apache.skywalking.oap.server.starter.OAPServerStartUp - 55 [main] ERROR [] - ScopeDefine fieldName = All not found. URL: https://github.com/apache/skywalking/issues/3477#issuecomment-532186180 This class is in the distribution. I am not sure why the

[GitHub] [skywalking] wu-sheng closed issue #3477: org.apache.skywalking.oap.server.starter.OAPServerStartUp - 55 [main] ERROR [] - ScopeDefine fieldName = All not found.

2019-09-17 Thread GitBox
wu-sheng closed issue #3477: org.apache.skywalking.oap.server.starter.OAPServerStartUp - 55 [main] ERROR [] - ScopeDefine fieldName = All not found. URL: https://github.com/apache/skywalking/issues/3477 This is an

[GitHub] [skywalking] wu-sheng commented on issue #3477: org.apache.skywalking.oap.server.starter.OAPServerStartUp - 55 [main] ERROR [] - ScopeDefine fieldName = All not found.

2019-09-17 Thread GitBox
wu-sheng commented on issue #3477: org.apache.skywalking.oap.server.starter.OAPServerStartUp - 55 [main] ERROR [] - ScopeDefine fieldName = All not found. URL: https://github.com/apache/skywalking/issues/3477#issuecomment-532193396 I think you need to debug and find out why the classpath

[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-17 Thread GitBox
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-532209203 Need new support for Spring Kafka. This is an automated

[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-17 Thread GitBox
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-532210148 @stalary do you have interest to enhance this part? This

[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-17 Thread GitBox
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-53862 > When spring-kafka exists, how can I enable spring-kafka-plugin by not launching the kafka plugin,I need a little help.

[GitHub] [skywalking] tsuilouis commented on a change in pull request #3323: Add Light4j plugin

2019-09-17 Thread GitBox
tsuilouis commented on a change in pull request #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#discussion_r325288071 ## File path:

[GitHub] [skywalking] tsuilouis commented on a change in pull request #3323: Add Light4j plugin

2019-09-17 Thread GitBox
tsuilouis commented on a change in pull request #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#discussion_r325436372 ## File path:

[GitHub] [skywalking] tsuilouis commented on a change in pull request #3323: Add Light4j plugin

2019-09-17 Thread GitBox
tsuilouis commented on a change in pull request #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#discussion_r325431072 ## File path:

[GitHub] [skywalking] Zack-Ku opened a new issue #3479: How to set UI login?

2019-09-17 Thread GitBox
Zack-Ku opened a new issue #3479: How to set UI login? URL: https://github.com/apache/skywalking/issues/3479 Please answer these questions before submitting your issue. - Why do you submit this issue? - [√ ] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3323: Add Light4j plugin

2019-09-17 Thread GitBox
wu-sheng commented on a change in pull request #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#discussion_r325459027 ## File path:

[GitHub] [skywalking] tsuilouis commented on a change in pull request #3323: Add Light4j plugin

2019-09-17 Thread GitBox
tsuilouis commented on a change in pull request #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#discussion_r325417646 ## File path: docs/en/setup/service-agent/java-agent/README.md ## @@ -102,6 +102,7 @@ property key | Description | Default |

[GitHub] [skywalking] tsuilouis commented on a change in pull request #3323: Add Light4j plugin

2019-09-17 Thread GitBox
tsuilouis commented on a change in pull request #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#discussion_r325417646 ## File path: docs/en/setup/service-agent/java-agent/README.md ## @@ -102,6 +102,7 @@ property key | Description | Default |

[GitHub] [skywalking] stevehu commented on a change in pull request #3323: Add Light4j plugin

2019-09-17 Thread GitBox
stevehu commented on a change in pull request #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#discussion_r325453199 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3323: Add Light4j plugin

2019-09-17 Thread GitBox
wu-sheng commented on a change in pull request #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#discussion_r325436714 ## File path:

[GitHub] [skywalking] stevehu commented on a change in pull request #3323: Add Light4j plugin

2019-09-17 Thread GitBox
stevehu commented on a change in pull request #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#discussion_r325462183 ## File path:

[GitHub] [skywalking] tsuilouis commented on a change in pull request #3323: Add Light4j plugin

2019-09-17 Thread GitBox
tsuilouis commented on a change in pull request #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#discussion_r325469781 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3323: Add Light4j plugin

2019-09-17 Thread GitBox
wu-sheng commented on a change in pull request #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#discussion_r325431815 ## File path:

[GitHub] [skywalking] wu-sheng closed issue #3479: How to set UI login?

2019-09-17 Thread GitBox
wu-sheng closed issue #3479: How to set UI login? URL: https://github.com/apache/skywalking/issues/3479 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [skywalking] wu-sheng commented on issue #3479: How to set UI login?

2019-09-17 Thread GitBox
wu-sheng commented on issue #3479: How to set UI login? URL: https://github.com/apache/skywalking/issues/3479#issuecomment-532500842 Because the login is not the real login, you could bypass it easily. It is being treated as a security vulnerability, so have to remove it.

[GitHub] [skywalking] wu-sheng closed issue #3480: TraceContext.traceId() always return [Ignored Trace]

2019-09-17 Thread GitBox
wu-sheng closed issue #3480: TraceContext.traceId() always return [Ignored Trace] URL: https://github.com/apache/skywalking/issues/3480 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] qlql489 opened a new issue #3480: TraceContext.traceId() always return [Ignored Trace]

2019-09-17 Thread GitBox
qlql489 opened a new issue #3480: TraceContext.traceId() always return [Ignored Trace] URL: https://github.com/apache/skywalking/issues/3480 Please answer these questions before submitting your issue. - Why do you submit this issue? - [x] Question or discussion - [ ] Bug -

[GitHub] [skywalking] wu-sheng commented on issue #3481: An enhancement about A Table model Of Span View.

2019-09-17 Thread GitBox
wu-sheng commented on issue #3481: An enhancement about A Table model Of Span View. URL: https://github.com/apache/skywalking/issues/3481#issuecomment-532529269 This UI enhancement is open to anyone who has interests to contribute. If you could send a pull request with a video to show how

[GitHub] [skywalking] wuguangkuo commented on a change in pull request #3475: Add feature to control the maximum agent log files

2019-09-17 Thread GitBox
wuguangkuo commented on a change in pull request #3475: Add feature to control the maximum agent log files URL: https://github.com/apache/skywalking/pull/3475#discussion_r325492827 ## File path:

[GitHub] [skywalking] zhaoxunyong opened a new issue #3481: An enhancement about A Table Of Span view.

2019-09-17 Thread GitBox
zhaoxunyong opened a new issue #3481: An enhancement about A Table Of Span view. URL: https://github.com/apache/skywalking/issues/3481 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ]

[GitHub] [skywalking] dmsolr commented on a change in pull request #3475: Add feature to control the maximum agent log files

2019-09-17 Thread GitBox
dmsolr commented on a change in pull request #3475: Add feature to control the maximum agent log files URL: https://github.com/apache/skywalking/pull/3475#discussion_r325484491 ## File path:

[GitHub] [skywalking] wu-sheng commented on issue #3480: TraceContext.traceId() always return [Ignored Trace]

2019-09-17 Thread GitBox
wu-sheng commented on issue #3480: TraceContext.traceId() always return [Ignored Trace] URL: https://github.com/apache/skywalking/issues/3480#issuecomment-532529877 You need to find out why `IgnoredTracerContext` created. In my mind, either agent hasn't registered to backend

[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-17 Thread GitBox
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-532224926 I am not asking there must be a Spring-kafka plugin, but the kafka plugin should work as expected. In some cases,

[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-17 Thread GitBox
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-532224590 > However, an error is reported when it passes through the kafka-plugin Why? If we intercept the right place, then

[GitHub] [skywalking] stalary commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-17 Thread GitBox
stalary commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-532228200 yes | | 李荣谦 | | stal...@163.com | 签名由 网易邮箱大师 定制 On 09/17/2019 21:44, 吴晟 Wu

[GitHub] [skywalking] stalary commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-17 Thread GitBox
stalary commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-532226273 @wu-sheng ok,I got it This is an automated message from the

[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-17 Thread GitBox
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-532227110 Such as from this error log, we are intercepting `KafkaProducer` constructor, right? >

[GitHub] [skywalking] stalary commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-17 Thread GitBox
stalary commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-532228758 > Such as from this error log, we are intercepting `KafkaProducer` constructor, right? > > >

[GitHub] [skywalking] stalary removed a comment on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-17 Thread GitBox
stalary removed a comment on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-532228200 yes | | 李荣谦 | | stal...@163.com | 签名由 网易邮箱大师 定制 On 09/17/2019 21:44,