[GitHub] [skywalking] wu-sheng commented on pull request #5523: Provide metrics APIs for agent plugin

2020-09-22 Thread GitBox
wu-sheng commented on pull request #5523: URL: https://github.com/apache/skywalking/pull/5523#issuecomment-697081340 @yu199195 This PR is not ready to be merged, there are 2 things left 1. The implementations of meter core are duplicated in the toolkit and agent core both. I have

[GitHub] [skywalking] wu-sheng commented on pull request #5523: Provide metrics APIs for agent plugin

2020-09-22 Thread GitBox
wu-sheng commented on pull request #5523: URL: https://github.com/apache/skywalking/pull/5523#issuecomment-697081340 @yu199195 This PR is not ready to be merged, there are 2 things left 1. The implementations of meter core are duplicated in the toolkit and agent core both. I have

[GitHub] [skywalking] wu-sheng commented on pull request #5523: Provide metrics APIs for agent plugin

2020-09-21 Thread GitBox
wu-sheng commented on pull request #5523: URL: https://github.com/apache/skywalking/pull/5523#issuecomment-695794326 Also, the CI seems to fail somehow, please recheck. This is an automated message from the Apache Git

[GitHub] [skywalking] wu-sheng commented on pull request #5523: Provide metrics APIs for agent plugin

2020-09-20 Thread GitBox
wu-sheng commented on pull request #5523: URL: https://github.com/apache/skywalking/pull/5523#issuecomment-695794326 Also, the CI seems to fail somehow, please recheck. This is an automated message from the Apache Git