wu-sheng merged PR #679:
URL: https://github.com/apache/skywalking-java/pull/679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
AlchemyDing commented on PR #679:
URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2047539249
> > Of course, this is possible.
> > But before that, I also have a question. I searched for the code of
skywalking-java and found that only the druid plugin has attributes
wu-sheng commented on PR #679:
URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2047540086
> Therefore, I have a proposal to standardize our semantic conventions,
which can avoid potential semantic ambiguity in the future.
We should consider that in a way.
--
AlchemyDing commented on PR #679:
URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2047538313
> > 当然，这是可能的。
> >
但在此之前，我还有一个问题。我搜索了skywalking-java的代码，发现只有druid插件有叫做poolingCount和idleCount的属性。我们是否需要在APM中改变druid对于这两个属性的原始含义，也许我们需要一个标准化的语义约定？
>
> 好问题。最好删除它，而不是重新计算。
AlchemyDing commented on PR #679:
URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2047537804
Therefore, I have a proposal to standardize our semantic conventions, which
can avoid potential semantic ambiguity in the future.
--
This is an automated message from the
wu-sheng commented on PR #679:
URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2047512936
> Of course, this is possible.
> But before that, I also have a question. I searched for the code of
skywalking-java and found that only the druid plugin has attributes called
AlchemyDing commented on PR #679:
URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2047501587
> > Poolingcount represents the concept of idle
>
> Then why don't put `Poolingcount` to `idle`, and `idle` +
`activeCount`(maybe?) as the real `poolingCount`? The reason
wu-sheng commented on PR #679:
URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2047422300
BTW, as a metric label is removed, the CI fails as expected. Let's focus on
the above question first.
--
This is an automated message from the Apache Git Service.
To respond to
wu-sheng commented on PR #679:
URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2047403819
> Poolingcount represents the concept of idle
Then why don't put `Poolingcount` to `idle`, and `idle` +
`activeCount`(maybe?) as the real `poolingCount`?
The reason I am
AlchemyDing commented on PR #679:
URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2047396570
Pollingcount represents the concept of idle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
wu-sheng commented on PR #679:
URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2047376377
So, Druid pool doesn't have an idle concept? Then what is the status of the
connection after it is used?
--
This is an automated message from the Apache Git Service.
To respond
AlchemyDing commented on PR #679:
URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2046949056
`idleCount` should be `druidDataSource.getPoolingCount()`
But this way it's the same as `poolingCount`.
wu-sheng commented on PR #679:
URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2046826378
Your fix at OTEL-java side seems different. Could you explain more here or
need to align with that?
--
This is an automated message from the Apache Git Service.
To respond to
wu-sheng commented on PR #679:
URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2046518883
Pending on OTEL side discussion, as I want to keep the whole context
continuous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
14 matches
Mail list logo
