[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #8256: [sql_json] Ensuring the request body is JSON encoded

graceguo-supercat commented on a change in pull request #8256: [sql_json] Ensuring the request body is JSON encoded URL: https://github.com/apache/incubator-superset/pull/8256#discussion_r326028235 ## File path: superset/assets/src/SqlLab/actions/sqlLab.js ## @@ -220,9

[GitHub] [incubator-superset] dpgaspar commented on issue #8256: [sql_json] Ensuring the request body is JSON encoded

dpgaspar commented on issue #8256: [sql_json] Ensuring the request body is JSON encoded URL: https://github.com/apache/incubator-superset/pull/8256#issuecomment-533018263 #8163 :eyes: This is an automated message from the

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8163: [SQLLab] Refactor sql json endpoint

codecov-io edited a comment on issue #8163: [SQLLab] Refactor sql json endpoint URL: https://github.com/apache/incubator-superset/pull/8163#issuecomment-529036459 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8258: refactor: use deck.gl plugins from npm package

codecov-io edited a comment on issue #8258: refactor: use deck.gl plugins from npm package URL: https://github.com/apache/incubator-superset/pull/8258#issuecomment-533033116 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8258?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-io commented on issue #8258: refactor: use deck.gl plugins from npm package

codecov-io commented on issue #8258: refactor: use deck.gl plugins from npm package URL: https://github.com/apache/incubator-superset/pull/8258#issuecomment-533033116 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8258?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8258: refactor: use deck.gl plugins from npm package

codecov-io edited a comment on issue #8258: refactor: use deck.gl plugins from npm package URL: https://github.com/apache/incubator-superset/pull/8258#issuecomment-533033116 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8258?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] kalimuthu123 commented on issue #8236: Pivot Table Conditional Formatting on Cells - Add Colour to Cells

kalimuthu123 commented on issue #8236: Pivot Table Conditional Formatting on Cells - Add Colour to Cells URL: https://github.com/apache/incubator-superset/issues/8236#issuecomment-532999635 Look the pull request for row and column configuration

[GitHub] [incubator-superset] kalimuthu123 edited a comment on issue #8236: Pivot Table Conditional Formatting on Cells - Add Colour to Cells

kalimuthu123 edited a comment on issue #8236: Pivot Table Conditional Formatting on Cells - Add Colour to Cells URL: https://github.com/apache/incubator-superset/issues/8236#issuecomment-532999635 Look the pull request for row and column configuration

[GitHub] [incubator-superset] kristw opened a new pull request #8258: refactor: use deck.gl plugins from npm package

kristw opened a new pull request #8258: refactor: use deck.gl plugins from npm package URL: https://github.com/apache/incubator-superset/pull/8258 ### CATEGORY Choose one - [X] Refactor ### SUMMARY `deck.gl` plugins are migrated to new repo

[GitHub] [incubator-superset] graceguo-supercat commented on issue #8060: SIP-23: Persist SQL Lab state in the backend

graceguo-supercat commented on issue #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#issuecomment-533037917 @betodealmeida deleting tab still not working for me, see 2 issues below: 1. delete query tab with history:

[GitHub] [incubator-superset] celestewang1026 removed a comment on issue #8114: superset conn hive faied

celestewang1026 removed a comment on issue #8114: superset conn hive faied URL: https://github.com/apache/incubator-superset/issues/8114#issuecomment-532037277 > @celestewang1026 Try this steps > > 1. stop Superset process > 2. activate virtual environment if you use it > 3.

[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8259: unable to display data table in sqlite

issue-label-bot[bot] commented on issue #8259: unable to display data table in sqlite URL: https://github.com/apache/incubator-superset/issues/8259#issuecomment-533058972 Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.87. Please mark this

[GitHub] [incubator-superset] LoveMyBaby opened a new issue #8259: unable to display data table in sqlite

LoveMyBaby opened a new issue #8259: unable to display data table in sqlite URL: https://github.com/apache/incubator-superset/issues/8259 last report(run in docker): [https://github.com/apache/incubator-superset/issues/8249#issue-495165654 ](url) I have successfully installed

[GitHub] [incubator-superset] yravindra commented on issue #8248: SQL Lab doesn't display queries results but rather 'offline' followed by an empty table

yravindra commented on issue #8248: SQL Lab doesn't display queries results but rather 'offline' followed by an empty table URL: https://github.com/apache/incubator-superset/issues/8248#issuecomment-533065741 you can select column in query like (select column1,column2 from table name

[GitHub] [incubator-superset] dpgaspar edited a comment on issue #8254: WIP. Avoid circular dependency between superset config and superset package

dpgaspar edited a comment on issue #8254: WIP. Avoid circular dependency between superset config and superset package URL: https://github.com/apache/incubator-superset/pull/8254#issuecomment-533137242 I would rename `superset/security/security.py` to `superset/security/manager.py`.

[GitHub] [incubator-superset] stale[bot] closed issue #6348: Mapbox dosen't show anything

stale[bot] closed issue #6348: Mapbox dosen't show anything URL: https://github.com/apache/incubator-superset/issues/6348 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-superset] dpgaspar commented on issue #8259: unable to display data table in sqlite

dpgaspar commented on issue #8259: unable to display data table in sqlite URL: https://github.com/apache/incubator-superset/issues/8259#issuecomment-533125739 Hi, Just tested it, I've done the following on superset local dev env, with loaded examples: - created a sqllite db with

[GitHub] [incubator-superset] dpgaspar commented on issue #8254: WIP. Avoid circular dependency between superset config and superset package

dpgaspar commented on issue #8254: WIP. Avoid circular dependency between superset config and superset package URL: https://github.com/apache/incubator-superset/pull/8254#issuecomment-533137242 I would rename `superset/security/security.py` to `superset/security/manager.py`. You need

[GitHub] [incubator-superset] williamdrake commented on issue #2687: "e.map is not a function" error on time series

williamdrake commented on issue #2687: "e.map is not a function" error on time series URL: https://github.com/apache/incubator-superset/issues/2687#issuecomment-533103243 I'm getting this issue when trying to load graphs from the Explore function from SQL Lab.

[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8260: contrib/docker doesnt support corporate environment/proxy

issue-label-bot[bot] commented on issue #8260: contrib/docker doesnt support corporate environment/proxy URL: https://github.com/apache/incubator-superset/issues/8260#issuecomment-533174517 Issue Label Bot is not confident enough to auto-label this issue. See

[GitHub] [incubator-superset] dprophet opened a new issue #8260: contrib/docker doesnt support corporate environment/proxy

dprophet opened a new issue #8260: contrib/docker doesnt support corporate environment/proxy URL: https://github.com/apache/incubator-superset/issues/8260 A clear and concise description of what the bug is. ### Expected results If you run

[GitHub] [incubator-superset] davidhassan commented on issue #8236: Pivot Table Conditional Formatting on Cells - Add Colour to Cells

davidhassan commented on issue #8236: Pivot Table Conditional Formatting on Cells - Add Colour to Cells URL: https://github.com/apache/incubator-superset/issues/8236#issuecomment-533219506 Did this pull request ever make it into the official releases? Are we suppose to just take these

[GitHub] [incubator-superset] john-bodley commented on issue #8163: [SQLLab] Refactor sql json endpoint

john-bodley commented on issue #8163: [SQLLab] Refactor sql json endpoint URL: https://github.com/apache/incubator-superset/pull/8163#issuecomment-533231079 @dpgaspar I think this solves a different problem than https://github.com/apache/incubator-superset/pull/8256 and thus both PRs are

[GitHub] [incubator-superset] CyrilLeMat commented on issue #8248: SQL Lab doesn't display queries results but rather 'offline' followed by an empty table

CyrilLeMat commented on issue #8248: SQL Lab doesn't display queries results but rather 'offline' followed by an empty table URL: https://github.com/apache/incubator-superset/issues/8248#issuecomment-533195451 - I cleared my cache and it doesn't change anything. - there is no

[GitHub] [incubator-superset] villebro commented on a change in pull request #8229: [POC] add echarts scatter

villebro commented on a change in pull request #8229: [POC] add echarts scatter URL: https://github.com/apache/incubator-superset/pull/8229#discussion_r326310227 ## File path: superset/viz.py ## @@ -2765,6 +2765,15 @@ def get_data(self, df): return

[GitHub] [incubator-superset] CoryChaplin commented on issue #8236: Pivot Table Conditional Formatting on Cells - Add Colour to Cells

CoryChaplin commented on issue #8236: Pivot Table Conditional Formatting on Cells - Add Colour to Cells URL: https://github.com/apache/incubator-superset/issues/8236#issuecomment-533190545 Need that ! :) This is an

[GitHub] [incubator-superset] graceguo-supercat merged pull request #8223: Fix sync failed when datasource is schema-less

graceguo-supercat merged pull request #8223: Fix sync failed when datasource is schema-less URL: https://github.com/apache/incubator-superset/pull/8223 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-superset] john-bodley commented on issue #8163: [SQLLab] Refactor sql json endpoint

john-bodley commented on issue #8163: [SQLLab] Refactor sql json endpoint URL: https://github.com/apache/incubator-superset/pull/8163#issuecomment-533245048 @dpgaspar do you want to merge your PR? I'll rebase my change on top of yours.

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8256: [sql_json] Ensuring the request body is JSON encoded

etr2460 commented on a change in pull request #8256: [sql_json] Ensuring the request body is JSON encoded URL: https://github.com/apache/incubator-superset/pull/8256#discussion_r326294938 ## File path: superset/views/core.py ## @@ -2594,16 +2594,16 @@ def

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8256: [sql_json] Ensuring the request body is JSON encoded

etr2460 commented on a change in pull request #8256: [sql_json] Ensuring the request body is JSON encoded URL: https://github.com/apache/incubator-superset/pull/8256#discussion_r326295702 ## File path: superset/assets/src/SqlLab/actions/sqlLab.js ## @@ -220,9 +220,9 @@

[GitHub] [incubator-superset] DiggidyDave commented on a change in pull request #8229: [POC] add echarts scatter

DiggidyDave commented on a change in pull request #8229: [POC] add echarts scatter URL: https://github.com/apache/incubator-superset/pull/8229#discussion_r326279881 ## File path: superset/viz.py ## @@ -2765,6 +2765,15 @@ def get_data(self, df): return

[GitHub] [incubator-superset] dpgaspar commented on issue #8163: [SQLLab] Refactor sql json endpoint

dpgaspar commented on issue #8163: [SQLLab] Refactor sql json endpoint URL: https://github.com/apache/incubator-superset/pull/8163#issuecomment-533232876 Yes I know This is an automated message from the Apache Git Service.

[GitHub] [incubator-superset] villebro commented on issue #8183: How to pass time filters to SQL Lab queries

villebro commented on issue #8183: How to pass time filters to SQL Lab queries URL: https://github.com/apache/incubator-superset/issues/8183#issuecomment-533304850 Can you post a case where a jinja-based date filter needs to be used? I'm not saying there isn't one, but as the majority of

[GitHub] [incubator-superset] rubypollev commented on issue #1367: Column/Metric description tooltips missing

rubypollev commented on issue #1367: Column/Metric description tooltips missing URL: https://github.com/apache/incubator-superset/issues/1367#issuecomment-533313251 This would be really awesome! This is an automated message

[GitHub] [incubator-superset] serenajiang closed pull request #8220: [sqllab] use celery worker for stop_query

serenajiang closed pull request #8220: [sqllab] use celery worker for stop_query URL: https://github.com/apache/incubator-superset/pull/8220 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-superset] dpgaspar commented on issue #8163: [SQLLab] Refactor sql json endpoint

dpgaspar commented on issue #8163: [SQLLab] Refactor sql json endpoint URL: https://github.com/apache/incubator-superset/pull/8163#issuecomment-533248566 That would be great! merge away then This is an automated message from

[GitHub] [incubator-superset] john-bodley merged pull request #8163: [SQLLab] Refactor sql json endpoint

john-bodley merged pull request #8163: [SQLLab] Refactor sql json endpoint URL: https://github.com/apache/incubator-superset/pull/8163 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-superset] graceguo-supercat edited a comment on issue #8060: SIP-23: Persist SQL Lab state in the backend

graceguo-supercat edited a comment on issue #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#issuecomment-533037917 @betodealmeida deleting tab is still **not** working for me, see 2 issues below: 1. delete query tab with

[GitHub] [incubator-superset] LoveMyBaby commented on issue #8259: unable to display data table in sqlite

LoveMyBaby commented on issue #8259: unable to display data table in sqlite URL: https://github.com/apache/incubator-superset/issues/8259#issuecomment-533376882 Thanks dpgaspar even if I repeat the test, this problem still occurs. when I create a new mysql connection, it is right.

[GitHub] [incubator-superset] CyrilLeMat edited a comment on issue #8248: SQL Lab doesn't display queries results but rather 'offline' followed by an empty table

CyrilLeMat edited a comment on issue #8248: SQL Lab doesn't display queries results but rather 'offline' followed by an empty table URL: https://github.com/apache/incubator-superset/issues/8248#issuecomment-533195451 Hi, thanks for answering! - I cleared my cache and it doesn't

[GitHub] [incubator-superset] villebro commented on issue #8262: [SQL Lab] Add commit to resolve query table lock

villebro commented on issue #8262: [SQL Lab] Add commit to resolve query table lock URL: https://github.com/apache/incubator-superset/pull/8262#issuecomment-533417254 Hmm. Tracing back it seems there is already a `session.commit()` going on before this in the calling method:

[GitHub] [incubator-superset] etr2460 commented on issue #8215: chore: fix flaky SQL Lab test with .focus().blur()

etr2460 commented on issue #8215: chore: fix flaky SQL Lab test with .focus().blur() URL: https://github.com/apache/incubator-superset/pull/8215#issuecomment-533407778 I think the problem here is that the select all on the textbox is failing. The travis logs show running a query like:

[GitHub] [incubator-superset] dpgaspar commented on issue #8163: [SQLLab] Refactor sql json endpoint

dpgaspar commented on issue #8163: [SQLLab] Refactor sql json endpoint URL: https://github.com/apache/incubator-superset/pull/8163#issuecomment-533135575 @mistercrunch @john-bodley This is an automated message from the

[GitHub] [incubator-superset] xcaptain closed pull request #7795: add an option to export csv file with verbose column names

xcaptain closed pull request #7795: add an option to export csv file with verbose column names URL: https://github.com/apache/incubator-superset/pull/7795 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-superset] graceguo-supercat edited a comment on issue #8060: SIP-23: Persist SQL Lab state in the backend

graceguo-supercat edited a comment on issue #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#issuecomment-533037917 @betodealmeida deleting tab is still **not** working for me, see 2 issues below: 1. First, delete a few

[GitHub] [incubator-superset] etr2460 merged pull request #8138: [typing] add typing for superset/connectors and superset/common

etr2460 merged pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #8261: [migration] Stripping leading and trailing whitespace

john-bodley commented on a change in pull request #8261: [migration] Stripping leading and trailing whitespace URL: https://github.com/apache/incubator-superset/pull/8261#discussion_r326426479 ## File path:

[GitHub] [incubator-superset] etr2460 opened a new pull request #8262: [SQL Lab] Add commit to resolve query table lock

etr2460 opened a new pull request #8262: [SQL Lab] Add commit to resolve query table lock URL: https://github.com/apache/incubator-superset/pull/8262 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests

[GitHub] [incubator-superset] codecov-io commented on issue #8254: WIP. Avoid circular dependency between superset config and superset package

codecov-io commented on issue #8254: WIP. Avoid circular dependency between superset config and superset package URL: https://github.com/apache/incubator-superset/pull/8254#issuecomment-533354475 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8254?src=pr=h1) Report

[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8263: Login Page Default Focus.

issue-label-bot[bot] commented on issue #8263: Login Page Default Focus. URL: https://github.com/apache/incubator-superset/issues/8263#issuecomment-533354732 Issue-Label Bot is automatically applying the label `#enhancement` to this issue, with a confidence of 0.90. Please mark this

[GitHub] [incubator-superset] kuckjwi0928 opened a new issue #8263: Login Page Default Focus.

kuckjwi0928 opened a new issue #8263: Login Page Default Focus. URL: https://github.com/apache/incubator-superset/issues/8263 **Is your feature request related to a problem? Please describe.** No **Describe the solution you'd like** It would be good to basically focus on the

[GitHub] [incubator-superset] kuckjwi0928 opened a new pull request #8265: Fixed korean translation error.

kuckjwi0928 opened a new pull request #8265: Fixed korean translation error. URL: https://github.com/apache/incubator-superset/pull/8265 ### CATEGORY - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development

[GitHub] [incubator-superset] codecov-io commented on issue #8256: [sql_json] Ensuring the request body is JSON encoded

codecov-io commented on issue #8256: [sql_json] Ensuring the request body is JSON encoded URL: https://github.com/apache/incubator-superset/pull/8256#issuecomment-533346097 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8256?src=pr=h1) Report > Merging

[GitHub] [incubator-superset] bkyryliuk commented on issue #8254: Avoid circular dependency between superset config and superset package

bkyryliuk commented on issue #8254: Avoid circular dependency between superset config and superset package URL: https://github.com/apache/incubator-superset/pull/8254#issuecomment-533355430 @dpgaspar did you mean import `SupersetSecurityManager ` in `superset/security/__init__.py`

[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8264: Heatmap x-axis not sorting properly

issue-label-bot[bot] commented on issue #8264: Heatmap x-axis not sorting properly URL: https://github.com/apache/incubator-superset/issues/8264#issuecomment-533365050 Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.92. Please mark this

[GitHub] [incubator-superset] syazwan0913 opened a new issue #8264: Heatmap x-axis not sorting properly

syazwan0913 opened a new issue #8264: Heatmap x-axis not sorting properly URL: https://github.com/apache/incubator-superset/issues/8264 ### Expected results sorting on x-axis is proper order like 0, 1, 2, 3, 4, 5, 6, ### Actual results Sorting is not in order

[GitHub] [incubator-superset] john-bodley opened a new pull request #8261: [migration] Stripping leading and trailing whitespace

john-bodley opened a new pull request #8261: [migration] Stripping leading and trailing whitespace URL: https://github.com/apache/incubator-superset/pull/8261 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8261: [migration] Stripping leading and trailing whitespace

etr2460 commented on a change in pull request #8261: [migration] Stripping leading and trailing whitespace URL: https://github.com/apache/incubator-superset/pull/8261#discussion_r326425156 ## File path:

[GitHub] [incubator-superset] kristw merged pull request #8258: refactor: use deck.gl plugins from npm package

kristw merged pull request #8258: refactor: use deck.gl plugins from npm package URL: https://github.com/apache/incubator-superset/pull/8258 This is an automated message from the Apache Git Service. To respond to the