[GitHub] [superset] eschutho commented on pull request #14956: chore: Add height/width TrashIcon SVG(18px/18px)-Edit Dataset modal

eschutho commented on pull request #14956: URL: https://github.com/apache/superset/pull/14956#issuecomment-861787882 /testenv up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [superset] codecov[bot] edited a comment on pull request #15157: feat: Synchronously return cached charts

codecov[bot] edited a comment on pull request #15157: URL: https://github.com/apache/superset/pull/15157#issuecomment-861050802 #

[GitHub] [superset] github-actions[bot] commented on pull request #14978: refactor: Convert TableElement to TypeScript

github-actions[bot] commented on pull request #14978: URL: https://github.com/apache/superset/pull/14978#issuecomment-861835022 Ephemeral environment shutdown and build artifacts deleted. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [superset] pkdotson commented on pull request #14462: refactor: change warning icon to use icons

pkdotson commented on pull request #14462: URL: https://github.com/apache/superset/pull/14462#issuecomment-861855217 Going to close this as there is no longer an icon for add dataset modal -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [superset] pkdotson closed pull request #14462: refactor: change warning icon to use icons

pkdotson closed pull request #14462: URL: https://github.com/apache/superset/pull/14462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [superset] betodealmeida opened a new pull request #15181: fix: ignore errors in GetLog

betodealmeida opened a new pull request #15181: URL: https://github.com/apache/superset/pull/15181 ### SUMMARY We're seeing errors in Databricks that say: ``` Couldn't find log associated with operation handle ``` Searching for the message suggests that this

[GitHub] [superset] pkdotson commented on a change in pull request #14463: refactor: refactor Icon to Icons in sqlEditor component

pkdotson commented on a change in pull request #14463: URL: https://github.com/apache/superset/pull/14463#discussion_r652185514 ## File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx ## @@ -638,7 +638,9 @@ class SqlEditor extends React.PureComponent {

[GitHub] [superset] codecov[bot] commented on pull request #15180: chore: add default themecolor to Icons component

codecov[bot] commented on pull request #15180: URL: https://github.com/apache/superset/pull/15180#issuecomment-861870396 #

[GitHub] [superset] rusackas commented on pull request #14463: refactor: refactor Icon to Icons in sqlEditor component

rusackas commented on pull request #14463: URL: https://github.com/apache/superset/pull/14463#issuecomment-861900683 /testenv up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [superset] codecov[bot] edited a comment on pull request #15123: fix(logging): downgrade csv export log to debug

codecov[bot] edited a comment on pull request #15123: URL: https://github.com/apache/superset/pull/15123#issuecomment-861902043 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15151: feat: adding server-side validation and unmasked password on create

codecov[bot] edited a comment on pull request #15151: URL: https://github.com/apache/superset/pull/15151#issuecomment-860840728 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15151: feat: adding server-side validation and unmasked password on create

codecov[bot] edited a comment on pull request #15151: URL: https://github.com/apache/superset/pull/15151#issuecomment-860840728 #

[GitHub] [superset] codecov[bot] commented on pull request #15186: fix(dashboard-list): change name of dashboard is not reflected instantly

codecov[bot] commented on pull request #15186: URL: https://github.com/apache/superset/pull/15186#issuecomment-862048658 #

[GitHub] [superset] stephenLYZ opened a new pull request #15186: fix(dashboard-list): change name of dashboard is not reflected instantly

stephenLYZ opened a new pull request #15186: URL: https://github.com/apache/superset/pull/15186 ### SUMMARY Fix the title of dashboard list is not reflected instantly after editing. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF before

[GitHub] [superset] codecov[bot] edited a comment on pull request #15151: feat: adding server-side validation and unmasked password on create

codecov[bot] edited a comment on pull request #15151: URL: https://github.com/apache/superset/pull/15151#issuecomment-860840728 #

[GitHub] [superset] villebro commented on pull request #15157: feat: Synchronously return cached charts

villebro commented on pull request #15157: URL: https://github.com/apache/superset/pull/15157#issuecomment-862046726 @benjreinhart @robdiciuccio thanks for the context. Like I said, I don't have a strong opinion here, and I agree that deferring an already cached result to the async flow

[GitHub] [superset] codecov[bot] edited a comment on pull request #15111: chore: add Chinese translation, wrap some text inside translation function

codecov[bot] edited a comment on pull request #15111: URL: https://github.com/apache/superset/pull/15111#issuecomment-859345729 #

[GitHub] [superset] AAfghahi commented on a change in pull request #15151: feat: adding server-side validation and unmasked password on create

AAfghahi commented on a change in pull request #15151: URL: https://github.com/apache/superset/pull/15151#discussion_r652353048 ## File path: tests/databases/api_tests.py ## @@ -1668,38 +1675,74 @@ def test_validate_parameters_invalid_payload_schema(self): response =

[GitHub] [superset] codecov[bot] edited a comment on pull request #15111: chore: add Chinese translation, wrap some text inside translation function

codecov[bot] edited a comment on pull request #15111: URL: https://github.com/apache/superset/pull/15111#issuecomment-859345729 #

[GitHub] [superset] lilila commented on issue #13486: [dashboard]Create color mappings for quick update of dashboard colors

lilila commented on issue #13486: URL: https://github.com/apache/superset/issues/13486#issuecomment-862032702 Dear @opus-42 , Could you please give us some examples on how you manage to do this: `An alternative that is already used in my company is to use the dashboard REST API

[GitHub] [superset] codecov[bot] edited a comment on pull request #15157: feat: Synchronously return cached charts

codecov[bot] edited a comment on pull request #15157: URL: https://github.com/apache/superset/pull/15157#issuecomment-861050802 #

[GitHub] [superset] eschutho commented on pull request #14978: refactor: Convert TableElement to TypeScript

eschutho commented on pull request #14978: URL: https://github.com/apache/superset/pull/14978#issuecomment-861810021 You're right, @corbinrobb. That example didn't have anything to sort. I tested on a different list and it's working. I'll go ahead and merge. Thanks for the help on this!

[GitHub] [superset] eschutho merged pull request #14978: refactor: Convert TableElement to TypeScript

eschutho merged pull request #14978: URL: https://github.com/apache/superset/pull/14978 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [superset] codecov[bot] edited a comment on pull request #14463: refactor: refactor Icon to Icons in sqlEditor component

codecov[bot] edited a comment on pull request #14463: URL: https://github.com/apache/superset/pull/14463#issuecomment-832207182 #

[GitHub] [superset] codecov[bot] commented on pull request #15121: feat: Select component (Iteration 1)

codecov[bot] commented on pull request #15121: URL: https://github.com/apache/superset/pull/15121#issuecomment-861833019 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #14891: fix(aarch64): Bump pyarrow version to 4.0.1

codecov[bot] edited a comment on pull request #14891: URL: https://github.com/apache/superset/pull/14891#issuecomment-850168743 #

[GitHub] [superset] codecov[bot] commented on pull request #15181: fix: ignore errors in GetLog

codecov[bot] commented on pull request #15181: URL: https://github.com/apache/superset/pull/15181#issuecomment-861873615 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15151: feat: adding server-side validation and unmasked password on create

codecov[bot] edited a comment on pull request #15151: URL: https://github.com/apache/superset/pull/15151#issuecomment-860840728 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15157: feat: Synchronously return cached charts

codecov[bot] edited a comment on pull request #15157: URL: https://github.com/apache/superset/pull/15157#issuecomment-861050802 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15151: feat: adding server-side validation and unmasked password on create

codecov[bot] edited a comment on pull request #15151: URL: https://github.com/apache/superset/pull/15151#issuecomment-860840728 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15151: feat: adding server-side validation and unmasked password on create

codecov[bot] edited a comment on pull request #15151: URL: https://github.com/apache/superset/pull/15151#issuecomment-860840728 #

[GitHub] [superset] willbarrett commented on a change in pull request #15149: feat(dao): admin can remove self from object owners

willbarrett commented on a change in pull request #15149: URL: https://github.com/apache/superset/pull/15149#discussion_r652303978 ## File path: superset/commands/base.py ## @@ -37,3 +41,38 @@ def validate(self) -> None: Will raise exception if validation fails

[GitHub] [superset] codecov[bot] edited a comment on pull request #15115: chore: Improves the native filters bar layout

codecov[bot] edited a comment on pull request #15115: URL: https://github.com/apache/superset/pull/15115#issuecomment-859614460 #

[GitHub] [superset] andrewbastian opened a new pull request #15179: chore: Add tooltips and button to Connect Postgresql DB Modal Form

andrewbastian opened a new pull request #15179: URL: https://github.com/apache/superset/pull/15179 ### SUMMARY Add tooltips and edit tooltip dialog on Postgresql connection modal, Add button link on SQLAcademy modal. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

[GitHub] [superset] codecov[bot] edited a comment on pull request #14891: fix(aarch64): Bump pyarrow version to 4.0.0

codecov[bot] edited a comment on pull request #14891: URL: https://github.com/apache/superset/pull/14891#issuecomment-850168743 #

[GitHub] [superset] corbinrobb commented on pull request #14978: refactor: Convert TableElement to TypeScript

corbinrobb commented on pull request #14978: URL: https://github.com/apache/superset/pull/14978#issuecomment-861811639 Whew! That's relieving, I got super worried for a moment there lol Thanks for everything! @eschutho -- This is an automated message from the Apache Git Service. To

[GitHub] [superset] benjreinhart commented on a change in pull request #15157: feat: Synchronously return cached charts

benjreinhart commented on a change in pull request #15157: URL: https://github.com/apache/superset/pull/15157#discussion_r652151380 ## File path: superset-frontend/src/chart/chartAction.js ## @@ -395,7 +395,16 @@ export function exploreJSON( if

[GitHub] [superset] codecov[bot] commented on pull request #15178: chore: Allows the user to force fetch the default values

codecov[bot] commented on pull request #15178: URL: https://github.com/apache/superset/pull/15178#issuecomment-861836046 #

[GitHub] [superset] github-actions[bot] commented on pull request #15121: feat: Select component (Iteration 1)

github-actions[bot] commented on pull request #15121: URL: https://github.com/apache/superset/pull/15121#issuecomment-861851192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [superset] pkdotson commented on a change in pull request #14462: refactor: change warning icon to use icons

pkdotson commented on a change in pull request #14462: URL: https://github.com/apache/superset/pull/14462#discussion_r652171283 ## File path: superset-frontend/src/views/CRUD/data/dataset/AddDatasetModal.tsx ## @@ -107,7 +109,7 @@ const DatasetModal: FunctionComponent = ({

[GitHub] [superset] codecov[bot] edited a comment on pull request #15181: fix: ignore errors in GetLog

codecov[bot] edited a comment on pull request #15181: URL: https://github.com/apache/superset/pull/15181#issuecomment-861873615 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15151: feat: adding server-side validation and unmasked password on create

codecov[bot] edited a comment on pull request #15151: URL: https://github.com/apache/superset/pull/15151#issuecomment-860840728 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #14891: fix(aarch64): Bump pyarrow version to 4.0.1

codecov[bot] edited a comment on pull request #14891: URL: https://github.com/apache/superset/pull/14891#issuecomment-850168743 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15151: feat: adding server-side validation and unmasked password on create

codecov[bot] edited a comment on pull request #15151: URL: https://github.com/apache/superset/pull/15151#issuecomment-860840728 #

[GitHub] [superset] nazrulhadi commented on issue #15035: Unable to upgrade superset database

nazrulhadi commented on issue #15035: URL: https://github.com/apache/superset/issues/15035#issuecomment-861988324 hi @cortesjpb currently i test it in my local -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [superset] codecov[bot] edited a comment on pull request #15111: chore: add Chinese translation, wrap some text inside translation function

codecov[bot] edited a comment on pull request #15111: URL: https://github.com/apache/superset/pull/15111#issuecomment-859345729 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15177: feat(trino): add support for query cost estimate #15166

codecov[bot] edited a comment on pull request #15177: URL: https://github.com/apache/superset/pull/15177#issuecomment-861785984 #

[GitHub] [superset] rusackas commented on pull request #15121: feat: Select component (Iteration 1)

rusackas commented on pull request #15121: URL: https://github.com/apache/superset/pull/15121#issuecomment-861834255 /testenv up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [superset] github-actions[bot] commented on pull request #14956: chore: Add height/width TrashIcon SVG(18px/18px)-Edit Dataset modal

github-actions[bot] commented on pull request #14956: URL: https://github.com/apache/superset/pull/14956#issuecomment-861854818 @eschutho Ephemeral environment spinning up at http://35.166.235.161:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and

[GitHub] [superset] github-actions[bot] commented on pull request #15180: chore: add default themecolor to Icons component

github-actions[bot] commented on pull request #15180: URL: https://github.com/apache/superset/pull/15180#issuecomment-861866437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [superset] pkdotson merged pull request #15175: fix: trim string value of spaces in listview search

pkdotson merged pull request #15175: URL: https://github.com/apache/superset/pull/15175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [superset] betodealmeida merged pull request #15181: fix: ignore errors in GetLog

betodealmeida merged pull request #15181: URL: https://github.com/apache/superset/pull/15181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [superset] codecov[bot] commented on pull request #15123: fix(logging): downgrade csv export log to debug

codecov[bot] commented on pull request #15123: URL: https://github.com/apache/superset/pull/15123#issuecomment-861902043 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15151: feat: adding server-side validation and unmasked password on create

codecov[bot] edited a comment on pull request #15151: URL: https://github.com/apache/superset/pull/15151#issuecomment-860840728 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15151: feat: adding server-side validation and unmasked password on create

codecov[bot] edited a comment on pull request #15151: URL: https://github.com/apache/superset/pull/15151#issuecomment-860840728 #

[GitHub] [superset] pkdotson commented on a change in pull request #14462: refactor: change warning icon to use icons

pkdotson commented on a change in pull request #14462: URL: https://github.com/apache/superset/pull/14462#discussion_r652171283 ## File path: superset-frontend/src/views/CRUD/data/dataset/AddDatasetModal.tsx ## @@ -107,7 +109,7 @@ const DatasetModal: FunctionComponent = ({

[GitHub] [superset] codecov[bot] edited a comment on pull request #15151: feat: adding server-side validation and unmasked password on create

codecov[bot] edited a comment on pull request #15151: URL: https://github.com/apache/superset/pull/15151#issuecomment-860840728 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15182: fix: hiding HiddenControl inputs for real, so they don't add height

codecov[bot] edited a comment on pull request #15182: URL: https://github.com/apache/superset/pull/15182#issuecomment-861894067 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15182: fix: hiding HiddenControl inputs for real, so they don't add height

codecov[bot] edited a comment on pull request #15182: URL: https://github.com/apache/superset/pull/15182#issuecomment-861894067 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15123: fix(logging): downgrade csv export log to debug

codecov[bot] edited a comment on pull request #15123: URL: https://github.com/apache/superset/pull/15123#issuecomment-861902043 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15123: fix(logging): downgrade csv export log to debug

codecov[bot] edited a comment on pull request #15123: URL: https://github.com/apache/superset/pull/15123#issuecomment-861902043 #

[GitHub] [superset] betodealmeida opened a new pull request #15184: fix: datasource payload is incorrect

betodealmeida opened a new pull request #15184: URL: https://github.com/apache/superset/pull/15184 ### SUMMARY We currently return all datasources in the `/datasources/` and `/chart/add` endpoints. This PR changes the payload to have only user-accessible datasources. The

[GitHub] [superset] codecov[bot] edited a comment on pull request #15157: feat: Synchronously return cached charts

codecov[bot] edited a comment on pull request #15157: URL: https://github.com/apache/superset/pull/15157#issuecomment-861050802 #

[GitHub] [superset] zhaoyongjie commented on pull request #15111: chore: add Chinese translation, wrap some text inside translation function

zhaoyongjie commented on pull request #15111: URL: https://github.com/apache/superset/pull/15111#issuecomment-861991269 > > `superset/translations/zh/LC_MESSAGES/messages.po` looks like there are some problems > >

[GitHub] [superset] villebro commented on pull request #14891: fix(aarch64): Bump pyarrow version to 4.0.0

villebro commented on pull request #14891: URL: https://github.com/apache/superset/pull/14891#issuecomment-861778401 @danielewood I noticed `pyarrow==4.0.1` is out, can you bump the dependency in this PR to that version? I feel inclined to get this merged to unblock `aarch64` support.

[GitHub] [superset] codecov[bot] commented on pull request #15177: feat(trino): add support for query cost estimate #15166

codecov[bot] commented on pull request #15177: URL: https://github.com/apache/superset/pull/15177#issuecomment-861785984 #

[GitHub] [superset] exemplary-citizen commented on pull request #14449: feat: Add parquet upload

exemplary-citizen commented on pull request #14449: URL: https://github.com/apache/superset/pull/14449#issuecomment-861785894 Looks like the failing presto postgres test was fixed in #15163. CI should come back green now. -- This is an automated message from the Apache Git Service. To

[GitHub] [superset] eschutho commented on pull request #14978: refactor: Convert TableElement to TypeScript

eschutho commented on pull request #14978: URL: https://github.com/apache/superset/pull/14978#issuecomment-861790422 @corbinrobb this looks great. I wasn't able to sort the columns in the test environment. Can you check and see if that is working for you? It should sort both ascending and

[GitHub] [superset] corbinrobb commented on pull request #14978: refactor: Convert TableElement to TypeScript

corbinrobb commented on pull request #14978: URL: https://github.com/apache/superset/pull/14978#issuecomment-861798062 @eschutho Hmm, mine is working as expected. The button originally doesn't sort the columns and just displays the way the table is sent and the button toggles between

[GitHub] [superset] codecov[bot] edited a comment on pull request #15157: feat: Synchronously return cached charts

codecov[bot] edited a comment on pull request #15157: URL: https://github.com/apache/superset/pull/15157#issuecomment-861050802 #

[GitHub] [superset] graceguo-supercat commented on a change in pull request #15109: fix: SQL Lab show "Refetch Results" button while fetching new query results

graceguo-supercat commented on a change in pull request #15109: URL: https://github.com/apache/superset/pull/15109#discussion_r652135854 ## File path: superset-frontend/src/SqlLab/reducers/sqlLab.js ## @@ -517,7 +517,23 @@ export default function sqlLabReducer(state = {},

[GitHub] [superset] codecov[bot] edited a comment on pull request #15109: fix: SQL Lab show "Refetch Results" button while fetching new query results

codecov[bot] edited a comment on pull request #15109: URL: https://github.com/apache/superset/pull/15109#issuecomment-859282112 #

[GitHub] [superset] pkdotson opened a new pull request #15180: chore: add default themecolor

pkdotson opened a new pull request #15180: URL: https://github.com/apache/superset/pull/15180 ### SUMMARY This pr is to add the default base theme color for icon when one is not specified. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTIONS Will

[GitHub] [superset] pkdotson commented on pull request #15180: chore: add default themecolor

pkdotson commented on pull request #15180: URL: https://github.com/apache/superset/pull/15180#issuecomment-861823308 /testenv up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [superset] codecov[bot] edited a comment on pull request #14881: feat: Database Connection UI

codecov[bot] edited a comment on pull request #14881: URL: https://github.com/apache/superset/pull/14881#issuecomment-849871089 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15109: fix: SQL Lab show "Refetch Results" button while fetching new query results

codecov[bot] edited a comment on pull request #15109: URL: https://github.com/apache/superset/pull/15109#issuecomment-859282112 #

[GitHub] [superset] benjreinhart opened a new issue #15183: getChartDataRequest handling does not account for async query responses

benjreinhart opened a new issue #15183: URL: https://github.com/apache/superset/issues/15183 [`getChartDataRequest`](https://github.com/apache/superset/blob/7dc0cee5be33848f46e443fcf3181b605811945b/superset-frontend/src/chart/chartAction.js#L202) is currently used to grab data for charts

[GitHub] [superset] codecov[bot] commented on pull request #15182: fix: hiding HiddenControl inputs for real, so they don't add height

codecov[bot] commented on pull request #15182: URL: https://github.com/apache/superset/pull/15182#issuecomment-861894067 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15182: fix: hiding HiddenControl inputs for real, so they don't add height

codecov[bot] edited a comment on pull request #15182: URL: https://github.com/apache/superset/pull/15182#issuecomment-861894067 #

[GitHub] [superset] github-actions[bot] commented on pull request #14463: refactor: refactor Icon to Icons in sqlEditor component

github-actions[bot] commented on pull request #14463: URL: https://github.com/apache/superset/pull/14463#issuecomment-861901252 @rusackas Ephemeral environment spinning up at http://54.218.200.160:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and

[GitHub] [superset] codecov[bot] edited a comment on pull request #15157: feat: Synchronously return cached charts

codecov[bot] edited a comment on pull request #15157: URL: https://github.com/apache/superset/pull/15157#issuecomment-861050802 #

[GitHub] [superset] cabo40 commented on pull request #14006: fix: Cast out of bounds timestamps as objects

cabo40 commented on pull request #14006: URL: https://github.com/apache/superset/pull/14006#issuecomment-861856030 Hi. Sorry, can we open this PR? It is not duplicate and issue #13661 persists -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [superset] rusackas opened a new pull request #15182: fix: hiding HiddenControl inputs for real, so they don't add height

rusackas opened a new pull request #15182: URL: https://github.com/apache/superset/pull/15182 ### SUMMARY There are (or were) some hidden inputs in the Explore control panel, which were taking up about a pixel each vertically, thanks to Bootstrap. This PR simply adds a

[GitHub] [superset] henryyeh commented on pull request #15181: fix: ignore errors in GetLog

henryyeh commented on pull request #15181: URL: https://github.com/apache/superset/pull/15181#issuecomment-861926364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [superset] codecov[bot] commented on pull request #15184: fix: datasource payload is incorrect

codecov[bot] commented on pull request #15184: URL: https://github.com/apache/superset/pull/15184#issuecomment-861938209 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15157: feat: Synchronously return cached charts

codecov[bot] edited a comment on pull request #15157: URL: https://github.com/apache/superset/pull/15157#issuecomment-861050802 #

[GitHub] [superset] eschutho commented on a change in pull request #14956: chore: Add height/width TrashIcon SVG(18px/18px)-Edit Dataset modal

eschutho commented on a change in pull request #14956: URL: https://github.com/apache/superset/pull/14956#discussion_r652109512 ## File path: superset-frontend/src/CRUD/CollectionTable.tsx ## @@ -261,7 +261,7 @@ export default class CRUDCollection extends React.PureComponent<

[GitHub] [superset] codecov[bot] edited a comment on pull request #15109: fix: SQL Lab show "Refetch Results" button while fetching new query results

codecov[bot] edited a comment on pull request #15109: URL: https://github.com/apache/superset/pull/15109#issuecomment-859282112 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15177: feat(trino): add support for query cost estimate #15166

codecov[bot] edited a comment on pull request #15177: URL: https://github.com/apache/superset/pull/15177#issuecomment-861785984 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #14891: fix(aarch64): Bump pyarrow version to 4.0.1

codecov[bot] edited a comment on pull request #14891: URL: https://github.com/apache/superset/pull/14891#issuecomment-850168743 #

[GitHub] [superset] rusackas commented on pull request #15173: fix(examples): calendar chart metric should be metrics

rusackas commented on pull request #15173: URL: https://github.com/apache/superset/pull/15173#issuecomment-861865000 I've restarted the presto/hive tests a third time now. If it doesn't pass, it doesn't seem like flakiness. The error doesn't _look_ like it has anything to do with this PR

[GitHub] [superset] github-actions[bot] commented on pull request #15121: feat: Select component (Iteration 1)

github-actions[bot] commented on pull request #15121: URL: https://github.com/apache/superset/pull/15121#issuecomment-861867235 @rusackas Ephemeral environment spinning up at http://54.185.132.105:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and

[GitHub] [superset] robdiciuccio commented on pull request #14891: fix(aarch64): Bump pyarrow version to 4.0.1

robdiciuccio commented on pull request #14891: URL: https://github.com/apache/superset/pull/14891#issuecomment-861884621 /testenv up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [superset] grace-shi commented on pull request #15111: chore: add Chinese translation, wrap some text inside translation function

grace-shi commented on pull request #15111: URL: https://github.com/apache/superset/pull/15111#issuecomment-861981299 > `superset/translations/zh/LC_MESSAGES/messages.po` looks like there are some problems > >

[GitHub] [superset] codecov[bot] edited a comment on pull request #14881: feat: Database Connection UI

codecov[bot] edited a comment on pull request #14881: URL: https://github.com/apache/superset/pull/14881#issuecomment-849871089 #

[GitHub] [superset] robdiciuccio commented on a change in pull request #15157: feat: Synchronously return cached charts

robdiciuccio commented on a change in pull request #15157: URL: https://github.com/apache/superset/pull/15157#discussion_r652124572 ## File path: superset-frontend/src/chart/chartAction.js ## @@ -395,7 +395,16 @@ export function exploreJSON( if

[GitHub] [superset] codecov[bot] edited a comment on pull request #15128: feat(explore): Upgraded viz select gallery

codecov[bot] edited a comment on pull request #15128: URL: https://github.com/apache/superset/pull/15128#issuecomment-859971652 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #14462: refactor: change warning icon to use icons

codecov[bot] edited a comment on pull request #14462: URL: https://github.com/apache/superset/pull/14462#issuecomment-832056367 #

[GitHub] [superset] github-actions[bot] commented on pull request #14891: fix(aarch64): Bump pyarrow version to 4.0.1

github-actions[bot] commented on pull request #14891: URL: https://github.com/apache/superset/pull/14891#issuecomment-861885260 @robdiciuccio Ephemeral environment spinning up at http://35.162.119.13:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and

[GitHub] [superset] robdiciuccio edited a comment on pull request #15157: feat: Synchronously return cached charts

robdiciuccio edited a comment on pull request #15157: URL: https://github.com/apache/superset/pull/15157#issuecomment-861887944 We had this debate early on, whether pre-cached data should be returned synchronously. There are pros and cons here, as @benjreinhart pointed out. We're

  1   2   3   >