[GitHub] [superset] dpgaspar commented on a change in pull request #15082: fix: Honor ROW_LIMIT setting in elasticsearch queries

2021-06-16 Thread GitBox
dpgaspar commented on a change in pull request #15082: URL: https://github.com/apache/superset/pull/15082#discussion_r652442836 ## File path: superset/models/core.py ## @@ -379,6 +379,9 @@ def _log_query(sql: str) -> None: with closing(engine.raw_connection()) as

[GitHub] [superset] villebro opened a new pull request #15188: feat(api): add featured datatypes to dashboard dataset ep

2021-06-16 Thread GitBox
villebro opened a new pull request #15188: URL: https://github.com/apache/superset/pull/15188 ### SUMMARY To be able to filter out unnecessary filter types on the native filters config form (primarily temporal filters), we need to know what types of datatypes are available on the

[GitHub] [superset] codecov[bot] edited a comment on pull request #15186: fix(dashboard-list): change name of dashboard is not reflected instantly

2021-06-16 Thread GitBox
codecov[bot] edited a comment on pull request #15186: URL: https://github.com/apache/superset/pull/15186#issuecomment-862048658 #

[GitHub] [superset] kgabryje commented on pull request #15186: fix(dashboard-list): change name of dashboard is not reflected instantly

2021-06-16 Thread GitBox
kgabryje commented on pull request #15186: URL: https://github.com/apache/superset/pull/15186#issuecomment-862107531 Could we try to use the response from the request we're already making? There's the updated title available:

[GitHub] [superset] dpgaspar commented on a change in pull request #15184: fix: datasource payload is incorrect

2021-06-16 Thread GitBox
dpgaspar commented on a change in pull request #15184: URL: https://github.com/apache/superset/pull/15184#discussion_r652457750 ## File path: superset/connectors/connector_registry.py ## @@ -73,6 +74,47 @@ def get_all_datasources(cls, session: Session) ->

[GitHub] [superset] jinghua-qa opened a new issue #15189: [explore][time-series] marker option is not work when rich tooltip option is unselected.

2021-06-16 Thread GitBox
jinghua-qa opened a new issue #15189: URL: https://github.com/apache/superset/issues/15189 ### Description In time series chart, marker option is not work when rich tooltip option is unselected. ### Screenshot or Video

[GitHub] [superset] kgabryje commented on a change in pull request #15186: fix(dashboard-list): change name of dashboard is not reflected instantly

2021-06-16 Thread GitBox
kgabryje commented on a change in pull request #15186: URL: https://github.com/apache/superset/pull/15186#discussion_r652479537 ## File path: superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx ## @@ -157,7 +157,7 @@ function DashboardList(props: DashboardListProps) {

[GitHub] [superset] stephenLYZ commented on pull request #15186: fix(dashboard-list): change name of dashboard is not reflected instantly

2021-06-16 Thread GitBox
stephenLYZ commented on pull request #15186: URL: https://github.com/apache/superset/pull/15186#issuecomment-862135950 > Could we try to use the response from the request we're already making? There's the updated title available: >

[GitHub] [superset] codecov[bot] edited a comment on pull request #15186: fix(dashboard-list): change name of dashboard is not reflected instantly

2021-06-16 Thread GitBox
codecov[bot] edited a comment on pull request #15186: URL: https://github.com/apache/superset/pull/15186#issuecomment-862048658 #

[GitHub] [superset] dpgaspar commented on a change in pull request #15082: fix: Honor ROW_LIMIT setting in elasticsearch queries

2021-06-16 Thread GitBox
dpgaspar commented on a change in pull request #15082: URL: https://github.com/apache/superset/pull/15082#discussion_r652442836 ## File path: superset/models/core.py ## @@ -379,6 +379,9 @@ def _log_query(sql: str) -> None: with closing(engine.raw_connection()) as

[GitHub] [superset] kgabryje commented on a change in pull request #15186: fix(dashboard-list): change name of dashboard is not reflected instantly

2021-06-16 Thread GitBox
kgabryje commented on a change in pull request #15186: URL: https://github.com/apache/superset/pull/15186#discussion_r652458965 ## File path: superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx ## @@ -157,7 +157,7 @@ function DashboardList(props: DashboardListProps) {

[GitHub] [superset] villebro commented on a change in pull request #15186: fix(dashboard-list): change name of dashboard is not reflected instantly

2021-06-16 Thread GitBox
villebro commented on a change in pull request #15186: URL: https://github.com/apache/superset/pull/15186#discussion_r652483657 ## File path: superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx ## @@ -157,7 +157,7 @@ function DashboardList(props: DashboardListProps) {

[GitHub] [superset] codecov[bot] edited a comment on pull request #15188: feat(api): add featured datatypes to dashboard dataset ep

2021-06-16 Thread GitBox
codecov[bot] edited a comment on pull request #15188: URL: https://github.com/apache/superset/pull/15188#issuecomment-862178795 #

[GitHub] [superset] lyndsiWilliams opened a new pull request #15187: style: Database connect UI Polish - Step 3

2021-06-16 Thread GitBox
lyndsiWilliams opened a new pull request #15187: URL: https://github.com/apache/superset/pull/15187 ### SUMMARY Added styling to match the [figma specifications](https://www.figma.com/file/NbuTOMaUdv2GCBoDyihdLw/Database-Connection?node-id=1698%3A401419) for step 3 of the database

[GitHub] [superset] dpgaspar commented on a change in pull request #15082: fix: Honor ROW_LIMIT setting in elasticsearch queries

2021-06-16 Thread GitBox
dpgaspar commented on a change in pull request #15082: URL: https://github.com/apache/superset/pull/15082#discussion_r652442836 ## File path: superset/models/core.py ## @@ -379,6 +379,9 @@ def _log_query(sql: str) -> None: with closing(engine.raw_connection()) as

[GitHub] [superset] stephenLYZ commented on a change in pull request #15186: fix(dashboard-list): change name of dashboard is not reflected instantly

2021-06-16 Thread GitBox
stephenLYZ commented on a change in pull request #15186: URL: https://github.com/apache/superset/pull/15186#discussion_r652466987 ## File path: superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx ## @@ -157,7 +157,7 @@ function DashboardList(props: DashboardListProps)

[GitHub] [superset] codecov[bot] commented on pull request #15188: feat(api): add featured datatypes to dashboard dataset ep

2021-06-16 Thread GitBox
codecov[bot] commented on pull request #15188: URL: https://github.com/apache/superset/pull/15188#issuecomment-862178795 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15188: feat(api): add featured datatypes to dashboard dataset ep

2021-06-16 Thread GitBox
codecov[bot] edited a comment on pull request #15188: URL: https://github.com/apache/superset/pull/15188#issuecomment-862178795 #

[GitHub] [superset] Stephane-Thales opened a new issue #15190: Trreemap don't show data on Clickhouse when filtered

2021-06-16 Thread GitBox
Stephane-Thales opened a new issue #15190: URL: https://github.com/apache/superset/issues/15190 When using the TreeMap object, with filter, there is 2 lines that are excluded. ### Expected results Filter 1 value, show 1 square, filter 2 values, show 2, filter 3 show 3,

[GitHub] [superset] villebro merged pull request #15188: feat(api): add featured datatypes to dashboard dataset ep

2021-06-16 Thread GitBox
villebro merged pull request #15188: URL: https://github.com/apache/superset/pull/15188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,