dpgaspar commented on a change in pull request #15082:
URL: https://github.com/apache/superset/pull/15082#discussion_r652442836
##########
File path: superset/models/core.py
##########
@@ -379,6 +379,9 @@ def _log_query(sql: str) -> None:
with closing(engine.raw_connection()) as conn:
cursor = conn.cursor()
+ if hasattr(cursor, 'fetch_size'):
Review comment:
Adding an engine specific configuration on engine agnostic code is not
the best path IMO. Also overriding a database connection behind the scenes does
not seem like the right way to go.
Can you add more context and a real world example on why this is needed.
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
