[GitHub] [superset] tvorogme commented on issue #15291: Dashboard Native Filter: cannot filter null values

2021-06-27 Thread GitBox
tvorogme commented on issue #15291: URL: https://github.com/apache/superset/issues/15291#issuecomment-869120277 Hi! I see @mironovmeow created pull request with fixing this issue. @zhaoyongjie @junlincc will you review it? Or we wait for realization from superset team? -- This is

[GitHub] [superset] syazwan0913 opened a new issue #15406: Gunicorn gevent worker keep timeout

2021-06-27 Thread GitBox
syazwan0913 opened a new issue #15406: URL: https://github.com/apache/superset/issues/15406 A clear and concise description of what the bug is. ### Expected results Gunicorn worker shouldn't be timeout since timeout is 10mins (600s) ### Actual results Gunicorn

[GitHub] [superset] ofekisr opened a new pull request #15407: fix removed flask_app property can break derived class

2021-06-27 Thread GitBox
ofekisr opened a new pull request #15407: URL: https://github.com/apache/superset/pull/15407 After renaming "flask_app" property to "superset_app", we understand that it can brack derived classes so I added "flask_app" as deprecated property -- This is an automated message

[GitHub] [superset] tvorogme removed a comment on issue #15291: Dashboard Native Filter: cannot filter null values

2021-06-27 Thread GitBox
tvorogme removed a comment on issue #15291: URL: https://github.com/apache/superset/issues/15291#issuecomment-869120277 Hi! I see @mironovmeow created pull request with fixing this issue. @zhaoyongjie @junlincc will you review it? Or we wait for realization from superset team? --

[GitHub] [superset] amitmiran137 commented on a change in pull request #15407: fix(regression): removed flask_app property can break derived class

2021-06-27 Thread GitBox
amitmiran137 commented on a change in pull request #15407: URL: https://github.com/apache/superset/pull/15407#discussion_r659323911 ## File path: superset/initialization/__init__.py ## @@ -64,6 +65,11 @@ def __init__(self, app: SupersetApp) -> None: self.config =

[GitHub] [superset] codecov[bot] edited a comment on pull request #15407: fix(regression): removed flask_app property can break derived class

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #15407: URL: https://github.com/apache/superset/pull/15407#issuecomment-869161813 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15407: fix(regression): removed flask_app property can break derived class

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #15407: URL: https://github.com/apache/superset/pull/15407#issuecomment-869161813 #

[GitHub] [superset] codecov[bot] commented on pull request #15405: chore(refactor): load configuration and merge recursively

2021-06-27 Thread GitBox
codecov[bot] commented on pull request #15405: URL: https://github.com/apache/superset/pull/15405#issuecomment-869124850 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15405: chore(refactor): load configuration and merge recursively

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #15405: URL: https://github.com/apache/superset/pull/15405#issuecomment-869124850 #

[GitHub] [superset] zufolo441 commented on issue #15331: Nginx Configuration

2021-06-27 Thread GitBox
zufolo441 commented on issue #15331: URL: https://github.com/apache/superset/issues/15331#issuecomment-869129955 our configuration: superset server is 192.168.1.80 server { listen 159.213.63.16:80; server_name dwh.istitutodegliinnocenti.it; include

[GitHub] [superset] codecov[bot] edited a comment on pull request #15405: chore(refactor): load configuration and merge recursively

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #15405: URL: https://github.com/apache/superset/pull/15405#issuecomment-869124850 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15407: fix(regression): removed flask_app property can break derived class

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #15407: URL: https://github.com/apache/superset/pull/15407#issuecomment-869161813 #

[GitHub] [superset] mironovmeow closed pull request #15387: fix: Add null var to native filter (#15291)

2021-06-27 Thread GitBox
mironovmeow closed pull request #15387: URL: https://github.com/apache/superset/pull/15387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [superset] MatanBobi commented on issue #13013: [SIP-58] Proposal to move superset-ui to this repo

2021-06-27 Thread GitBox
MatanBobi commented on issue #13013: URL: https://github.com/apache/superset/issues/13013#issuecomment-869109109 Just updating here as I'll probably start working on it this week. After consulting with @amitmiran137 and @rusackas, we'll probably start with building the monorepo approach

[GitHub] [superset] ofekisr opened a new pull request #15405: refactor load configuration

2021-06-27 Thread GitBox
ofekisr opened a new pull request #15405: URL: https://github.com/apache/superset/pull/15405 ### SUMMARY ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTIONS ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes

[GitHub] [superset] codecov[bot] edited a comment on pull request #15405: chore(refactor): load configuration and merge recursively

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #15405: URL: https://github.com/apache/superset/pull/15405#issuecomment-869124850 #

[GitHub] [superset] codecov[bot] commented on pull request #15407: fix(regression): removed flask_app property can break derived class

2021-06-27 Thread GitBox
codecov[bot] commented on pull request #15407: URL: https://github.com/apache/superset/pull/15407#issuecomment-869161813 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15407: fix(regression): removed flask_app property can break derived class

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #15407: URL: https://github.com/apache/superset/pull/15407#issuecomment-869161813 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15407: fix(regression): removed flask_app property can break derived class

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #15407: URL: https://github.com/apache/superset/pull/15407#issuecomment-869161813 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15407: fix(regression): removed flask_app property can break derived class

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #15407: URL: https://github.com/apache/superset/pull/15407#issuecomment-869161813 #

[GitHub] [superset] codecov[bot] commented on pull request #15408: refactor: icon to icons for listviewcomponent

2021-06-27 Thread GitBox
codecov[bot] commented on pull request #15408: URL: https://github.com/apache/superset/pull/15408#issuecomment-869164859 #

[GitHub] [superset] mvoitko commented on pull request #15297: fix: bootstrapScript in values.yaml of the helm chart

2021-06-27 Thread GitBox
mvoitko commented on pull request #15297: URL: https://github.com/apache/superset/pull/15297#issuecomment-869139185 @craig-rueda Could you please review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [superset] pkdotson opened a new pull request #15408: refactor: icon to icons for listviewcomponent

2021-06-27 Thread GitBox
pkdotson opened a new pull request #15408: URL: https://github.com/apache/superset/pull/15408 ### SUMMARY this pr refactors the listview icon and and cardview icon to the new icons component ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF before

[GitHub] [superset] ofekisr commented on a change in pull request #15407: fix(regression): removed flask_app property can break derived class

2021-06-27 Thread GitBox
ofekisr commented on a change in pull request #15407: URL: https://github.com/apache/superset/pull/15407#discussion_r659324643 ## File path: superset/initialization/__init__.py ## @@ -64,6 +65,11 @@ def __init__(self, app: SupersetApp) -> None: self.config =

[GitHub] [superset] codecov[bot] edited a comment on pull request #15409: feat: more SIP-40 error messages for SQL Lab

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #15409: URL: https://github.com/apache/superset/pull/15409#issuecomment-869202759 #

[GitHub] [superset] nytai edited a comment on issue #15406: Gunicorn gevent worker keep timeout

2021-06-27 Thread GitBox
nytai edited a comment on issue #15406: URL: https://github.com/apache/superset/issues/15406#issuecomment-869215911 Also, this issue is really with gunicorn and not superset -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [superset] nytai commented on issue #15406: Gunicorn gevent worker keep timeout

2021-06-27 Thread GitBox
nytai commented on issue #15406: URL: https://github.com/apache/superset/issues/15406#issuecomment-869215911 Also this issue is really with gunicorn and not superset -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [superset] amitmiran137 merged pull request #15407: fix(regression): removed flask_app property can break derived class

2021-06-27 Thread GitBox
amitmiran137 merged pull request #15407: URL: https://github.com/apache/superset/pull/15407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [superset] craig-rueda merged pull request #15297: fix: bootstrapScript in values.yaml of the helm chart

2021-06-27 Thread GitBox
craig-rueda merged pull request #15297: URL: https://github.com/apache/superset/pull/15297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [superset] betodealmeida opened a new pull request #15409: feat: more SIP-40 error messages for SQL Lab

2021-06-27 Thread GitBox
betodealmeida opened a new pull request #15409: URL: https://github.com/apache/superset/pull/15409 ### SUMMARY Add more SIP-40 compliant error messages to SQL Lab. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ![Screenshot 2021-06-27 at 10-45-02 DEV

[GitHub] [superset] nytai removed a comment on issue #15406: Gunicorn gevent worker keep timeout

2021-06-27 Thread GitBox
nytai removed a comment on issue #15406: URL: https://github.com/apache/superset/issues/15406#issuecomment-869215294 It’s probably the `keepalive` setting you have at 60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [superset] codecov[bot] edited a comment on pull request #15407: fix(regression): removed flask_app property can break derived class

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #15407: URL: https://github.com/apache/superset/pull/15407#issuecomment-869161813 #

[GitHub] [superset] zhaoyongjie commented on a change in pull request #15153: feat: Adding a show all button to the column/metrics list in the explore view (Allow more than 50 columns to be shown)

2021-06-27 Thread GitBox
zhaoyongjie commented on a change in pull request #15153: URL: https://github.com/apache/superset/pull/15153#discussion_r659343457 ## File path: superset-frontend/src/explore/components/DatasourcePanel/index.tsx ## @@ -113,6 +125,11 @@ export default function DataSourcePanel({

[GitHub] [superset] codecov[bot] edited a comment on pull request #15409: feat: more SIP-40 error messages for SQL Lab

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #15409: URL: https://github.com/apache/superset/pull/15409#issuecomment-869202759 #

[GitHub] [superset] JavierLopezT opened a new pull request #15410: docs: Small addition in add new databases with docker

2021-06-27 Thread GitBox
JavierLopezT opened a new pull request #15410: URL: https://github.com/apache/superset/pull/15410 Based on my own noob experience Since it is a small doc change, I think it doesn't need an Issue first -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [superset] zhaoyongjie commented on a change in pull request #15153: feat: Adding a show all button to the column/metrics list in the explore view (Allow more than 50 columns to be shown)

2021-06-27 Thread GitBox
zhaoyongjie commented on a change in pull request #15153: URL: https://github.com/apache/superset/pull/15153#discussion_r659343457 ## File path: superset-frontend/src/explore/components/DatasourcePanel/index.tsx ## @@ -113,6 +125,11 @@ export default function DataSourcePanel({

[GitHub] [superset] codecov[bot] edited a comment on pull request #15405: chore(refactor): load configuration and merge recursively

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #15405: URL: https://github.com/apache/superset/pull/15405#issuecomment-869124850 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15405: chore(refactor): load configuration and merge recursively

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #15405: URL: https://github.com/apache/superset/pull/15405#issuecomment-869124850 #

[GitHub] [superset] codecov[bot] commented on pull request #15409: feat: more SIP-40 error messages for SQL Lab

2021-06-27 Thread GitBox
codecov[bot] commented on pull request #15409: URL: https://github.com/apache/superset/pull/15409#issuecomment-869202759 #

[GitHub] [superset] nytai commented on issue #15406: Gunicorn gevent worker keep timeout

2021-06-27 Thread GitBox
nytai commented on issue #15406: URL: https://github.com/apache/superset/issues/15406#issuecomment-869215102 Are you it’s not something else in the stack like nginx timing out? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [superset] nytai commented on issue #15406: Gunicorn gevent worker keep timeout

2021-06-27 Thread GitBox
nytai commented on issue #15406: URL: https://github.com/apache/superset/issues/15406#issuecomment-869215294 It’s probably the `keepalive` setting you have at 60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [superset] nytai removed a comment on issue #15406: Gunicorn gevent worker keep timeout

2021-06-27 Thread GitBox
nytai removed a comment on issue #15406: URL: https://github.com/apache/superset/issues/15406#issuecomment-869215102 Are you it’s not something else in the stack like nginx timing out? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [superset] nytai commented on issue #15406: Gunicorn gevent worker keep timeout

2021-06-27 Thread GitBox
nytai commented on issue #15406: URL: https://github.com/apache/superset/issues/15406#issuecomment-869215733 Have you tried setting it to 0 to disable all timeouts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [superset] amitmiran137 merged pull request #15153: feat: Adding a show all button to the column/metrics list in the explore view (Allow more than 50 columns to be shown)

2021-06-27 Thread GitBox
amitmiran137 merged pull request #15153: URL: https://github.com/apache/superset/pull/15153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [superset] amitmiran137 commented on pull request #14508: potential fix for issue 11988

2021-06-27 Thread GitBox
amitmiran137 commented on pull request #14508: URL: https://github.com/apache/superset/pull/14508#issuecomment-869220529 closing due to inactivity -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [superset] codecov[bot] edited a comment on pull request #14278: docs: Update SIP template

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #14278: URL: https://github.com/apache/superset/pull/14278#issuecomment-824365814 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #14278: docs: Update SIP template

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #14278: URL: https://github.com/apache/superset/pull/14278#issuecomment-824365814 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #14278: docs: Update SIP template

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #14278: URL: https://github.com/apache/superset/pull/14278#issuecomment-824365814 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #14278: docs: Update SIP template

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #14278: URL: https://github.com/apache/superset/pull/14278#issuecomment-824365814 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #14278: docs: Update SIP template

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #14278: URL: https://github.com/apache/superset/pull/14278#issuecomment-824365814 #

[GitHub] [superset] amitmiran137 merged pull request #14908: chore: Add Slovenian (sl_SI) translation

2021-06-27 Thread GitBox
amitmiran137 merged pull request #14908: URL: https://github.com/apache/superset/pull/14908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [superset] codecov[bot] edited a comment on pull request #15408: refactor: icon to icons for listviewcomponent

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #15408: URL: https://github.com/apache/superset/pull/15408#issuecomment-869164859 #

[GitHub] [superset] zhaoyongjie commented on issue #14751: [Explore]Search data panel column by key words

2021-06-27 Thread GitBox
zhaoyongjie commented on issue #14751: URL: https://github.com/apache/superset/issues/14751#issuecomment-869258874 closed by https://github.com/apache/superset/pull/15153#event-4944281888 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [superset] zhaoyongjie closed issue #14751: [Explore]Search data panel column by key words

2021-06-27 Thread GitBox
zhaoyongjie closed issue #14751: URL: https://github.com/apache/superset/issues/14751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [superset] amitmiran137 merged pull request #14572: docs: release documentation for 1.2

2021-06-27 Thread GitBox
amitmiran137 merged pull request #14572: URL: https://github.com/apache/superset/pull/14572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [superset] amitmiran137 commented on pull request #14464: chore(dashboard): add new e2e tests

2021-06-27 Thread GitBox
amitmiran137 commented on pull request #14464: URL: https://github.com/apache/superset/pull/14464#issuecomment-869220033 Lets close and re-open if needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [superset] amitmiran137 closed pull request #14464: chore(dashboard): add new e2e tests

2021-06-27 Thread GitBox
amitmiran137 closed pull request #14464: URL: https://github.com/apache/superset/pull/14464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [superset] amitmiran137 closed pull request #14508: potential fix for issue 11988

2021-06-27 Thread GitBox
amitmiran137 closed pull request #14508: URL: https://github.com/apache/superset/pull/14508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [superset] amitmiran137 closed pull request #14499: fix: OrderDate is a bad reference

2021-06-27 Thread GitBox
amitmiran137 closed pull request #14499: URL: https://github.com/apache/superset/pull/14499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [superset] codecov[bot] edited a comment on pull request #14278: docs: Update SIP template

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #14278: URL: https://github.com/apache/superset/pull/14278#issuecomment-824365814 #

[GitHub] [superset] mistercrunch opened a new pull request #14499: fix: OrderDate is a bad reference

2021-06-27 Thread GitBox
mistercrunch opened a new pull request #14499: URL: https://github.com/apache/superset/pull/14499 Creating this as pointer to an issue. To reproduce: https://user-images.githubusercontent.com/487433/117216211-421f5400-adb4-11eb-8005-800895c378ea.png;> Bug:

[GitHub] [superset] codecov[bot] edited a comment on pull request #15408: refactor: icon to icons for listviewcomponent

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #15408: URL: https://github.com/apache/superset/pull/15408#issuecomment-869164859 #

[GitHub] [superset] zhaoyongjie closed issue #15258: documented data cache config doesn't work with flask-caching v1.9.0

2021-06-27 Thread GitBox
zhaoyongjie closed issue #15258: URL: https://github.com/apache/superset/issues/15258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [superset] zhaoyongjie merged pull request #15259: fix: upgrade Flask-Caching>=1.10.0

2021-06-27 Thread GitBox
zhaoyongjie merged pull request #15259: URL: https://github.com/apache/superset/pull/15259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [superset] jgibson2 closed pull request #14149: feat: Add loadBalancerSourceRanges to helm configuration

2021-06-27 Thread GitBox
jgibson2 closed pull request #14149: URL: https://github.com/apache/superset/pull/14149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [superset] codecov[bot] edited a comment on pull request #15279: feat: run extra query on QueryObject and add compare operator for post_processing

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #15279: URL: https://github.com/apache/superset/pull/15279#issuecomment-865701614 #

[GitHub] [superset] villebro opened a new pull request #15411: fix(native-filters): show human readable time grain label in indicator

2021-06-27 Thread GitBox
villebro opened a new pull request #15411: URL: https://github.com/apache/superset/pull/15411 ### SUMMARY Currently when using a time grain native filter, the ISO-8601 time duration is shown in the filter indicator. Instead of showing the technical duration in the indicator (e.g.

[GitHub] [superset] codecov[bot] edited a comment on pull request #15279: feat: run extra query on QueryObject and add compare operator for post_processing

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #15279: URL: https://github.com/apache/superset/pull/15279#issuecomment-865701614 #

[GitHub] [superset] blackhawk28 commented on issue #5650: Not able to add a table from external Redshift Spectrum schema

2021-06-27 Thread GitBox
blackhawk28 commented on issue #5650: URL: https://github.com/apache/superset/issues/5650#issuecomment-869379641 hi @RodBart and @robert-yxin05 I need some clarification, where did you create the table in redshift? and in local schema? and then import that table with the local schema in

[GitHub] [superset] srikark16 commented on issue #15214: Creating and Update Superset Users in Bulk through API, apache superset version 1.1.0

2021-06-27 Thread GitBox
srikark16 commented on issue #15214: URL: https://github.com/apache/superset/issues/15214#issuecomment-869379979 @zhaoyongjie can you please let me know how to create user with multiple roles using the below command. superset fab create-user -- This is an automated message from

[GitHub] [superset] codecov[bot] edited a comment on pull request #15279: feat: run extra query on QueryObject and add compare operator for post_processing

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #15279: URL: https://github.com/apache/superset/pull/15279#issuecomment-865701614 #

[GitHub] [superset] amitmiran137 merged pull request #14278: docs: Update SIP template

2021-06-27 Thread GitBox
amitmiran137 merged pull request #14278: URL: https://github.com/apache/superset/pull/14278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [superset] amitmiran137 commented on pull request #15384: refactor(dashboard): [chart-maximize-mode]put chart full-size state in redux

2021-06-27 Thread GitBox
amitmiran137 commented on pull request #15384: URL: https://github.com/apache/superset/pull/15384#issuecomment-869345696 could you fix test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [superset] codecov[bot] edited a comment on pull request #15279: feat: run extra query on QueryObject and add compare operator for post_processing

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #15279: URL: https://github.com/apache/superset/pull/15279#issuecomment-865701614 #

[GitHub] [superset] codecov[bot] edited a comment on pull request #15279: feat: run extra query on QueryObject and add compare operator for post_processing

2021-06-27 Thread GitBox
codecov[bot] edited a comment on pull request #15279: URL: https://github.com/apache/superset/pull/15279#issuecomment-865701614 #

[GitHub] [superset] villebro commented on a change in pull request #15390: fix: Cascading filter popover widens automatically

2021-06-27 Thread GitBox
villebro commented on a change in pull request #15390: URL: https://github.com/apache/superset/pull/15390#discussion_r659489653 ## File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/index.tsx ## @@ -53,28 +49,26

[GitHub] [superset] lyndsiWilliams opened a new pull request #15412: style: Database Connection Modal UI Polish R5

2021-06-27 Thread GitBox
lyndsiWilliams opened a new pull request #15412: URL: https://github.com/apache/superset/pull/15412 ### SUMMARY Implemented UI polish tasks in [Clubhouse ticket](https://app.clubhouse.io/preset/story/17847/ui-polish-r5) - Centered modal in window - Fixed inconsistent header

[GitHub] [superset] rumbin commented on pull request #15403: feat: cancel db query on stop

2021-06-27 Thread GitBox
rumbin commented on pull request #15403: URL: https://github.com/apache/superset/pull/15403#issuecomment-869375535 Slightly off-topic: How does the Stop button in Explore handle this situation? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [superset] codecov[bot] commented on pull request #15412: style: Database Connection Modal UI Polish R5

2021-06-27 Thread GitBox
codecov[bot] commented on pull request #15412: URL: https://github.com/apache/superset/pull/15412#issuecomment-869379037 #