[jira] [Created] (YETUS-471) Add possibility to configure Findbug source folders

2016-12-01 Thread Peter Vary (JIRA)
Peter Vary created YETUS-471: Summary: Add possibility to configure Findbug source folders Key: YETUS-471 URL: https://issues.apache.org/jira/browse/YETUS-471 Project: Yetus Issue Type: Improveme

[jira] [Updated] (YETUS-471) Add possibility to configure Findbugs source folders

2016-12-01 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated YETUS-471: - Summary: Add possibility to configure Findbugs source folders (was: Add possibility to configure Findbug s

[jira] [Updated] (YETUS-471) Add possibility to configure Findbugs source folders

2016-12-01 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated YETUS-471: - Attachment: YETUS-471.00.patch Proposed patch. Please feel free to point out any minor mistakes as well, s

[jira] [Commented] (YETUS-471) Add possibility to configure Findbugs source folders

2016-12-01 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15711593#comment-15711593 ] Peter Vary commented on YETUS-471: -- [~aw], [~mzuehlke] could you please take a look at it?

[jira] [Updated] (YETUS-471) Add possibility to configure Findbugs source folders

2016-12-01 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated YETUS-471: - Attachment: YETUS-471.01.patch Addressed issues found by precommit tests > Add possibility to configure Fi

[jira] [Commented] (YETUS-471) Add possibility to configure Findbugs source folders

2016-12-01 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15712105#comment-15712105 ] Peter Vary commented on YETUS-471: -- These were the ones used before my change, so it felt

[jira] [Commented] (YETUS-471) Add possibility to configure Findbugs source folders

2016-12-01 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15712120#comment-15712120 ] Peter Vary commented on YETUS-471: -- To tell the truth I am not sure how much time is consu

[jira] [Commented] (YETUS-471) Add possibility to configure Findbugs source folders

2016-12-01 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15712132#comment-15712132 ] Peter Vary commented on YETUS-471: -- I understand your point, and I think we could use both

[jira] [Comment Edited] (YETUS-471) Add possibility to configure Findbugs source folders

2016-12-01 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15712132#comment-15712132 ] Peter Vary edited comment on YETUS-471 at 12/1/16 2:53 PM: --- I und

[jira] [Commented] (YETUS-471) Add possibility to configure Findbugs source folders

2016-12-01 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15712298#comment-15712298 ] Peter Vary commented on YETUS-471: -- Thanks [~sacharya] for the review. To tell the truth,

[jira] [Updated] (YETUS-471) Add possibility to configure Findbugs source folders

2016-12-01 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated YETUS-471: - Attachment: YETUS-471.02.patch Attached a patch addressing [~sekikn]'s points. All of which are valid. Sti

[jira] [Commented] (YETUS-471) Add possibility to configure Findbugs source folders

2016-12-08 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732714#comment-15732714 ] Peter Vary commented on YETUS-471: -- {quote} We could ask maven to list the configured sour

[jira] [Updated] (YETUS-471) Add possibility to configure Findbugs source folders

2016-12-19 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated YETUS-471: - Attachment: YETUS-471.03.patch Attaching the agreed upon solution: - Add a flag to skip the source folder c

[jira] [Updated] (YETUS-471) Add possibility to skip the source check for Findbugs

2017-01-10 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated YETUS-471: - Summary: Add possibility to skip the source check for Findbugs (was: Add possibility to configure Findbugs

[jira] (YETUS-484) When running checkstyle plugin against multiple modules it runs only for the first module

2017-01-30 Thread Peter Vary (JIRA)
Title: Message Title Peter Vary created an issue

[jira] (YETUS-484) Fixing bug when checkstyle runs on multiple modules

2017-01-30 Thread Peter Vary (JIRA)
Title: Message Title Peter Vary updated an issue

[jira] (YETUS-484) Fixing bug when checkstyle runs on multiple modules

2017-01-30 Thread Peter Vary (JIRA)
Title: Message Title Peter Vary updated an issue

[jira] (YETUS-484) Fixing bug when checkstyle runs on multiple modules

2017-01-30 Thread Peter Vary (JIRA)
Title: Message Title Peter Vary updated an issue

[jira] (YETUS-484) Fixing bug when checkstyle runs on multiple modules

2017-01-30 Thread Peter Vary (JIRA)
Title: Message Title Peter Vary updated an issue

[jira] (YETUS-484) Fixing bug when checkstyle runs on multiple modules

2017-01-30 Thread Peter Vary (JIRA)
Title: Message Title Peter Vary commented on YETUS-484

[jira] [Commented] (YETUS-484) Fixing bug when checkstyle runs on multiple modules

2017-02-02 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849952#comment-15849952 ] Peter Vary commented on YETUS-484: -- Thanks [~aw]! > Fixing bug when checkstyle runs on mu

[jira] [Created] (YETUS-488) Checkstyle reports new error if the file still longer than expected

2017-02-15 Thread Peter Vary (JIRA)
Peter Vary created YETUS-488: Summary: Checkstyle reports new error if the file still longer than expected Key: YETUS-488 URL: https://issues.apache.org/jira/browse/YETUS-488 Project: Yetus Issu

[jira] [Commented] (YETUS-488) Checkstyle reports new error if the file still longer than expected

2017-02-15 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867959#comment-15867959 ] Peter Vary commented on YETUS-488: -- I would greatly value your opinions: [~aw], [~caseyjbr

[jira] [Updated] (YETUS-488) Checkstyle reports new error if the file still longer than expected

2017-02-15 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated YETUS-488: - Attachment: YETUS-488.00.patch The patch which contains the first solution, so anyone interested could test

[jira] [Commented] (YETUS-488) Checkstyle reports new error if the file still longer than expected

2017-02-16 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870107#comment-15870107 ] Peter Vary commented on YETUS-488: -- Thanks guys for the input! My impression was, that I

[jira] [Commented] (YETUS-488) Checkstyle reports new error if the file still longer than expected

2017-02-20 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874556#comment-15874556 ] Peter Vary commented on YETUS-488: -- Hi, I have been thinking about this on the weekend. A

[jira] [Updated] (YETUS-488) Checkstyle reports new error if the file still longer than expected

2017-03-01 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated YETUS-488: - Attachment: YETUS-488.01.patch Implemented the proposed solution. Added an extra \x01 before the checkstyl

[jira] [Updated] (YETUS-488) Checkstyle reports new error if the file still longer than expected

2017-03-02 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated YETUS-488: - Attachment: YETUS-488.02.patch Addressed precommit error > Checkstyle reports new error if the file still

[jira] [Commented] (YETUS-488) Checkstyle reports new error if the file still longer than expected

2017-03-16 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927944#comment-15927944 ] Peter Vary commented on YETUS-488: -- Did anyone have time to review? Thanks, Peter > Che

[jira] [Commented] (YETUS-488) Checkstyle reports new error if the file still longer than expected

2017-03-23 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938037#comment-15938037 ] Peter Vary commented on YETUS-488: -- :D Thanks [~aw]! Take your time, just was not sure if

[jira] [Commented] (YETUS-488) Checkstyle reports new error if the file still longer than expected

2017-03-23 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938847#comment-15938847 ] Peter Vary commented on YETUS-488: -- Thanks [~aw]! I will try to take a look at the stuff

[jira] [Created] (YETUS-506) When modul name and name of the modul directory is different maven_reorder_module_process fails to find the module

2017-05-15 Thread Peter Vary (JIRA)
Peter Vary created YETUS-506: Summary: When modul name and name of the modul directory is different maven_reorder_module_process fails to find the module Key: YETUS-506 URL: https://issues.apache.org/jira/browse/YETUS

[jira] [Updated] (YETUS-506) Enhance maven_reorder_module_process to handle modules where directory name is different than the artifactId

2017-05-15 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated YETUS-506: - Summary: Enhance maven_reorder_module_process to handle modules where directory name is different than the

[jira] [Updated] (YETUS-506) Enhance maven_reorder_module_process to handle modules where directory name is different than the artifactId

2017-05-15 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated YETUS-506: - Attachment: YETUS-506.00.patch The proposed patch > Enhance maven_reorder_module_process to handle modules

[jira] [Commented] (YETUS-506) Enhance maven_reorder_module_process to handle modules where directory name is different than the artifactId

2017-05-15 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010754#comment-16010754 ] Peter Vary commented on YETUS-506: -- Yeah, you are right! This might cause problems, if the

[jira] [Updated] (YETUS-506) Enhance maven_reorder_module_process to handle modules where directory name is different than the artifactId

2017-05-15 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated YETUS-506: - Attachment: YETUS-506.01.patch As [~aw] suggested added the extra -Dexec.args="" > Enhance maven_reorder_m

[jira] [Updated] (YETUS-506) Enhance maven_reorder_module_process to handle modules where directory name is different than the artifactId

2017-05-16 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated YETUS-506: - Attachment: YETUS-506.02.patch Removed not used variable identified by the check > Enhance maven_reorder_m

[jira] [Commented] (YETUS-506) Enhance maven_reorder_module_process to handle modules where directory name is different than the artifactId

2017-05-16 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011936#comment-16011936 ] Peter Vary commented on YETUS-506: -- [~aw], what do you think? It this patch ok now? Thank

[jira] [Commented] (YETUS-488) Checkstyle reports new error if the file still longer than expected

2017-05-17 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16013723#comment-16013723 ] Peter Vary commented on YETUS-488: -- Hi [aw], Well, as you can see I started to pick up st

[jira] [Updated] (YETUS-506) Enhance maven_reorder_module_process to handle modules where directory name is different than the artifactId

2017-05-17 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated YETUS-506: - Attachment: YETUS-506.03.patch Updated the patch: - Modified the message text to mention dependency downloa

[jira] [Commented] (YETUS-506) Enhance maven_reorder_module_process to handle modules where directory name is different than the artifactId

2017-05-18 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015700#comment-16015700 ] Peter Vary commented on YETUS-506: -- [~aw]: Could you please help me with the "wrodsmithing

[jira] [Commented] (YETUS-488) Checkstyle reports new error if the file still longer than expected

2017-05-24 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022598#comment-16022598 ] Peter Vary commented on YETUS-488: -- Thanks for the review and the commit [aw]! > Checksty

[jira] [Comment Edited] (YETUS-488) Checkstyle reports new error if the file still longer than expected

2017-05-24 Thread Peter Vary (JIRA)
[ https://issues.apache.org/jira/browse/YETUS-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022598#comment-16022598 ] Peter Vary edited comment on YETUS-488 at 5/24/17 9:24 AM: --- Thank